Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-18 Thread Jan Vesely
On Mon, 2017-08-14 at 17:11 +0900, Michel Dänzer wrote: > On 11/08/17 02:13 AM, Jan Vesely wrote: > > On Thu, 2017-08-10 at 17:45 +0100, Emil Velikov wrote: > > > > > > Topic for another thread: > > > There's been a handful of issues reported with BUILD_SHARED_LIBS=ON. > > > Should we consider

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Michel Dänzer
On 15/08/17 07:55 AM, Grazvydas Ignotas wrote: > On Mon, Aug 14, 2017 at 11:13 PM, Andy Furniss wrote: >> Michel Dänzer wrote: >>> >>> On 11/08/17 01:45 AM, Emil Velikov wrote: >>> >>> Thanks, pushed. >> >> >> Don't know if this is expected or not, but llvm built like - >> >>

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Grazvydas Ignotas
On Tue, Aug 15, 2017 at 1:55 AM, Grazvydas Ignotas wrote: > > Also, llvm-config --version says "6.0.0git-f49c401", which means I had > to manually hack configure.ac every time to "6.0.0svn" to get mesa > building too :( Nevermind about this one, -DLLVM_APPEND_VC_REV=OFF solves

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Grazvydas Ignotas
On Mon, Aug 14, 2017 at 11:13 PM, Andy Furniss wrote: > Michel Dänzer wrote: >> >> On 11/08/17 01:45 AM, Emil Velikov wrote: >> >> Thanks, pushed. > > > Don't know if this is expected or not, but llvm built like - > > cmake -DCMAKE_INSTALL_PREFIX=/usr

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Andy Furniss
Michel Dänzer wrote: On 11/08/17 01:45 AM, Emil Velikov wrote: On 9 August 2017 at 02:00, Michel Dänzer wrote: On 09/08/17 03:24 AM, Emil Velikov wrote: I think we'd want to keep the best of both - just not sure how to exactly do that. --libs/--libfiles was completely

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Michel Dänzer
On 11/08/17 02:13 AM, Jan Vesely wrote: > On Thu, 2017-08-10 at 17:45 +0100, Emil Velikov wrote: >> >> Topic for another thread: >> There's been a handful of issues reported with BUILD_SHARED_LIBS=ON. >> Should we consider that unsupported setup and error out? I don't really see the point / gain

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-14 Thread Michel Dänzer
On 11/08/17 01:45 AM, Emil Velikov wrote: > On 9 August 2017 at 02:00, Michel Dänzer wrote: >> On 09/08/17 03:24 AM, Emil Velikov wrote: >>> >>> I think we'd want to keep the best of both - just not sure how to >>> exactly do that. >>> --libs/--libfiles was completely busted

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-10 Thread Jan Vesely
On Thu, 2017-08-10 at 17:45 +0100, Emil Velikov wrote: > On 9 August 2017 at 02:00, Michel Dänzer wrote: > > On 09/08/17 03:24 AM, Emil Velikov wrote: > > > On 8 August 2017 at 08:23, Michel Dänzer wrote: > > > > From: Michel Dänzer

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-10 Thread Emil Velikov
On 9 August 2017 at 02:00, Michel Dänzer wrote: > On 09/08/17 03:24 AM, Emil Velikov wrote: >> On 8 August 2017 at 08:23, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> No need to manually look for the library files anymore

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Michel Dänzer
On 09/08/17 03:24 AM, Emil Velikov wrote: > On 8 August 2017 at 08:23, Michel Dänzer wrote: >> From: Michel Dänzer >> >> No need to manually look for the library files anymore with current >> LLVM. This sidesteps the manual method failing when LLVM was

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 08:23, Michel Dänzer wrote: > From: Michel Dänzer > > No need to manually look for the library files anymore with current > LLVM. This sidesteps the manual method failing when LLVM was built with > -DLLVM_APPEND_VC_REV=ON. > IIRC

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Tue, Aug 8, 2017 at 9:23 AM, Michel Dänzer wrote: > From: Michel Dänzer > > No need to manually look for the library files anymore with current > LLVM. This sidesteps the manual method failing when

[Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-08 Thread Michel Dänzer
From: Michel Dänzer No need to manually look for the library files anymore with current LLVM. This sidesteps the manual method failing when LLVM was built with -DLLVM_APPEND_VC_REV=ON. (This might already work with older versions of LLVM) Signed-off-by: Michel Dänzer