Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
Thanks Michel. I could able to submit new merge request. On 1/6/2020 2:01 PM, Michel Dänzer wrote: [CAUTION: External Email] On 2020-01-06 6:14 a.m., Sahu, Satyajit wrote: Hi Michel, I tried with git push. It is failing with below error remote: You are not allowed to push code to this project. fatal: unable to access 'https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa.git%2Fdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=697khejIBws9CYeSvWQACsxx7oJUmOHoEkz19%2BtHSrU%3Dreserved=0': The requested URL returned error: 403 That's the main Mesa repository. You need to push to your forked repository[0] instead: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=s9U8FDMRTIvASG8bResXNrT75EHRIKCgX70o3hpiZ4c%3Dreserved=0/mesa.git [0] Make sure you did create a forked repository using the "Fork" button on https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesadata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=TXEoJ6pv6dQFHR%2Fp2XaLuarvbS7yjGgcA9KdqJk3ims%3Dreserved=0 before trying this, otherwise git push will create a non-forked project on the fly, which won't work for making MRs. -- Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.comdata=02%7C01%7Csatyajit.sahu%40amd.com%7Ca4002167a6a04cdcef8a08d79282e14c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637138963148199763sdata=Pal4%2FSJHOor6d%2Bzz0eDLExbbVvmrX7Stvni3WTm9hv4%3Dreserved=0 Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
On 2020-01-06 6:14 a.m., Sahu, Satyajit wrote: > Hi Michel, > > I tried with git push. It is failing with below error > > remote: You are not allowed to push code to this project. > fatal: unable to access 'https://gitlab.freedesktop.org/mesa/mesa.git/': > The requested URL returned error: 403 That's the main Mesa repository. You need to push to your forked repository[0] instead: https://gitlab.freedesktop.org//mesa.git [0] Make sure you did create a forked repository using the "Fork" button on https://gitlab.freedesktop.org/mesa/mesa before trying this, otherwise git push will create a non-forked project on the fly, which won't work for making MRs. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
Hi Michel, I tried with git push. It is failing with below error remote: You are not allowed to push code to this project. fatal: unable to access 'https://gitlab.freedesktop.org/mesa/mesa.git/': The requested URL returned error: 403 regards, Satyajit On 1/3/2020 9:30 PM, Michel Dänzer wrote: [CAUTION: External Email] On 2020-01-03 10:06 a.m., Sahu, Satyajit wrote: I do not find new merge request option in the merge request page. Do I need to have some specific access to create new merge request. No, just being logged into your GitLab account should be enough. Note that it's probably easier to create an MR by clicking on the URL in the git push terminal output when pushing to the branch in your forked repository. -- Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.comdata=02%7C01%7Csatyajit.sahu%40amd.com%7Cfdd53b72f98e464165ee08d79066183b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637136640495200981sdata=T5CDj9o4wF3j1yfGjXo7Zia%2BSNlmfxz4nxhqvQ71iS4%3Dreserved=0 Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
On 2020-01-03 10:06 a.m., Sahu, Satyajit wrote: > I do not find new merge request option in the merge request page. Do I > need to have some specific access to create new merge request. No, just being logged into your GitLab account should be enough. Note that it's probably easier to create an MR by clicking on the URL in the git push terminal output when pushing to the branch in your forked repository. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
I do not find new merge request option in the merge request page. Do I need to have some specific access to create new merge request. On 1/3/2020 2:05 AM, Liu, Leo wrote: The mesa process has switched to using merge requests. -Original Message- From: mesa-dev On Behalf Of Satyajit Sahu Sent: Tuesday, December 24, 2019 4:39 AM To: mesa-dev@lists.freedesktop.org Cc: Sharma, Deepak ; Sahu, Satyajit Subject: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder Set proper cropping parameter if frame cropping is enabled Signed-off-by: Satyajit Sahu diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index aa9182f273b..0bcce867327 100644 --- a/src/gallium/drivers/radeon/radeon_vcn_enc.c +++ b/src/gallium/drivers/radeon/radeon_vcn_enc.c @@ -52,10 +52,17 @@ static void radeon_vcn_enc_get_param(struct radeon_encoder *enc, struct pipe_pic enc->enc_pic.ref_idx_l1 = pic->ref_idx_l1; enc->enc_pic.not_referenced = pic->not_referenced; enc->enc_pic.is_idr = (pic->picture_type == PIPE_H264_ENC_PICTURE_TYPE_IDR); - enc->enc_pic.crop_left = 0; - enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; - enc->enc_pic.crop_top = 0; - enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + if (pic->pic_ctrl.enc_frame_cropping_flag) { + enc->enc_pic.crop_left = pic->pic_ctrl.enc_frame_crop_left_offset; + enc->enc_pic.crop_right = pic->pic_ctrl.enc_frame_crop_right_offset; + enc->enc_pic.crop_top = pic->pic_ctrl.enc_frame_crop_top_offset; + enc->enc_pic.crop_bottom = pic->pic_ctrl.enc_frame_crop_bottom_offset; + } else { + enc->enc_pic.crop_left = 0; + enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; + enc->enc_pic.crop_top = 0; + enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + } enc->enc_pic.rc_layer_init.target_bit_rate = pic->rate_ctrl.target_bitrate; enc->enc_pic.rc_layer_init.peak_bit_rate = pic->rate_ctrl.peak_bitrate; enc->enc_pic.rc_layer_init.frame_rate_num = pic->rate_ctrl.frame_rate_num; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
The mesa process has switched to using merge requests. -Original Message- From: mesa-dev On Behalf Of Satyajit Sahu Sent: Tuesday, December 24, 2019 4:39 AM To: mesa-dev@lists.freedesktop.org Cc: Sharma, Deepak ; Sahu, Satyajit Subject: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder Set proper cropping parameter if frame cropping is enabled Signed-off-by: Satyajit Sahu diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index aa9182f273b..0bcce867327 100644 --- a/src/gallium/drivers/radeon/radeon_vcn_enc.c +++ b/src/gallium/drivers/radeon/radeon_vcn_enc.c @@ -52,10 +52,17 @@ static void radeon_vcn_enc_get_param(struct radeon_encoder *enc, struct pipe_pic enc->enc_pic.ref_idx_l1 = pic->ref_idx_l1; enc->enc_pic.not_referenced = pic->not_referenced; enc->enc_pic.is_idr = (pic->picture_type == PIPE_H264_ENC_PICTURE_TYPE_IDR); - enc->enc_pic.crop_left = 0; - enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; - enc->enc_pic.crop_top = 0; - enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + if (pic->pic_ctrl.enc_frame_cropping_flag) { + enc->enc_pic.crop_left = pic->pic_ctrl.enc_frame_crop_left_offset; + enc->enc_pic.crop_right = pic->pic_ctrl.enc_frame_crop_right_offset; + enc->enc_pic.crop_top = pic->pic_ctrl.enc_frame_crop_top_offset; + enc->enc_pic.crop_bottom = pic->pic_ctrl.enc_frame_crop_bottom_offset; + } else { + enc->enc_pic.crop_left = 0; + enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; + enc->enc_pic.crop_top = 0; + enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + } enc->enc_pic.rc_layer_init.target_bit_rate = pic->rate_ctrl.target_bitrate; enc->enc_pic.rc_layer_init.peak_bit_rate = pic->rate_ctrl.peak_bitrate; enc->enc_pic.rc_layer_init.frame_rate_num = pic->rate_ctrl.frame_rate_num; -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-devdata=02%7C01%7Cleo.liu%40amd.com%7Cebe0ab52bd1948be95b108d788552cd2%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637127771729035994sdata=8APh%2FJucqePZPxtib0Wg5spsKYysUtAlzR6W34muOcc%3Dreserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder
Set proper cropping parameter if frame cropping is enabled Signed-off-by: Satyajit Sahu diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index aa9182f273b..0bcce867327 100644 --- a/src/gallium/drivers/radeon/radeon_vcn_enc.c +++ b/src/gallium/drivers/radeon/radeon_vcn_enc.c @@ -52,10 +52,17 @@ static void radeon_vcn_enc_get_param(struct radeon_encoder *enc, struct pipe_pic enc->enc_pic.ref_idx_l1 = pic->ref_idx_l1; enc->enc_pic.not_referenced = pic->not_referenced; enc->enc_pic.is_idr = (pic->picture_type == PIPE_H264_ENC_PICTURE_TYPE_IDR); - enc->enc_pic.crop_left = 0; - enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; - enc->enc_pic.crop_top = 0; - enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + if (pic->pic_ctrl.enc_frame_cropping_flag) { + enc->enc_pic.crop_left = pic->pic_ctrl.enc_frame_crop_left_offset; + enc->enc_pic.crop_right = pic->pic_ctrl.enc_frame_crop_right_offset; + enc->enc_pic.crop_top = pic->pic_ctrl.enc_frame_crop_top_offset; + enc->enc_pic.crop_bottom = pic->pic_ctrl.enc_frame_crop_bottom_offset; + } else { + enc->enc_pic.crop_left = 0; + enc->enc_pic.crop_right = (align(enc->base.width, 16) - enc->base.width) / 2; + enc->enc_pic.crop_top = 0; + enc->enc_pic.crop_bottom = (align(enc->base.height, 16) - enc->base.height) / 2; + } enc->enc_pic.rc_layer_init.target_bit_rate = pic->rate_ctrl.target_bitrate; enc->enc_pic.rc_layer_init.peak_bit_rate = pic->rate_ctrl.peak_bitrate; enc->enc_pic.rc_layer_init.frame_rate_num = pic->rate_ctrl.frame_rate_num; -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev