Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-12 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote: [...] None in this case other than I tend to avoid switch-case statements instinctively for some reason. But detecting missing cases during compile time sounds good, I've changed it to a

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: [SNIP] I also don't like that this way there is no difference between explicit and implicit kernel arguments. On the other hand it's

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: [SNIP] I also don't like that this way there is no difference between

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: [SNIP] I also don't like that

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-10 Thread Jan Vesely
On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: [SNIP] I also don't like that this way there is no difference between explicit and implicit kernel arguments. On the other hand it's simple, and does not need additional per

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-08 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: [SNIP] I also don't like that this way there is no difference between explicit and implicit kernel arguments. On the other hand it's simple, and does not need additional per driver code. Yeah... We definitely want to hide these from the

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-22 Thread Jan Vesely
[SNIP] I also don't like that this way there is no difference between explicit and implicit kernel arguments. On the other hand it's simple, and does not need additional per driver code. Yeah... We definitely want to hide these from the user, as e.g. the CL_KERNEL_NUM_ARGS

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-02 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Sat, 2014-08-16 at 13:13 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-02 Thread Jan Vesely
On Tue, 2014-09-02 at 15:36 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Sat, 2014-08-16 at 13:13 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-01 Thread Jan Vesely
On Sat, 2014-08-16 at 13:13 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-16 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit args

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-08 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Thu, Aug 07, 2014 at 04:02:40PM +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-08 Thread Jan Vesely
On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit args after the kernel args. Hmmm... Maybe it

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-07 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit args after the kernel args. Hmmm... Maybe it would make sense to add some sort of versioning (e.g. as part of

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-07 Thread Tom Stellard
On Thu, Aug 07, 2014 at 04:02:40PM +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit args after the kernel args. Hmmm...

[Mesa-dev] [PATCH 0/3] cl workdim v2

2014-08-06 Thread Jan Vesely
This respin includes Francisco's approach of providing implicit in the arg vector passed from clover, and Tom's idea of appending implicit args after the kernel args. I assumed it's not safe to modify exec.input, so the input vector is copied before appending work dim. Passes get-work-dim piglit