Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > radv was always just mirroring a derived version of the anv > version, sometimes hacked together and sometimes very behind. > > As we grow more vulkan drivers this repetition makes even less > sense, so lets merge them. I took the anv generators as the > template and made radv use them. > > This includes some messy stuff in the build system due to > difficulties with python includes. I tested with meson and > autotools. Android.mk is updated but not tested. > I've sent out a couple of fixup commits for 3/4 and 4/4. They remove the hacky PYTHONPATH, by introducing --import-path argument. An idea shamelessly copied from src/intel/compiler/brw_nir_trig_workarounds.py I haven't actually tested these - just getting it out to illustrate what I meant earlier. Feel free to reuse as much or as little as you like. HTH Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On Wed 08 Aug 2018, Bas Nieuwenhuizen wrote: > radv was always just mirroring a derived version of the anv > version, sometimes hacked together and sometimes very behind. > > As we grow more vulkan drivers this repetition makes even less > sense, so lets merge them. I took the anv generators as the > template and made radv use them. > > This includes some messy stuff in the build system due to > difficulties with python includes. I tested with meson and > autotools. Android.mk is updated but not tested. > > Bas Nieuwenhuizen (4): > vulkan: Add central copy of entrypoints/extensions code. > vulkan/util: Add support to not generate the trampolines. > anv: Use central api generation scripts. > radv: Integrate with common generators. git-am complains that patches 3 and 4 insert trailing whitespace. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On 08/08/2018 06:43 PM, Tapani Pälli wrote: On 08.08.2018 17:31, Lionel Landwerlin wrote: On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some messy stuff in the build system due to difficulties with python includes. I tested with meson and autotools. Android.mk is updated but not tested. We have an android build target in our CI. I can give this series a go. - Lionel Oh my bad, we don't actually have the Vulkan driver on Android as a target (just GL atm). I can try building with these changes on Android tomorrow. I did this and anv builds and works fine on Android with these changes. // Tapani ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On 08.08.2018 17:31, Lionel Landwerlin wrote: On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some messy stuff in the build system due to difficulties with python includes. I tested with meson and autotools. Android.mk is updated but not tested. We have an android build target in our CI. I can give this series a go. - Lionel Oh my bad, we don't actually have the Vulkan driver on Android as a target (just GL atm). I can try building with these changes on Android tomorrow. // Tapani ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some messy stuff in the build system due to difficulties with python includes. I tested with meson and autotools. Android.mk is updated but not tested. We have an android build target in our CI. I can give this series a go. - Lionel Oh my bad, we don't actually have the Vulkan driver on Android as a target (just GL atm). - Lionel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some messy stuff in the build system due to difficulties with python includes. I tested with meson and autotools. Android.mk is updated but not tested. We have an android build target in our CI. I can give this series a go. - Lionel Bas Nieuwenhuizen (4): vulkan: Add central copy of entrypoints/extensions code. vulkan/util: Add support to not generate the trampolines. anv: Use central api generation scripts. radv: Integrate with common generators. src/amd/vulkan/Android.mk | 16 +- src/amd/vulkan/Makefile.am | 29 +- src/amd/vulkan/meson.build | 91 ++-- src/amd/vulkan/radv_device.c| 56 ++- src/amd/vulkan/radv_entrypoints_gen.py | 462 +--- src/amd/vulkan/radv_extensions.py | 236 +-- src/amd/vulkan/radv_extensions_gen.py | 44 ++ src/amd/vulkan/radv_icd.py | 1 + src/amd/vulkan/radv_private.h | 9 +- src/amd/vulkan/radv_wsi.c | 6 +- src/intel/Android.vulkan.mk | 9 + src/intel/Makefile.vulkan.am| 25 +- src/intel/vulkan/anv_device.c | 46 ++ src/intel/vulkan/anv_entrypoints_gen.py | 537 +--- src/intel/vulkan/anv_extensions.py | 68 +-- src/intel/vulkan/anv_extensions_gen.py | 177 +--- src/intel/vulkan/meson.build| 15 +- src/vulkan/Makefile.am | 3 + src/vulkan/util/meson.build | 2 + src/vulkan/util/vk_entrypoints_gen.py | 522 +++ src/vulkan/util/vk_extensions.py| 93 src/vulkan/util/vk_extensions_gen.py| 205 + 22 files changed, 1131 insertions(+), 1521 deletions(-) create mode 100644 src/amd/vulkan/radv_extensions_gen.py create mode 100644 src/vulkan/util/vk_entrypoints_gen.py create mode 100644 src/vulkan/util/vk_extensions.py create mode 100644 src/vulkan/util/vk_extensions_gen.py ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/4] Merge vulkan API generators.
radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the template and made radv use them. This includes some messy stuff in the build system due to difficulties with python includes. I tested with meson and autotools. Android.mk is updated but not tested. Bas Nieuwenhuizen (4): vulkan: Add central copy of entrypoints/extensions code. vulkan/util: Add support to not generate the trampolines. anv: Use central api generation scripts. radv: Integrate with common generators. src/amd/vulkan/Android.mk | 16 +- src/amd/vulkan/Makefile.am | 29 +- src/amd/vulkan/meson.build | 91 ++-- src/amd/vulkan/radv_device.c| 56 ++- src/amd/vulkan/radv_entrypoints_gen.py | 462 +--- src/amd/vulkan/radv_extensions.py | 236 +-- src/amd/vulkan/radv_extensions_gen.py | 44 ++ src/amd/vulkan/radv_icd.py | 1 + src/amd/vulkan/radv_private.h | 9 +- src/amd/vulkan/radv_wsi.c | 6 +- src/intel/Android.vulkan.mk | 9 + src/intel/Makefile.vulkan.am| 25 +- src/intel/vulkan/anv_device.c | 46 ++ src/intel/vulkan/anv_entrypoints_gen.py | 537 +--- src/intel/vulkan/anv_extensions.py | 68 +-- src/intel/vulkan/anv_extensions_gen.py | 177 +--- src/intel/vulkan/meson.build| 15 +- src/vulkan/Makefile.am | 3 + src/vulkan/util/meson.build | 2 + src/vulkan/util/vk_entrypoints_gen.py | 522 +++ src/vulkan/util/vk_extensions.py| 93 src/vulkan/util/vk_extensions_gen.py| 205 + 22 files changed, 1131 insertions(+), 1521 deletions(-) create mode 100644 src/amd/vulkan/radv_extensions_gen.py create mode 100644 src/vulkan/util/vk_entrypoints_gen.py create mode 100644 src/vulkan/util/vk_extensions.py create mode 100644 src/vulkan/util/vk_extensions_gen.py -- 2.18.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
