Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Thanks.. my expectation is that ~0 gets cast to the same enum on both sides of the != so I *think* we should be good. BR, -R On Sat, Aug 6, 2016 at 9:05 AM, Francesco Ansanelli wrote: > Hello, > > I did more tests... and I didn't experience any error. > I attach last

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Hello, I did more tests... and I didn't experience any error. I attach last version of the script. Cheers, Francesco 2016-08-04 19:50 GMT+02:00 Francesco Ansanelli : > Hi Eric, > > after your question: > > [snip] > I expect, with enums having varying size, that this cast

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Hi Eric, after your question: [snip] I expect, with enums having varying size, that this cast will not always work. [snip] I started a script for testing with variable enum sizes and compilers... If does makes sense to you, I'll try to loop from 1 to n (suggestions?) and build with gcc and

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

On Mon, Aug 1, 2016 at 8:10 AM, Eric Engestrom wrote: > On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: >> Signed-off-by: Francesco Ansanelli >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index