Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-05 Thread Ian Romanick
On 09/04/2013 05:43 PM, Timothy Arceri wrote: +/** + * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel(). + */ +static void +set_label(struct gl_context *ctx, char **labelPtr, const char *label, + int length, const char *caller) +{ + if (*labelPtr) { + /* free

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-05 Thread Timothy Arceri
On Wed, 2013-09-04 at 20:09 -0700, Ian Romanick wrote: On 09/04/2013 05:43 PM, Timothy Arceri wrote: +/** + * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel(). + */ +static void +set_label(struct gl_context *ctx, char **labelPtr, const char *label, + int length,

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-05 Thread Brian Paul
On 09/04/2013 09:09 PM, Ian Romanick wrote: In the mean time, we should land Brian's patch to fix 'make check'. Does that imply your R-b? -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-05 Thread Brian Paul
On 09/05/2013 01:05 AM, Timothy Arceri wrote: I also have one more question about working on Mesa. Is there a wiki page or something where developers register who is working on what extension to avoid double up? There's no such page right now. People sometimes will post a message to say

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-05 Thread Ian Romanick
On 09/05/2013 09:57 AM, Brian Paul wrote: On 09/04/2013 09:09 PM, Ian Romanick wrote: In the mean time, we should land Brian's patch to fix 'make check'. Does that imply your R-b? Yeah. I meant to go ahead and reply (again) to the patch. It was getting late, and I forgot. -Brian

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-04 Thread Ian Romanick
On 08/26/2013 03:43 AM, Timothy Arceri wrote: Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/mesa/main/objectlabel.c | 277 +++ src/mesa/main/objectlabel.h | 61 ++ 2 files changed, 338 insertions(+) create mode 100644

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-04 Thread Timothy Arceri
+/** + * Helper for _mesa_ObjectLabel() and _mesa_ObjectPtrLabel(). + */ +static void +set_label(struct gl_context *ctx, char **labelPtr, const char *label, +          int length, const char *caller) +{ +  if (*labelPtr) { +      /* free old label string */ +      free(*labelPtr); + 

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-09-04 Thread Timothy Arceri
+         /* explicit length */ +         *labelPtr = (char *) malloc(length); +         if (*labelPtr) { +            memcpy(*labelPtr, label, length); +         } +      } +      else { +         /* null-terminated string */ +         int len = strlen(label); +         if (len =

[Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-08-26 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/mesa/main/objectlabel.c | 277 +++ src/mesa/main/objectlabel.h | 61 ++ 2 files changed, 338 insertions(+) create mode 100644 src/mesa/main/objectlabel.c create mode 100644

Re: [Mesa-dev] [PATCH 10/15] mesa: Implement KHR_debug ObjectLabel functions

2013-08-26 Thread Brian Paul
On 08/26/2013 04:43 AM, Timothy Arceri wrote: Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/mesa/main/objectlabel.c | 277 +++ src/mesa/main/objectlabel.h | 61 ++ 2 files changed, 338 insertions(+) create mode 100644