Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Tom Stellard
On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: Make the function static. No need to cc llvm-commits on these mesa patches. Reviewers follow both lists. This needs corresponding change in LLVM otherwise it breaks parameter passing CC: Tom Stellard t...@stellard.net CC: Matt

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Jan Vesely
On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: Make the function static. No need to cc llvm-commits on these mesa patches. Reviewers follow both lists. sorry about that This needs corresponding change in LLVM

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Tom Stellard
On Thu, Jul 31, 2014 at 01:28:45PM -0400, Jan Vesely wrote: On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: Make the function static. No need to cc llvm-commits on these mesa patches. Reviewers follow both lists.

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Jan Vesely
On Thu, 2014-07-31 at 14:58 -0400, Tom Stellard wrote: On Thu, Jul 31, 2014 at 01:28:45PM -0400, Jan Vesely wrote: On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: Make the function static. No need to cc

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Matt Arsenault
On 07/31/2014 03:58 PM, Jan Vesely wrote: Would that work with things like one kernel calling another kernel? If we had a function called from two kernels how would it know where to look? I don't think this case can be handled as 2 separate kernels with the same calling convention. If a kernel

[Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-30 Thread Jan Vesely
Make the function static. This needs corresponding change in LLVM otherwise it breaks parameter passing CC: Tom Stellard t...@stellard.net CC: Matt Arsenault matthew.arsena...@amd.com Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/drivers/r600/evergreen_compute.c | 26