Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Marek Olšák
On Mon, May 2, 2016 at 9:51 PM, Rob Clark wrote: > On Mon, May 2, 2016 at 3:21 PM, Marek Olšák wrote: >> On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: >>> This is for the non-zero-copy case.. for example pixels live in gl >>>

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Rob Clark
On Mon, May 2, 2016 at 3:21 PM, Marek Olšák wrote: > On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: >> This is for the non-zero-copy case.. for example pixels live in gl >> texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps >> (or some

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Marek Olšák
On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: > This is for the non-zero-copy case.. for example pixels live in gl > texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps > (or some tiled format, etc). > > Since in those cases, you have to copy part of the

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Rob Clark
This is for the non-zero-copy case.. for example pixels live in gl texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps (or some tiled format, etc). Since in those cases, you have to copy part of the buffer, as specified by the bounding box, to and/or from staging buffer (based

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Greg Hackmann
On 05/01/2016 11:58 PM, Daniel Vetter wrote: Adding Greg Hackmann from the Android side. Greg, please add anyone else who might be relevant. On Sat, Apr 30, 2016 at 2:54 PM, Rob Clark wrote: On Sat, Apr 30, 2016 at 8:26 AM, Marek Olšák wrote: On Sat,

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-05-02 Thread Daniel Vetter
Adding Greg Hackmann from the Android side. Greg, please add anyone else who might be relevant. On Sat, Apr 30, 2016 at 2:54 PM, Rob Clark wrote: > On Sat, Apr 30, 2016 at 8:26 AM, Marek Olšák wrote: >> On Sat, Apr 30, 2016 at 1:55 PM, Rob Clark

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-30 Thread Rob Clark
On Sat, Apr 30, 2016 at 8:26 AM, Marek Olšák wrote: > On Sat, Apr 30, 2016 at 1:55 PM, Rob Clark wrote: >> On Sat, Apr 30, 2016 at 5:39 AM, Michel Dänzer wrote: >>> On 26.04.2016 03:51, Rob Herring wrote: On Mon, Apr 25, 2016 at

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-30 Thread Marek Olšák
On Sat, Apr 30, 2016 at 1:55 PM, Rob Clark wrote: > On Sat, Apr 30, 2016 at 5:39 AM, Michel Dänzer wrote: >> On 26.04.2016 03:51, Rob Herring wrote: >>> On Mon, Apr 25, 2016 at 9:25 AM, Emil Velikov >>> wrote: On 25 April

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-30 Thread Rob Clark
On Sat, Apr 30, 2016 at 5:39 AM, Michel Dänzer wrote: > On 26.04.2016 03:51, Rob Herring wrote: >> On Mon, Apr 25, 2016 at 9:25 AM, Emil Velikov >> wrote: >>> On 25 April 2016 at 13:46, Daniel Stone wrote: On 23 April

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-30 Thread Michel Dänzer
On 26.04.2016 03:51, Rob Herring wrote: > On Mon, Apr 25, 2016 at 9:25 AM, Emil Velikov > wrote: >> On 25 April 2016 at 13:46, Daniel Stone wrote: >>> On 23 April 2016 at 03:08, Rob Herring wrote: On Fri, Apr 22, 2016 at

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-28 Thread Eric Anholt
Rob Herring writes: > On Wed, Apr 27, 2016 at 5:01 PM, Emil Velikov > wrote: >> On 27 April 2016 at 19:51, Eric Anholt wrote: >>> Rob Herring writes: >>> On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Rob Herring
On Wed, Apr 27, 2016 at 5:01 PM, Emil Velikov wrote: > On 27 April 2016 at 19:51, Eric Anholt wrote: >> Rob Herring writes: >> >>> On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: Rob Herring

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Emil Velikov
On 27 April 2016 at 19:51, Eric Anholt wrote: > Rob Herring writes: > >> On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: >>> Rob Herring writes: >>> On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Eric Anholt
Rob Herring writes: > On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: >> Rob Herring writes: >> >>> On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring wrote: On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Rob Herring
On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: > Rob Herring writes: > >> On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring wrote: >>> On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov >>> wrote: Hi Rob,

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Eric Anholt
Rob Herring writes: > On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring wrote: >> On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov >> wrote: >>> Hi Rob, >>> >>> On 22 April 2016 at 16:50, Rob Herring wrote: This adds

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Rob Herring
On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring wrote: > On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov > wrote: >> Hi Rob, >> >> On 22 April 2016 at 16:50, Rob Herring wrote: >>> This adds map and unmap functions to GBM utilizing the

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Rob Herring
On Mon, Apr 25, 2016 at 9:25 AM, Emil Velikov wrote: > Hi all, > > On 25 April 2016 at 13:46, Daniel Stone wrote: >> Hi, >> >> On 23 April 2016 at 03:08, Rob Herring wrote: >>> On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Daniel Stone
Hi, On 25 April 2016 at 15:25, Emil Velikov wrote: > On 25 April 2016 at 13:46, Daniel Stone wrote: >> On 23 April 2016 at 03:08, Rob Herring wrote: >>> I'm not using GBM_BO_USE_WRITE and that is not a condition for mapping >>>

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Emil Velikov
Hi all, On 25 April 2016 at 13:46, Daniel Stone wrote: > Hi, > > On 23 April 2016 at 03:08, Rob Herring wrote: >> On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov >> wrote: >>> Can we take a look at the GBM gralloc as well. One

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Daniel Stone
Hi, On 23 April 2016 at 03:08, Rob Herring wrote: > On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov > wrote: >> Can we take a look at the GBM gralloc as well. One thing that worries >> me is that (most likely) you are requesting/creating a bo without >>

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-25 Thread Daniel Stone
Hi, On 22 April 2016 at 19:21, Eric Anholt wrote: > I don't think we want to always make a spare context just in case > someone uses the map API. Contexts can be pretty expensive to set up, > in time (for piglit tests on gbm) and memory (for X.Org). > > It's too bad I don't

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Rob Herring
On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov wrote: > Hi Rob, > > On 22 April 2016 at 16:50, Rob Herring wrote: >> This adds map and unmap functions to GBM utilizing the DRIimage extension >> mapImage/unmapImage functions or existing internal mapping

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Emil Velikov
Hi Rob, On 22 April 2016 at 16:50, Rob Herring wrote: > This adds map and unmap functions to GBM utilizing the DRIimage extension > mapImage/unmapImage functions or existing internal mapping for dumb > buffers. Ftr that this is quite sensitive and apart from the obvious breakage

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Rob Herring
On Fri, Apr 22, 2016 at 1:21 PM, Eric Anholt wrote: > Rob Herring writes: > >> This adds map and unmap functions to GBM utilizing the DRIimage extension >> mapImage/unmapImage functions or existing internal mapping for dumb >> buffers. Unlike prior attempts,

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Eric Anholt
Rob Herring writes: > This adds map and unmap functions to GBM utilizing the DRIimage extension > mapImage/unmapImage functions or existing internal mapping for dumb > buffers. Unlike prior attempts, this version provides a region to map and > usage flags for the mapping. The

[Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Rob Herring
This adds map and unmap functions to GBM utilizing the DRIimage extension mapImage/unmapImage functions or existing internal mapping for dumb buffers. Unlike prior attempts, this version provides a region to map and usage flags for the mapping. The operation follows the same semantics as the