Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

2016-07-29 Thread Emil Velikov
On 28 July 2016 at 14:58, Stefan Dirsch wrote: > On Thu, Jul 14, 2016 at 05:20:55PM +0100, Emil Velikov wrote: >> On 14 July 2016 at 15:23, Eric Engestrom wrote: >> > On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: >> >> This 'last'

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

2016-07-28 Thread Stefan Dirsch
On Thu, Jul 14, 2016 at 05:20:55PM +0100, Emil Velikov wrote: > On 14 July 2016 at 15:23, Eric Engestrom wrote: > > On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: > >> This 'last' variable used in FindGLXFunction(...) may become negative, > >> but has

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

2016-07-14 Thread Emil Velikov
On 14 July 2016 at 15:23, Eric Engestrom wrote: > On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: >> This 'last' variable used in FindGLXFunction(...) may become negative, >> but has been defined as unsigned int resulting in an overflow, >> finally

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

2016-07-14 Thread Eric Engestrom
On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: > This 'last' variable used in FindGLXFunction(...) may become negative, > but has been defined as unsigned int resulting in an overflow, > finally resulting in a segfault when accessing _glXDispatchTableStrings[...]. > Fixed this by

[Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

2016-07-14 Thread Stefan Dirsch
This 'last' variable used in FindGLXFunction(...) may become negative, but has been defined as unsigned int resulting in an overflow, finally resulting in a segfault when accessing _glXDispatchTableStrings[...]. Fixed this by definining it as signed int. 'first' variable also needs to be defined