Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

On Sat, Jul 30, 2016 at 07:44:02PM +0200, Marek Olšák wrote: > On Sat, Jul 30, 2016 at 6:16 PM, Roland Scheidegger > wrote: > > This looks very bogus to me. > > How is this supposed to work if you immediately close the library again? > > The functions are still going to get

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

On Sat, Jul 30, 2016 at 6:16 PM, Roland Scheidegger wrote: > This looks very bogus to me. > How is this supposed to work if you immediately close the library again? > The functions are still going to get used. > This just segfaults right, left and center. > > If you want to

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

This looks very bogus to me. How is this supposed to work if you immediately close the library again? The functions are still going to get used. This just segfaults right, left and center. If you want to fix this for real, some util_format_s3tc_exit() is probably needed, albeit I'm not entirely

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

Pushed, thanks. Marek On Sat, Jul 30, 2016 at 2:35 AM, Eric Engestrom wrote: > CovID: 401540 > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

Reviewed-by: Edward O'Callaghan On 07/30/2016 10:35 AM, Eric Engestrom wrote: > CovID: 401540 > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

CovID: 401540 Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c index 8c4f215..1ed4336 100644 ---