Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-28 Thread Cherniak, Bruce
> On Apr 28, 2017, at 3:20 PM, Ilia Mirkin wrote: > > On Fri, Apr 28, 2017 at 3:58 PM, Cherniak, Bruce > wrote: >> >>> On Apr 27, 2017, at 7:50 PM, Ilia Mirkin wrote: >>> >>> On Thu, Apr 27, 2017 at 8:45 PM, Cherniak,

Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-28 Thread Ilia Mirkin
On Fri, Apr 28, 2017 at 3:58 PM, Cherniak, Bruce wrote: > >> On Apr 27, 2017, at 7:50 PM, Ilia Mirkin wrote: >> >> On Thu, Apr 27, 2017 at 8:45 PM, Cherniak, Bruce >> wrote: >>> On Apr 27, 2017, at 7:38 PM, Ilia

Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-28 Thread Cherniak, Bruce
> On Apr 27, 2017, at 7:50 PM, Ilia Mirkin wrote: > > On Thu, Apr 27, 2017 at 8:45 PM, Cherniak, Bruce > wrote: >> >>> On Apr 27, 2017, at 7:38 PM, Ilia Mirkin wrote: >>> >>> Erm, so ... what happens if I render to FB1,

Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-27 Thread Ilia Mirkin
On Thu, Apr 27, 2017 at 8:45 PM, Cherniak, Bruce wrote: > >> On Apr 27, 2017, at 7:38 PM, Ilia Mirkin wrote: >> >> Erm, so ... what happens if I render to FB1, then render to FB2, then >> render to FB1 again (and I have blending enabled)? Doesn't

Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-27 Thread Cherniak, Bruce
> On Apr 27, 2017, at 7:38 PM, Ilia Mirkin wrote: > > Erm, so ... what happens if I render to FB1, then render to FB2, then > render to FB1 again (and I have blending enabled)? Doesn't the resolve > lose the per-sample information? Or does the resolve merely precompute >

Re: [Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-27 Thread Ilia Mirkin
Erm, so ... what happens if I render to FB1, then render to FB2, then render to FB1 again (and I have blending enabled)? Doesn't the resolve lose the per-sample information? Or does the resolve merely precompute the resolved version on the off chance that it's needed, without losing the source

[Mesa-dev] [PATCH v2] swr: move msaa resolve to generalized StoreTile

2017-04-27 Thread Bruce Cherniak
v2: Reword commit message to more closely adhere to community guidelines. This patch moves msaa resolve down into core/StoreTiles where the surface format conversion routines are available. The previous "experimental" resolve was limited to 8-bit unsigned render targets. This fixes a number of