Re: [Mesa-dev] [PATCH v2 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-27 Thread Lucas Stach 
Am Dienstag, den 26.02.2019, 19:15 +0100 schrieb Christian Gmeiner:
> Signed-off-by: Christian Gmeiner 

Reviewed-by: Lucas Stach 

> ---
>  src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +---
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c 
> b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index de822fc85ca..ee32a499fb5 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> @@ -518,19 +518,9 @@ gpu_supports_texure_format(struct etna_screen *screen, 
> uint32_t fmt,
> if (util_format_is_srgb(format))
>    supported = VIV_FEATURE(screen, chipMinorFeatures1, HALTI0);
>  
> -   if (fmt & EXT_FORMAT) {
> +   if (fmt & EXT_FORMAT)
>    supported = VIV_FEATURE(screen, chipMinorFeatures1, HALTI0);
>  
> -  /* ETC1 is checked above, as it has its own feature bit. ETC2 is
> -   * supported with HALTI0, however that implementation is buggy in 
> hardware.
> -   * The blob driver does per-block patching to work around this. As this
> -   * is currently not implemented by etnaviv, enable it for HALTI1 
> (GC3000)
> -   * only.
> -   */
> -  if (util_format_is_etc(format))
> - supported = VIV_FEATURE(screen, chipMinorFeatures2, HALTI1);
> -   }
> -
> if (fmt & ASTC_FORMAT) {
>    supported = screen->specs.tex_astc;
> }
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 4/4] etnaviv: enable ETC2 texture compression support for HALTI0 GPUs

2019-02-26 Thread Christian Gmeiner 
Signed-off-by: Christian Gmeiner 
---
 src/gallium/drivers/etnaviv/etnaviv_screen.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c 
b/src/gallium/drivers/etnaviv/etnaviv_screen.c
index de822fc85ca..ee32a499fb5 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
@@ -518,19 +518,9 @@ gpu_supports_texure_format(struct etna_screen *screen, 
uint32_t fmt,
if (util_format_is_srgb(format))
   supported = VIV_FEATURE(screen, chipMinorFeatures1, HALTI0);
 
-   if (fmt & EXT_FORMAT) {
+   if (fmt & EXT_FORMAT)
   supported = VIV_FEATURE(screen, chipMinorFeatures1, HALTI0);
 
-  /* ETC1 is checked above, as it has its own feature bit. ETC2 is
-   * supported with HALTI0, however that implementation is buggy in 
hardware.
-   * The blob driver does per-block patching to work around this. As this
-   * is currently not implemented by etnaviv, enable it for HALTI1 (GC3000)
-   * only.
-   */
-  if (util_format_is_etc(format))
- supported = VIV_FEATURE(screen, chipMinorFeatures2, HALTI1);
-   }
-
if (fmt & ASTC_FORMAT) {
   supported = screen->specs.tex_astc;
}
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev