Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On 29/08/2019 01:12, Dave Airlie wrote:
> On Tue, 27 Aug 2019 at 20:30, Jose Fonseca wrote:
>>
>> FYI, I've followed Eric Engestroms' instructions for better Mesa <->
>> AppVeyor integration. (Thanks Eric.)
>>
>> I haven't tested, but hopefully this new integration method should now
>> trigger Appveyor builds on pull requests too, which should come handy.
>>
>> I'm still keeping the old webhook method integration around (with a
>> different name.) So the list might receive duplicate notifications. I'll
>> disable this when we're satisfied the new method works well.
>>
>> For the record, these Appveyor runs are running on a separate Appveyor
>> account dedicated for Mesa and FDO projects like Piglit, and not my personal
>> Appveyor account.
>
> It appears all the results are going to mesa-dev, is there a way to
> send them to the same ppl that would get them from gitlab?
>
> I push to some of my PRs quite a lot (esp when llvm version wrangling).
>
> Dave.
>
That would indeed be the ideal, but I don't know how to do that selectively.
Per https://www.appveyor.com/docs/notifications/ one can use
`{{commitAuthorEmail}}`, but then this would apply to all builds (PRs
and non PRs alike.
It seems the only solution is two have two integrations -- one running
master CC mesa-dev, another running PRs CC'ing the authors. But from
another mail on this thread, perhaps a better solution is to add a
Gitlab Pipeline -> Appveyor trigger, which waits for the result.
I'm afraid I don't have the time right now to dig into this. On one
hand, better integration would be nice, on the other, it might be easier
to wait and see of Appevyor <-> Gitlab gets better by itself upstream.
For now I've disabled PR -> Appveyor builds to keep the noise level down.
Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On Tue, 27 Aug 2019 at 20:30, Jose Fonseca wrote: > > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> AppVeyor > integration. (Thanks Eric.) > > I haven't tested, but hopefully this new integration method should now > trigger Appveyor builds on pull requests too, which should come handy. > > I'm still keeping the old webhook method integration around (with a different > name.) So the list might receive duplicate notifications. I'll disable this > when we're satisfied the new method works well. > > For the record, these Appveyor runs are running on a separate Appveyor > account dedicated for Mesa and FDO projects like Piglit, and not my personal > Appveyor account. It appears all the results are going to mesa-dev, is there a way to send them to the same ppl that would get them from gitlab? I push to some of my PRs quite a lot (esp when llvm version wrangling). Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
Hi, On Wed, 28 Aug 2019 at 11:18, Michel Dänzer wrote: > On 2019-08-28 3:08 a.m., Eric Engestrom wrote: > > On Tuesday, 2019-08-27 13:31:22 +, Jose Fonseca wrote: > >> Appveyor seems to be building other MR 1781: > >> > >> https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/26989425 > >> https://ci.appveyor.com/project/mesa3d/mesa-re1yd/history > >> https://gitlab.freedesktop.org/eric/mesa/pipelines/59190 > > > > You shouldn't take my MRs as an example for this, as I've set up the > > hook on my account, so my MRs always get picked up by appveyor :) > > Yeah, the external integration settings are per GitLab project, and > pre-merge CI pipelines for MRs run in the source project context, so the > appveyor integration would need to be set up in each forked project used > for MRs. > > This is a bit unfortunate, as it means the CI pipeline which runs (in > the main project context) after an MR is merged could fail at the > appveyor step, even if the pre-merge pipeline passed. > > Not sure what can be done about this though, other than requiring forked > projects used for MRs to set up the appveyor integration as well. To be honest, given the relative immaturity of external-job reporting, and some of the problems reported in #freedesktop for NetworkManager using it, I would probably suggest not using it. For Panfrost CI, which executes on an external system (LAVA), we create a new job in the GitLab CI pipeline with the 'idle-jobs' tag, which submits an HTTP request to LAVA to schedule the job, then sits waiting for it to report results and logs back. The 'idle-jobs' runner can do something like 64 concurrent jobs, as it's supposed to only be used for things like this. That might help with some of the flakiness, and bring the result reporting in line with the rest of execution. Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On 28/08/2019 11:18, Michel Dänzer wrote: > On 2019-08-28 3:08 a.m., Eric Engestrom wrote: >> On Tuesday, 2019-08-27 13:31:22 +, Jose Fonseca wrote: >>> Appveyor seems to be building other MR 1781: >>> >>> >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fbuilds%2F26989425data=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606sdata=1UouYWYgyMdOVBEvlQgjByq3Scl2yyy%2FEJKfrIM7vNk%3Dreserved=0 >>> >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fhistorydata=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606sdata=uefH8tE%2F0i8D8hn8W9i%2BsS61OuPYrKoAVxNoJkBfS3c%3Dreserved=0 >>> >>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Feric%2Fmesa%2Fpipelines%2F59190data=02%7C01%7Cjfonseca%40vmware.com%7Cfe3cd31e967944da212808d72ba11193%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637025843105542606sdata=wIlfbXS1USrnLRnLQJ5sMqDTtyQ2cDTYRolH6UezXco%3Dreserved=0 >> >> You shouldn't take my MRs as an example for this, as I've set up the >> hook on my account, so my MRs always get picked up by appveyor :) > > Yeah, the external integration settings are per GitLab project, and > pre-merge CI pipelines for MRs run in the source project context, so the > appveyor integration would need to be set up in each forked project used > for MRs. > > This is a bit unfortunate, as it means the CI pipeline which runs (in > the main project context) after an MR is merged could fail at the > appveyor step, even if the pre-merge pipeline passed. > > Not sure what can be done about this though, other than requiring forked > projects used for MRs to set up the appveyor integration as well. > > That's unfortunate. Though it looks like Appveyor is actually running MRs: https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/27008264 and notifying mesa-dev about failures: https://lists.freedesktop.org/archives/mesa-dev/2019-August/222329.html It's just unfortunate that there's no mention of it on the actual MR page https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1743 Caio, did you happen to receive any direct email from this? If we can't get these MRs notifcations right, then I think we're better off not running for MRs. To avoid spamming the list. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On 2019-08-28 3:08 a.m., Eric Engestrom wrote: > On Tuesday, 2019-08-27 13:31:22 +, Jose Fonseca wrote: >> Appveyor seems to be building other MR 1781: >> >> https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/26989425 >> https://ci.appveyor.com/project/mesa3d/mesa-re1yd/history >> https://gitlab.freedesktop.org/eric/mesa/pipelines/59190 > > You shouldn't take my MRs as an example for this, as I've set up the > hook on my account, so my MRs always get picked up by appveyor :) Yeah, the external integration settings are per GitLab project, and pre-merge CI pipelines for MRs run in the source project context, so the appveyor integration would need to be set up in each forked project used for MRs. This is a bit unfortunate, as it means the CI pipeline which runs (in the main project context) after an MR is merged could fail at the appveyor step, even if the pre-merge pipeline passed. Not sure what can be done about this though, other than requiring forked projects used for MRs to set up the appveyor integration as well. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
I'm not following. I picked MR 1781 not because it was yours, but because it was running on my appveyor account -- https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/26989425 . See for yourself on https://ci.appveyor.com/project/mesa3d/mesa-re1yd/history -- there's plenty of MRs being run there. Here's another one from another person: https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/27006958 The odd thing is that there's no report of Appveyor on https://gitlab.freedesktop.org/cmarcelo/mesa/pipelines/59368 So it seems there are actually two problems: * appveyor is not running for some MRs * even when appveyor is running, it is not reporting back results for all MRs Jose From: Eric Engestrom Sent: Wednesday, August 28, 2019 02:08 To: Jose Fonseca Cc: mesa-dev@lists.freedesktop.org ; Brian Paul Subject: Re: Mesa GitLab <-> AppVeyor integration On Tuesday, 2019-08-27 13:31:22 +, Jose Fonseca wrote: > Appveyor seems to be building other MR 1781: > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fbuilds%2F26989425data=02%7C01%7Cjfonseca%40vmware.com%7C46b201504bcd45aca1f408d72b544469%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025513249945766sdata=1jROCgNnCM04pscw1K%2FoUWF5qlqWKxzfyW9jbld%2FPoY%3Dreserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci.appveyor.com%2Fproject%2Fmesa3d%2Fmesa-re1yd%2Fhistorydata=02%7C01%7Cjfonseca%40vmware.com%7C46b201504bcd45aca1f408d72b544469%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025513249945766sdata=6pqEuMnrInz7jF4ymROan8nfmPpxx%2BEuk4G9FrKd8ts%3Dreserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Feric%2Fmesa%2Fpipelines%2F59190data=02%7C01%7Cjfonseca%40vmware.com%7C46b201504bcd45aca1f408d72b544469%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025513249955761sdata=XICobt%2BBKAIcu8WCtN%2B%2B98w0Mnk5JlIehxjbBaikoOI%3Dreserved=0 You shouldn't take my MRs as an example for this, as I've set up the hook on my account, so my MRs always get picked up by appveyor :) > > I don't know what's special about MR 1779. Perhaps it's just the sheer > volume of merges and merge requests? > > Jose > > > From: Eric Engestrom > Sent: Tuesday, August 27, 2019 14:23 > To: Jose Fonseca > Cc: mesa-dev@lists.freedesktop.org ; Brian > Paul > Subject: Re: Mesa GitLab <-> AppVeyor integration > > On Tuesday, 2019-08-27 10:30:07 +, Jose Fonseca wrote: > > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> > > AppVeyor integration. (Thanks Eric.) > > > > I haven't tested, but hopefully this new integration method should now > > trigger Appveyor builds on pull requests too, which should come handy. > > > > I'm still keeping the old webhook method integration around (with a > > different name.) So the list might receive duplicate notifications. I'll > > disable this when we're satisfied the new method works well. > > > > For the record, these Appveyor runs are running on a separate Appveyor > > account dedicated for Mesa and FDO projects like Piglit, and not my > > personal Appveyor account. > > > > Jose > > Thanks! > > Looks like it didn't quite work though... MR !1779 [1] was created after > your email, and doesn't have the [external/appveyor] job on its pipeline. > > I doubt there's much I could do that you can't to try to debug this, but > feel free to ask me :) > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fmerge_requests%2F1779data=02%7C01%7Cjfonseca%40vmware.com%7C46b201504bcd45aca1f408d72b544469%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025513249955761sdata=IbHZhB9FV3mATtyZk2WbJKHfxK4xFn9gFoz2BK3CN%2BQ%3Dreserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On Tuesday, 2019-08-27 13:31:22 +, Jose Fonseca wrote: > Appveyor seems to be building other MR 1781: > > https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/26989425 > https://ci.appveyor.com/project/mesa3d/mesa-re1yd/history > https://gitlab.freedesktop.org/eric/mesa/pipelines/59190 You shouldn't take my MRs as an example for this, as I've set up the hook on my account, so my MRs always get picked up by appveyor :) > > I don't know what's special about MR 1779. Perhaps it's just the sheer > volume of merges and merge requests? > > Jose > > > From: Eric Engestrom > Sent: Tuesday, August 27, 2019 14:23 > To: Jose Fonseca > Cc: mesa-dev@lists.freedesktop.org ; Brian > Paul > Subject: Re: Mesa GitLab <-> AppVeyor integration > > On Tuesday, 2019-08-27 10:30:07 +, Jose Fonseca wrote: > > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> > > AppVeyor integration. (Thanks Eric.) > > > > I haven't tested, but hopefully this new integration method should now > > trigger Appveyor builds on pull requests too, which should come handy. > > > > I'm still keeping the old webhook method integration around (with a > > different name.) So the list might receive duplicate notifications. I'll > > disable this when we're satisfied the new method works well. > > > > For the record, these Appveyor runs are running on a separate Appveyor > > account dedicated for Mesa and FDO projects like Piglit, and not my > > personal Appveyor account. > > > > Jose > > Thanks! > > Looks like it didn't quite work though... MR !1779 [1] was created after > your email, and doesn't have the [external/appveyor] job on its pipeline. > > I doubt there's much I could do that you can't to try to debug this, but > feel free to ask me :) > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fmerge_requests%2F1779data=02%7C01%7Cjfonseca%40vmware.com%7C9bd7988d457342fb2a2808d72af1d2a2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025090427847960sdata=3G9tePq%2BMLG1Yw%2FWr92MCo1ksWwe7exFKqoxhS2LmQU%3Dreserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
Appveyor seems to be building other MR 1781: https://ci.appveyor.com/project/mesa3d/mesa-re1yd/builds/26989425 https://ci.appveyor.com/project/mesa3d/mesa-re1yd/history https://gitlab.freedesktop.org/eric/mesa/pipelines/59190 I don't know what's special about MR 1779. Perhaps it's just the sheer volume of merges and merge requests? Jose From: Eric Engestrom Sent: Tuesday, August 27, 2019 14:23 To: Jose Fonseca Cc: mesa-dev@lists.freedesktop.org ; Brian Paul Subject: Re: Mesa GitLab <-> AppVeyor integration On Tuesday, 2019-08-27 10:30:07 +, Jose Fonseca wrote: > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> AppVeyor > integration. (Thanks Eric.) > > I haven't tested, but hopefully this new integration method should now > trigger Appveyor builds on pull requests too, which should come handy. > > I'm still keeping the old webhook method integration around (with a different > name.) So the list might receive duplicate notifications. I'll disable this > when we're satisfied the new method works well. > > For the record, these Appveyor runs are running on a separate Appveyor > account dedicated for Mesa and FDO projects like Piglit, and not my personal > Appveyor account. > > Jose Thanks! Looks like it didn't quite work though... MR !1779 [1] was created after your email, and doesn't have the [external/appveyor] job on its pipeline. I doubt there's much I could do that you can't to try to debug this, but feel free to ask me :) [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fmesa%2Fmesa%2Fmerge_requests%2F1779data=02%7C01%7Cjfonseca%40vmware.com%7C9bd7988d457342fb2a2808d72af1d2a2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637025090427847960sdata=3G9tePq%2BMLG1Yw%2FWr92MCo1ksWwe7exFKqoxhS2LmQU%3Dreserved=0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
On Tuesday, 2019-08-27 10:30:07 +, Jose Fonseca wrote: > FYI, I've followed Eric Engestroms' instructions for better Mesa <-> AppVeyor > integration. (Thanks Eric.) > > I haven't tested, but hopefully this new integration method should now > trigger Appveyor builds on pull requests too, which should come handy. > > I'm still keeping the old webhook method integration around (with a different > name.) So the list might receive duplicate notifications. I'll disable this > when we're satisfied the new method works well. > > For the record, these Appveyor runs are running on a separate Appveyor > account dedicated for Mesa and FDO projects like Piglit, and not my personal > Appveyor account. > > Jose Thanks! Looks like it didn't quite work though... MR !1779 [1] was created after your email, and doesn't have the [external/appveyor] job on its pipeline. I doubt there's much I could do that you can't to try to debug this, but feel free to ask me :) [1] https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1779 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa GitLab <-> AppVeyor integration
FYI, I've followed Eric Engestroms' instructions for better Mesa <-> AppVeyor integration. (Thanks Eric.) I haven't tested, but hopefully this new integration method should now trigger Appveyor builds on pull requests too, which should come handy. I'm still keeping the old webhook method integration around (with a different name.) So the list might receive duplicate notifications. I'll disable this when we're satisfied the new method works well. For the record, these Appveyor runs are running on a separate Appveyor account dedicated for Mesa and FDO projects like Piglit, and not my personal Appveyor account. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
