Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Rafael Avila de Espindola]

Emil Velikov  writes:

> On 4 July 2017 at 16:04, Rafael Avila de Espindola
>  wrote:
>> Emil Velikov  writes:
>>
>>> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
>>> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
>>> so we cannot rely on that.
>>> Doesn't seem like LLVM is giving us something robust to work with here.
>>>
>>> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
>>> changes that toggle default value, for now.
>>> As LLVM does a few releases where it has a reliable way of determining
>>> the library name users can switch to it.
>>>
>>> How does this sound?
>>
>> I am not sure I understand why having the hash in the version causes
>> problems.
>>
> Because llvm-config --libnames/libfiles is unreliable ;-( Hence we use
> llvm-config --version to get the DSO name.

OK, looks like that is the real bug that needs to be fixed.

Is there a bug report?

Cheers,
Rafael
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Rafael Avila de Espindola]

Emil Velikov  writes:

> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
> so we cannot rely on that.
> Doesn't seem like LLVM is giving us something robust to work with here.
>
> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
> changes that toggle default value, for now.
> As LLVM does a few releases where it has a reliable way of determining
> the library name users can switch to it.
>
> How does this sound?

I am not sure I understand why having the hash in the version causes
problems.

Can you send an email to llvm-...@lists.llvm.org about it?

Cheers,
Rafael
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Emil Velikov]

On 4 July 2017 at 16:47, Rafael Avila de Espindola
 wrote:
> Emil Velikov  writes:
>
>> On 4 July 2017 at 16:04, Rafael Avila de Espindola
>>  wrote:
>>> Emil Velikov  writes:
>>>
 So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
 time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
 so we cannot rely on that.
 Doesn't seem like LLVM is giving us something robust to work with here.

 LLVM users/devs (Rafael), I would suggest up-streaming a patch which
 changes that toggle default value, for now.
 As LLVM does a few releases where it has a reliable way of determining
 the library name users can switch to it.

 How does this sound?
>>>
>>> I am not sure I understand why having the hash in the version causes
>>> problems.
>>>
>> Because llvm-config --libnames/libfiles is unreliable ;-( Hence we use
>> llvm-config --version to get the DSO name.
>
> OK, looks like that is the real bug that needs to be fixed.
>
> Is there a bug report?
>
I get the feeling you've missed part of my earlier reply. Please do so ;-)

libnames/libfiles were broken (fixed with [1]) for the released
3.9.0/3.9.1 at least. This is not something one can retroactively fix,
me thinks.

Although in general skim through git log [2] for all the breakages and
feel free to reference which releases went out without the
corresponding fix :-P

Thanks
Emil

[1] 
https://github.com/llvm-mirror/llvm/commit/5340b5b3d970069aebf3dde49d8964583742e01a
[2] 
https://github.com/llvm-mirror/llvm/commits/master/tools/llvm-config/llvm-config.cpp
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Emil Velikov]

On 4 July 2017 at 16:04, Rafael Avila de Espindola
 wrote:
> Emil Velikov  writes:
>
>> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
>> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
>> so we cannot rely on that.
>> Doesn't seem like LLVM is giving us something robust to work with here.
>>
>> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
>> changes that toggle default value, for now.
>> As LLVM does a few releases where it has a reliable way of determining
>> the library name users can switch to it.
>>
>> How does this sound?
>
> I am not sure I understand why having the hash in the version causes
> problems.
>
Because llvm-config --libnames/libfiles is unreliable ;-( Hence we use
llvm-config --version to get the DSO name.


> Can you send an email to llvm-...@lists.llvm.org about it?
>
It might be better for some LLVM expert to do that, considering I'm
the least experienced person in things LLVM in this thread ;-)

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Mike Lothian]

Hi

I'm not seeing this issue on Gentoo. My llvm-config --version shows
"5.0.0git-79da0992d18"

I'm attaching the patch we use

Regards

Mike

On Tue, 4 Jul 2017 at 10:10 Emil Velikov  wrote:

> On 3 July 2017 at 22:51, Andy Furniss  wrote:
> > Emil Velikov wrote:
> >>
> >> On 3 July 2017 at 16:31, Andy Furniss  wrote:
> >>>
> >>> Rafael Avila de Espindola wrote:
> 
> 
>  What check is configure doing?
> >>>
> >>>
> >>>
> >>> Not sure just a user.
> >>>
>  Is the llvm build a clean one? What is the value of
> LLVM_APPEND_VC_REV?
> >>>
> >>>
> >>>
> >>> It is a clean build.
> >>> A reply to the list advised to start using
> >>>
> >>> -DLLVM_APPEND_VC_REV=OFF
> >>>
> >>> With this it is OK.
> >>>
> >> Skimming through the LLVM it's not obvious what is the before/after
> >> output of `llvm-config --version'. Can anyone share some examples?
> >
> >
> > On current git head, well it was when I started the build from clean,
> > probably not by now :-)
> >
> > Without -DLLVM_APPEND_VC_REV=OFF the output is
> >
> > 5.0.0git-5a8feb7
> >
> > With it, it's
> >
> > 5.0.0svn
> >
> So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
> time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
> so we cannot rely on that.
> Doesn't seem like LLVM is giving us something robust to work with here.
>
> LLVM users/devs (Rafael), I would suggest up-streaming a patch which
> changes that toggle default value, for now.
> As LLVM does a few releases where it has a reliable way of determining
> the library name users can switch to it.
>
> How does this sound?
>
> Thanks
> Emil
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>


0007-llvm-config-Clean-up-exported-values-update-for-shar.patch
Description: Binary data
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Emil Velikov]

On 3 July 2017 at 22:51, Andy Furniss  wrote:
> Emil Velikov wrote:
>>
>> On 3 July 2017 at 16:31, Andy Furniss  wrote:
>>>
>>> Rafael Avila de Espindola wrote:


 What check is configure doing?
>>>
>>>
>>>
>>> Not sure just a user.
>>>
 Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?
>>>
>>>
>>>
>>> It is a clean build.
>>> A reply to the list advised to start using
>>>
>>> -DLLVM_APPEND_VC_REV=OFF
>>>
>>> With this it is OK.
>>>
>> Skimming through the LLVM it's not obvious what is the before/after
>> output of `llvm-config --version'. Can anyone share some examples?
>
>
> On current git head, well it was when I started the build from clean,
> probably not by now :-)
>
> Without -DLLVM_APPEND_VC_REV=OFF the output is
>
> 5.0.0git-5a8feb7
>
> With it, it's
>
> 5.0.0svn
>
So the version is FOOgit-$SHA while the DSO uses, FOOsvn. At the same
time at least 3.9.0/3.9.1 has broken llvm-config --libnames/libfiles,
so we cannot rely on that.
Doesn't seem like LLVM is giving us something robust to work with here.

LLVM users/devs (Rafael), I would suggest up-streaming a patch which
changes that toggle default value, for now.
As LLVM does a few releases where it has a reliable way of determining
the library name users can switch to it.

How does this sound?

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Rafael Avila de Espindola]

What check is configure doing?

Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?

Cheers,
Rafael


Andy Furniss  writes:

> Don't know if mesa needs changing or it's an llvm needs fixing issue, 
> but since llvm commit
>
> commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6
> Author: Rafael Espindola 
> Date:   Fri Jun 30 18:48:33 2017 +
>
>  Completely disable git/svn version checking if not needed.
>
>  Working with git on a branch I find it really annoying that committing
>  a change causes ninja to think that stuff needs to be rebuilt.
>
>  With this change at least nothing in llvm needs to be rebuild when
>  something is committed.
>
>  git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306858 
> 91177308-0d34-0410-b5e6-96231b3b80d8
>
> configuring mesa bails after failing to find llvm shared libs (and gives 
> outdated suggestion). Shared libs are installed.
>
> checking for AMDGPU... yes
> configure: error: Could not find llvm shared libraries:
>  Please make sure you have built llvm with the --enable-shared 
> option
>  and that your llvm libraries are installed in /usr/lib
>  If you have installed your llvm libraries to a different 
> directory you
>  can use the --with-llvm-prefix= configure flag to specify this 
> directory.
>  NOTE: Mesa is attempting to use llvm shared libraries by default.
>  If you do not want to build with llvm shared libraries and 
> instead want to
>  use llvm static libraries then add --disable-llvm-shared-libs 
> to your configure
>  invocation and rebuild.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Andy Furniss]

Emil Velikov wrote:

On 3 July 2017 at 16:31, Andy Furniss  wrote:

Rafael Avila de Espindola wrote:


What check is configure doing?



Not sure just a user.


Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?



It is a clean build.
A reply to the list advised to start using

-DLLVM_APPEND_VC_REV=OFF

With this it is OK.


Skimming through the LLVM it's not obvious what is the before/after
output of `llvm-config --version'. Can anyone share some examples?


On current git head, well it was when I started the build from clean, 
probably not by now :-)


Without -DLLVM_APPEND_VC_REV=OFF the output is

5.0.0git-5a8feb7

With it, it's

5.0.0svn


It sounds like one decided to omit the "svn" (or equivalent) from the
string returned, while the DSO still has it.

Speaking of breakage - 3.9.1 has broken llvm-config
--libnames/libfiles [1] ... sigh.
If there's a for 3.9.2 we might want to nominate it ;-)

-Emil



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Emil Velikov]

On 3 July 2017 at 16:31, Andy Furniss  wrote:
> Rafael Avila de Espindola wrote:
>>
>> What check is configure doing?
>
>
> Not sure just a user.
>
>> Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?
>
>
> It is a clean build.
> A reply to the list advised to start using
>
> -DLLVM_APPEND_VC_REV=OFF
>
> With this it is OK.
>
Skimming through the LLVM it's not obvious what is the before/after
output of `llvm-config --version'. Can anyone share some examples?

It sounds like one decided to omit the "svn" (or equivalent) from the
string returned, while the DSO still has it.

Speaking of breakage - 3.9.1 has broken llvm-config
--libnames/libfiles [1] ... sigh.
If there's a for 3.9.2 we might want to nominate it ;-)

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Andy Furniss]

Rafael Avila de Espindola wrote:

What check is configure doing?


Not sure just a user.


Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV?


It is a clean build.
A reply to the list advised to start using

-DLLVM_APPEND_VC_REV=OFF

With this it is OK.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Andy Furniss]

Laurent Carlier wrote:

Le lundi 3 juillet 2017, 13:53:12 CEST Andy Furniss a écrit :

Don't know if mesa needs changing or it's an llvm needs fixing issue,
but since llvm commit

commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6
Author: Rafael Espindola 
Date:   Fri Jun 30 18:48:33 2017 +

  Completely disable git/svn version checking if not needed.

  Working with git on a branch I find it really annoying that committing
  a change causes ninja to think that stuff needs to be rebuilt.

  With this change at least nothing in llvm needs to be rebuild when
  something is committed.

  git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306858
91177308-0d34-0410-b5e6-96231b3b80d8

configuring mesa bails after failing to find llvm shared libs (and gives
outdated suggestion). Shared libs are installed.

checking for AMDGPU... yes
configure: error: Could not find llvm shared libraries:
  Please make sure you have built llvm with the --enable-shared
option
  and that your llvm libraries are installed in /usr/lib
  If you have installed your llvm libraries to a different
directory you
  can use the --with-llvm-prefix= configure flag to specify this
directory.
  NOTE: Mesa is attempting to use llvm shared libraries by default.
  If you do not want to build with llvm shared libraries and
instead want to
  use llvm static libraries then add --disable-llvm-shared-libs
to your configure
  invocation and rebuild.
___


It's a llvm change, you need to add -DLLVM_APPEND_VC_REV=OFF when you build
llvm, It should fix the issue.


Ahh, thanks for the info.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

[Laurent Carlier]

Le lundi 3 juillet 2017, 13:53:12 CEST Andy Furniss a écrit :
> Don't know if mesa needs changing or it's an llvm needs fixing issue,
> but since llvm commit
> 
> commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6
> Author: Rafael Espindola 
> Date:   Fri Jun 30 18:48:33 2017 +
> 
>  Completely disable git/svn version checking if not needed.
> 
>  Working with git on a branch I find it really annoying that committing
>  a change causes ninja to think that stuff needs to be rebuilt.
> 
>  With this change at least nothing in llvm needs to be rebuild when
>  something is committed.
> 
>  git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306858
> 91177308-0d34-0410-b5e6-96231b3b80d8
> 
> configuring mesa bails after failing to find llvm shared libs (and gives
> outdated suggestion). Shared libs are installed.
> 
> checking for AMDGPU... yes
> configure: error: Could not find llvm shared libraries:
>  Please make sure you have built llvm with the --enable-shared
> option
>  and that your llvm libraries are installed in /usr/lib
>  If you have installed your llvm libraries to a different
> directory you
>  can use the --with-llvm-prefix= configure flag to specify this
> directory.
>  NOTE: Mesa is attempting to use llvm shared libraries by default.
>  If you do not want to build with llvm shared libraries and
> instead want to
>  use llvm static libraries then add --disable-llvm-shared-libs
> to your configure
>  invocation and rebuild.
> ___

It's a llvm change, you need to add -DLLVM_APPEND_VC_REV=OFF when you build 
llvm, It should fix the issue.

-- 
Laurent Carlier
http://www.archlinux.org

signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] configure fails to find llvm since recent llvm commit.

[Andy Furniss]

Don't know if mesa needs changing or it's an llvm needs fixing issue, 
but since llvm commit


commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6
Author: Rafael Espindola 
Date:   Fri Jun 30 18:48:33 2017 +

Completely disable git/svn version checking if not needed.

Working with git on a branch I find it really annoying that committing
a change causes ninja to think that stuff needs to be rebuilt.

With this change at least nothing in llvm needs to be rebuild when
something is committed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306858 
91177308-0d34-0410-b5e6-96231b3b80d8


configuring mesa bails after failing to find llvm shared libs (and gives 
outdated suggestion). Shared libs are installed.


checking for AMDGPU... yes
configure: error: Could not find llvm shared libraries:
Please make sure you have built llvm with the --enable-shared 
option

and that your llvm libraries are installed in /usr/lib
If you have installed your llvm libraries to a different 
directory you
can use the --with-llvm-prefix= configure flag to specify this 
directory.

NOTE: Mesa is attempting to use llvm shared libraries by default.
If you do not want to build with llvm shared libraries and 
instead want to
use llvm static libraries then add --disable-llvm-shared-libs 
to your configure

invocation and rebuild.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev