Re: [Mesa-dev] [PATCH 07/13] linker: Use gl_shader_program::AttributeBindings for attrib locations

2011-10-09 Thread Marcin Slusarz
On Thu, Oct 06, 2011 at 06:54:38PM -0700, Stéphane Marchesin wrote: Hi Ian, This regresses Chrome GPU acceleration for all GPUs (I tested i915g, llvmpipe, i965). FYI, I bisected black screen in OilRush (glretrace of OilRush trace actually) to this commit too. Marcin

Re: [Mesa-dev] [PATCH 0/9] Elminate redudnant Mesa IR references

2011-10-09 Thread Marcin Slusarz
On Tue, Oct 04, 2011 at 01:44:03PM -0700, Ian Romanick wrote: This is the next in my series of internal shader API cleaning. The primary purpose of this series is to remove the extra tracking of Mesa IR shaders. The gl_shader_program has a reference to the Mesa IR shader for each stage, and

Re: [Mesa-dev] [PATCH 0/9] Elminate redudnant Mesa IR references

2011-10-09 Thread Marcin Slusarz
On Sun, Oct 09, 2011 at 04:41:43PM +0200, Marcin Slusarz wrote: On Tue, Oct 04, 2011 at 01:44:03PM -0700, Ian Romanick wrote: This is the next in my series of internal shader API cleaning. The primary purpose of this series is to remove the extra tracking of Mesa IR shaders. The

Re: [Mesa-dev] [PATCH] st/mesa: kill instruction if writemask=0 in eliminate_dead_code_advanced()

2011-10-09 Thread Bryan Cain
I don't think there's any reason we can't eliminate a dead instruction when the writemask is zero. I do wonder, though, why this patch actually makes a difference. There's an if (!inst-dead_mask || !inst-dst.writemask) three lines before the code visible in the patch that makes it not kill the

Re: [Mesa-dev] [PATCH] st/mesa: kill instruction if writemask=0 in eliminate_dead_code_advanced()

2011-10-09 Thread Bryan Cain
What does it do if there's no destination register? In any case, I don't think glsl_to_tgsi emits any ARLs of that form, so it shouldn't be a problem. Bryan On 10/07/2011 01:06 PM, Marek Olšák wrote: I think ARL is allowed to have no destination register, right? In that case, there should be

Re: [Mesa-dev] [PATCH] st/mesa: kill instruction if writemask=0 in eliminate_dead_code_advanced()

2011-10-09 Thread Marek Olšák
Correct. The thing was: even though we have an addressing register in TGSI (e.g. tgsi_full_dst|src_register::Indirect), everybody except nv50 and partially svga doesn't use it now. They expect the indirect register file is always TGSI_FILE_ADDRESS and the index is 0, making the destination of ARL

[Mesa-dev] [Bug 41630] New: r600g nexuiz segfault on quit since recent LinkedShaders changes

2011-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41630 Summary: r600g nexuiz segfault on quit since recent LinkedShaders changes Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW

[Mesa-dev] [Bug 41595] Hi10P videos produce improper output in gl unless yv12 is used.

2011-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41595 --- Comment #1 from Tobias Jakobi liquid.a...@gmx.net 2011-10-09 13:28:33 PDT --- Ahh, another anime fan :) I already posted this problem here: https://bugs.freedesktop.org/show_bug.cgi?id=41461 -- Configure bugmail:

[Mesa-dev] [PATCH] mesa/st: Check for a NULL _LinkedShader[i] before using it.

2011-10-09 Thread Stéphane Marchesin
The rest of the linker/glsl translation code checks for NULL, so I suppose we should check here too. Fixes crash on exit with i915g instanced drawing. --- src/mesa/state_tracker/st_program.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [Bug 41636] New: glXMakeCurrent() can SIGSEGV due to XGetVisualInfo failure in xvfb

2011-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41636 Summary: glXMakeCurrent() can SIGSEGV due to XGetVisualInfo failure in xvfb Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW