Re: [Mesa-dev] [PATCH 8/8] clover/llvm: Make __OPENCL_VERSION__ dynamic

2017-08-10 Thread Jan Vesely
On Wed, 2017-08-09 at 22:36 -0500, Aaron Watry wrote: > On Fri, Aug 4, 2017 at 1:43 PM, Jan Vesely wrote: > > On Sun, 2017-07-30 at 20:26 -0500, Aaron Watry wrote: > > > Signed-off-by: Aaron Watry > > > CC: Jan Vesely > > > > >

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-10 Thread Jason Ekstrand
On August 10, 2017 2:42:29 AM Kenneth Graunke wrote: On Wednesday, August 9, 2017 1:20:53 PM PDT Jason Ekstrand wrote: On Wed, Aug 9, 2017 at 1:09 PM, Kenneth Graunke wrote: > Also, silence an obnoxious finishme that started occurring for all

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-10 Thread Marathe, Yogesh
Tomasz, > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Thursday, August 10, 2017 5:29 PM > To: Marathe, Yogesh > Hi Yogesh, > > On Thu, Aug 10, 2017 at 5:25 PM, Marathe, Yogesh > wrote: > > Hi Tomasz, > >

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-08-10 Thread Julien Isorce
Boyuan, gentle ping ? On 26 July 2017 at 19:36, Christian König wrote: > So that means Reviewed-and-tested-by: Zhang, Boyuan >? > > Christian. > > > Am 26.07.2017 um 20:29 schrieb Zhang, Boyuan: > >> The code looks good to me. I also did a few

[Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

2017-08-10 Thread Kenneth Graunke
Passing screen lets us get the kernel features, devinfo, and bufmgr, without needing container_of. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102062 Cc: Mauro Rossi Cc: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_context.c |

[Mesa-dev] [PATCH 2/2] i965: Guard GetBufferSubData's streaming memcpy load with USE_SSE41

2017-08-10 Thread Kenneth Graunke
This should hopefully fix build issues on 32-bit Android-x86. Cc: Mauro Rossi Cc: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102050 --- src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH 03/22] glformats: Add a mapping for MESA_FORMAT_S_UINT8

2017-08-10 Thread Erik Faye-Lund
On Sat, Aug 5, 2017 at 11:39 AM, Chris Wilson wrote: > Map the user format of GL_DEPTH_COMPONENT, GL_UNSIGNED_BYTE to the > internal format of MESA_FORMAT_S_UINT8. > --- > src/mesa/main/glformats.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-08-10 Thread Iago Toral
On Wed, 2017-08-09 at 16:18 +0100, Lionel Landwerlin wrote: > Acked-by: Lionel Landwerlin > > I can see that it fixes the tests and it makes sense, but I'm failing > to  > see how gl_attrib_wa_flags ends up being set from anv :/ Sorry, I should've explained that.

Re: [Mesa-dev] [PATCH 2/2] dri3: Swapbuffer update

2017-08-10 Thread Thomas Hellstrom
On 08/10/2017 05:27 AM, Michel Dänzer wrote: On 09/08/17 04:07 PM, Thomas Hellstrom wrote: On 08/09/2017 08:36 AM, Michel Dänzer wrote: On 08/08/17 03:48 PM, Thomas Hellstrom wrote: Implement back-to-fake-front flips, Fix EGL_BUFFER_PRESERVED path. Implement dri3 support for

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2017-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 John changed: What|Removed |Added CC||john.etted...@gmail.com

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

2017-08-10 Thread Tapani Pälli
On 06/22/2017 02:08 AM, Eric Anholt wrote: Tapani Pälli writes: On 06/14/2017 01:12 AM, Eric Anholt wrote: Tapani Pälli writes: On 06/12/2017 09:52 AM, Tapani Pälli wrote: On 05/18/2017 09:39 PM, Eric Anholt wrote: Eric Anholt

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-10 Thread Michel Dänzer
On 10/08/17 02:25 PM, Thomas Hellstrom wrote: > On 08/10/2017 05:20 AM, Michel Dänzer wrote: >> On 09/08/17 06:53 PM, Thomas Hellstrom wrote: >>> The attribMap had two entries for this attribute, and >>> driGetConfigAttribIndex didn't return a proper value for this attribute. >>> Fix this, and

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-10 Thread Marathe, Yogesh
Hi Tomasz, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Tomasz Figa > Sent: Tuesday, August 8, 2017 7:45 AM > To: Marathe, Yogesh > >> > >> Changing the topic, the patch doesn't seem to change the > >> >

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-10 Thread Kenneth Graunke
On Wednesday, August 9, 2017 1:20:53 PM PDT Jason Ekstrand wrote: > On Wed, Aug 9, 2017 at 1:09 PM, Kenneth Graunke > wrote: > > > Also, silence an obnoxious finishme that started occurring for all > > GL applications which use stencil after the i965 ISL conversion. > >

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 John changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

2017-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #16 from John --- Hello, I've been having the same issue for a while, even with Emil's patch on master: libtool: link: ( cd "glsl/.libs" && rm -f "libstandalone.la" && ln -s "../libstandalone.la"

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-10 Thread Emil Velikov
Hi Thomas, Apologies for dropping in so late. On 9 August 2017 at 10:53, Thomas Hellstrom wrote: > The attribMap had two entries for this attribute, and > driGetConfigAttribIndex didn't return a proper value for this attribute. > Fix this, and also make sure we return

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-10 Thread Emil Velikov
On 9 August 2017 at 02:00, Michel Dänzer wrote: > On 09/08/17 03:24 AM, Emil Velikov wrote: >> On 8 August 2017 at 08:23, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> No need to manually look for the library files anymore

Re: [Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

2017-08-10 Thread Emil Velikov
On 8 August 2017 at 19:42, Adam Jackson wrote: > On Tue, 2017-08-08 at 19:11 +0100, Emil Velikov wrote: >> On 2 August 2017 at 21:24, Adam Jackson wrote: >> > The device extension string is expected to contain the name of the >> > extension defining what kind of

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-10 Thread Thomas Hellstrom
Hi, Emil, On 08/10/2017 06:20 PM, Emil Velikov wrote: Hi Thomas, Apologies for dropping in so late. On 9 August 2017 at 10:53, Thomas Hellstrom wrote: The attribMap had two entries for this attribute, and driGetConfigAttribIndex didn't return a proper value for this

Re: [Mesa-dev] [PATCH 1/4] dri: Fix __DRIconfig reporting of __DRI_ATTRIB_SWAP_METHOD

2017-08-10 Thread Emil Velikov
On 10 August 2017 at 17:40, Thomas Hellstrom wrote: > It's checked in a later patch > > https://lists.freedesktop.org/archives/mesa-dev/2017-August/165848.html > > But I'm currently splitting it up into a series with some extra fixes in it. > Great, thanks. -Emil

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Emil Velikov
On 10 August 2017 at 13:51, Tomasz Figa wrote: > On Thu, Aug 10, 2017 at 9:40 PM, Eric Engestrom wrote: >> On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: >>> dri2_fallback_swap_interval() currently used to stub out swap interval >>>

[Mesa-dev] [PATCH] dri: fix typo in comment

2017-08-10 Thread Gwan-gyeong Mun
Signed-off-by: Mun Gwan-gyeong --- include/GL/internal/dri_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 2cbd738439..b90c9b2c66 100644 ---

Re: [Mesa-dev] [PATCH] configure: Trust LLVM >= 4.0 llvm-config --libs for shared libraries

2017-08-10 Thread Jan Vesely
On Thu, 2017-08-10 at 17:45 +0100, Emil Velikov wrote: > On 9 August 2017 at 02:00, Michel Dänzer wrote: > > On 09/08/17 03:24 AM, Emil Velikov wrote: > > > On 8 August 2017 at 08:23, Michel Dänzer wrote: > > > > From: Michel Dänzer

[Mesa-dev] [PATCH 1/3] radeonsi/gfx9: fix the scissor bug workaround

2017-08-10 Thread Marek Olšák
From: Marek Olšák otherwise there is corruption in most apps. Fixes: 0fe0320 radeonsi: use optimal packet order when doing a pipeline sync --- src/gallium/drivers/radeonsi/si_state_draw.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] gallium/radeon: only pass shader-specific debug flags to the disk shader cache

2017-08-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 2acef6a..95458d2e 100644 ---

[Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

2017-08-10 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 95458d2e..0038c9a 100644 ---

[Mesa-dev] [PATCH] radeonsi/gfx9: use the VI codepath for clamping Z

2017-08-10 Thread Marek Olšák
From: Marek Olšák This fixes corrupted shadows in Unigine Valley. The corruption disappeared when I stopped setting IMG_DATA_FORMAT_24_8 for depth. Cc: 17.2 --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +-

Re: [Mesa-dev] [PATCH 14/25] i965: Use a common table to translate logical to hardware types

2017-08-10 Thread Matt Turner
On Mon, Aug 7, 2017 at 3:43 PM, Scott D Phillips wrote: > Matt Turner writes: >> --- >> src/intel/compiler/brw_reg_type.c | 65 >> +-- >> 1 file changed, 29 insertions(+), 36 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH v3 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

2017-08-10 Thread Marek Olšák
On Tue, Aug 8, 2017 at 6:57 PM, Samuel Pitoiset wrote: > A new pair of user SGPR is needed for loading the bindless > descriptors from shaders. Because the descriptors are global for > all stages, there is no need to add separate indices for GFX9. > > v3: - fix merged

[Mesa-dev] [PATCH 00/13] clang warning fixes

2017-08-10 Thread Matt Turner
Just a simple series cleaning up various bits of code that clang warns about. The only real change is to "i965/vec4: Return float from spill_cost_for_type()" which fixes an obvious mistake. The rest just cleans things up like marking internal functions static.

[Mesa-dev] [PATCH 03/13] mesa: Don't compare unsigned for < 0

2017-08-10 Thread Matt Turner
The INTEL_performance_query spec says "Performance counter id 0 is reserved as an invalid counter." GLuint counterid_to_index(GLuint counterid) just returns counterid - 1, so with unsigned overflow rules, it will generate 0x given an input of 0. 0x will trigger the

[Mesa-dev] [PATCH 01/13] egl: Fix inclusion of egl.h+mesa_glinterop.h

2017-08-10 Thread Matt Turner
Previously clang would warn about redefinition of typedef EGLDisplay. Avoid this by adding preprocessor guards to mesa_glinterop.h and including it after EGL.h is indirectly included. --- include/GL/mesa_glinterop.h | 4 src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/main/eglapi.c

[Mesa-dev] [PATCH 07/13] intel/isl: Remove 'inline' keywords

2017-08-10 Thread Matt Turner
Unless you have data, the compiler knows better than you whether a function should be inlined. --- src/intel/isl/isl_emit_depth_stencil.c | 2 +- src/intel/isl/isl_format.c | 2 +- src/intel/isl/isl_surface_state.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 02/13] nir/spirv: Use unreachable("...") rather than assert(!"...")

2017-08-10 Thread Matt Turner
Quiets a number of uninitialized variable warnings in clang. --- src/compiler/spirv/spirv_to_nir.c | 24 src/compiler/spirv/vtn_variables.c | 10 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 06/13] anv: Remove 'inline' keywords

2017-08-10 Thread Matt Turner
Unless you have data, the compiler knows better than you whether a function should be inlined. --- src/intel/vulkan/anv_batch_chain.c | 4 ++-- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/gen7_cmd_buffer.c | 2 +- src/intel/vulkan/gen8_cmd_buffer.c | 4 ++--

[Mesa-dev] [PATCH 04/13] glsl: Remove unused private fields

2017-08-10 Thread Matt Turner
--- src/compiler/glsl/lower_int64.cpp | 4 +--- src/mesa/program/ir_to_mesa.cpp | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/lower_int64.cpp b/src/compiler/glsl/lower_int64.cpp index 9770d314af..aa2e1e063d 100644 ---

[Mesa-dev] [PATCH 05/13] anv: Move clamp_int64() inside the IVB check

2017-08-10 Thread Matt Turner
It's only used in the gen7_cmd_buffer_emit_scissor() function. --- src/intel/vulkan/gen7_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_cmd_buffer.c b/src/intel/vulkan/gen7_cmd_buffer.c index b1721c78ba..5f7b5a07e4 100644 ---

[Mesa-dev] [PATCH 08/13] i965: Remove some 'inline' keywords

2017-08-10 Thread Matt Turner
brw_texture_view_sane() is only used by an assert()... --- src/mesa/drivers/dri/i965/genX_state_upload.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index

[Mesa-dev] [PATCH 10/13] i965/vec4: Use 'class' src_reg, rather than 'struct' src_reg

2017-08-10 Thread Matt Turner
--- src/intel/compiler/brw_vec4.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_vec4.cpp b/src/intel/compiler/brw_vec4.cpp index 410922c62b..45e918127d 100644 --- a/src/intel/compiler/brw_vec4.cpp +++ b/src/intel/compiler/brw_vec4.cpp @@ -1950,7

[Mesa-dev] [PATCH 13/13] glsl: Add prototype for udivmod64()

2017-08-10 Thread Matt Turner
--- src/compiler/glsl/builtin_functions.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/builtin_functions.h b/src/compiler/glsl/builtin_functions.h index 2053c82b74..89ec9b7d5d 100644 --- a/src/compiler/glsl/builtin_functions.h +++

[Mesa-dev] [PATCH 09/13] i965/vec4: Return float from spill_cost_for_type()

2017-08-10 Thread Matt Turner
--- src/intel/compiler/brw_vec4_reg_allocate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_vec4_reg_allocate.cpp b/src/intel/compiler/brw_vec4_reg_allocate.cpp index a0ba77b867..bbad46ee6c 100644 --- a/src/intel/compiler/brw_vec4_reg_allocate.cpp

[Mesa-dev] [PATCH 11/13] i965: Mark functions static

2017-08-10 Thread Matt Turner
Cuts 300 bytes of .text --- src/intel/compiler/brw_fs_surface_builder.cpp | 30 - src/intel/compiler/brw_vec4_nir.cpp | 5 +++-- src/intel/compiler/brw_vec4_surface_builder.cpp | 6 ++--- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 12/13] glsl: Mark functions static

2017-08-10 Thread Matt Turner
Cuts 3224 bytes of .text --- src/compiler/glsl/ast_function.cpp | 10 +- src/compiler/glsl/ast_to_hir.cpp| 6 +++--- src/compiler/glsl/glsl_parser_extras.cpp| 2 +- src/compiler/glsl/ir_validate.cpp | 2 +-

[Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

2017-08-10 Thread Eric Anholt
I've been trying to get away without these conditionals in vc4's NEON code, but it meant compiling extra unused code on x86, and build failing on ARMv6. v2: Use the _arm/_arm64 flags to simplify detection (suggested by Rob), but hide the _arm version under ARCH_ARM_HAVE_NEON to keep from

[Mesa-dev] [PATCH 5/7 v2] broadcom/vc4: Build the vc4_tiling_lt_neon.c with -mfpu=neon on ARM.

2017-08-10 Thread Eric Anholt
If you don't pass this, the compiler refuses to compile the assembly for pre-v7 CPUs. This also keeps us from building identical, non-NEON code on aarch64 and x86. Fixes: a373f77662c5 ("vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.") v2: Fix Android build by just appending

[Mesa-dev] [PATCH 6/7 v3] broadcom/vc4: Port NEON-code to ARM64

2017-08-10 Thread Eric Anholt
From: Jonas Pfeil Changed all register and instruction names, works the same. v2: Rebase on build system changes (by anholt) v3: Fix build on clang (by anholt, reported by Rob) Signed-off-by: Jonas Pfeil --- src/gallium/drivers/vc4/vc4_tiling_lt.c | 84

Re: [Mesa-dev] [PATCH 02/13] nir/spirv: Use unreachable("...") rather than assert(!"...")

2017-08-10 Thread Jordan Justen
On 2017-08-10 15:02:33, Matt Turner wrote: > Quiets a number of uninitialized variable warnings in clang. > --- > src/compiler/spirv/spirv_to_nir.c | 24 > src/compiler/spirv/vtn_variables.c | 10 +- > 2 files changed, 17 insertions(+), 17 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 00/13] clang warning fixes

2017-08-10 Thread Jordan Justen
Where's the patchlist on your cover letter? :) 1: Reviewed-by: Jordan Justen 2: If only changing the string calls: Reviewed-by: Jordan Justen 3-5: Reviewed-by: Jordan Justen 6-8: Do you have data that

Re: [Mesa-dev] [PATCH] i965/blorp: Correct type of src_format in call to intel_miptree_texture_aux_usage

2017-08-10 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-08-09 15:52:30, Scott D Phillips wrote: > intel_miptree_texture_aux_usage() takes an isl_format, but we are > passing a mesa_format. clang warns: > > brw_blorp.c:305:52: warning: implicit conversion from enumeration > type

Re: [Mesa-dev] [PATCH] build: Fix up spirv_info.Plo

2017-08-10 Thread Emil Velikov
Thanks Matt. Patch is: Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-08-10 Thread Zhang, Boyuan
Oops, I thought I did it in previous email. Sorry about that. Patches are Reviewed-and-tested-by: Boyuan Zhang Regards, Boyuan From: Julien Isorce [mailto:julien.iso...@gmail.com] Sent: August-10-17 11:37 AM To: Christian König Cc: Zhang, Boyuan; Liu, Leo; Andy Furniss;

[Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tomasz Figa
dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat) to fail due to an unexpected error and my loose interpretation of the EGL 1.5 specification

[Mesa-dev] [PATCH libdrm] tests/amdgpu: add uvd encode unit tests

2017-08-10 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- tests/amdgpu/Makefile.am | 1 + tests/amdgpu/amdgpu_test.c | 6 + tests/amdgpu/amdgpu_test.h | 15 ++ tests/amdgpu/frame.h | 2 +- tests/amdgpu/uvd_enc_tests.c | 500

[Mesa-dev] [PATCH] configure: remove trailing "-a" in swr architecture test

2017-08-10 Thread Tim Rowley
Fixes "configure: line 27326: test: argument expected" CC: mesa-sta...@lists.freedesktop.org --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 5b12dd8..316e6a8 100644 --- a/configure.ac +++ b/configure.ac @@ -2545,7 +2545,7 @@

Re: [Mesa-dev] [PATCH] configure: remove trailing "-a" in swr architecture test

2017-08-10 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/25] i965: Reorder brw_reg_type enum values

2017-08-10 Thread Matt Turner
On Tue, Aug 8, 2017 at 4:21 PM, Scott D Phillips wrote: > Matt Turner writes: >> These vaguely corresponded to the hardware encodings, but that is purely >> historical at this point. Reorder them so we stop making things "almost >> work" when

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

2017-08-10 Thread Eric Anholt
Tapani Pälli writes: > On 06/22/2017 02:08 AM, Eric Anholt wrote: >> Tapani Pälli writes: >> >>> On 06/14/2017 01:12 AM, Eric Anholt wrote: Tapani Pälli writes: > On 06/12/2017 09:52 AM, Tapani Pälli wrote:

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Chad Versace
On Thu 10 Aug 2017, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to an unexpected error and my loose

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure: remove trailing "-a" in swr architecture test

2017-08-10 Thread Chuck Atkins
I hit this a few weeks ago when I was adding the cray flags to swr and patched it manually but forgot to push it upstream. Thanks for the fix. Tested-by: Chuck Atkins - Chuck On Thu, Aug 10, 2017 at 2:04 PM, Matt Turner wrote: > Reviewed-by:

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Tapani Pälli
I agree to the interpretation, it is stated that EGL_FALSE happens 'on failure' and there are 2 error cases specified for eglSwapInterval. It seems right to assume those are the only cases where it can fail (no current context or surface bound). Reviewed-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

2017-08-10 Thread Tomasz Figa
Hi Yogesh, On Thu, Aug 10, 2017 at 5:25 PM, Marathe, Yogesh wrote: > Hi Tomasz, > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf >> Of Tomasz Figa >> Sent: Tuesday, August 8, 2017 7:45 AM >> To: Marathe, Yogesh

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Emil Velikov
On 10 August 2017 at 14:59, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to an

Re: [Mesa-dev] [PATCH 3/7] util: Fix build on old glibc.

2017-08-10 Thread Matt Turner
On 08/08, Eric Anholt wrote: We need to link librt for u_thread.h's clock_gettime() call. Fixes: b822d9dd67b5 ("gallium/util: move u_queue.{c,h} to src/util") --- Reviewed-by: Matt Turner signature.asc Description: Digital signature

Re: [Mesa-dev] [PATCH v2 5/8] glsl: pass mem_ctx to constant_expression_value(...) and friends

2017-08-10 Thread Kenneth Graunke
On Thursday, August 10, 2017 3:42:29 AM PDT Timothy Arceri wrote: > The main motivation for this is that threaded compilation can fall > over if we were to allocate IR inside constant_expression_value() > when calling it on a builtin. This is because builtins are shared > across the whole OpenGL

Re: [Mesa-dev] [PATCH 6/8] glsl: stop cloning builtin fuctions _mesa_glsl_find_builtin_function()

2017-08-10 Thread Kenneth Graunke
On Tuesday, August 8, 2017 8:34:07 PM PDT Timothy Arceri wrote: > The cloning was introduced in f81ede469910d to fixed a problem with > shaders including IR that was owned by builtins. > > However the approach of cloning the whole function each time we > reference a builtin lead to a significant

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-10 Thread Ilia Mirkin
On Wed, Aug 9, 2017 at 4:09 PM, Kenneth Graunke wrote: > Also, silence an obnoxious finishme that started occurring for all > GL applications which use stencil after the i965 ISL conversion. Without commenting on the correctness of the patch, either this or something like

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-10 Thread Jason Ekstrand
On August 10, 2017 12:45:43 PM Ilia Mirkin wrote: On Wed, Aug 9, 2017 at 4:09 PM, Kenneth Graunke wrote: Also, silence an obnoxious finishme that started occurring for all GL applications which use stencil after the i965 ISL conversion. Without

Re: [Mesa-dev] [PATCH 4/7 v2] configure.ac: Introduce HAVE_ARM_ASM/HAVE_AARCH64_ASM and the -D flags.

2017-08-10 Thread Rob Herring
On Thu, Aug 10, 2017 at 5:43 PM, Eric Anholt wrote: > I've been trying to get away without these conditionals in vc4's NEON > code, but it meant compiling extra unused code on x86, and build failing > on ARMv6. > > v2: Use the _arm/_arm64 flags to simplify detection (suggested by

Re: [Mesa-dev] [PATCH 6/7 v3] broadcom/vc4: Port NEON-code to ARM64

2017-08-10 Thread Rob Herring
On Thu, Aug 10, 2017 at 5:43 PM, Eric Anholt wrote: > From: Jonas Pfeil > > Changed all register and instruction names, works the same. > > v2: Rebase on build system changes (by anholt) > v3: Fix build on clang (by anholt, reported by Rob) > > Signed-off-by:

Re: [Mesa-dev] [PATCH 5/7 v2] broadcom/vc4: Build the vc4_tiling_lt_neon.c with -mfpu=neon on ARM.

2017-08-10 Thread Rob Herring
On Thu, Aug 10, 2017 at 5:43 PM, Eric Anholt wrote: > If you don't pass this, the compiler refuses to compile the assembly for > pre-v7 CPUs. This also keeps us from building identical, non-NEON code on > aarch64 and x86. > > Fixes: a373f77662c5 ("vc4: Use a wrapper file to set

Re: [Mesa-dev] [PATCH] build: Fix up spirv_info.Plo

2017-08-10 Thread Rhys Kidd
On 10 August 2017 at 12:46, Emil Velikov wrote: > Thanks Matt. Patch is: > > Reviewed-by: Emil Velikov > It's a little late, but gets my: Tested-by: Rhys Kidd Thanks Matt for fixing the out-of-tree builds. > > -Emil

Re: [Mesa-dev] [PATCH 2/3] gallium/radeon: only pass shader-specific debug flags to the disk shader cache

2017-08-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] gallium/radeon: pass LLVM processor to the disk shader cache

2017-08-10 Thread Timothy Arceri
On 11/08/17 05:57, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c

Re: [Mesa-dev] [PATCH] ac: fail shader compilation if libelf is replaced by an incompatible version

2017-08-10 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 08/09/2017 10:34 PM, Marek Olšák wrote: From: Marek Olšák UE4Editor has this issue. This commit prevents hangs (release build) or assertion failures (debug build). Cc: 17.2

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #50 from Marko --- Hi everyone, I've tested DOOM yesterday for maybe half an hour and you can color me impressed. The FPS is in the 50's range for High/ultra, no glitches, stuttering or

[Mesa-dev] [PATCH v2 5/8] glsl: pass mem_ctx to constant_expression_value(...) and friends

2017-08-10 Thread Timothy Arceri
The main motivation for this is that threaded compilation can fall over if we were to allocate IR inside constant_expression_value() when calling it on a builtin. This is because builtins are shared across the whole OpenGL context. f81ede469910d worked around the problem by cloning the entire

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Eric Engestrom
On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: > dri2_fallback_swap_interval() currently used to stub out swap interval > support in Android backend does nothing besides returning EGL_FALSE. > This causes at least one known application (Android Snapchat) to fail > due to

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way

2017-08-10 Thread Tomasz Figa
On Thu, Aug 10, 2017 at 9:40 PM, Eric Engestrom wrote: > On 10 August 2017 06:43:45 BST, Tomasz Figa wrote: >> dri2_fallback_swap_interval() currently used to stub out swap interval >> support in Android backend does nothing besides returning EGL_FALSE. >>

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 08/10/2017 04:59 PM, Tomasz Figa wrote: dri2_fallback_swap_interval() currently used to stub out swap interval support in Android backend does nothing besides returning EGL_FALSE. This causes at least one known application (Android Snapchat)

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

2017-08-10 Thread Tomasz Figa
On Fri, Aug 11, 2017 at 2:29 AM, Emil Velikov wrote: > On 10 August 2017 at 14:59, Tomasz Figa wrote: >> dri2_fallback_swap_interval() currently used to stub out swap interval >> support in Android backend does nothing besides returning EGL_FALSE. >>

[Mesa-dev] [PATCH 1/2] st/omx_tizonia: add --enable-omx-tizonia flag and build files

2017-08-10 Thread Gurkirpal Singh
Coexist with --enable-omx so they can be built independently Detect tizonia package config file Generate libomxtiz_mesa.so and install it to libtizcore.pc::pluginsdir Only compile empty source (target.c) for now. GSoC Project link: https://summerofcode.withgoogle.com/projects/#4737166321123328

[Mesa-dev] [PATCH 2/2] st/omx_tizonia: Add AVC decoder

2017-08-10 Thread Gurkirpal Singh
Signed-off-by: Gurkirpal Singh --- src/gallium/state_trackers/omx_tizonia/Makefile.am | 35 + .../state_trackers/omx_tizonia/Makefile.sources|9 + .../state_trackers/omx_tizonia/entrypoint.c| 152 ++ .../state_trackers/omx_tizonia/entrypoint.h|

[Mesa-dev] [PATCH] radeonsi: don't enable surf index on shareable images.

2017-08-10 Thread Dave Airlie
From: Dave Airlie This fixes the SteamVR menus, which were broken by this feature. Signed-off-by: Dave Airlie --- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

2017-08-10 Thread Tapani Pälli
On 08/10/2017 10:04 PM, Eric Anholt wrote: Tapani Pälli writes: On 06/22/2017 02:08 AM, Eric Anholt wrote: Tapani Pälli writes: On 06/14/2017 01:12 AM, Eric Anholt wrote: Tapani Pälli writes: On 06/12/2017 09:52