Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

Hi, On 4 January 2012 18:45, Ian Romanick i...@freedesktop.org wrote: Okay, I looked back at your build output, and I think I see the problem:  * econf: updating Mesa-/bin/config.sub with /usr/share/gnuconfig/config.sub  * econf: updating Mesa-/bin/config.guess with

Re: [Mesa-dev] X/Graphics DevRoom at FOSDEM 2012? (4-5 February)

Hi, On Tuesday, 20 September 2011, Luc Verhaegen l...@skynet.be wrote: This sound like a rather redhat specific topic. How certain are you that redhat is going to send you to FOSDEM, and if they don't, are you coming regardless? In much the same way that every RadeonHD talk was completely

Re: [Mesa-dev] X/Graphics DevRoom at FOSDEM 2012? (4-5 February)

Hi, On Tuesday, 20 September 2011, Chris Wilson ch...@chris-wilson.co.uk wrote: Daniel, think you might pop over for the weekend and teach us a thing or two about the DRM infrastructure and what it might look like in a year or two as more SoC gradually become mainline? Perhaps. FOSDEM is a

Re: [Mesa-dev] Last chance: FOSDEM2012 speakers due today.

Hi, On 2 October 2011 08:17, Matthieu Herrb matthieu.he...@laas.fr wrote: On Sat, Oct 01, 2011 at 03:14:12PM +0200, Luc Verhaegen wrote: If you know that you are coming to FOSDEM, but for some reason think that someone else should step up instead, then think again, and reply ASAP. Luc, I

[Mesa-dev] [PATCH] Fix const errors in GL(ES) API

51b0a0b3 introduced a number of const restrictions in glext.h, but didn't propagate these to the GL API XML files, leading to a number of prototype mismatch warnings. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/mapi/glapi/gen/ARB_debug_output.xml |2 +- src/mapi

[Mesa-dev] [PATCH] nv50: Fix broken assertion

The assertion added in f09910f3 broke nv50 completely by asserting that the number of elements in a dereferenced pointer (i.e. 1) was greater than i (which ranged up to six), rather than checking the number of elements in the containing array. Signed-off-by: Daniel Stone dan...@fooishbar.org

Re: [Mesa-dev] [PATCH] nv50: Fix broken assertion

On 7 February 2012 13:03, Christoph Bumiller e0425...@student.tuwien.ac.at wrote: On 07.02.2012 13:47, Jose Fonseca wrote: Makes sense. Very much so ... http://cgit.freedesktop.org/mesa/mesa/commit/?id=189e6c7e81ce35b89d9b52d4bd0d6271a7e9c10f (of 26 hours ago). Ha, snap. Thanks anyway. :)

[Mesa-dev] [PATCH] Don't fail if libX11 isn't installed

configure.ac would previously refuse to complete if libX11 wasn't installed, even if we'd disabled GLX and weren't building an X11 EGL platform. Make the check simply set the no_x variable that's used (but never set) immediately below for what looks like this very case. Signed-off-by: Daniel

[Mesa-dev] [PATCH] teximage: Remove unnecessary compressed format check

Ever since df4a88ac, the check for compressed formats has been unnecessary. And ever since cb72ec5f, the build has been broken with FEATURE_ES. Remove it, as it does nothing. Signed-off-by: Daniel Stone dan...@fooishbar.org --- src/mesa/main/teximage.c |4 1 file changed, 4 deletions

Re: [Mesa-dev] [PATCH] Don't fail if libX11 isn't installed

Hi, On 10 October 2012 01:07, Dan Nicholson dbn.li...@gmail.com wrote: On Oct 8, 2012 10:49 PM, Matt Turner matts...@gmail.com wrote: Wow, it's been like that since 2008. Reviewed-by: Matt Turner matts...@gmail.com Originally configure basically supported only GLX either through DRI or

Re: [Mesa-dev] threads and X.org/AIGLX drivers

On Thu, May 12, 2011 at 09:45:14AM -0400, Kristian Høgsberg wrote: A different solution could be to use the input thread idea and stop taking SIGIO. The input thread needs a lot of work though - we don't do any locking at all. So try doing device creation/destruction in a loop, or changing the

Re: [Mesa-dev] Move wayland-drm protocol from Mesa to wayland-core

Hi, On 28 November 2013 10:04, Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 28 Nov 2013 10:24:33 +0100 Benjamin Gaignard benjamin.gaign...@linaro.org wrote: From my point of view wl_drm isn't link to Mesa, it is only about exchange buffers by using a file descriptor and, for example,

Re: [Mesa-dev] [PATCH] [RFC] mesa: propose simple EGL_MESA_image_dma_buf_export

Hi, On 29 August 2014 08:46, Gwenole Beauchesne gb.de...@gmail.com wrote: Could you please describe in there the ownership model? I think the implementation should own the fd, so the clients should dup() it if ever necessary. So the fd can be destroyed at any time, particularly with

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] egl/drm: expose KHR_image_pixmap extension

Reviewed-by: Daniel Stone dani...@collabora.com On 16 September 2014 22:23, Emil Velikov emil.l.veli...@gmail.com wrote: Hello gents, Can anyone spare a couple of minutes and review this patch ? Thanks Emil On 03/09/14 21:43, Andreas Pokorny wrote: This changes enables

Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Fix black buffers when importing prime fds

Reviewed-by: Daniel Stone dani...@collabora.com On 16 September 2014 22:29, Emil Velikov emil.l.veli...@gmail.com wrote: Another humble ping. I realise that i915 hardware is not top priority yet 5 minutes of someone experienced with the driver will be greatly appreciated :) Cheers, Emil

Re: [Mesa-dev] [PATCH] Releasing a surfaceless EGL context doesn't release underlying DRI context.

() is that _mesa_make_current(NULL, NULL, NULL) gets called, which is what we want. Could you please document some part of that in the commit message for future archaeology? Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel Signed-off-by: Alexandros Frantzis alexandros.frant...@canonical.com Signed

Re: [Mesa-dev] [PATCH] Releasing a surfaceless EGL context doesn't release underlying DRI context.

On 24 October 2014 11:18, Daniel Stone dan...@fooishbar.org wrote: Yep, that looks good to me; seems like you've found the only possible case that would trigger this breakage. Calling DestroyContext will always unbind if it's current in that thread (see the end _mesa_free_context_data); it's

Re: [Mesa-dev] [PATCH V2] mesa: add SSE optimisation for glDrawElements

Hi, On 24 October 2014 18:51, Emil Velikov emil.l.veli...@gmail.com wrote: Sigh... why can't everyone be like Gentoo - set compiler flags and rebuild for your machine/cpu :P Apart from the Makefile.sources change spotted by Matt, can you make use of USE_SSE41 ? Take a look at commit

Re: [Mesa-dev] [PATCH 3/3] glx: Allow to create any OpenGL ES version.

Hi, On 12 November 2014 12:37, jfons...@vmware.com wrote: @@ -544,9 +544,22 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs, case GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB: *api = __DRI_API_OPENGL; break; - case

Re: [Mesa-dev] Move mesa version scheme to a more common style ?

Hi, On 14 November 2014 15:07, Erik Faye-Lund kusmab...@gmail.com wrote: On Fri, Nov 14, 2014 at 3:39 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Are there any objections if I move to the above format starting with mesa 10.4-rc1 ? I would appreciate any feedback over the next 2-3

Re: [Mesa-dev] [RFC] tegra: Initial support

Hi, On 28 November 2014 at 09:17, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Nov 28, 2014 at 12:32:43AM -0500, Ilia Mirkin wrote: Also, can you explain why it's advantageous for the setup to appear as though it is a single device? i.e. what's wrong with just using nouveau as a

Re: [Mesa-dev] Implement GLX_EXT_buffer_age for DRI2

Hi, On 20 January 2015 at 21:49, Dave Airlie airl...@gmail.com wrote: On 19 January 2015 at 21:00, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to suport GLX_EXT_buffer_age in DRI2, we need to pass back the last swap buffer count that the back buffer was defined for. For simplicity,

Re: [Mesa-dev] [PATCH ] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN7

Hi, On 17 March 2015 at 16:37, marius.pre...@intel.com wrote: --- a/src/mesa/drivers/dri/i965/gen7_sf_state.c +++ b/src/mesa/drivers/dri/i965/gen7_sf_state.c @@ -198,9 +198,15 @@ upload_sf_state(struct brw_context *brw) float line_width = roundf(CLAMP(ctx-Line.Width, 0.0,

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

Hi, On Tuesday, March 3, 2015, Dave Airlie airl...@gmail.com wrote: +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy, + EGLImageKHR image, + int *fourcc, + int *num_planes);

Re: [Mesa-dev] [PATCH] [RFC] egl: propose simple EGL_MESA_image_dma_buf_export v2.2

Hi, On 3 March 2015 at 18:40, Chad Versace chad.vers...@intel.com wrote: On 03/03/2015 12:13 AM, Daniel Stone wrote: On Tuesday, March 3, 2015, Dave Airlie airl...@gmail.com mailto:airl...@gmail.com wrote: +EGLBoolean eglExportDMABUFImageQueryMESA(EGLDisplay dpy

Re: [Mesa-dev] [PATCH 2/2] egl: implement EGL_MESA_transparent_alpha for x11 and wayland

Hi, On 3 March 2015 at 18:56, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Mar 3, 2015 at 10:07 AM, Chad Versace chad.vers...@intel.com wrote: On 02/23/2015 06:32 AM, Jonny Lamb wrote: + static const EGLint argb_attrs[] = { + EGL_TRANSPARENT_TYPE, EGL_TRANSPARENT_ALPHA_MESA,

Re: [Mesa-dev] egl dma-buf export extension again

Hi, On 3 March 2015 at 23:26, Kristian Høgsberg k...@bitplanet.net wrote: On Tue, Mar 3, 2015 at 10:43 AM, Chad Versace chad.vers...@intel.com wrote: Please use EGLImages as the import/export object. That provides consistency with existing similar EGL APIs. And it allows a clean separation

Re: [Mesa-dev] [PATCH] glx/dri3: Use a separate xcb connection for Present events

Hi, On Saturday, April 18, 2015, Axel Davy axel.d...@ens.fr wrote: There's a strange issue with xcb_get_geometry: If I use the new xcb connection it fails and the error is a drawable error. If I use the Xlib xcb connection (what I did in this patch) it works. If anyone knows why, please

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

Hi, On 23 April 2015 at 14:12, Emil Velikov emil.l.veli...@gmail.com wrote: Boyan Ding (2): i965: Add XRGB format to intel_screen_make_configs i915: Add XRGB format to intel_screen_make_configs This fixes https://bugs.freedesktop.org/show_bug.cgi?id=89689 but re-breaks ES3

Re: [Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

-batch_bo); + fence-batch_bo = NULL; Should this branch be setting fence-signalled = true as well, to match client_wait? The rest looks good to me, going on what I remember of having looked at this about 5 years ago, so: Reviewed-by: Daniel Stone dani...@collabora.com Cheers, Daniel

Re: [Mesa-dev] [PATCH 0/9] Some egl/wayland patches

with X11 in mind. As a result, it doesn't fit perfectly wayland: a copy could be avoided by upgrading this API. There doesn't seem to be interest in doing this work for a small gain for something that's not as efficient as hw rendering anyway. Patches 1-7 are Reviewed-by: Daniel Stone dani

Re: [Mesa-dev] [PATCH 7/9] egl/wayland: assume EGL_WINDOW_BIT

Hi, On 6 May 2015 at 07:25, Pekka Paalanen ppaala...@gmail.com wrote: On Wed, 6 May 2015 11:00:13 +1000 Dave Airlie airl...@gmail.com wrote: On 2 May 2015 at 20:15, Axel Davy axel.d...@ens.fr wrote: Only EGL_WINDOW_BIT is supported. Remove tests related. Is this there no plans to support

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

Hi, On 14 May 2015 at 23:33, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Marek, On 12/05/15 22:54, Marek Olšák wrote: -#elif defined(__WINSCW__) || defined(__SYMBIAN32__) /* Symbian */ +#elif defined(__APPLE__) || defined(__WINSCW__) || defined(__SYMBIAN32__) /* Symbian */ typedef

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

Hi, On 9 April 2015 at 17:20, Kristian Høgsberg k...@bitplanet.net wrote: On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, Can we get a pair of eyes on this patch please ? Reviewed-by: Kristian Høgsberg k...@bitplanet.net Thanks for the reminder.

Re: [Mesa-dev] Valve games for Mesa/DRI developers

Valve saying so. I agree it would be nice though! Cheers, Daniel Thierry On Thu, Apr 09, 2015 at 06:10:42PM +0100, Daniel Stone wrote: Hi, At Collabora (my lovely dayjob), we've been working with Valve on SteamOS. Valve are keen to give back to the community, and we've been discussing ways

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: implement platform_null (v2).

On 4 April 2015 at 08:46, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-04-03 19:18:35, Stéphane Marchesin wrote: Perhaps EGL_MESA_platform_surfaceless and platform_surfaceless.c? That's a very good name. As it happens, it also matches Chrome's naming. Chad made the point that this

Re: [Mesa-dev] st_TexSubImage: unaligned memcpy performance

Hi, On 8 April 2015 at 10:57, Vasilis Liaskovitis vlias...@gmail.com wrote: I have an issue where st_TexSubImage causes very high CPU load in __memcpy_sse2_unaligned (Mesa 10.1.3, Xorg 1.15.1, radeon driver, HD 7870). Any obvious causes / tips for this? e.g. align textures or use different

Re: [Mesa-dev] egl streams, trying to gain some knowledge

Hi, My two cents, which largely parallels Jason's ... On 2 April 2015 at 08:35, Dave Airlie airl...@gmail.com wrote: So nvidia have indicated they would like to use an EGLstreams based solution to enable wayland on their binary driver stack at some point. No real surprise, I guess. NVIDIA have

[Mesa-dev] Valve games for Mesa/DRI developers

Hi, At Collabora (my lovely dayjob), we've been working with Valve on SteamOS. Valve are keen to give back to the community, and we've been discussing ways they can help do that, including providing free access to Valve games on Steam to Debian developers last year. We're happy to say that this

Re: [Mesa-dev] [PATCH v5] egl/dri2: implement platform_surfaceless

Hi, On 12 June 2015 at 15:43, Emil Velikov emil.l.veli...@gmail.com wrote: On 11/06/15 17:43, Zach Reizner wrote: + dri2_dpy-fd = open(card_path, O_RDWR); Pretty sure that we'd want some O_CLOEXEC/fcntl() magic but that can be done as a separate patch. We absolutely want O_CLOEXEC; if

Re: [Mesa-dev] [PATCH 00/13] Avoid double promotion

Hi, On 14 July 2015 at 00:22, Matt Turner matts...@gmail.com wrote: but it's not really useful in general because float arguments are always cast to double when passed as arguments to varargs functions like printf (why?), and it warns about that, generating a lot of noise. It might shock you

Re: [Mesa-dev] [PATCH 11/13] mesa: add API dispatch for GL_ARB_get_texture_sub_image

Hi, On 14 July 2015 at 02:21, Brian Paul bri...@vmware.com wrote: +category name=GL_ARB_get_texture_sub_image number=96 +function name=GetTextureSubImage offset=assign +param name=program type=GLuint/ Surely texture rather than program? Cheers, Daniel

Re: [Mesa-dev] [PATCH] mesa: automake: replace $(RM) with rm -f

Hi, On 20 July 2015 at 17:40, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 July 2015 at 23:13, Jonathan Gray j...@jsg.id.au wrote: $(RM) is set to 'rm -f' by GNU make, this is not true of other versions of make and RM is not one of the macros required by POSIX. Slightly unfortunate but

Re: [Mesa-dev] [RFC 1/2] gallium: add renderonly driver

Hi Lucas, On 19 October 2015 at 10:25, Lucas Stach wrote: > Am Sonntag, den 18.10.2015, 21:41 +0200 schrieb Christian Gmeiner: >> 2015-10-16 15:31 GMT+02:00 Thierry Reding : >> > Gallium driver is rather complicated, but that's due to the fact

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

Hi, I know this isn't your fault, but I really really don't see any reason why the vl winsys bits should continue to exist. We already have a winsys/presentation layer in Mesa ... Cheers, Daniel On 29 October 2015 at 17:40, Julien Isorce wrote: > This patch allows to use

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

a matter of modifying the existing internal EGL platform API to be able to use it from vl_*, rather than straight reuse. DItto for gbm if there's anything useful in there that could use the same codepaths. Cheers, Daniel > Cheers > Julien > > > On 30 October 2015 at 08:47, Daniel Stone &l

[Mesa-dev] [PATCH] egl/wayland: Ignore rects from SwapBuffersWithDamage

full-surface damage. bce64c6c provides the explanation for why we send maximum-range damage, rather than the full size of the surface: in the presence of buffer transformations, full-surface damage may not actually cover the entire surface. Signed-off-by: Daniel Stone <dani...@collabora.com&

Re: [Mesa-dev] [PATCH] egl/wayland: Ignore rects from SwapBuffersWithDamage

On 12 November 2015 at 16:47, Jason Ekstrand wrote: > On Thu, Nov 12, 2015 at 6:46 AM, Pekka Paalanen wrote: >> Reviewed-by: Pekka Paalanen >> >> Perhaps a TODO comment referring to >>

Re: [Mesa-dev] Bugzilla (Was: [Bug 93686] Performance improvement : Please consider hardware ɢᴘᴜ rendering in llvmpipe)

Hi, On 18 January 2016 at 12:48, Jose Fonseca wrote: > There's something weird going on with bugzilla and maybe ytrezq's browser. > mesa-dev received a lot of CC add/remove notification emails from bugzilla, > but if you look at

Re: [Mesa-dev] [PATCH] egl/wayland: Set __DRI_IMAGE_USE_SCANOUT for shared buffers

On 29 January 2016 at 03:44, Michel Dänzer wrote: > It still sounds like significant work (particularly for somebody like me > who isn't very familiar with Wayland details yet). It should be done by > somebody who cares about the difference you're describing. I think it's >

Re: [Mesa-dev] [PATCH] egl/wayland: Set __DRI_IMAGE_USE_SCANOUT for shared buffers

On 28 January 2016 at 03:21, Michel Dänzer <mic...@daenzer.net> wrote: > On 27.01.2016 23:54, Daniel Stone wrote: >> On 27 January 2016 at 14:16, Axel Davy <axel.d...@ens.fr> wrote: >>> On 27/01/2016 13:43, Daniel Stone wrote: >>>> If the compositor want

Re: [Mesa-dev] [PATCH 0/8] Fixes for building AOSP master

Hi, On 25 February 2016 at 01:47, Emil Velikov wrote: > On 24 February 2016 at 18:56, Rob Herring wrote: >> AOSP master branch has switched to clang from gcc and has major build >> system changes moving away from GNU make. > > Out of curiosity: what

Re: [Mesa-dev] Mesa for OpenVMS

Hi, On 19 January 2016 at 02:14, Timothy Arceri wrote: > On Mon, 2016-01-18 at 16:47 +0100, Jouk Jansen wrote: >> Can someone insert these patches in the git-repository. >> I cannot do it myself, because the git-client on my OpenVMS is very >> -very >> limited and

Re: [Mesa-dev] [PATCH] egl/wayland: Set __DRI_IMAGE_USE_SCANOUT for shared buffers

Hi, On 27 January 2016 at 09:34, Michel Dänzer wrote: > The compositor may have the hardware scan out directly from the buffers > sent by the client, so we must make sure the buffers we create are > suitable for scanout. If the compositor wants to scan out directly, it will

Re: [Mesa-dev] [PATCH] egl/wayland: Set __DRI_IMAGE_USE_SCANOUT for shared buffers

Hi, On 27 January 2016 at 14:16, Axel Davy <axel.d...@ens.fr> wrote: > On 27/01/2016 13:43, Daniel Stone wrote: >> On 27 January 2016 at 09:34, Michel Dänzer <mic...@daenzer.net> wrote: >>> The compositor may have the hardware scan out directly from the buffers >

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

Hi, On 16 February 2016 at 16:34, Derek Foreman wrote: > +try_damage_buffer(struct dri2_egl_surface *dri2_surf, > + const EGLint *rects, > + EGLint n_rects) > +{ > +/* The WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION macro and > + *

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hi, On 9 March 2016 at 02:57, Michel Dänzer <mic...@daenzer.net> wrote: > On 08.03.2016 20:36, Daniel Stone wrote: >> Taking the approach I suggested would allow us to solve multi-GPU >> with the same approach, whereas with the wrapper driver ... who >> volunteer

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hey Emil, On 8 March 2016 at 17:04, Emil Velikov wrote: > Summarising and stating some unsaid assumptions. > > Assumptions: > - The proposed solution is a replacement of the wrapped drivers > approach. No, it's meant to introduce an API mostly gears towards > DRI_PRIME

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hi, On 7 March 2016 at 10:19, Thierry Reding wrote: > On Mon, Mar 07, 2016 at 10:46:52AM +0100, Lucas Stach wrote: >> Am Freitag, den 04.03.2016, 18:34 + schrieb Emil Velikov: >> > While I'm more inclined to Daniel's suggestion, I wonder why people >> > moved away

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hi, On 7 March 2016 at 20:45, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 7 March 2016 at 10:35, Daniel Stone <dan...@fooishbar.org> wrote: >> On 7 March 2016 at 10:19, Thierry Reding <thierry.red...@gmail.com> wrote: >>> On Mon, Mar 07, 2016 at

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hi Lucas, On 4 March 2016 at 13:49, Lucas Stach wrote: > this is a first shot at trying to hash out an API to allow bootstrapping > an EGL context on top of split render/scanout DRM devices. It tries to make > things really easy for applications, while leaving them in

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

Hi, On 4 March 2016 at 16:08, Lucas Stach <l.st...@pengutronix.de> wrote: > Am Freitag, den 04.03.2016, 15:09 + schrieb Daniel Stone: >> Thanks for taking this on, it looks really good! I just have the one >> question though - did you look at the EGLDe

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

Hi, On 29 March 2016 at 15:44, Rob Clark wrote: > On Tue, Mar 29, 2016 at 10:30 AM, Rob Herring wrote: >> On Tue, Mar 29, 2016 at 8:43 AM, Rob Clark wrote: >>> On Mon, Mar 28, 2016 at 12:29 PM, Rob Herring wrote:

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

Hey, On 29 March 2016 at 19:06, Rob Clark <robdcl...@gmail.com> wrote: > On Tue, Mar 29, 2016 at 1:51 PM, Daniel Stone <dan...@fooishbar.org> wrote: >> Yep, you got it right: in the original intention, the only mappable >> GBM BOs were cursor BOs. This is mostly because

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

Hi, On 31 March 2016 at 04:21, Rob Herring wrote: > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index 6bbd3fa..b059112 100644 > --- a/include/GL/internal/dri_interface.h > +++ b/include/GL/internal/dri_interface.h > @@ -1101,6

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

Hi, On 25 April 2016 at 15:25, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 25 April 2016 at 13:46, Daniel Stone <dan...@fooishbar.org> wrote: >> On 23 April 2016 at 03:08, Rob Herring <r...@kernel.org> wrote: >>> I'm not using GBM_BO_USE_WRITE and

Re: [Mesa-dev] [PATCH] wayland/egl: Assigning window size to window surface size property

Hi Adrian, On 25 April 2016 at 14:23, Adrian Pielech wrote: > Till now window surface size on wayland was -1. > It's better to assign windows size to proper surface property. Hm. This will be done from update_buffers(), so will only be 'invalid' before the first

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

a completely empty file. But wasn't planning to > wait for it to be completely populated to start with. If you want a bit more to add: WAYLAND EGL SUPPORT R: Daniel Stone <dani...@collabora.com> F: src/egl/wayland/* F: src/egl/drivers/dri2/platform_wayland.c Cheers, Daniel ___

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

Hi, On 22 April 2016 at 19:12, Eric Anholt wrote: > I think this needs a longer comment to explain what the interface does: > > "Returns a map of the specified region of a __DRIimage for the specified > usage. > > flags must always include __DRI_IMAGE_TRANSFER_READ and may

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

Hi, On 22 April 2016 at 19:21, Eric Anholt wrote: > I don't think we want to always make a spare context just in case > someone uses the map API. Contexts can be pretty expensive to set up, > in time (for piglit tests on gbm) and memory (for X.Org). > > It's too bad I don't

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

Hi, On 23 April 2016 at 03:08, Rob Herring wrote: > On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov > wrote: >> Can we take a look at the GBM gralloc as well. One thing that worries >> me is that (most likely) you are requesting/creating a bo without >>

Re: [Mesa-dev] [RFC 1/5] wayland-drm: add a few lovely notes about future work.

ch we don't check but perhaps > we should. > + > #ifndef WL_DRM_FORMAT_ENUM > #define WL_DRM_FORMAT_ENUM > enum wl_drm_format { Indeed, this is already provided by wayland-drm-*-protocol.h, and only used in places which may include those files. Reviewed

Re: [Mesa-dev] [PATCH] egl: Check if API is supported when using eglBindAPI.

Hi, On 13 May 2016 at 17:03, Plamena Manolova wrote: > @@ -444,6 +444,8 @@ _eglCreateAPIsString(_EGLDisplay *dpy) >strcat(dpy->ClientAPIsString, "OpenVG "); > > assert(strlen(dpy->ClientAPIsString) < sizeof(dpy->ClientAPIsString)); > + > +

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

Hi, On 18 May 2016 at 00:00, Ian Romanick wrote: > On 05/17/2016 09:59 AM, Ben Widawsky wrote: >> I think you misstated this. It's not invalid to have any other value. It's >> invalid to not have one of the 3 values, which I suppose is technically >> possible >> if you say

[Mesa-dev] [PATCH RFC 2/2] i965: Implement validation for scanout usage

Add a more comprehensive validateUsage() call, checking that the tiling mode for the __DRIimage. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> --- src/mesa/drivers/dri/i965/intel_screen.c | 9 + 1 file changed, 9 insertions(+)

[Mesa-dev] [PATCH RFC 1/2] i965: Store gen in DRIimages

This will be used so we can implement a better validateUsage, which takes neither a screen nor a context. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> --- src/mesa/drivers/dri/i965/intel_image.h | 2 ++ src/mesa/drivers/dri/i965/in

Re: [Mesa-dev] [PATCH] egl/wayland: Set __DRI_IMAGE_USE_SCANOUT for shared buffers

Hi, On 3 May 2016 at 14:52, Daniel Vetter wrote: > On Mon, Feb 01, 2016 at 12:48:52PM +0900, Michel Dänzer wrote: >> As I said before, looking at intel_validate_usage, I suspect the latter. > > Just jumping in here, but it's correct atm. Well if we ignore a recent bug > to

Re: [Mesa-dev] [PATCH] egl/wayland: Avoid race conditions when on non-main thread

Hi Jonas, On 4 May 2016 at 09:53, Jonas Ådahl wrote: > When EGL is used on some other thread than the thread that drives the > main wl_display queue, the Wayland EGL dri2 implementation is > vulnerable to a race condition related to display round trips and global > object

[Mesa-dev] [PATCH RESEND] Revert "i965: Always use Y-tiled buffers on SKL+"

6a0d036483caf87d43ebe2edd1905873446c9589. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Ben Widawsky <b...@bwidawsk.net> Cc: Topi Pohjolainen <topi.pohjolai...@intel.com> Cc: Kenneth Graunke <kenn...@whitecape.org> --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 4 ++-- s

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

Hi, On 2 May 2016 at 11:44, Rob Clark wrote: > On Mon, May 2, 2016 at 2:15 AM, Michel Dänzer wrote: >> So, what is this based on? Maybe I'm not looking in the right place, but >> out of hundreds of changes in Git touching those files, I see one change >>

Re: [Mesa-dev] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

Hi, I'd already suggested the same, but it never got pushed: https://lists.freedesktop.org/archives/mesa-dev/2016-May/115501.html So I guess we can add the Tested-by from the other, for whichever gets pushed. Cheers, Daniel On Sunday, 8 May 2016, Hans de Goede wrote: >

Re: [Mesa-dev] Why is www.freedesktop.org/wiki/AccountRequests/ so "complicated"?

Hi, On 17 April 2016 at 16:58, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > Secondly, the content of the wiki page feels overly bureaucratic to me. Not > in absolute sense, but in relative sense: when compared to services such as > github.com, the freedesktop.org wiki page feels like a nice example of >

Re: [Mesa-dev] [PATCH] Don't manually close fds for queryImage. drm uses CLOEXEC

Hi, On 14 April 2016 at 13:19, Chokshi, Mitul wrote: > If create_wl_buffer() closes the file descriptor returned by > dri2_dpy->image->queryImage then OS hands out the same file > descriptor number to other process which then experiences error > when fd is closed due to

Re: [Mesa-dev] [PATCH] Revert "i965: Always use Y-tiled buffers on SKL+"

Hi, On 8 May 2016 at 20:05, Ben Widawsky <b...@bwidawsk.net> wrote: > On Sun, May 08, 2016 at 12:15:00PM +0100, Daniel Stone wrote: >> I'd already suggested the same, but it never got pushed: >> https://lists.freedesktop.org/archives/mesa-dev/2016-May/115501.html >&g

Re: [Mesa-dev] [PATCH 8/8] egldevice: implement eglQueryDisplayAttribEXT

Hi, On 21 July 2016 at 15:11, Emil Velikov wrote: > On 21 July 2016 at 14:57, Adam Jackson wrote: >>> + device_name = drv->QueryDeviceName(disp); >> >> This is /dev/dri/renderD128... >> >>> + mtx_lock(_eglGlobal.Mutex); >>> + >>> +

Re: [Mesa-dev] [PATCH] anv: add function to get prime buffer from memory+image

Hi Jonathan, On 19 July 2016 at 20:47, Jonathan wrote: > +typedef VkResult (VKAPI_PTR *PFN_vkGetDmaBufINTEL)(VkDevice device, > VkDeviceMemory mem, VkImage image, int *fd, uint32_t *pitch); Some things you should consider adding to this: - multi-plane support for

Re: [Mesa-dev] [PATCH] anv: add function to get prime buffer from memory+image

On 20 July 2016 at 13:47, Daniel Stone <dan...@fooishbar.org> wrote: > On 19 July 2016 at 20:47, Jonathan <jonat...@marek.ca> wrote: >> +typedef VkResult (VKAPI_PTR *PFN_vkGetDmaBufINTEL)(VkDevice device, >> VkDeviceMemory mem, VkImage image, int *fd, uint32_t *pitch);

Re: [Mesa-dev] [RFC] EGL extension for additional DRM_BUFFER_FORMATs

Hi Nicolai, On 7 February 2017 at 09:07, Nicolai Hähnle wrote: > On 06.02.2017 20:57, Dave Airlie wrote: >> I just saw this, EGL_MESA_drm_image is really not a good place to start, >> >> we have two specs instead, >> EGL_EXT_image_dma_buf_import. >>

Re: [Mesa-dev] [PATCH 06/34] gbm: Export a per plane getter for stride

Hi, On 4 February 2017 at 05:29, Ben Widawsky wrote: > On 17-01-31 11:33:39, Jason Ekstrand wrote: >> On Mon, Jan 23, 2017 at 10:19 PM, Ben Widawsky wrote: >>> + /* Preserve legacy behavior if plane is 0 */ >>> + if (plane == 0) >>> + return

Re: [Mesa-dev] [PATCH 14/34] gbm: Get modifiers from DRI

Hi, On 6 February 2017 at 19:22, Jason Ekstrand wrote: > On Sun, Feb 5, 2017 at 1:15 PM, Ben Widawsky wrote: >> Introducing the LINEAR modifier (which happened after v2 of this series) did >> make things complex because it's possible in some horrific

[Mesa-dev] [PATCH] egl/wayland: Don't use DRM format codes for SHM

fail with an error. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Emil Velikov <emil.veli...@collabora.com> Cc: mesa-sta...@lists.freedesktop.org Fixes: cb5e799448 ("egl/wayland: unify dri2_wl_create_surface implementations") --- src/egl/drivers/dri2/p

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Don't use DRM format codes for SHM

Hi, On 13 February 2017 at 17:49, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 13 February 2017 at 17:34, Daniel Stone <dan...@fooishbar.org> wrote: >> On 13 February 2017 at 17:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: >&g

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Don't use DRM format codes for SHM

Hey, On 13 February 2017 at 17:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 13 February 2017 at 14:06, Daniel Stone <dani...@collabora.com> wrote: >> static EGLBoolean >> dri2_wl_swrast_allocate_buffer(struct dri2_egl_display *dri2_dpy, >> -

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: use the destroy_window_callback for swrast

face.") if we attempt to destroy a EGL surface >> attached to already destroyed Wayland window we'll get a segfault. >> >> v2: set the correct callback alongside the window->private. (Dan) >> > Humble poke on this and 2/2 ? Both are

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Don't use DRM format codes for SHM

Hi Emil, On 15 February 2017 at 12:23, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 13 February 2017 at 17:54, Daniel Stone <dan...@fooishbar.org> wrote: >>> From a quick look shm_handle_format() comes to mind. Keep in mind that >>> I'm not that big of a

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

bug.cgi?id=97773 Weston is the only report now, but unless the world has switched to requiring get_all_proc_addresses, it'll break a hell of a lot more. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH v2 30/30] egl/dri2: set WL_bind_wayland_display in a consistent way

On 16 September 2016 at 18:02, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Introduce a helper and use it throughout the platform code. This allows > us to reduce the amount of ifdef(s) and (potentially) use > kms_swrast_dri.so for !drm platforms (namely wayland and x11). Revi

Re: [Mesa-dev] [PATCH] Revert "wayland: Block for the frame callback in get_back_bo not dri2_swap_buffers"

Hi, On 10 November 2016 at 06:08, Jonas Ådahl <jad...@gmail.com> wrote: > On Mon, Oct 24, 2016 at 08:42:59PM +0100, Daniel Stone wrote: >> The intent of moving blocking from SwapBuffers to get_back_bo, was to >> avoid unnecessary triple-buffering by ensuring that the co

Re: [Mesa-dev] [PATCH] gbm/drm: Pick the oldest available buffer in get_back_bo

Hi, On Nov 10 2016, at 2:09 pm, Pekka Paalanen wrote: > On Wed, 9 Nov 2016 14:57:22 -0600 Derek Foreman wrote: > > > We find the oldest backbuffer we can, on the grounds that clients are > only going to keep a fixed history queue, so

Re: [Mesa-dev] [PATCH mesa] wsi/wayland: fix error path

Hi Eric, On 20 October 2016 at 00:09, Eric Engestrom wrote: > I'm not sure this is the right fix. The other thing I'm starting to lean > toward is to just remove these last two instruction (ie. everything after > `return VK_SUCCESS`). > Also, this is untested. It compiles, but

  1   2   3   4   5   6   7   8   >