Re: [Mesa-dev] [PATCH] automake: get in-tree `make distclean' working again.

On Wed, Jun 08, 2016 at 03:44:39PM +0100, Emil Velikov wrote: > From: Emil Velikov > > With earlier commit we've handled the `make distclean' out of tree > build, yet we failed to attribute that for in-tree builds the test > condition will return 1. Thus effectively

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Fri, Jun 10, 2016 at 12:28:38PM +0200, Stephan Bergmann wrote: > On 06/10/2016 12:09 PM, Eric Engestrom wrote: > > On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: > > > > Since you didn't send this patch from your primary email account, > > you

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote: Since you didn't send this patch from your primary email account, you might want to add this line here, otherwise the author will be "stephan.bergmann.second...@googlemail.com": From: Stephan Bergmann >

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > > > diff --git a/src/mesa/main/extensions_table.c > > b/src/mesa/main/extensions_table.c > > new file mode 100644 > > index 000..1e37fbc > > --- /dev/null > > +++ b/src/mesa/ma

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote: > You can add an entry to the end of the enum defined in extensions.h called > "MESA_EXTENSION_COUNT" or similar. This is a good idea, but with one caveat: I've seen twice already bugs caused by people using ALL_CAPS counter entries

Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

, it was off by 1 since ES > 3.20 >"support" was added. > Looks all good to me :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] mesa: replace 1.F with 1.0F

On Wed, Jun 15, 2016 at 09:07:23PM +0530, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> After all the fuss :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++--- > 1 fi

Re: [Mesa-dev] [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f

On Wed, Jun 15, 2016 at 03:38:04PM +0530, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/gallium/auxiliary/draw/draw_pipe_clip.c | 2 +- > src/gallium/auxiliary/gal

Re: [Mesa-dev] [PATCH 2/2] mesa: replace 1.F with 0.F

the v2. > has nothing to do with the use of "f" and "F". Regarding replacing the "F" > with "f", maybe someone can shed some light as to why "F" was used > specifically. > > Regards, > Nayan. > > On Wed, Jun 15, 2016 at 6:32 PM,

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > static enum { extension_table_size = > ARRAY_SIZE(extension_table_for_size) }; Sorry, I don't know how that `static` snuck in here, but it obviously shouldn't be here. __

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

extension_table[] = { > +#define EXT(name_str, driver_cap, gll_ver, glc_ver, gles_ver, gles2_ver, > ) \ > +{ .name = "GL_" #name_str, .offset = o(driver_cap), \ > + .version = { \ > + [API_OPENGL_COMPAT] = gll_ver, \ > +[

[Mesa-dev] [PATCH] target/d3dadapter9: make sure strings are null-terminated

From strncpy's man page: Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. CoverityID: 1320457, 1320458, 1255671 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/targets/d3dadapter9/description.

[Mesa-dev] [PATCH] swr: [rasterizer common] avoid divison by zero

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/rdtsc_buckets.cpp b/src/gallium/drivers/swr/rast

[Mesa-dev] [PATCH] st/va: restore old buffer format on error

CoverityID: 1337953 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- Note that I do not know this code at all; I'm blindly following Coverity's advice on this one :] --- src/gallium/state_trackers/va/image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_tr

[Mesa-dev] [PATCH] glsl: Remove tautological check

`size_t offset` can never be `< 0` Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/compiler/glsl/blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/blob.c b/src/compiler/glsl/blob.c index dd4341b..ef17255 100644 --- a/src/compiler/gl

[Mesa-dev] [PATCH] st/osmesa: remove double-write (overwriting)

These two lines have been here since the file was created. I'm guessing the second one was just for testing during dev, so it's the one that's going away. CoverityID: 1296205 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- This should probably be tested by someone who knows what t

[Mesa-dev] [PATCH] anv: limit string copy to target buffer size

CoverityID: 1358935 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/intel/vulkan/anv_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 046777d..e451138 100644 --- a/src/intel/

[Mesa-dev] [PATCH] st/glsl_to_tgsi: prevent infinite loop

`unsigned j` would never fail `j >= 0`, leading to an infinite loop as `j--` wraps around. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/stat

[Mesa-dev] [PATCH] .gitignore: Ignore tags generated by `make tags`

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 7db5639..d3f3589 100644 --- a/.gitignore +++ b/.gitignore @@ -48,3 +48,4 @@ Makefile Makefile.in .install-mesa-links .install-gallium-links

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

> > >} > > > > > >surf->buffer->destroy(surf->buffer); > > >surf->buffer = tmp_buf; > > > + surf->templat.buffer_format = format; > > > } > > > > > > Cheers > > > Julien &

Re: [Mesa-dev] [PATCH] st/osmesa: remove double-write (overwriting)

On Tue, May 31, 2016 at 06:33:53AM -0600, Brian Paul wrote: > On 05/30/2016 07:26 PM, Eric Engestrom wrote: > > These two lines have been here since the file was created. > > I'm guessing the second one was just for testing during dev, so it's the > > one that's going away

Re: [Mesa-dev] [PATCH] automake: avoid fetching unnecessary data for the generation of git_sha1.h

en the only output is already what we want. I'd find something like this cleaner, but your patch also works: printf '#define MESA_GIT_SHA1 "git-%s"\n' > git_sha1.h \ $(git --git-dir=$(top_srcdir)/.git rev-parse --short HEAD) Either way, this patch is

Re: [Mesa-dev] [PATCH 2/2] mesa: replace 1.F with 0.F

On Wed, Jun 15, 2016 at 03:38:05PM +0530, Nayan Deshmukh wrote: > Signed-off-by: Nayan Deshmukh > --- > src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/r200/r200_swtcl.c >

Re: [Mesa-dev] [PATCH 1/4] clover: conditionally use MESA_GIT_SHA1

w-up commits. > > Cc: mesa-sta...@lists.freedesktop.org > Cc: Vedran Miletić <ved...@miletic.net> > Cc: Francisco Jerez <curroje...@riseup.net> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- LGTM Reviewed-by: Eric Engestrom <eric.engest...@imgt

Re: [Mesa-dev] [PATCH 2/4] anv: use cache uuid based on the build timestamp.

n the same second, and I don't see why we would want to avoid modifying anv_timestamp.h's timestamp in this case, since that would be the only thing that would be changed, and said timestamp would be within the same second anyway. I suggest to drop the `if` and unconditionally do the move. Since thi

Re: [Mesa-dev] [PATCH 3/4] automake: don't mandate git_sha1.h/MESA_GIT_SHA1

On Wed, Jun 22, 2016 at 01:04:42PM +0100, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > It has proven subtle to get it right both form the build side POV (see s/form/from/ Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > commit list

Re: [Mesa-dev] [PATCH 2/4] anv: use cache uuid based on the build timestamp.

On Wed, Jun 22, 2016 at 04:57:39PM +0100, Eric Engestrom wrote: > On Wed, Jun 22, 2016 at 01:04:41PM +0100, Emil Velikov wrote: > > From: Emil Velikov <emil.veli...@collabora.com> [...] > > diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am > > in

Re: [Mesa-dev] [PATCH v2] mesa: replace 1.F with 1.0F

On Wed, Jun 15, 2016 at 11:19:28PM +0530, Nayan Deshmukh wrote: > Hi Eric, > > Could you please push both the patches as I don't have the push access. > > Thanks, > Nayan. I don't have push access either. Emil will probably be happy to do it for you though, seeing as this was his idea :)

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

On Wed, Jun 15, 2016 at 11:58:29AM -0600, Brian Paul wrote: > To match what's done in the automake build. > --- > src/SConscript | 43 +++ > src/mesa/SConscript | 43 ++- > 2 files changed, 45 insertions(+), 41

Re: [Mesa-dev] [PATCH] loader: fix sysfs uevent file parsing

tec.com> For both patches: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa] gbm: doc fixes

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/gbm/main/gbm.c | 8 src/gbm/main/gbm.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gbm/main/gbm.c b/src/gbm/main/gbm.c index 0f4657a..a464f3c 100644 --- a/src/gbm/main/gbm.c +++ b/s

Re: [Mesa-dev] [PATCH] gbm: Fix comments

On Thu, Jun 23, 2016 at 03:54:11PM +0530, Gurkirpal Singh wrote: > --- Yes, and this reminds me I forgot to send similar fixes I made in this file ^^ Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> You might also want to add a Signed-off-by: line with your name (although I do

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

On Thu, Jun 16, 2016 at 09:48:54AM -0600, Brian Paul wrote: > On 06/16/2016 07:35 AM, Eric Engestrom wrote: > > That fixed truncation can give non-unique hashes. Switching to rev-parse > > (suggested above) fixes this. > > rev-parse --short produces a 7-char

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

On Thu, Jun 16, 2016 at 11:15:55AM -0600, Brian Paul wrote: > To match what's done in the automake build. > > v2: Use git rev-parse to get a 10-character hash ID > Fix Python imports > --- Perfect, thanks! Reviewed-by: Eric Engestrom <eric.en

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

On Fri, Jun 17, 2016 at 04:09:55PM +0200, ⚛ wrote: > Hello. Are you editing those files by hand? Yup, editing everything by hand. You just need a magnetized needle and a steady hand. I'm still learning to use C-x M-c M-butterfly though, haven't mastered that yet.

Re: [Mesa-dev] [PATCH 1/4] mesa: Use STATIC_ASSERT whenever possible.

Good idea! For the whole series: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> On Tue, Apr 12, 2016 at 07:37:43AM +0100, Jose Fonseca wrote: > --- > src/mesa/main/imports.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/impo

Re: [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Mon, Apr 25, 2016 at 05:08:18PM +0100, Emil Velikov wrote: > On 21 April 2016 at 11:24, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the > > VK_PROTOTYPES to VK_NO_PROTOTYPES > > This brin

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

On Tue, May 03, 2016 at 11:11:56AM -0400, Rob Clark wrote: > > Ok, I've renamed to REVIEWERS and scripts/get_reviewer.pl and updated > the verbage appropriately. scripts/get_reviewer.pl still obeys .get_maintainer.conf and .get_maintainer.ignore. Is that something we want to make more

Re: [Mesa-dev] [PATCH] vulkan: Fix use of uninitialized variable.

= wl_display_create_queue(chain->display->display); > - if (!chain->queue) > + if (!chain->queue) { > + result = VK_ERROR_INITIALIZATION_FAILED; ditto >goto fail; > + } > > for (uint32_t i = 0; i < chain->image_count; i+

Re: [Mesa-dev] [RFC 3/5] anv: add a note about strange looking define

On Thu, Apr 21, 2016 at 01:24:45PM +0100, Emil Velikov wrote: > diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h > index 120696e..3eb0475 100644 > --- a/src/intel/vulkan/anv_private.h > +++ b/src/intel/vulkan/anv_private.h > @@ -53,6 +53,9 @@ typedef struct

[Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

Commit 3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all the VK_PROTOTYPES to VK_NO_PROTOTYPES This brings the Intel header in line with the rest of the Vulkan code. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This might break code that was using the old guard

[Mesa-dev] [PATCH mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

3d0fac7aca237bbe8ed8e2a362d3b42d0ef8c46c changed all VK_PROTOTYPES to VK_NO_PROTOTYPES This brings the Intel header in line with the rest of the Vulkan code. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This might break code that was using the old guard scheme (not su

Re: [Mesa-dev] [PATCH v2 mesa] vk/intel: use negative VK_NO_PROTOTYPES scheme

On Sun, May 01, 2016 at 09:39:58PM -0700, Jason Ekstrand wrote: > On May 1, 2016 6:04 PM, "Kenneth Graunke" wrote: > > On Sunday, May 1, 2016 9:51:00 AM PDT Emil Velikov wrote: > > > Adding the anv authors. > > > > > > Jason, Chad, is there a canonical place where changes

Re: [Mesa-dev] [PATCH 3/6] spriv: Mark default cases unreachable().

3; break; > case 4: op = nir_op_bany_inequal4; break; > + default: unreachable("not reached"); I'll admit I don't know this code very well, but I'm sure one can write a more informative message :) "invalid number of components" for instance? With those two and the typo fix

Re: [Mesa-dev] [PATCH] i965: Fix shadowing of 'height' parameter

> the code clearer. > > This would typically break the bo size computation, but we don't use > that except when mmaping, and we don't mmap YUV buffers much. > > Signed-off-by: Kristian Høgsberg Kristensen <k...@bitplanet.net> > --- Why does that even compile… Reviewed-

Re: [Mesa-dev] [PATCH] configure: fix LLVM 4.0.0svn compilation, add libs for LLVM static linking

On Tue, Jul 26, 2016 at 09:54:27PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > configure.ac | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 5c196a9..58c2db4 100644 > ---

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

ast entry), but until DI_FUNCTION_COUNT reaches UINT_MAX this wouldn't wrap around. It's unlikely we'll ever have more than INT_MAX entries in the dispatch table, so I think this patch is OK. I tried to find a better fix, but adding checks before updating first and last feels too heavy. Review

[Mesa-dev] [PATCH mesa v2] vl: fix memory leak

CovID: 1363008 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v2: avoid using malloc() altogether (Christian König) --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filte

Re: [Mesa-dev] mesa from git fails to compile

On Thu, Jul 14, 2016 at 12:24:32PM +0200, Pali Rohár wrote: > Any news? Or possible fix? Have you tried Emil's suggestion, ie. upgrading to at least 0.8.0? Build system wizards: Any way to check the version and abort the compilation before running into this issue? If it helps, this prints the

Re: [Mesa-dev] [PATCH mesa] vl: fix memory leak

few minutes. > > Regards, > Christian. > > Am 13.07.2016 um 00:02 schrieb Eric Engestrom: > > CovID: 1363008 > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > src/gallium/auxiliary/vl/vl_bicubic_filter.c | 3 +++ > > 1 file changed,

Re: [Mesa-dev] mesa from git fails to compile

On Thu, Jul 14, 2016 at 10:51:43AM -0400, Rob Clark wrote: > On Thu, Jul 14, 2016 at 10:41 AM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > > On Thu, Jul 14, 2016 at 12:24:32PM +0200, Pali Rohár wrote: > >> Any news? Or possible fix? > > > > Have you

[Mesa-dev] Required Mako version? (WAS: mesa from git fails to compile)

On Thu, Jul 14, 2016 at 04:01:13PM +0100, Eric Engestrom wrote: > Oh right, there's already check for the Mako version, but the minimum is > currently set to 0.3.4 (configure.ac:92). > > Emil, you were the one to mention 0.8.0; is that the actual minimum, or > just a known worki

Re: [Mesa-dev] [Patch v2] clover: make GCC 4.8 happy

lue of type '' > > v2: change commit title and add error message like Eric Engestrom requested Thanks! Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: Dieter Nützel <die...@nuetzel-hh.de> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: > Hello, > > unluckily this didn't fix the warning... > I've done some more compile testing and found this solution: > > - static struct ir3_shader_key key = {{0}}; > +static struct ir3_shader_key key = {{{0, 0, 0, 0, 0, 0, 0,

Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

On Wed, Jul 27, 2016 at 02:02:54PM +0100, Emil Velikov wrote: > From: Emil Velikov > > The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not +"advertise" > that the driver supports the extension. Furturmore the functions are empty > stubs.

[Mesa-dev] [PATCH mesa] freedreno/a2xx: remove duplicate assignment

CovID: 1362445, 1362446 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.h b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.h

[Mesa-dev] [PATCH mesa] freedreno/a2xx: add missing `break` after error message

CovID: 1362455, 1362456, 1362457 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c index 2

[Mesa-dev] [PATCH mesa] gallium/freedreno: move cast to avoid integer overflow

Previously, the bitshift would be performed on a simple int (32 bits on most systems), overflow, and then be cast to 64 bits. CovID: 1362461 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 4 ++-- 1 file changed, 2 insertions

[Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

CovID: 401540 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c index 8c4f215..1ed4336 100644 ---

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

On Sat, Jul 30, 2016 at 07:44:02PM +0200, Marek Olšák wrote: > On Sat, Jul 30, 2016 at 6:16 PM, Roland Scheidegger > wrote: > > This looks very bogus to me. > > How is this supposed to work if you immediately close the library again? > > The functions are still going to get

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > AST_NUM_OPERATORS stores the dimension of the ast_operators > enumeration but was not updated after its last modification. > > This doesn't add any real modification for any code paths but it makes > sense for coherence. > >

Re: [Mesa-dev] [PATCH] clover: make older c++ (4.8.x) happy

On Tue, Jul 26, 2016 at 04:21:26AM +0200, Dieter Nützel wrote: > Signed-off-by: Dieter Nützel The change itself looks good, but could you replace "c++ 4.8" with "GCC 4.8" in the commit title, and add a commit message with the error? For reference: error: invalid

Re: [Mesa-dev] [PATCH] configure: add support for LLVM 4.0.0svn static libs

On Wed, Jul 27, 2016 at 01:36:16PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> Thanks! Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertions(+), 1 dele

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

On Mon, Aug 01, 2016 at 03:43:17PM +0200, ⚛ wrote: > On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: > >> Signed-off-by: Jan Ziak (http://atom-symbol.net

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead of 'int' for boolean variables

On Tue, Aug 02, 2016 at 05:32:16PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> Much better with the s/0/false/;s/1/true/ :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/egl/drivers/dri2/egl_

[Mesa-dev] [PATCH mesa] glx/dri3: remove never-used field

This field was added in 2d94601582e4f0fcaf8c ("Add DRI3+Present loader"), which was a v2. Guessing it was used in v1 and Keith forgot to remove it in v2. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Fair warning: This patch will conflict with Jan Ziak's "[

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > > [snip] > > > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/gls

Re: [Mesa-dev] __func__ vs. __FUNCTION__

On Wed, Aug 03, 2016 at 11:41:58AM +0200, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I've seen we're using __func__ as well as __FUNCTION__. > Should we consolidate that ? > > > --mtx Hi, To reply this and your other questions, I think you should just send those patches and

[Mesa-dev] [PATCH mesa] vl: fix memory leak

CovID: 1363008 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/auxiliary/vl/vl_bicubic_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_bicubic_filter.c b/src/gallium/auxiliary/vl/vl_bicubic_filter.c index 25bc58c..602424b

[Mesa-dev] [PATCH mesa] gallium/cso: avoid unnecessary null dereference

The label `out:` calls `destroy()` which dereferences `ctx`. This is unnecessary as there is nothing to destroy. Immediately return instead. CovID: 1258255 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/auxiliary/cso_cache/cso_context.c | 2 +- 1 file changed, 1 ins

[Mesa-dev] [PATCH mesa] vc4: fix memory leak

The allocation has succeeded by that point, so it needs to be freed. CovID: 1358929 Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/drivers/vc4/vc4_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c

[Mesa-dev] [PATCH mesa] st/xvmc: fix a couple 'unused-but-set-variable' warnings

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/gallium/state_trackers/xvmc/surface.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/surface.c b/src/gallium/state_trackers/xvmc/surface.c index 199712b..93ec708 100644 ---

Re: [Mesa-dev] [PATCH] glu/autoconf: Don't modify CFLAGS in configure script

quot;-g -O0 -DDEBUG" > +DEBUGCXXFLAGS="-g -O0 -DDEBUG"], > + [test "$enableval" = xno], > + [DEBUGCFLAGS="-DNDEBUG" > +DEBUGCXXFLAGS="-DNDEBUG"]), These tabs mess up the formatting. The con

Re: [Mesa-dev] [PATCH 3/4] egl: Refactor errors for bad EGLSync attributes

On Fri, Jul 08, 2016 at 03:44:20PM -0700, Chad Versace wrote: > Move the error handling into a little helper function. This will keep > the code clean when later adding error handling for attribute > EGL_SYNC_NATIVE_FENCE_FD_ANDROID. > > And fix the log message to work when EGLAttrib is 32-bit or

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps

K_MONOTONIC, 0, , NULL); \ This is an actual function, not a macro; the backslashes are unnecessary :) This is a good change though, so with those removed: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> One (kind of unrelated) thing, though: Does a negative sleep really make sense?

[Mesa-dev] [RFC mesa] Introduce .editorconfig

A few weeks ago, Jose Fonseca suggested [0] we use .editorconfig files to try and enforce the formatting of the code, to which Michel Dänzer suggested [1] we start by importing the existing .dir-locals.el settings. This is a first draft, with settings from the mentioned emacs files, augmented

[Mesa-dev] [PATCH mesa] configure.ac: raise Mako required version to 0.8.0

we can. [0] https://lists.freedesktop.org/archives/mesa-dev/2016-July/122772.html [1] https://lists.freedesktop.org/archives/mesa-dev/2016-July/122775.html [2] https://lists.freedesktop.org/archives/mesa-dev/2016-July/123278.html Signed-off-by: Eric Engestrom <eric.engest...@imgtec.

Re: [Mesa-dev] [PATCH] configure.ac: Use ${datarootdir} for --with-vulkan-icddir help string too

On Tue, Jul 19, 2016 at 12:45:54PM +0200, Andreas Boll wrote: > The help string wasn't updated in cbc37f7. > > Fixes: cbc37f7 ("anv: install the intel_icd.json to ${datarootdir} by > default") > > Signed-off-by: Andreas Boll <andreas.boll@gmail.com> Good

Re: [Mesa-dev] Required Mako version? (WAS: mesa from git fails to compile)

On Mon, Jul 18, 2016 at 08:11:56PM -0700, Kenneth Graunke wrote: > On Monday, July 18, 2016 10:58:25 PM PDT Pali Rohár wrote: > > Any conclusion or fix for this issue? > > Dylan suggested you use pip --user to install a newer version of Mako. > Is that a workable solution to your problem? > >

Re: [Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

make sure > the structure is kept allocated as long as it is required. > > Signed-off-by: Nicolas Boichat <drink...@chromium.org> Looks good to me :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > > Replaces https://patchwork.freedesktop.org/patch/98

Re: [Mesa-dev] [PATCH] gallium/os: use CLOCK_MONOTONIC for sleeps (v2)

On Tue, Jul 19, 2016 at 06:29:20PM +0200, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > v2: handle EINTR, remove backslashes I was a bit surprised by the way you use clock_nanosleep(), but I checked the man and you're right :) Reviewed-by: Eric Engestr

Re: [Mesa-dev] [PATCH] build: Remove unused AX_CHECK_COMPILE_FLAG macro

On Wed, Jul 20, 2016 at 11:19:47AM +0200, Andreas Boll wrote: > Unused since 1a6ae840413d7fb6d2e83f6a83081d5246c7ac9e Double-checked, and you're right, no reason to leave it in :) Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > Signed-off-by: Andreas Boll <andreas.

Re: [Mesa-dev] [PATCH 2/4] egl: Fix type errors in _eglParseSyncAttribList64()

tch #3: "fix the log message to work when EGLAttrib is 32-bit or 64-bit" (The include would need to be moved to the other patch as well.) With that and the other issue in patch #3 fixed, the series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > + retu

[Mesa-dev] [PATCH mesa] egl/display: remove unnecessary code and make it easier to read

Remove the two first level `if` as they will always be true, and flatten the two remaining `if`. No functional change. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/egl/main/egldisplay.c | 29 ++--- 1 file changed, 14 insertions(+), 15 del

Re: [Mesa-dev] [PATCH] meta/texsubimage: tex_image is always non-null, avoid confusing code

his point it can't be null anymore. Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > > Happened upon this when trying to figure out the "incomplete fbo" issue. > > src/mesa/drivers/common/meta_tex_subimage.c | 2 +- > 1 file changed, 1 insertion(

[Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I know nothing about blorp, but GCC6 noticed the weird indentation, and my best guess looking at the code is that there are missing braces. CC gen7_blorp.lo gen7_blorp.c: In function ‘gen7_blorp_exec’: gen7_blorp.c

Re: [Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

On Wed, Jul 06, 2016 at 05:26:40PM +0100, Eric Engestrom wrote: > diff --git a/src/intel/vulkan/Makefile.sources > b/src/intel/vulkan/Makefile.sources > index aa1459a..7303995 100644 > --- a/src/intel/vulkan/Makefile.sources > +++ b/src/intel/vulkan/Makefile.sources &

[Mesa-dev] [PATCH mesa] i965/blorp: add missing braces

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I know nothing about blorp, but GCC6 noticed the weird indentation, and my best guess looking at the code is that there are missing braces. CC gen7_blorp.lo gen7_blorp.c: In function ‘gen7_blorp_exec’: gen7_blorp.c

[Mesa-dev] [PATCH mesa] i965/docs: update Intel Linux Graphics URLs

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- docs/developers.html | 2 +- docs/faq.html| 2 +- src/mesa/drivers/dri/i965/brw_defines.h | 2 +- src/mesa/drivers/dri/i965/brw_sf_state.c | 2 +- 4 files changed, 4 insertions

[Mesa-dev] [PATCH mesa] i965/blorp: fix indentation level

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/mesa/drivers/dri/i965/gen7_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_blorp.c b/src/mesa/drivers/dri/i965/gen7_blorp.c index 7201549..0afd76b 100644 --- a/src/mesa/d

Re: [Mesa-dev] [PATCH mesa] i965/blorp: fix indentation level

On Thu, Jul 07, 2016 at 08:36:35AM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 06, 2016 at 10:02:42PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > src/mesa/drivers/dri/i965/gen7_blorp.c | 2 +- > > 1 file ch

[Mesa-dev] [PATCH Mesa] egl/wayland: check drmGetMagic for failure

Coverity (CovID 1255672) noticed that all the other calls to drmGetMagic were checked for failure, but not this one. Fix this, and return before an invalid magic token is used to authenticate the device. Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- src/egl/driver

Re: [Mesa-dev] [PATCH] i965: fix ignored qualifiers warning

ne int > pipeline_target_to_index(int target) > { > if (target == GL_GEOMETRY_SHADER_INVOCATIONS) > -- > 1.7.9.5 Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/4] st/mesa: refactor duplicated etc fallback checks

On Fri, Jul 08, 2016 at 02:48:04AM -0400, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_cb_texture.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/state_tracker/st_cb_texture.c >

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead of 'int' for boolean variables

On Wed, Aug 03, 2016 at 01:22:35PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- It is customary to put [PATCH vN] in the subject to keep track of which version is current, as well as to add a description of what changed since the

Re: [Mesa-dev] [PATCH mesa] glx/dri3: remove never-used field

On Wed, Aug 03, 2016 at 01:25:08PM +0200, ⚛ wrote: > Your patch created rev4 at https://patchwork.freedesktop.org/series/10429/ > > I just created rev5 which no longer includes field hasPresent. Oh, OK, I read this mail after sending my previous mail (a couple minutes ago), but my point there

[Mesa-dev] [PATCH mesa] mapi: fix typo in macro name

Fixes: 5ec140c17b54c2592009 ("mapi: Massage code to allow clang to compile.") Reported-by: Alexandre Demers <alexandre.f.dem...@gmail.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mapi/entry_x86-64_tls.h | 2 +- src/mapi/entry_x86_tls.h| 2 +- sr

[Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since `x` is already a boolean expression. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- v2: replace `x == 0` with `!x` for consistency. src/mesa/drivers/dri/i915/intel_screen.c | 4 +

[Mesa-dev] [PATCH v2 1/2] i965: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since both `x` are already boolean expressions. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/mesa/drivers/dri/i965/intel_screen.c | 8 ++-- 1 file changed, 2 insertions(+), 6 del

  1   2   3   4   5   6   7   8   9   10   >