[Mesa-dev] [PATCH] targets/xvmc-nouveau: add in missing nv30 lib

2013-06-23 Thread Ilia Mirkin
Currently libXvMCnouveau.so is missing nv30_screen_create. Add it in so that it may be dlopen'd. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- MPEG1/2 bitstream decoding is nowhere near working in vl. XvMC appears to work flawlessly though, so let's make sure it's usable. src/gallium

[Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-23 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- These changes make MPEG2 I-frames generate the correct macroblock data (as compared to mplayer via xvmc). Other MPEG2 frames are still misparsed, and MPEG1 I-frames have some errors (but largely match up). src/gallium/auxiliary/vl

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-23 Thread Ilia Mirkin
On Sun, Jun 23, 2013 at 5:47 PM, Andy Furniss adf.li...@gmail.com wrote: Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- These changes make MPEG2 I-frames generate the correct macroblock data (as compared to mplayer via xvmc). Other MPEG2 frames are still misparsed

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-24 Thread Ilia Mirkin
On Mon, Jun 24, 2013 at 4:48 AM, Christian König deathsim...@vodafone.de wrote: Am 23.06.2013 18:59, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- These changes make MPEG2 I-frames generate the correct macroblock data (as compared to mplayer via xvmc). Other MPEG2

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-25 Thread Ilia Mirkin
On Mon, Jun 24, 2013 at 2:13 PM, Christian König deathsim...@vodafone.de wrote: Am 24.06.2013 18:39, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 4:48 AM, Christian König deathsim...@vodafone.de wrote: Am 23.06.2013 18:59, schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin imir

Re: [Mesa-dev] [PATCH] vl/mpeg12: implement inverse scan/quantization steps

2013-06-26 Thread Ilia Mirkin
On Wed, Jun 26, 2013 at 4:33 AM, Christian König deathsim...@vodafone.de wrote: Am 26.06.2013 05:29, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 2:13 PM, Christian König deathsim...@vodafone.de wrote: Am 24.06.2013 18:39, schrieb Ilia Mirkin: On Mon, Jun 24, 2013 at 4:48 AM, Christian

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: H.264/MPEG2 decoding support via VP2, available on NV84-NV96, NVA0

2013-06-29 Thread Ilia Mirkin
On Sat, Jun 29, 2013 at 2:07 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Ilia, On 27/06/13 12:26, Ilia Mirkin wrote: Adds H.264 and MPEG2 codec support via VP2, using firmware from the blob. Acceleration is supported at the bitstream level for H.264 and IDCT level for MPEG2. Known

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: H.264/MPEG2 decoding support via VP2, available on NV84-NV96, NVA0

2013-06-29 Thread Ilia Mirkin
On Sat, Jun 29, 2013 at 8:33 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 29/06/13 21:21, Ilia Mirkin wrote: On Sat, Jun 29, 2013 at 2:07 PM, Emil Velikov emil.l.veli...@gmail.com wrote: I believe the hardware is capable of accelerating IDCT for VC1. Do you have any plans

[Mesa-dev] [PATCH 1/2] nv30: hook up PMPEG support via nouveau_video, enables XvMC to work

2013-07-29 Thread Ilia Mirkin
It seems as though at least the NV44 expects the same format as VP2 does. But NV96 expects the format as currently done. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_video.c | 43 + src/gallium/drivers/nouveau/nouveau_video.h

[Mesa-dev] [PATCH 2/2] nv50: allow forcing PMPEG use, for ease of testing

2013-07-29 Thread Ilia Mirkin
This also allows people who don't want to install the binary blobs required for VP2 to still get MPEG decoding. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nv50/nv50_context.c | 2 +- src/gallium/drivers/nv50/nv50_screen.c | 2 +- 2 files changed, 2 insertions(+), 2

[Mesa-dev] [PATCHv2 2/2] nv50: allow forcing PMPEG use, for ease of testing

2013-07-29 Thread Ilia Mirkin
This also allows people who don't want to install the binary blobs required for VP2 to still get MPEG decoding. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- v1 - v2: - switched to using debug_get_bool_option and NOUVEAU prefix, for which there is some precedent src/gallium

[Mesa-dev] [PATCH] nv50: fix some h264 interlaced decoding on vp2

2013-08-01 Thread Ilia Mirkin
Some videos specify mb_adaptive_frame_field_flag instead of field_pic_flag. This implies that the pic height needs to be halved, and this field needs to be passed to the VP engine. Cc: 9.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This makes at least

[Mesa-dev] [PATCH 1/4] nouveau: fix number of surfaces in video buffer, use defines

2013-08-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- The pipe_surface miscount caused issues for my (failed) attempt at getting vdpau to work with pmpeg. src/gallium/drivers/nouveau/nouveau_video.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 3/4] nv30: hook up PMPEG support via nouveau_video, enables XvMC to work

2013-08-10 Thread Ilia Mirkin
Force the format to be the reasonable format that doesn't require an inverse z-scan. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Tested this on both nv44 and nv96, and it works, all at the same time. Without the 0x72 command, they default to different scan orders. Putting the 0x72

[Mesa-dev] [PATCH 2/4] nouveau: set buffer format of video buffer

2013-08-10 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- I don't think anything looks at this right now, but seems good to store. (Also ran into it with my vdpau attempt.) src/gallium/drivers/nouveau/nouveau_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 4/4] nv50: allow forcing PMPEG use, for ease of testing

2013-08-10 Thread Ilia Mirkin
This also allows people who don't want to install the binary blobs required for VP2 to still get MPEG decoding. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nv50/nv50_context.c | 3 ++- src/gallium/drivers/nv50/nv50_screen.c | 3 ++- 2 files changed, 4 insertions

[Mesa-dev] [PATCH 00/10] Add support for MPEG2 and VC-1 on VP3/VP4 for NV98-NVAF

2013-08-11 Thread Ilia Mirkin
although I didn't think that would be appropriate for sending to the ML. Ilia Mirkin (10): nvc0: refactor video buffer management logic into nouveau_vp3 nvc0: standardize on using #if for NVC0_DEBUG_FENCE nvc0: move nvc0_decoder into nouveau, rename to nouveau_vp3_decoder nvc0: move bsp param

[Mesa-dev] [PATCH 01/10] nvc0: refactor video buffer management logic into nouveau_vp3

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/Makefile.sources| 3 +- src/gallium/drivers/nouveau/nouveau_vp3_video.c | 165 src/gallium/drivers/nouveau/nouveau_vp3_video.h | 38 ++ src/gallium/drivers/nvc0/nvc0_video.c

[Mesa-dev] [PATCH 02/10] nvc0: standardize on using #if for NVC0_DEBUG_FENCE

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nvc0/nvc0_video.c | 2 +- src/gallium/drivers/nvc0/nvc0_video.h | 6 +++--- src/gallium/drivers/nvc0/nvc0_video_bsp.c | 4 ++-- src/gallium/drivers/nvc0/nvc0_video_ppp.c | 2 +- src/gallium/drivers/nvc0

[Mesa-dev] [PATCH 03/10] nvc0: move nvc0_decoder into nouveau, rename to nouveau_vp3_decoder

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video.h | 160 +++ src/gallium/drivers/nvc0/nvc0_video.c | 22 ++-- src/gallium/drivers/nvc0/nvc0_video.h | 165 +--- src/gallium/drivers/nvc0

[Mesa-dev] [PATCH 04/10] nvc0: move bsp param-filling logic into nouveau

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/Makefile.sources | 3 +- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 10 +- .../drivers/nouveau/nouveau_vp3_video_bsp.c| 310 + src/gallium/drivers/nvc0/nvc0_video_bsp.c

[Mesa-dev] [PATCH 05/10] nvc0: move vp param filling logic into nouveau

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/Makefile.sources | 3 +- src/gallium/drivers/nouveau/nouveau_vp3_video.h| 6 + src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c | 485 + src/gallium/drivers/nvc0/nvc0_video.h

[Mesa-dev] [PATCH 06/10] nvc0: move some of the simpler decoder functions into nouveau

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video.c | 63 src/gallium/drivers/nouveau/nouveau_vp3_video.h | 3 ++ src/gallium/drivers/nvc0/nvc0_video.c | 65 ++--- 3 files changed, 69

[Mesa-dev] [PATCH 07/10] nvc0: move firmware loading functions to nouveau

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video.c | 101 src/gallium/drivers/nouveau/nouveau_vp3_video.h | 5 ++ src/gallium/drivers/nvc0/nvc0_video.c | 92 + 3 files changed, 108

[Mesa-dev] [PATCH 08/10] nvc0: move video param and format support functions to nouveau

2013-08-11 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video.c | 37 + src/gallium/drivers/nouveau/nouveau_vp3_video.h | 10 +++ src/gallium/drivers/nvc0/nvc0_context.h | 5 src/gallium/drivers/nvc0/nvc0_screen.c

[Mesa-dev] [PATCH 09/10] nv50: separate video logic from noalloc

2013-08-11 Thread Ilia Mirkin
The upcoming vp3 logic will want the video layout, but allocated by the miptree. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nv50/nv50_miptree.c | 6 -- src/gallium/drivers/nv50/nv50_resource.h | 1 + src/gallium/drivers/nv50/nv84_video.c| 2 +- 3 files

[Mesa-dev] [PATCH 10/10] nv50: add vp3/vp4 support for mpeg2/vc1

2013-08-11 Thread Ilia Mirkin
h264/mpeg4 remain disabled for pre-nvc0, there's some minor bug/difference which causes the decoding to hang after some frames. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video.c | 39 ++- src/gallium/drivers/nv50/Makefile.sources | 6

Re: [Mesa-dev] nouveau: xvmc on nv43

2013-08-16 Thread Ilia Mirkin
On Fri, Aug 16, 2013 at 5:40 AM, Pali Rohár pali.ro...@gmail.com wrote: Hello Ilia, I was your last commit which fixing xvmc support for nv30 hw in mesa git tree. Maybe you can help me. I have graphics card nvidia geforce 6600 gt (nv43 chip) According to wiki page

Re: [Mesa-dev] nouveau: xvmc on nv43

2013-08-17 Thread Ilia Mirkin
On Sat, Aug 17, 2013 at 11:56 AM, Pali Rohár pali.ro...@gmail.com wrote: Now I compiled mesa from git master again and installed kernel 3.11-rc5. After that mpeg2play_accel not crashing anymore. It looks like I forgot to install mesa with your xvmc patches (only compiled), so I had in system

[Mesa-dev] [PATCH] nv30: add forgotten PIPE_CAP_CUBE_MAP_ARRAY cap to list

2013-08-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Silences a warning about unrecognized param when in debug mode. src/gallium/drivers/nv30/nv30_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nv30/nv30_screen.c b/src/gallium/drivers/nv30/nv30_screen.c index

[Mesa-dev] [PATCH] nouveau/video: avoid overwriting base codec init with template

2013-08-23 Thread Ilia Mirkin
Commit 53e20b8b introduced the use of a template to initialize some common fields. Move this copying of fields to before the common vp3 fields are initialized. Reported-by: Martin Peres martin.pe...@labri.fr Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nv50

Re: [Mesa-dev] [PATCH] nouveau/video: avoid overwriting base codec init with template

2013-08-24 Thread Ilia Mirkin
On Sat, Aug 24, 2013 at 8:36 AM, Martin Peres martin.pe...@labri.fr wrote: On 24/08/2013 11:38, Christian König wrote: Am 24.08.2013 06:50, schrieb Ilia Mirkin: Commit 53e20b8b introduced the use of a template to initialize some common fields. Move this copying of fields to before the common

[Mesa-dev] [PATCH] nv30: find first unused texcoord rather than bailing if first is used

2013-09-01 Thread Ilia Mirkin
This fixes shaders produced by supertuxkart. Cc: 9.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nv30/nvfx_fragprog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/nv30/nvfx_fragprog.c b

[Mesa-dev] [PATCH] nv30: fix inconsistent setting of push-user_priv

2013-09-04 Thread Ilia Mirkin
It's set to nv30-bufctx everywhere else. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nv30/nv30_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nv30/nv30_context.c b/src

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MIXED_FRAMEBUFFER_SIZES

2013-09-07 Thread Ilia Mirkin
This CAP will determine whether ARB_framebuffer_object can be enabled. The nv30 driver does not allow mixing swizzled and linear zsbuf/cbufs. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Christoph, this is what I understood you suggested I do. Hopefully I got it right. I've split this up

[Mesa-dev] [PATCH 2/2] mesa/st: disable ARB_framebuffer_object when no driver support.

2013-09-07 Thread Ilia Mirkin
When PIPE_CAP_MIXED_FRAMEBUFFER_SIZES is not provided, parts of ARB_framebuffer_object can't be supported, such as on NV30. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/state_tracker/st_extensions.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] RFC: Fixing FB issues in nv30 gallium

2013-09-12 Thread Ilia Mirkin
Hello, I sent a patch earlier to add a new PIPE_CAP about disallowing mixed fb cbuf/zsbuf sizes, which would be used to disable ARB_fbo. I think people were generally in favor, but I didn't see any actual Reviewed-By's, I'll resend it with updated nouveau directories (I guess everything got moved

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd, st/vdpau: fix video format reporting

2013-10-01 Thread Ilia Mirkin
On Tue, Oct 1, 2013 at 3:06 PM, Grigori Goronzy g...@chown.ath.cx wrote: UVD can only support NV12 in the case of hardware decoding, but we can still use all other formats for software decoding. Use the UNKNOWN entrypoint to signal that we're not interesting in hardware decoding. FYI, in

[Mesa-dev] [PATCH] nouveau_vieux: add AllocTextureImageBuffer implementation

2013-10-04 Thread Ilia Mirkin
This fixes issues where get_rt_format would see a 0 format because the nouveau_surface had not been properly initialized. Fixes crash on supertuxkart startup (which still fails due to out-of-vram issues). Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/drivers/dri/nouveau

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MIXED_FRAMEBUFFER_SIZES

2013-10-04 Thread Ilia Mirkin
This CAP will determine whether ARB_framebuffer_object can be enabled. The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf textures. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/freedreno

[Mesa-dev] [PATCH 2/2] mesa/st: disable ARB_framebuffer_object when no driver support.

2013-10-04 Thread Ilia Mirkin
When PIPE_CAP_MIXED_FRAMEBUFFER_SIZES is not provided, parts of ARB_framebuffer_object can't be supported, such as on NV30. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/mesa/state_tracker/st_extensions.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 0/8] gallium: create a generic way to validate fb params

2013-10-04 Thread Ilia Mirkin
). This series is a follow-up to the discussion started in http://lists.freedesktop.org/archives/mesa-dev/2013-September/044658.html Ilia Mirkin (8): mesa/st: create interface to verify fb format, reject bad fbs gallium: add helper to use as a replacement for the MIXED_COLOR cap i915: hook up

[Mesa-dev] [PATCH 1/8] mesa/st: create interface to verify fb format, reject bad fbs

2013-10-04 Thread Ilia Mirkin
Extract format parameters in st_validate_framebuffer and call the new optional pipe-is_fb_format_supported function to check that parameters are supported by the driver. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- I'm a bit weirded out that no attempt is made to check if the att-Type

[Mesa-dev] [PATCH 2/8] gallium: add helper to use as a replacement for the MIXED_COLOR cap

2013-10-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/util/u_format.c | 20 src/gallium/auxiliary/util/u_format.h | 11 +++ 2 files changed, 31 insertions(+) diff --git a/src/gallium/auxiliary/util/u_format.c b/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 3/8] i915: hook up is_fb_format_supported

2013-10-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/i915/i915_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index 77607d0..78800ac 100644 --- a/src/gallium/drivers/i915

[Mesa-dev] [PATCH 4/8] r300: hook up is_fb_format_supported

2013-10-04 Thread Ilia Mirkin
Only do this in the !r500 case, same as how PIPE_CAP_MIXED_COLORBUFFER_FORMATS is set. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/r300/r300_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers

[Mesa-dev] [PATCH 5/8] softpipe: hook up is_fb_format_supported

2013-10-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/softpipe/sp_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 47ef20e..5dca415 100644 --- a/src/gallium/drivers/softpipe

[Mesa-dev] [PATCH 6/8] nv30: hook up is_fb_format_supported

2013-10-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c index 807100e..c546c43 100644 --- a/src/gallium

[Mesa-dev] [PATCH 7/8] gallium: remove PIPE_CAP_MIXED_COLORBUFFER_FORMATS

2013-10-04 Thread Ilia Mirkin
This is now completely handled by the new is_fb_format_supported callback. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/docs/source/screen.rst | 2 -- src/gallium/drivers/freedreno/freedreno_screen.c | 1 - src/gallium/drivers/i915/i915_screen.c | 1

[Mesa-dev] [PATCH 8/8] nv30: make sure that cbufs and zsbuf have the same depth

2013-10-04 Thread Ilia Mirkin
This should finally fix RT_FORMAT errors due to weird fb configurations. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv30

Re: [Mesa-dev] [PATCH 0/8] gallium: create a generic way to validate fb params

2013-10-04 Thread Ilia Mirkin
with a 16-bit zsbuf. They've fixed the crash in SVN (before I even got to report it!), but not yet in the latest released version. -ilia Marek On Fri, Oct 4, 2013 at 10:34 AM, Ilia Mirkin imir...@alum.mit.edu wrote: NV30 is blessed with all manners of hardware restrictions. One of them

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MIXED_FRAMEBUFFER_SIZES

2013-10-12 Thread Ilia Mirkin
ping On Fri, Oct 4, 2013 at 4:32 AM, Ilia Mirkin imir...@alum.mit.edu wrote: This CAP will determine whether ARB_framebuffer_object can be enabled. The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf textures. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src

Re: [Mesa-dev] [PATCH 3/7] vl/h264: split fields into SPS/PPS

2013-10-24 Thread Ilia Mirkin
On Thu, Oct 24, 2013 at 9:14 AM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Add alot of missing fields as well. Signed-off-by: Christian König christian.koe...@amd.com --- .../drivers/nouveau/nouveau_vp3_video_bsp.c| 30

Re: [Mesa-dev] [PATCH 3/7] vl/h264: split fields into SPS/PPS

2013-10-24 Thread Ilia Mirkin
On Thu, Oct 24, 2013 at 1:55 PM, Christian König deathsim...@vodafone.de wrote: Am 24.10.2013 19:18, schrieb Ilia Mirkin: On Thu, Oct 24, 2013 at 9:14 AM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Add alot of missing fields as well

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MIXED_FRAMEBUFFER_SIZES

2013-10-25 Thread Ilia Mirkin
, Oct 13, 2013 at 3:43 AM, Ilia Mirkin imir...@alum.mit.edu wrote: ping On Fri, Oct 4, 2013 at 4:32 AM, Ilia Mirkin imir...@alum.mit.edu wrote: This CAP will determine whether ARB_framebuffer_object can be enabled. The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf textures

[Mesa-dev] [PATCH 1/2] nouveau/video: don't try on nv3x

2013-11-09 Thread Ilia Mirkin
It doesn't work, I don't know why, but no point in hanging people's displays until it gets figured out. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.0 mesa-sta...@lists.freedesktop.org --- I tried a bunch of stuff, but in the end, I was unsuccessful. On the bright side, nv3x cards have

[Mesa-dev] [PATCH 2/2] nouveau/video: mark bitstream-level acceleration as unsupported

2013-11-09 Thread Ilia Mirkin
Adding a vl_mpeg-based helper didn't seem to work, as it produced data that the card couldn't handle. (And I didn't investigate further.) This makes the decoding functionality only accessible via XvMC and avoids crashes when attempting to use VDPAU. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Mesa-dev] [PATCH 2/2] targets/xvmc: export only necessary symbols

2013-11-16 Thread Ilia Mirkin
On Sat, Nov 16, 2013 at 4:39 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Export only XvMC* symbols for the xvmc targets. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Tested-by: Ilia Mirkin imir...@alum.mit.edu Works fine on my NV42, the vl_screen* and nouveau_drm_screen_create

[Mesa-dev] memory stomping/other error in a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function)

2013-11-28 Thread Ilia Mirkin
Hi Brian, I've just completed a bisect which pointed out a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function) as the bad commit. Starting with that commit, I see things like *** glibc detected *** glretrace: corrupted double-linked list: 0x016632f0 *** but it

Re: [Mesa-dev] memory stomping/other error in a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function)

2013-11-28 Thread Ilia Mirkin
On Thu, Nov 28, 2013 at 4:38 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Hi Brian, I've just completed a bisect which pointed out a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function) as the bad commit. Starting with that commit, I see things like *** glibc

[Mesa-dev] memory stomping in 95bd8a332d1 (dri: Move i965-specific context flag logic to dri common.)

2013-11-28 Thread Ilia Mirkin
, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Nov 28, 2013 at 4:38 AM, Ilia Mirkin imir...@alum.mit.edu wrote: My reproducer is running glretrace on the portal.trace file that you can obtain from https://bugs.freedesktop.org/show_bug.cgi?id=64323#c1. I was not able to repro using random other

Re: [Mesa-dev] memory stomping/other error in a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function)

2013-11-28 Thread Ilia Mirkin
On Thu, Nov 28, 2013 at 4:55 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Nov 28, 2013 at 4:38 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Hi Brian, I've just completed a bisect which pointed out a3ed98f7aa (gallium: new, unified pipe_context::set_sampler_views() function) as the bad

[Mesa-dev] [PATCH 1/2] nv50: fix a small leak on context destroy

2013-11-29 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- Found with valgrind. src/gallium/drivers/nouveau/nv50/nv50_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/src/gallium/drivers

[Mesa-dev] [PATCH 2/2] mesa: don't leak performance monitors on context destroy

2013-11-29 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.0 mesa-sta...@lists.freedesktop.org --- Found with valgrind. Don't have the hardware to test a real implementation, but with nv50 it seemed to work in that valgrind was no longer marking the hash table as leaked. src/mesa/main/context.c

[Mesa-dev] [PATCH 1/2 v2] nv50: fix a small leak on context destroy

2013-11-29 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- v2: use FREE instead of free. src/gallium/drivers/nouveau/nv50/nv50_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/src/gallium

[Mesa-dev] [PATCH 2/2] nv50: wait on the buf's fence before sticking it into pushbuf

2013-11-29 Thread Ilia Mirkin
This resolves some rendering issues in source games. See https://bugs.freedesktop.org/show_bug.cgi?id=64323 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- Doing a nouveau_bo_wait works as well, but I got a slightly higher framerate from

[Mesa-dev] [PATCH 1/2] nouveau: avoid leaking fences while waiting

2013-11-29 Thread Ilia Mirkin
This fixes a memory leak in some situations. Also avoids emitting an extra fence if the kick handler does the call to nouveau_fence_next itself. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- TBH I'm pretty confused by the whole fence

[Mesa-dev] [PATCH] nv50: report 15 max inputs for fragment programs

2013-12-01 Thread Ilia Mirkin
://bugs.freedesktop.org/show_bug.cgi?id=69155 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src

[Mesa-dev] [PATCH] nv50: Fix GPU_READING/WRITING bit removal

2013-12-01 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- These look like pretty obvious typos. The x |= read; x = ~write; (or vice-versa) pattern occurs in nvc0, so I'm guessing that this is what was intended here as well. Not sure if this fixes anything in particular though. src/gallium/drivers

[Mesa-dev] [PATCH] nouveau: Add lots of comments to the buffer transfer logic

2013-12-01 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This is my shot at understanding this whole transfer business. The upshot is that after reading through it and understanding it, the transfer logic does appear correct if potentially less-than-perfectly-efficient (e.g. one could keep track

Re: [Mesa-dev] [PATCH] nouveau: Add lots of comments to the buffer transfer logic

2013-12-02 Thread Ilia Mirkin
On Mon, Dec 2, 2013 at 9:31 PM, Chris Forbes chr...@ijw.co.nz wrote: + * + * Also marks vbo/cb dirty if the buffer's binding Looks like this stops mid-sentence. Hah, yeah. I kinda trailed off there, didn't I. Not sure how to finish that sentence though -- it's if pipe_resource-bind

[Mesa-dev] [PATCH] nvc0: make sure nvd7 gets NVC8_3D_CLASS

2013-12-05 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- It has the NVC8 class, at least according to the kernel driver's setup code. src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b

Re: [Mesa-dev] Unreviewed patches marked for stable

2013-12-06 Thread Ilia Mirkin
On Fri, Dec 6, 2013 at 11:19 AM, Ian Romanick i...@freedesktop.org wrote: There are a number of patches marked for stable that don't appear to have any reviews. Most of these patches cover areas that I'm not qualified to review, so I don't really feel comfortable cherry-picking them over.

[Mesa-dev] [PATCH] nv50: enable H.264 for NV98+ (VP3, VP4.0)

2013-12-06 Thread Ilia Mirkin
Create the ref_bo without any storage type flags set for now. This can probably be split up somehow later on, but this seems to work. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.0 mesa-sta...@lists.freedesktop.org --- Would be great if someone could see if this also makes MPEG4 work

Re: [Mesa-dev] [Nouveau] [PATCH] nv50: enable MPEG-4 for NVA3+ (VP4.0)

2013-12-07 Thread Ilia Mirkin
this comment to reflect reality. Or just remove it. With that change, Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Or I can fold this into my h264 change if you don't want to send a v2, up to you. return profile = PIPE_VIDEO_PROFILE_MPEG1 ( -- 1.8.4.2

Re: [Mesa-dev] memory stomping in 95bd8a332d1 (dri: Move i965-specific context flag logic to dri common.)

2013-12-07 Thread Ilia Mirkin
ping? I'm pretty sure all gallium drivers are getting random bits corrupted in 10.0+... at least if driCreateContextAttribs is getting called. Kristian, you had a patch on IRC, but I didn't see it get posted... -ilia On Thu, Nov 28, 2013 at 11:27 PM, Ilia Mirkin imir...@alum.mit.edu wrote

Re: [Mesa-dev] [PATCH] nv50: enable H.264 for NV98+ (VP3, VP4.0)

2013-12-07 Thread Ilia Mirkin
On Fri, Dec 6, 2013 at 11:43 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Create the ref_bo without any storage type flags set for now. This can probably be split up somehow later on, but this seems to work. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.0 mesa-sta

[Mesa-dev] [PATCH 2/3] nouveau/video: update h264 picparm field names based on usage

2013-12-07 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c | 28 ++ 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video_vp.c b/src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 3/3] nouveau/video: update a few more h264 picparm field names

2013-12-07 Thread Ilia Mirkin
Based on comments by Benjamin Morris bmor...@nvidia.com in http://lists.freedesktop.org/archives/nouveau/2013-December/015328.html This adds setting of is_long_term, and updates a few field names we were unclear about. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers

[Mesa-dev] [PATCH 1/3] nv50: enable h264 and mpeg4 for nv98+ (vp3, vp4.0)

2013-12-07 Thread Ilia Mirkin
Create the ref_bo without any storage type flags set for now. The issue probably arises from our use of the additional buffer space at the end of the ref_bo. It should probably be split up in the future. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Tested-by: Martin Peres martin.pe...@labri.fr

Re: [Mesa-dev] [PATCH] dri_util: Don't assume __DRIcontext-driverPrivate is a gl_context

2013-12-07 Thread Ilia Mirkin
deletions(-) I'd suggest something like this... I haven't verified that it actually fixes the problem, I just wanted to illustrate what the fix would look like and ended up writing the full patch after all. Tested-by: Ilia Mirkin imir...@alum.mit.edu Verified that without this patch valgrind

[Mesa-dev] [PATCH] nv50: TXF already has integer arguments, don't try to convert from f32

2013-12-08 Thread Ilia Mirkin
Fixes the texelFetch piglit tests. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Verified a few things, but it's hard to check this fully. They array-texture piglit test fails if the conversion isn't done at all, and texelFetch starts passing if the conversion is removed. Dunno

Re: [Mesa-dev] [PATCH 7/7] nouveau: allow blend_minmax_factor

2014-01-02 Thread Ilia Mirkin
On Thu, Jan 2, 2014 at 8:18 PM, Maxence Le Doré maxence.led...@gmail.com wrote: Sound strange if nvidia would had chosen a different implementation of min/max blending (where even intel i830 allow factors with min/max blending). Indeed, the driver doesn't set src and dst factors to ONE when

Re: [Mesa-dev] [PATCH] configure: Disable xvmc by default

2014-01-05 Thread Ilia Mirkin
On Sun, Jan 5, 2014 at 9:49 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com The xvmc unit tests are failing on r300g and r600g. FWIW it works fine on nv40-nv96. (Haven't checked the actual unit-tests, but the functionality is fine.) --- configure.ac | 2

[Mesa-dev] commit 0a1479c829 breaks glsl-fs-lots-of-tex.shader_test on nv50/nvc0

2014-01-09 Thread Ilia Mirkin
Hi Marek, I won't pretend to understand what's going on, but I just bisected a failure on tests/shaders/glsl-fs-lots-of-tex.shader_test in piglit between 9.1 and HEAD, and it landed on your commit. It's approximately the simplest shader known to man (esp at HEAD when all the TEX instructions are

[Mesa-dev] [PATCH] nouveau: add framebuffer validation callback

2014-01-10 Thread Ilia Mirkin
Fixes assertions when trying to attach textures to fbs with formats not supported by the render engines. See https://bugs.freedesktop.org/show_bug.cgi?id=73459 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- In a perfect world I'd have separate callbacks for depth and color, but given

[Mesa-dev] [PATCH] mesa: fix GL_COLOR_SUM enum for drivers without ARB_vertex_program

2014-01-10 Thread Ilia Mirkin
since the intent was for it to always be enabled. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 9.2 10.0 mesa-sta...@lists.freedesktop.org --- Someone mentioned that nouveau (dri) was getting errors with glDisable(GL_COLOR_SUM), even though the driver should have had support for it. src/mesa

[Mesa-dev] [PATCH] nv50, nvc0: initialize ctx-sample_mask to ~0

2014-01-12 Thread Ilia Mirkin
of EXT_framebuffer_multisample piglit tests. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv50/nv50_state.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_state.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_state.c b/src/gallium/drivers

[Mesa-dev] [PATCH 01/19] nv50/ir: fix PFETCH and add RDSV to get VSTRIDE for GPs

2014-01-13 Thread Ilia Mirkin
From: Christoph Bumiller e0425...@student.tuwien.ac.at --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 1 + .../drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 62 -- .../drivers/nouveau/codegen/nv50_ir_print.cpp | 1 + 3 files changed, 59 insertions(+), 5

[Mesa-dev] [PATCH 09/19] nv50: properly set the PRIMITIVE_ID enable flag when it is a gp input.

2014-01-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_program.c b/src/gallium/drivers/nouveau/nv50/nv50_program.c index 78a12e3..f46f240 100644 --- a/src

[Mesa-dev] [RFC PATCH 18/19] nv50: report glsl 1.50 now that gp tests pass

2014-01-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- There are still some things that fail -- mostly gl_Layer stuff, and also using gl_PositionID without a gp. src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 14/19] nvc0: don't forget to also clear additional layers

2014-01-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 22 -- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_program.c

[Mesa-dev] [PATCH 08/19] nv50/ir: add support for gl_PrimitiveIDIn

2014-01-13 Thread Ilia Mirkin
for accessing e.g. a[$r1], however that's not supported for now. (Could be added by checking the register file of the indirect parameter.) Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 6 +++--- src/gallium/drivers/nouveau/codegen

[Mesa-dev] [PATCH 03/19] nv50: add support for geometry shaders

2014-01-13 Thread Ilia Mirkin
-by: Ilia Mirkin imir...@alum.mit.edu --- .../drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 25 -- src/gallium/drivers/nouveau/nv50/nv50_program.c| 16 ++ .../drivers/nouveau/nv50/nv50_shader_state.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_tex.c

[Mesa-dev] [PATCH 02/19] nv50/ir: delay calculation of indirect addresses

2014-01-13 Thread Ilia Mirkin
analysis] Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 38 ++-- .../nouveau/codegen/nv50_ir_lowering_nv50.cpp | 104 - .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 7 ++ 3 files changed, 136

[Mesa-dev] [RFC PATCH 19/19] nv50: enable seamless cube maps on all hw for OpenGL 3.2

2014-01-13 Thread Ilia Mirkin
Some of the hardware support is missing. The NVIDIA-provided driver, which claims 3.3 support fails a slew of the relevant tests as well. This allows us to expose geometry shaders without doing the additional work involved in supporting ARB_geometry_shader4. Signed-off-by: Ilia Mirkin imir

[Mesa-dev] [PATCH 00/19] nv50: add sampler2DMS/GP support to get OpenGL 3.2

2014-01-13 Thread Ilia Mirkin
: fix PFETCH and add RDSV to get VSTRIDE for GPs Ilia Mirkin (16): nv50: allow vert_count to be 255 nv50/ir: disallow predicates on emit/restart ops nv50/ir: disallow shader input propagation for gp nv50/ir: comment out code to allow input/immed loads nv50/ir: add support

[Mesa-dev] [PATCH 17/19] nv50: add support for textureFetch'ing MS textures, ARB_texture_multisample

2014-01-13 Thread Ilia Mirkin
piglits pass, so turn on PIPE_CAP_TEXTURE_MULTISAMPLE. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 8 +++ .../drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 1 + .../nouveau/codegen/nv50_ir_lowering_nv50.cpp | 60

[Mesa-dev] [PATCH 16/19] nv50: copy nvc0's get_sample_position implementation

2014-01-13 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 46 + 1 file changed, 46 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c b/src/gallium/drivers/nouveau/nv50/nv50_context.c index 11afc48

[Mesa-dev] [PATCH 07/19] nv50/ir: comment out code to allow input/immed loads

2014-01-13 Thread Ilia Mirkin
This code was missing a break which made it ineffective. But since shader input loads have been disallowed, define the code out. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >