[Mesa-dev] Mesa build fails with xlib/egl

/pace-xorg/mesa-7.8.2/src » make: *** [default] Erreur 1 Maybe all of this is the result of a misconfiguration on my side, so any help on this problem is welcome. Regards, -- Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] Black window on Mesa 7.10

10753 frames in 5.0 seconds = 2150.418 FPS 10654 frames in 5.0 seconds = 2130.680 FPS 10858 frames in 5.0 seconds = 2171.426 FPS If I switch to the software x11 rendering, there is no display problem. Any idea how to find the problem ? Regards, -- Lionel Landwerlin

Re: [Mesa-dev] Black window on Mesa 7.10

On Tue, 2011-02-08 at 16:16 +, Lionel Landwerlin wrote: Hi all, Ever since I can't see anything on the screen, even if the rendering seems to be done. For instance glxgears as well as any other opengl app displays just a black window, but still manages to compute framerate : user

[Mesa-dev] Trivial fix for ChromeOS unit test

Hey there, While enabling LibVA on the Ozone backend of ChromeOS (EGL/GLES2 without X), I stumbled upon a crash. This patch is a fix for that problem. It's pretty much a copy/paste of a snippet already in EGL/wayland file. Cheers, - Lionel ___

[Mesa-dev] [PATCH] egl/drm: do not crash when swapping buffers without any rendering

Signed-off-by: Lionel Landwerlin lionel.g.landwer...@intel.com --- src/egl/drivers/dri2/platform_drm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index 70bd7d4..f6b9c3a 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH] egl/drm: do not crash when swapping buffers without any rendering

Signed-off-by: Lionel Landwerlin lionel.g.landwer...@intel.com --- src/egl/drivers/dri2/platform_drm.c | 8 1 file changed, 8 insertions(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index 70bd7d4..f6b9c3a 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] Trivial fix for ChromeOS unit test

Hey there, While enabling LibVA on ChromeOS with their Ozone backend (EGL/GLES2 without X), I stumbled upon a crash. Here is a simple patch to fix it. It's pretty much a copy/paste of a snippet already in EGL/wayland. Cheers, - Lionel ___ mesa-dev

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

We let the user believe we support some transfer formats which we don't. This can lead to crashes when actually trying to use those formats. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_formats.c | 7 +-- 1 file changed, 5 insertions

Re: [Mesa-dev] [PATCH] anv/pipeline: Set up point coord enables

Tested-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 23/07/16 00:28, Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> Cc: "12.0" <mesa-sta...@lists.freedesktop.org> --- src/intel/vulkan/genX_pipeline_util.h | 5 + 1 file ch

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix transfer destination formats

. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Jason Ekstrand <jason.ekstr...@intel.com> --- src/intel/vulkan/anv_formats.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_for

[Mesa-dev] [PATCH 2/2] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

attachments. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/intel/vulkan/anv_formats.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/a

[Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

SampleMask is only 8bits long on gen7. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/intel/vulkan/genX_pipeline_util.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_util.h

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

attachments. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/intel/vulkan/anv_formats.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/

[Mesa-dev] [PATCH] anv/wsi: create swapchain images using specified image usage

From: Lionel Landwerlin <lionel.g.landwer...@intel.com> The image usage specified by the caller of vkCreateSwapchainKHR should be passed onto the internal image creation. Otherwise the driver might later crash when the user tries to use the image as a combined sampler even though the cr

[Mesa-dev] [PATCH] anv/wsi: create swapchain images using specified image usage

. Leaving the previous VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT as this might be expected even if the swapchain is created without any flag. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_wsi_wayland.c | 10 +++--- src/intel/vulkan/anv_wsi_x11.c

[Mesa-dev] [PATCH] anv: remove support for d32_sfloat_s8_uint

It doesn't seem like we have any support for 32bits of something + 8bits of something else. This fixes dEQP-VK.api.copy_and_blit.blit_image.all_formats.scaling_partial_d32_sfloat_s8_uint_d32_sfloat_s8_uint_nearest Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src

[Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

Fixes 6 failures from dEQP-VK.api.copy_and_blit.resolve_image.* Tested on IVB/HSW v2: Program multisample dispatch mode correctly Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/gen7_pipeline.c | 46 ++-- 1 file c

Re: [Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix transfer destination formats

On 03/08/16 16:01, Jason Ekstrand wrote: On Aug 3, 2016 5:53 AM, "Lionel Landwerlin" <lionel.g.landwer...@intel.com <mailto:lionel.g.landwer...@intel.com>> wrote: > > We let the user believe we support some transfer destination formats > which we don't. This ca

Re: [Mesa-dev] [PATCH] anv: remove support for d32_sfloat_s8_uint

On 05/08/16 18:08, Jason Ekstrand wrote: On Aug 5, 2016 9:49 AM, "Lionel Landwerlin" <lionel.g.landwer...@intel.com <mailto:lionel.g.landwer...@intel.com>> wrote: > > It doesn't seem like we have any support for 32bits of something + 8bits of > something

[Mesa-dev] [PATCH] anv: gen7/75: enable multisampling

Fixes 6 failures from dEQP-VK.api.copy_and_blit.resolve_image.* Tested on IVB/HSW Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/gen7_pipeline.c | 46 ++-- 1 file changed, 30 insertions(+), 16 deletions(-) diff

[Mesa-dev] [PATCH 1/2] anv: gen7: rename rasterization state variable

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: anuj.pho...@gmail.com --- src/intel/vulkan/gen7_pipeline.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 6

[Mesa-dev] [PATCH 2/2] anv: gen7/75: enable multisampling

-VK.api.copy_and_blit.resolve_image.with_regions_4_bit dEQP-VK.api.copy_and_blit.resolve_image.with_regions_8_bit Tested on IVB/HSW Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: anuj.pho...@gmail.com --- src/intel/vulkan/gen7_pipeline.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-)

[Mesa-dev] [PATCH 0/2] anv: Add support for multisampling on gen7/75

Hi, This updates a previous patch, based on the review feedback from Anuj. Thanks a lot for your time! Lionel Lionel Landwerlin (2): anv: gen7: rename rasterization state variable anv: gen7/75: enable multisampling src/intel/vulkan/gen7_pipeline.c | 39

[Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v2)

-VK.api.copy_and_blit.resolve_image.with_regions_4_bit dEQP-VK.api.copy_and_blit.resolve_image.with_regions_8_bit Tested on IVB/HSW v2: Check pMultisampleState is not NULL Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/gen7_pipeline.c | 24 +++

[Mesa-dev] [PATCH 0/2] Program multisampling modes on gen7/75

Some of the new CTS tests are failing basic image resolve operations on gen7/75. Turns out we're missing some bits there. Cheers, Lionel Landwerlin (2): anv: genX_pipeline: rename info to rs_info anv: gen7/75: Set multisample modes src/intel/vulkan/gen7_pipeline.c | 10 -- src

[Mesa-dev] [PATCH 1/2] anv: genX_pipeline: rename info to rs_info

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cc: Jason Ekstrand <ja...@jlekstrand.net> --- src/intel/vulkan/genX_pipeline_util.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline_util.h b/src/

[Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

-VK.api.copy_and_blit.resolve_image.with_regions_4_bit dEQP-VK.api.copy_and_blit.resolve_image.with_regions_8_bit Tested on IVB/HSW v2: Check pMultisampleState is not NULL v3: Drop rasterization state rename (Anuj) Fix value of MultisampleRasterizationMode in 3DSTATE_SF v4: rebase on master Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH] anv: gen7/75: enable multisampling (v3)

-VK.api.copy_and_blit.resolve_image.with_regions_4_bit dEQP-VK.api.copy_and_blit.resolve_image.with_regions_8_bit Tested on IVB/HSW v2: Check pMultisampleState is not NULL v3: Drop rasterization state rename (Anuj) Fix value of MultisampleRasterizationMode in 3DSTATE_SF Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com&

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

Thanks, that's pretty clean :) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 01:43, Jason Ekstrand wrote: This seemed to help Dota 2 by a percent or two. --- src/intel/vulkan/genX_pipeline.c | 133 +-- 1 file chang

Re: [Mesa-dev] [PATCH 1/2] genxml: Add the CACHE_MODE_0 register on gen9

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 06:11, Jason Ekstrand wrote: --- src/intel/genxml/gen9.xml | 28 1 file changed, 28 insertions(+) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 671322b..e

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 04:07, Jason Ekstrand wrote: The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

Oops, miss on the v2. Indeed clearing up the variables in case info == NULL is good! Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 04:12, Jason Ekstrand wrote: In order to get good performance numbers for this, I had to hack up the driver to whack wm_pro

Re: [Mesa-dev] [PATCH 0/5] anv: Implement the depth PMA fix on Broadwell

Not sure what happened to patches 1,2 & 4... If you have a branch somewhere, I'll give the remaining Rbs here. Thanks On 02/02/17 01:43, Jason Ekstrand wrote: This little series does a few little cleanups as well as implements the PMA fix on Broadwell. The cleanups are focussed around letting

Re: [Mesa-dev] [PATCH 0/5] anv: Implement the depth PMA fix on Broadwell

Oh, ignore me, my mail client is a bit crap :( On 02/02/17 11:08, Lionel Landwerlin wrote: Not sure what happened to patches 1,2 & 4... If you have a branch somewhere, I'll give the remaining Rbs here. Thanks On 02/02/17 01:43, Jason Ekstrand wrote: This little series does a few li

Re: [Mesa-dev] [PATCH 3/5] anv: Add support for the PMA fix on Broadwell

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 01:43, Jason Ekstrand wrote: In order to get good performance numbers for this, I had to hack up the driver to whack wm_prog_data::uses_kill to true to emulate a discard and used the Sascha "shadowmapping"

Re: [Mesa-dev] [PATCH 7/7] anv: enable VK_KHR_shader_draw_parameters

0 AM, Lionel Landwerlin <lionel.g.landwer...@intel.com <mailto:lionel.g.landwer...@intel.com>> wrote: Enables 10 tests from: dEQP-VK.draw.shader_draw_parameters.* Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com

Re: [Mesa-dev] [PATCH 7/7] anv: enable VK_KHR_shader_draw_parameters

On 01/02/17 02:35, Anuj Phogat wrote: On Tue, Jan 31, 2017 at 7:00 AM, Lionel Landwerlin <lionel.g.landwer...@intel.com> wrote: Enables 10 tests from: dEQP-VK.draw.shader_draw_parameters.* and I assume they all pass with this series. Yes :) Signed-off-by: Lionel Land

[Mesa-dev] [PATCH 0/7] Spirv/Anv: Add support for KHR_shader_draw_parameters

is hopefully explained clearly enough in patch 5. Cheers, Lionel Landwerlin (7): compiler: add missing enums for debug spirv: add SPV_KHR_shader_draw_parameters support anv: limit vertex buffers to 31 anv: move BaseVertexID/BaseInstanceID vertex buffer index to 31 anv: always allocate a vertex

[Mesa-dev] [PATCH 5/7] anv: always allocate a vertex element with vertexid or instanceid

(see vec4_vs_visitor::setup_attributes). Therefore we need to allocate an element for the SGVS elements as long as at least one of the SGVS element is needed by the shader. Otherwise our shader we use a gl_DrawIDARB value pull from the URB one element too far (probably garbage). Signed-off-by: Lionel Landwe

[Mesa-dev] [PATCH 2/7] spirv: add SPV_KHR_shader_draw_parameters support

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/nir_spirv.h | 1 + src/compiler/spirv/spirv_to_nir.c | 4 src/compiler/spirv/vtn_variables.c | 12 3 files changed, 17 insertions(+) diff --git a/src/compiler/spirv/nir_spirv.h

[Mesa-dev] [PATCH 7/7] anv: enable VK_KHR_shader_draw_parameters

Enables 10 tests from: dEQP-VK.draw.shader_draw_parameters.* Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_pipeline.c | 1 + 2 files changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_devi

[Mesa-dev] [PATCH 3/7] anv: limit vertex buffers to 31

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_device.c| 4 ++-- src/intel/vulkan/anv_private.h | 2 +- src/intel/vulkan/genX_pipeline.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 1/7] compiler: add missing enums for debug

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/shader_enums.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/shader_enums.c b/src/compiler/shader_enums.c index 3c5a268687..e704c95a6b 100644 --- a/src/compiler/shader_enums.c +++ b/src/co

[Mesa-dev] [PATCH v2] anv: always allocate a vertex element with vertexid or instanceid

onel) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/genX_pipeline.c | 12 1 file changed, 12 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 9629ca9bf9..4c1afd0319 100644 --- a/src/in

[Mesa-dev] [PATCH 4/7] anv: move BaseVertexID/BaseInstanceID vertex buffer index to 31

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 2 +- src/intel/vulkan/genX_pipeline.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 6/7] anv: emit DrawID if needed

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/genX_cmd_buffer.c | 43 +- src/intel/vulkan/genX_pipeline.c | 25 +- 2 files changed, 62 insertions(+), 6 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH v2] anv: move BaseVertexID/BaseInstanceID vertex buffer index to 31

v2: use define for buffer ID (Jason) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_private.h | 2 ++ src/intel/vulkan/genX_cmd_buffer.c | 2 +- src/intel/vulkan/genX_pipeline.c | 2

[Mesa-dev] [PATCH v2] anv: emit DrawID if needed

v2: use define for buffer ID (Jason) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Anuj Phogat <anuj.pho...@gmail.com> --- src/intel/vulkan/anv_private.h | 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 42 +- src/

Re: [Mesa-dev] [PATCH 4/7] i965/fs: Add support for nir_op_[iu]642f

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 --- src/mesa/drivers/dri/i965/brw_fs

Re: [Mesa-dev] [PATCH 7/7] i965/fs: add support for int64 to bool conversion

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 --- src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH 2/7] i965/fs: Add support for nir_op_[iu]642d

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: From: Jason Ekstrand <jason.ekstr...@intel.com> --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/driv

Re: [Mesa-dev] [PATCH 1/7] i965: Allow int64 conversion operations in channel_expressions

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: From: Jason Ekstrand <jason.ekstr...@intel.com> This fixes 143 of the new piglit tests added by Nicolai Cc: Ian Romanick <i...@freedesktop.org>

Re: [Mesa-dev] [PATCH 3/7] i965/fs: legalize [u]int64 to 32-bit data conversions in lower_d2x

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 --- src/mesa/drivers/dri/i965/brw_fs_l

Re: [Mesa-dev] [PATCH 5/7] i965/fs: Add support for nir_op_[iu]2[iu]32

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 --- src/mesa/drivers/dri/i965/brw_fs

Re: [Mesa-dev] [PATCH 6/7] nir: add opcode to perform int64 to bool conversions

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 08/02/17 14:58, Samuel Iglesias Gonsálvez wrote: Signed-off-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 --- src/compiler/glsl/glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH 2/5] genxml: Add the CACHE_MODE_1 register on gen8

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 01:43, Jason Ekstrand wrote: --- src/intel/genxml/gen8.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 970e637..32ed764

Re: [Mesa-dev] [PATCH 2/2] anv: Implement the Sky Lake stencil PMA optimization

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> The documentation has the following sentence for both CACHE_MODE_0 & CACHE_MODE_1 : "Before changing the value of this register, GFX pipeline must be idle i.e. full flush is required." That seems coh

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline: Make a copy of VkPipelineDepthStencilStateCreateinfo

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 01:43, Jason Ekstrand wrote: --- src/intel/vulkan/genX_pipeline.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src

[Mesa-dev] [PATCH] anv: descriptors: don't update immutables samplers with anything but their immutable value

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_descriptor_set.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c

[Mesa-dev] [PATCH] anv: add KHR_get_physical_device_properties2 support

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_device.c | 593 + src/intel/vulkan/anv_formats.c | 42 +++ 2 files changed, 398 insertions(+), 237 deletions(-) diff --git a/src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH 1/6] anv: Set viewport extents correctly when height is negative

height = -100, shouldn't we use YMinVP = -99 and YMaxVP = 0 instead of (-100, -1)? No, I think we still want -100, -1. In the case mentioned, the Y region, in floating-point, is [-100, 0]. However, it appears that, even though it's float, we're expected to provide max-1 in the ma

Re: [Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

On 24/01/17 00:50, Jason Ekstrand wrote: On Mon, Jan 23, 2017 at 4:25 PM, Chad Versace > wrote: On Mon 23 Jan 2017, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 3:31 PM, Chad Versace

[Mesa-dev] [PATCH v2] anv: fix descriptor pool internal size allocation

(Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_descriptor_set.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a4b7638a61..7853

[Mesa-dev] [PATCH] anv: don't assert on out of memory descriptor pool in debug mode

Fixes: dEQP-VK.api.descriptor_pool.out_of_pool_memory Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_util.c b/src/intel/vulkan/anv_util.c index 6408ac87c7..5fbc

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 26/01/17 13:18, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> MSVC warns about implicit conversion as below. Annotate the literal appropriately to silence the warning. nir_gather_info.c(24

Re: [Mesa-dev] [PATCH 2/8] nir: add extra const notation in compare_blocks()

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 26/01/17 13:18, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> MSVC warns about different const qualifiers. Add the extra const to silence it. nir_phi_builder.c(244) : warning C4090: '

[Mesa-dev] [PATCH] anv: fix descriptor pool internal size allocation

The size of the pool is slightly smaller than the size of the structure containing the whole pool. We need to take that into account on when setting up the internals. Fixes a crash due to out of bound memory access in: dEQP-VK.api.descriptor_pool.out_of_pool_memory Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH mesa 1/2] anv: add missing core errors in vk_errorf()

Both patches look good to me : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 26/01/17 13:48, Eric Engestrom wrote: Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- src/intel/vulkan/anv_util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] anv: don't assert on out of memory descriptor pool in debug mode

On 26/01/17 13:43, Eric Engestrom wrote: On Thursday, 2017-01-26 11:27:00 +, Lionel Landwerlin wrote: Fixes: dEQP-VK.api.descriptor_pool.out_of_pool_memory Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Eric Engestrom <eric.engest...@i

[Mesa-dev] [PATCH 1/2] spirv: handle OpUndef as part of the variable parsing pass

compiler currently stops parsing variables & types on the OpUndef and switches to instructions, leaving the following sc_[0-2] variables untreated. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/spirv_to_nir.c | 1 + src/compiler/spirv/vtn_varia

[Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

Fixes: dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_related dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_related* Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/spirv_to_nir.

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

On 27/01/17 09:57, Juan A. Suarez Romero wrote: On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: But what the test does is calling OpSpecConstantOp[2], which is the operation we are patching here. And according to the spec, "all Operands must be the s of other constant instruc

Re: [Mesa-dev] [PATCH] configure.ac: Add radeon to with-vulkan-drivers help message.

I was bitten by that too so : Acked-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 27/01/17 18:47, Bas Nieuwenhuizen wrote: Had someone that tried --with-vulkan-drivers=radv, this will guide people in the right direction. Signed-off-by: Bas Nieuwenhuizen <ba...@google.com&g

[Mesa-dev] [PATCH 2/3] spirv: add default handler for new enums

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/spirv_to_nir.c | 12 src/compiler/spirv/vtn_variables.c | 3 +++ 2 files changed, 15 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 1/3] spirv: fix typos

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/spirv_to_nir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index aecda17271..968502c5fd 100644 ---

Re: [Mesa-dev] [PATCH 2/2] spirv: bump headers to SPIRV 1.1

On 25/01/17 13:13, Bas Nieuwenhuizen wrote: On Wed, Jan 25, 2017, at 05:06, Lionel Landwerlin wrote: Just to confirm, are you fine with the header update triggering warnings fixed by the following commit? Can't you update the switches before updating the header? That would avoid any warnings

[Mesa-dev] [PATCH v2 3/3] spirv: bump headers to SPIRV 1.1

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/GLSL.std.450.h | 12 -- src/compiler/spirv/spirv.h| 77 --- src/compiler/spirv/spirv_info.c | 6 +++ 3 files changed, 86 insertions(+), 9 deletions(-)

Re: [Mesa-dev] [PATCH] vulkan/wsi: Lower the maximum image sizes

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 25/01/17 01:16, Jason Ekstrand wrote: --- src/vulkan/wsi/wsi_common_wayland.c | 3 ++- src/vulkan/wsi/wsi_common_x11.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vulk

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/wayland: Handle VK_INCOMPLETE for GetPresentModes

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 25/01/17 00:44, Jason Ekstrand wrote: --- src/vulkan/wsi/wsi_common_wayland.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulk

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi/wayland: Handle VK_INCOMPLETE for GetFormats

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 25/01/17 00:44, Jason Ekstrand wrote: --- src/vulkan/wsi/wsi_common_wayland.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulk

Re: [Mesa-dev] [PATCH 2/2] spirv: bump headers to SPIRV 1.1

.nl> for the series. On Wed, Jan 25, 2017, at 04:39, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/GLSL.std.450.h | 12 -- src/compiler/spirv/spirv.h | 77 +++--- src/compiler/spirv/

[Mesa-dev] [PATCH 0/2] Spirv: update headers to 1.1

as well as a few switch statements to avoid warnings at compile time. Cheers, Lionel Landwerlin (2): spirv: fix typos spirv: bump headers to SPIRV 1.1 src/compiler/spirv/GLSL.std.450.h | 12 -- src/compiler/spirv/spirv.h | 77 +++--- src/compiler

[Mesa-dev] [PATCH 1/2] spirv: fix typos

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/spirv_to_nir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index aecda17271..968502c5fd 100644 ---

[Mesa-dev] [PATCH 2/2] spirv: bump headers to SPIRV 1.1

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/GLSL.std.450.h | 12 -- src/compiler/spirv/spirv.h | 77 +++--- src/compiler/spirv/spirv_info.c| 6 +++ src/compiler/spirv/spirv_to_nir.c | 12 +

[Mesa-dev] [PATCH] anv: set command buffer to NULL when allocations fail

tries of the pCommandBuffers array to VK_NULL_HANDLE and return the error." Fixes: dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary Signed-off-by: Lionel Landwerlin <lio

Re: [Mesa-dev] [PATCH 0/5] anv: Implement VK_KHR_get_physical_device_properties2 (v2)

Looks good to me : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 25/01/17 20:12, Chad Versace wrote: Untested, but builds. I wanted to get feedback on this approach before going through the trouble of fetching and building the newest CTS. If the review feedback i

Re: [Mesa-dev] [PATCH 1/2] spirv: don't assert with location decorations on non i/o variables

On 20/01/17 20:40, Dave Airlie wrote: On 21 January 2017 at 03:08, Jason Ekstrand <ja...@jlekstrand.net> wrote: On Fri, Jan 20, 2017 at 8:45 AM, Lionel Landwerlin <lionel.g.landwer...@intel.com> wrote: Some applications might add location decoration to samplers. Rather than rais

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

On 27/01/17 08:44, Juan A. Suarez Romero wrote: On Thu, 2017-01-26 at 17:08 +, Lionel Landwerlin wrote: Fixes: dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_related dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_related* Signed-off

Re: [Mesa-dev] [PATCH] anv: handle VK_ERROR_OUT_OF_POOL_MEMORY_KHR error

On 27/01/17 16:26, Eric Engestrom wrote: On Friday, 2017-01-27 17:00:18 +0100, Juan A. Suarez Romero wrote: This fixes dEQP-VK.api.descriptor_pool.out_of_pool_memory test Signed-off-by: Juan A. Suarez Romero <jasua...@igalia.com> Thanks, this is correct, but Lionel Landwerlin already s

[Mesa-dev] [PATCH 0/2] Spirv/Anv: Add support for KHR_shader_draw_parameters

Hi, This extensions is the equivalent of GL_ARB_shader_draw_parameters. This was added by Vulkan 1.0.39. Cheers, Lionel Landwerlin (2): spirv: add SPV_KHR_shader_draw_parameters support anv: enable VK_KHR_shader_draw_parameters src/compiler/spirv/nir_spirv.h | 1 + src/compiler/spirv

[Mesa-dev] [PATCH 2/2] anv: enable VK_KHR_shader_draw_parameters

Enables 10 tests from: dEQP-VK.draw.shader_draw_parameters.* Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_pipeline.c | 1 + 2 files changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_devi

[Mesa-dev] [PATCH 1/2] spirv: add SPV_KHR_shader_draw_parameters support

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/compiler/spirv/nir_spirv.h | 1 + src/compiler/spirv/spirv_to_nir.c | 4 src/compiler/spirv/vtn_variables.c | 12 3 files changed, 17 insertions(+) diff --git a/src/compiler/spirv/nir_spirv.h

Re: [Mesa-dev] [PATCH 2/2] anv: enable VK_KHR_shader_draw_parameters

correctly? I'm pretty sure we have exactly zero code for that. On Wed, Jan 25, 2017 at 10:55 AM, Lionel Landwerlin <lionel.g.landwer...@intel.com <mailto:lionel.g.landwer...@intel.com>> wrote: Enables 10 tests from: dEQP-VK.draw.shader_draw_parameters.* Signed-of

Re: [Mesa-dev] [PATCH 1/5] intel/blorp: Explicitly flush all allocated state

On 20/02/17 19:21, Jason Ekstrand wrote: Found by inspection. However, I expect it fixes real bugs when using blorp from Vulkan on little-core platforms. Cc: "13.0 17.0" --- src/intel/blorp/blorp_genX_exec.h | 17 -

Re: [Mesa-dev] [PATCH 0/5] anv: Fix and rework flushing

Nice cleanup, patches 2->5 are : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Just one question on patch 1. On 20/02/17 19:21, Jason Ekstrand wrote: The first patch in this little series should fix actual bugs on little-core platforms because it makes BLORP properl

[Mesa-dev] [PATCH 1/3] anv/blorp/i965: blump blorp's pipe controls back into the embedding driver

At the moment, we don't seem to miss any workaround from having blorp's pipe controls not tracked by the embedding driver, but this should make things more robust if something new comes up. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/blorp/blorp_genX_

[Mesa-dev] [PATCH 2/3] anv: centralize PIPE_CONTROLs

This allows us to monitor pipe controls and apply workarounds in a single location if needed. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_genX.h| 26 ++ src/intel/vulkan/anv_private.h | 8 src

[Mesa-dev] [PATCH 3/3] anv: implement WaCsStallAtEveryFourthPipecontrol for gen7

Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- src/intel/vulkan/anv_batch_chain.c | 5 + src/intel/vulkan/anv_pipeline.c| 2 ++ src/intel/vulkan/anv_private.h | 4 src/intel/vulkan/genX_cmd_buffer.c | 21 +++-- 4 files chang

[Mesa-dev] [PATCH 0/3] anv/blorp/i965: pipe control blumping

centralize pipe controls in anv and implement one of the workaround we need on IVB/BYT. Cheers, Lionel Landwerlin (3): anv/blorp/i965: blump blorp's pipe controls back into the embedding driver anv: centralize PIPE_CONTROLs anv: implement WaCsStallAtEveryFourthPipecontrol for gen7 src

Re: [Mesa-dev] [PATCH] anv: ensure that we do not emit negative Depth in 3DSTATE_DEPTH_BUFFER

I can't reproduce on the vulkan-cts-next-dev (I just pull -r, so I shouldn't miss anything right?). On 22/02/17 14:45, Iago Toral Quiroga wrote: This fixes a number of new CTS tests that would crash otherwise: dEQP-VK.pipeline.render_to_image.* --- src/intel/vulkan/genX_cmd_buffer.c | 3 ++-

  1   2   3   4   5   6   7   8   9   10   >