[Mesa-dev] [PATCH] nvc0: Display an error when DRM version is too old to use performance counters

From: Samuel samuel.pitoi...@gmail.com --- src/gallium/drivers/nvc0/nvc0_query.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nvc0/nvc0_query.c b/src/gallium/drivers/nvc0/nvc0_query.c index 75c515a..7fc1ca9 100644 ---

[Mesa-dev] [PATCH 1/2] [RFC] nvc0: implement compute support for nvc0

. + * + * Authors: Samuel Pitoiset + */ + +#include nvc0_context.h +#include nvc0_compute.h + +int +nvc0_screen_compute_setup(struct nvc0_screen *screen, + struct nouveau_pushbuf *push) +{ + struct nouveau_object *chan = screen-base.channel; + struct nouveau_device *dev

[Mesa-dev] [PATCH 2/2] [RFC] nvc0: implement MP performance counters for nvc0:nvc8

--- src/gallium/drivers/nvc0/nvc0_query.c | 413 - src/gallium/drivers/nvc0/nvc0_screen.h | 35 +++ 2 files changed, 440 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/nvc0/nvc0_query.c b/src/gallium/drivers/nvc0/nvc0_query.c index

[Mesa-dev] [PATCH 05/11] nvc0: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 ++ 3 files changed, 56 insertions(+) diff --git

[Mesa-dev] [PATCH 01/11] nvc0: allocate more space before a counter is configured

On nvc0, a counter can up to 6 sources instead of only one for nve4+. This fixes a crash when a counter uses more than one source. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[Mesa-dev] [PATCH 11/11] [RFC] mesa/st: enable GL_AMD_performance_monitor

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 4207cb6..25042fb 100644 --- a/src/mesa/state_tracker

[Mesa-dev] [PATCH 06/11] gallium: add new counter types to pipe_driver_query_info

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 25 + src/gallium/include/pipe/p_defines.h | 12

[Mesa-dev] [PATCH 07/11] gallium: Add a f32 field to pipe_query_result

This will be used for the GL_FLOAT counter type of AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe

[Mesa-dev] [PATCH 09/11] nvc0: make begin_query return false when all MP counters are used

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index e38744a

[Mesa-dev] [PATCH 03/11] gallium: add a group_id field to pipe_driver_query_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 8f20974..e8a6f1a 100644 --- a/src/gallium/include/pipe

[Mesa-dev] [PATCH 08/11] gallium: make pipe_context::begin_query return a boolean

This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3

[Mesa-dev] [PATCH 04/11] nvc0: use of pipe_driver_query_info::group_id

This adds two groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 4 src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 5 + 2 files changed, 9 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0

[Mesa-dev] [PATCH 02/11] gallium: add pipe_context::get_driver_query_group_info

This will be used to sort counters per group for GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 2 files changed, 18 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 10/11] [RFC] mesa/st: implement GL_AMD_performance_monitor

From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) V2: (Samuel Pitoiset) - Fix compilation - Improve the original code - Rewrite some parts of the original code

[Mesa-dev] GL_AMD_performance_monitor for Nouveau

Hi, As part of my Google Summer of Code 2014, I implemented GL_AMD_performance_monitor for Nouveau using the state tracker of Gallium. Currently, only MP counters for NVC0+ (fermi) are exposed through this extension. At the end of my project, graphics counters for NV50 (tesla) will be available

Re: [Mesa-dev] GL_AMD_performance_monitor for Nouveau

On 07/05/2014 07:18 PM, Ilia Mirkin wrote: On Sat, Jul 5, 2014 at 2:49 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Hi, As part of my Google Summer of Code 2014, I implemented GL_AMD_performance_monitor for Nouveau using the state tracker of Gallium. Currently, only MP counters

Re: [Mesa-dev] [PATCH 06/11] gallium: add new counter types to pipe_driver_query_info

On 07/06/2014 01:39 PM, Marek Olšák wrote: The same as patch 3 - this will break radeon. Marek Thanks for your reviews, I'll fix the radeon part. On Sat, Jul 5, 2014 at 8:49 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This will be used by GL_AMD_performance_monitor. Signed-off

[Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

V2: - make group_id the last field of this struct, this fixes drivers which use pipe_driver_query_info like radeon Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe

[Mesa-dev] [PATCH 15/16] [RFC] mesa/st: implement GL_AMD_performance_monitor v3

From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) V2: (Samuel Pitoiset) - Fix compilation - Improve the original code - Rewrite some parts of the original code V3

[Mesa-dev] [PATCH 16/16] [RFC] mesa/st: enable GL_AMD_performance_monitor

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 4207cb6..25042fb 100644 --- a/src/mesa/state_tracker

[Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

This allows to return different numeric types for queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8

[Mesa-dev] [PATCH 13/16] gallium: make pipe_context::begin_query return a boolean

This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3

[Mesa-dev] [PATCH 14/16] nvc0: make begin_query return false when all MP counters are used v2

V2: - do not return immediately after nvc0_mp_pm_query_end() in order to set the current state of the given query Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 10/16] gallium: add is_percentage and is_float fields to pipe_driver_query_info

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index 501c1e2

[Mesa-dev] [PATCH 01/16] nvc0: allocate more space before a counter is configured v2

On nvc0, a counter can up to 6 sources instead of only one for nve4+. This fixes a crash when a counter uses more than one source. V2: - add the Reviewed-by Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com Reviewed-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 05/16] svga: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/svga/svga_screen.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index b213b04..5621271 100644 --- a/src

[Mesa-dev] [PATCH 07/16] radeon: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c b/src/gallium/drivers/radeon/r600_pipe_common.c index 46e8a79..43d86a4

[Mesa-dev] [PATCH 12/16] gallium: Add a f32 field to pipe_query_result

This will be used for the GL_FLOAT counter type of AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe

[Mesa-dev] [PATCH 06/16] freedreno: implement pipe_context::get_driver_query_group_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_query.c b/src/gallium/drivers/freedreno/freedreno_query.c index cb3b49a

[Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index

[Mesa-dev] [PATCH 04/16] gallium: use of pipe_driver_query_info::group_id v2

This adds two groups of queries for nvc0. All other drivers which use pipe_driver_query_info (freedreno, svga and radeon) only define one group of queries. V2: - rewrite commit message Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c

[Mesa-dev] GL_AMD_performance_monitor v2

Hello, This is the second version of GL_AMD_performance_monitor. V2 (global changes): - Fix radeon as pinpointd by Marek. - Implement pipe_driver_query_group_info for svga, radeon and freedreno GL_AMD_performance_monitor is now available for nvc0, svga, freedreno and radeon. Thanks in

[Mesa-dev] [PATCH 08/16] nvc0: implement pipe_context::get_driver_query_group_info

This adds two groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 ++ 3 files

[Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

This will be used to sort counters per group for GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 2 files changed, 18 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH 03/16] gallium: add a group_id field to pipe_driver_query_info v2

On 07/07/2014 05:12 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: V2: - make group_id the last field of this struct, this fixes drivers which use pipe_driver_query_info like radeon While I have no problem with this patch, how

Re: [Mesa-dev] [PATCH 04/16] gallium: use of pipe_driver_query_info::group_id v2

On 07/07/2014 05:13 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This adds two groups of queries for nvc0. All other drivers which use pipe_driver_query_info (freedreno, svga and radeon) only define one group of queries. V2

Re: [Mesa-dev] [PATCH 09/16] gallium: replace pipe_driver_query_info::max_value by a union

On 07/07/2014 05:17 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This allows to return different numeric types for queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c

Re: [Mesa-dev] [PATCH 16/16] [RFC] mesa/st: enable GL_AMD_performance_monitor

On 07/07/2014 05:23 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 02/16] gallium: add pipe_context::get_driver_query_group_info

bit in gallium/docs/source/screen.rst Otherwise looks ok to me. Roland Am 07.07.2014 17:47, schrieb Samuel Pitoiset: This will be used to sort counters per group for GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h

Re: [Mesa-dev] [PATCH 11/16] nvc0: use of new counter types

On 07/07/2014 06:32 PM, Ilia Mirkin wrote: On Mon, Jul 7, 2014 at 11:47 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 19 +-- 1 file changed, 13 insertions

Re: [Mesa-dev] [PATCH 10/16] gallium: add is_percentage and is_float fields to pipe_driver_query_info

of booleans. If that's not possible, please document how the booleans interact with each other. I'll take a look at this. Thanks. Marek On Mon, Jul 7, 2014 at 5:47 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset

[Mesa-dev] GL_AMD_performance_monitor v3

Hello, This is the third version of GL_AMD_performance_monitor. V2 (global changes): - Fix radeon as pinpointed by Marek - Implement pipe_driver_query_group_info for svga, radeon and freedreno V3 (global changes): - Re-organize the series according to hints of Ilia Mirkin - Document

[Mesa-dev] [PATCH 03/15] gallium: add new numeric types to pipe_query_result v2

This will be used by GL_AMD_performance_monitor. V2: - add 'uint32_t u32' - rename 'float f32' to 'float f' - add some comments Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 01/15] gallium: add pipe_screen::get_driver_query_group_info v2

/pipe_context/pipe_screen in the commit msg - rewrite commit message Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/docs/source/screen.rst | 10 ++ src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 3 files changed

[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info v2

According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. V2: - add pipe_driver_query_type enum Signed-off-by: Samuel

[Mesa-dev] [PATCH 05/15] gallium: make pipe_context::begin_query return a boolean

This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3

[Mesa-dev] [PATCH 14/15] nvc0: make begin_query return false when all MP counters are used v2

V2: - do not return immediately after nvc0_mp_pm_query_end() in order to set the current state of the given query Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 06/15] mesa/st: implement GL_AMD_performance_monitor v4

: (Samuel Pitoiset) - fix compilation - improve the original code - rewrite some parts of the original code V3: - do not use pipe_driver_query_info::min_value which is always set to 0 V4: - only enable AMD_performance_monitor if the driver implements pipe_screen::get_driver_query_group_info

[Mesa-dev] [PATCH 13/15] nvc0: expose driver queries with two groups

This adds a new group for MP performance counters and requires to write our own implementation of get_driver_query_group_info. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 -- src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 04/15] gallium: replace pipe_driver_query_info::max_value by a union v2

to gl_perf_monitor_counter_value Signed-off-by: Samuel Pitoiset samuel.pitoiset at gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 src/gallium

[Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info v3

This enables GL_AMD_performance_monitor for radeon. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + 1 file changed, 9

[Mesa-dev] [PATCH 15/15] nvc0: init all default values of pipe_driver_query_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46 ++ src/gallium/auxiliary/util/u_query.h | 44

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno and radeon. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- docs/relnotes/10.3.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.3.html b/docs/relnotes/10.3.html index 2e718fc..e73e078 100644

[Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/svga/svga_screen.c | 11 +++ 1 file changed, 11 insertions

[Mesa-dev] [PATCH 11/15] nvc0: implement pipe_screen::get_driver_query_group_info v2

This enables GL_AMD_performance_monitor for nvc0. V2: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers

[Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info v3

This enables GL_AMD_performance_monitor for freedreno. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c | 9 + 1 file changed, 9

Re: [Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release

On 07/09/2014 03:10 PM, Marek Olšák wrote: Also radeonsi, because the query code shared between both drivers. Added, thanks. Marek On Wed, Jul 9, 2014 at 4:34 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: GL_AMD_performance_monitor is supported by nvc0, svga, freedreno and radeon

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off-by: Samuel Pitoiset samuel.pitoi

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 06/15] mesa/st: implement GL_AMD_performance_monitor v4

On 07/09/2014 03:00 PM, Brian Paul wrote: In the subject, we usually use st/mesa:. Okay. On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: From: Christoph Bumiller e0425...@student.tuwien.ac.at This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org

Re: [Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v3

Pitoiset samuel.pitoi...@gmail.com wrote: On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info Signed-off

[Mesa-dev] [PATCH 03/15] gallium: add new numeric types to pipe_query_result v2

This will be used by GL_AMD_performance_monitor. V2: - add 'uint32_t u32' - rename 'float f32' to 'float f' - add some comments Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 04/15] gallium: replace pipe_driver_query_info::max_value by a union v2

to gl_perf_monitor_counter_value Signed-off-by: Samuel Pitoiset samuel.pitoiset at gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 src/gallium

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info v2

This generic function will be used to get groups of queries. V2: - add some comments as request by Brian Paul - put the function name on the next line Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util

[Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info v4

This enables GL_AMD_performance_monitor for radeon. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info V4: - add R600_QUERY_COUNT in r600_pipe_common.h Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/radeon

[Mesa-dev] [PATCH 13/15] nvc0: expose driver queries with two groups

This adds a new group for MP performance counters and requires to write our own implementation of get_driver_query_group_info. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 52 -- src/gallium/drivers/nouveau

[Mesa-dev] [PATCH 01/15] gallium: add pipe_screen::get_driver_query_group_info v2

/pipe_context/pipe_screen in the commit msg - rewrite commit message Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/docs/source/screen.rst | 10 ++ src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 3 files changed

[Mesa-dev] [PATCH 06/15] st/mesa: implement GL_AMD_performance_monitor v5

: (Samuel Pitoiset) - fix compilation - improve the original code - rewrite some parts of the original code V3: - do not use pipe_driver_query_info::min_value which is always set to 0 V4: - only enable AMD_performance_monitor if the driver implements pipe_screen::get_driver_query_group_info

[Mesa-dev] [PATCH 11/15] nvc0: implement pipe_screen::get_driver_query_group_info v3

This enables GL_AMD_performance_monitor for nvc0. V2: - use util_get_driver_query_group_info V3: - use of NVC0_QUERY_DRV_STAT_COUNT instead of a magic number Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.3 release v2

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno, r600 and radeonsi. V2: - add radeonsi Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- docs/relnotes/10.3.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.3.html b/docs/relnotes/10.3.html

[Mesa-dev] [PATCH 15/15] nvc0: init all default values of pipe_driver_query_info

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index

[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info v2

According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. V2: - add pipe_driver_query_type enum Signed-off-by: Samuel

[Mesa-dev] GL_AMD_performance_monitor v4

Hello everyone, New version of GL_AMD_performance_monitor (version 4). V2 (global changes): - Fix radeon as pinpointed by Marek - Implement pipe_driver_query_group_info for svga, radeon and freedreno V3 (global changes): - Re-organize the series according to hints of Ilia Mirkin -

[Mesa-dev] [PATCH 14/15] nvc0: make begin_query return false when all MP counters are used v2

V2: - do not return immediately after nvc0_mp_pm_query_end() in order to set the current state of the given query Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info v4

This enables GL_AMD_performance_monitor for freedreno. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info V4: - add FD_QUERY_COUNT in freedreno_query.h Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno

[Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info v4

This enables GL_AMD_performance_monitor for svga. V2: - s/pipe_context/pipe_screen in the commit msg V3: - use util_get_driver_query_group_info V4: - add SVGA_QUERY_COUNT in svga_context.h Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/svga/svga_context.h

[Mesa-dev] [PATCH 05/15] gallium: make pipe_context::begin_query return a boolean

This can be used to check if a query is unable to start. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno/freedreno_query_hw.c | 3

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

Bump, is someone want to make a review of this patch set ? Especially the core stuff... On 03/09/2015 10:09 PM, Samuel Pitoiset wrote: Hello, A series I have waited too long to re-submit, but I recently refactored the code and fixed some minor issues. This patchset enables

[Mesa-dev] [PATCH v2 04/15] gallium: replace pipe_driver_query_info::max_value by a union

This allows queries to return different numeric types. Signed-off-by: Samuel Pitoiset samuel.pitoiset at gmail.com --- src/gallium/auxiliary/hud/hud_driver_query.c| 3 ++- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 9

[Mesa-dev] [PATCH v2 00/15] GL_AMD_performance_monitor

GL_AMD_performance_monitor Samuel Pitoiset (14): gallium: add pipe_screen::get_driver_query_group_info gallium: add new fields to pipe_driver_query_info gallium: add new numeric types to pipe_query_result gallium: replace pipe_driver_query_info::max_value by a union gallium: make pipe_context

[Mesa-dev] [PATCH v2 08/15] svga: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for svga. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/svga/svga_context.h | 1 + src/gallium/drivers/svga/svga_screen.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/gallium/drivers/svga

[Mesa-dev] [PATCH v2 02/15] gallium: add new fields to pipe_driver_query_info

According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. v2: add PIPE_DRIVER_QUERY_TYPE_BYTES Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v2 09/15] freedreno: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for freedreno. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com Reviewed-by: Rob Clark robcl...@freedesktop.org --- src/gallium/drivers/freedreno/freedreno_query.c | 9 + src/gallium/drivers/freedreno/freedreno_query.h | 1 + 2 files

[Mesa-dev] [PATCH v2 03/15] gallium: add new numeric types to pipe_query_result

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index

[Mesa-dev] [PATCH v2 10/15] radeon: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for radeon. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com Reviewed-by: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 2 files changed, 10

[Mesa-dev] [PATCH v2 07/15] gallium: add util_get_driver_query_group_info

This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 50

[Mesa-dev] [PATCH v2 05/15] gallium: make pipe_context::begin_query return a boolean

GL_AMD_performance_monitor must return an error when a monitoring session cannot be started. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers

[Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

. Drivers must implement get_driver_query_group_info and get_driver_query_info in order to enable this extension. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_cb_perfmon.c | 455

[Mesa-dev] [PATCH v2 01/15] gallium: add pipe_screen::get_driver_query_group_info

by GL_AMD_performance monitor. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/docs/source/screen.rst | 10 ++ src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 3 files changed, 28 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v2 12/15] docs: mark GL_AMD_performance_monitor for the 10.6.0 release

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno, r600 and radeonsi. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- docs/relnotes/10.6.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html index 005

[Mesa-dev] [PATCH v2 13/15] nvc0: expose more driver-specific query groups

This patch exposes Driver statistics and MP counters groups. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 -- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 11 + 2 files changed, 69 insertions

[Mesa-dev] [PATCH v2 11/15] nvc0: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for nvc0. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 +++ 3 files

[Mesa-dev] [PATCH v2 15/15] nvc0: all queries use an unsigned 64-bits integer by default

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index c3a1899

[Mesa-dev] [PATCH v2 14/15] nvc0: make begin_query return false when all MP counters are used

Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index a63a740

Re: [Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

On 03/18/2015 06:13 PM, Marek Olšák wrote: The Gallium interface looked good to me (except where I replied). Sorry, I probably won't have time to review the st/mesa patch. Ok, thank you. I'll submit a v2 for that. Marek On Wed, Mar 18, 2015 at 5:00 PM, Samuel Pitoiset samuel.pitoi

Re: [Mesa-dev] [PATCH] gallium/targets/d3dadapter9: drop the libdrm prefix for drm.h

Looks good to me. :) On 03/20/2015 10:20 PM, Emil Velikov wrote: The path is provided by libdrm.pc and already used appropriately by the build system. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/targets/d3dadapter9/drm.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.6.0 release

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno, r600 and radeonsi. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- docs/relnotes/10.6.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html index a396109

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com --- src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On 03/09/2015 11:00 PM, Marek Olšák wrote: If you plan to add more functions, this file can stay. Yes, it's my plan. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add

  1   2   3   4   5   6   7   8   9   10   >