Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[Alexandros Frantzis]

On Fri, Jun 23, 2017 at 06:50:49PM +0300, alexandros.frant...@collabora.com 
wrote:
> From: Alexandros Frantzis 
> 
> Improve the surface format support in the Wayland Vulkan WSI, by
> automating the matching between wl_drm and Vulkan formats. The same
> mechanism can be used to improve format support in vulkan/wsi/x11
> (in a future patchset).

Hi all,

I would like to discuss the best way to move forward with the
improvements to the format support in the Vulkan WSI.

My understanding is that the main concern about the proposed patchset is
the introduction of another format description mechanism. In light of
that, I would like to get opinions on the following two alternatives for
moving forward, and of course I am open to other suggestions.

1. Now that I am aware of amd/vulkan/vk_format.h (thanks Dave), I think
   it will be a good base to provide the needed functionality. We could
   extract it to vulkan/util and use it as the common representation.
   We will still need to express native formats in this common
   representation (taking into account endianness etc) and we will also
   need code to perform the matching correctly.

2. Instead of making this mapping at runtime, we can use similar logic
   to automatically produce code that provides the same functionality
   and just commit that. This is fine for wayland that uses a
   predefined set of formats, but more complicated for X11 where
   formats are described as bitmasks.

Thanks,
Alexandros
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[Alexandros Frantzis]

On Tue, Jun 27, 2017 at 04:33:04PM -0700, Chad Versace wrote:
> On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote:
> > From: Alexandros Frantzis 
> > 
> > Improve the surface format support in the Wayland Vulkan WSI, by
> > automating the matching between wl_drm and Vulkan formats. The same
> > mechanism can be used to improve format support in vulkan/wsi/x11
> > (in a future patchset).
> 
> Thanks for attacking this problem, and attempting to fix the format
> hacks in wsi_common_wayland.c.
> 
> I suspect that the two of us have significant differences in our
> interpretation of VkFormat bit-layouts. I've responded to patch 1/1 with
> a lot of comments and questions. Hopefully we can untangle our format
> interpretations and we reach a common understanding.

Hi Chad,

thanks for the review!

I have replied to your review of [PATCH 1/2] with a more detailed
explanation of my rationale and implementation choices, which will
hopefully help us reach a common understanding (and perhaps help to
clear any misconceptions I may have).

Thanks,
Alexandros

> 
> > 
> > Alexandros Frantzis (2):
> >   vulkan/util: Introduce format utilities
> >   vulkan/wsi/wayland: Use the format utilities to find compatible
> > VkFormats
> > 
> >  src/vulkan/Makefile.sources |   2 +
> >  src/vulkan/util/vk_format_util.c| 173 
> > +++
> >  src/vulkan/util/vk_format_util.h| 100 
> >  src/vulkan/wsi/wsi_common_wayland.c | 178 
> > ++--
> >  4 files changed, 366 insertions(+), 87 deletions(-)
> >  create mode 100644 src/vulkan/util/vk_format_util.c
> >  create mode 100644 src/vulkan/util/vk_format_util.h
> > 
> > -- 
> > 2.11.0
> > 
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[Chad Versace]

On Fri 23 Jun 2017, alexandros.frant...@collabora.com wrote:
> From: Alexandros Frantzis 
> 
> Improve the surface format support in the Wayland Vulkan WSI, by
> automating the matching between wl_drm and Vulkan formats. The same
> mechanism can be used to improve format support in vulkan/wsi/x11
> (in a future patchset).

Thanks for attacking this problem, and attempting to fix the format
hacks in wsi_common_wayland.c.

I suspect that the two of us have significant differences in our
interpretation of VkFormat bit-layouts. I've responded to patch 1/1 with
a lot of comments and questions. Hopefully we can untangle our format
interpretations and we reach a common understanding.

> 
> Alexandros Frantzis (2):
>   vulkan/util: Introduce format utilities
>   vulkan/wsi/wayland: Use the format utilities to find compatible
> VkFormats
> 
>  src/vulkan/Makefile.sources |   2 +
>  src/vulkan/util/vk_format_util.c| 173 +++
>  src/vulkan/util/vk_format_util.h| 100 
>  src/vulkan/wsi/wsi_common_wayland.c | 178 
> ++--
>  4 files changed, 366 insertions(+), 87 deletions(-)
>  create mode 100644 src/vulkan/util/vk_format_util.c
>  create mode 100644 src/vulkan/util/vk_format_util.h
> 
> -- 
> 2.11.0
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[alexandros . frantzis]

From: Alexandros Frantzis 

Improve the surface format support in the Wayland Vulkan WSI, by
automating the matching between wl_drm and Vulkan formats. The same
mechanism can be used to improve format support in vulkan/wsi/x11
(in a future patchset).

Alexandros Frantzis (2):
  vulkan/util: Introduce format utilities
  vulkan/wsi/wayland: Use the format utilities to find compatible
VkFormats

 src/vulkan/Makefile.sources |   2 +
 src/vulkan/util/vk_format_util.c| 173 +++
 src/vulkan/util/vk_format_util.h| 100 
 src/vulkan/wsi/wsi_common_wayland.c | 178 ++--
 4 files changed, 366 insertions(+), 87 deletions(-)
 create mode 100644 src/vulkan/util/vk_format_util.c
 create mode 100644 src/vulkan/util/vk_format_util.h

-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[alexandros . frantzis]

From: Alexandros Frantzis 

Improve the surface format support in the Wayland Vulkan WSI, by
automating the matching between wl_drm and Vulkan formats. The same
mechanism can be used to improve format support in vulkan/wsi/x11
(in a future patchset).

Alexandros Frantzis (2):
  vulkan/util: Introduce format utilities
  vulkan/wsi/wayland: Use the format utilities to find compatible
VkFormats

 src/vulkan/Makefile.sources |   2 +
 src/vulkan/util/vk_format_util.c| 173 +++
 src/vulkan/util/vk_format_util.h| 100 
 src/vulkan/wsi/wsi_common_wayland.c | 178 ++--
 4 files changed, 366 insertions(+), 87 deletions(-)
 create mode 100644 src/vulkan/util/vk_format_util.c
 create mode 100644 src/vulkan/util/vk_format_util.h

-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev