Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

Hi, On 28 June 2017 at 19:09, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 10:59 AM, Daniel Stone wrote: >> i965 tries pretty hard to allocate sRGB images in the pre-DRIImage, >> DRI2 (as in the X11 protocol named 'DRI2') codepath, but this isn't

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Wed, Jun 28, 2017 at 11:09 AM, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 10:59 AM, Daniel Stone > wrote: > >> Hi, >> >> On 28 June 2017 at 16:35, Jason Ekstrand wrote: >> > On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Wed, Jun 28, 2017 at 10:59 AM, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 16:35, Jason Ekstrand wrote: > > On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone > wrote: > >> On 28 June 2017 at 02:05, Jason Ekstrand

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

Hi, On 28 June 2017 at 16:35, Jason Ekstrand wrote: > On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone wrote: >> On 28 June 2017 at 02:05, Jason Ekstrand wrote: >> > The long answer is that the DRI formats do not specify a

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Wed 28 Jun 2017, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 02:05, Jason Ekstrand wrote: > > Would you feel more comfortable with a boolean sRGB parameter? That would > > make the answers to the above questions much more obvious at the cost of > > some code. > >

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Wed, Jun 28, 2017 at 4:06 AM, Daniel Stone wrote: > Hi, > > On 28 June 2017 at 02:05, Jason Ekstrand wrote: > The long answer is that the DRI formats do not specify a colorspace. > > Also, strictly speaking, the DRI_IMAGE_FORMAT_* tokens don't

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

Hi, On 28 June 2017 at 02:05, Jason Ekstrand wrote: > The long answer is that the DRI formats do not specify a colorspace. Also, strictly speaking, the DRI_IMAGE_FORMAT_* tokens don't specify a colourspace, nor do the DRM FourCC tokens. DRI_IMAGE_FOURCC_* is equivalent to

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

Hi, On 28 June 2017 at 02:05, Jason Ekstrand wrote: > On Tue, Jun 27, 2017 at 12:49 PM, Chad Versace > wrote: >> In patch "i965: Use create_for_dri_image in intel_update_image_buffer", >> I see that you pass intel_rb_format(rb) down as the

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Tue, Jun 27, 2017 at 12:49 PM, Chad Versace wrote: > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > >

Re: [Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

On Fri 16 Jun 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 ++- > src/mesa/drivers/dri/i965/intel_tex_image.c | 3 ++- > 4 files