Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Thorsten Munsch
Hi all, I've done a lot of sessions with the current 1.12 branch. Just want to mention that the stability is impressive. I haven't found any bugs yet. :) If I can help with testing for the further 1.12 release, let me know. On the weekend I will watch for some (easy) bugs to solve. Am

Re: [Mixxx-devel] Accessing TrackModel

2015-10-15 Thread Trevor Hansen
+1 for this idea as well. On Thu, Oct 15, 2015 at 1:09 AM, Daniel Schürmann wrote: > Hi JAmes, > > Thank you for contributing to Mixxx. > > I am not 100 % clear what how the final feature will look like. > > Is it similar to https://bugs.launchpad.net/mixxx/+bug/1505408 ? >

[Mixxx-devel] Accessing TrackModel

2015-10-15 Thread JAmes Atwill
Hi, I've been wanting a feature in AutoDJ where the total duration of the selected tracks would be visible somewhere so I can estimate how much of a set I've put together. I thought this would be a decent way to dive into C++, Qt and associated tooling. I've connected the trackSelected signal to

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Daniel Schürmann
My latest commit, trying to fix the wchat_t windows issue is on 1.12 branch only. I will merge the 1.12 to master once 1.12 builds on windows. Unfortunately I have no access to the build server (network timeout) Since there are no recent windows builds builds on

Re: [Mixxx-devel] Accessing TrackModel

2015-10-15 Thread Daniel Schürmann
Hi JAmes, Thank you for contributing to Mixxx. I am not 100 % clear what how the final feature will look like. Is it similar to https://bugs.launchpad.net/mixxx/+bug/1505408 ? If yes, you may describe your feature there and assign the bug to yourselves. If not file a new one. The duration for

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Owen Williams
The build server was having network problems so I bought a new network card. I've started a new build, we'll see if it works. On Thu, 2015-10-15 at 08:42 +0200, Daniel Schürmann wrote: > My latest commit, trying to fix the wchat_t windows issue is on 1.12 > branch only. > > > I will merge the

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Owen Williams
Windows build failure: Ilib\fidlib-0.9.10 /IC:\usr\include\taglib /Ilib\hidapi-0.8.0-pre \hidapi /Ilib\xwax /Ilib\scratchlib /Ilib\vamp-2.3 soundsourcemediafoundation.cpp c:\mixxx\environments\2.0-x64-debug\include\taglib\trefcounter.h(36) : warning C4005: 'NOMINMAX' : macro redefinition

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
As we are in a #ifdef _WIN32, why not using native static_assert ? https://msdn.microsoft.com/fr-fr/library/dd293588.aspx sb Le 15/10/2015 22:05, Daniel Schürmann a écrit : > Thank you. > > I have fixed the issue and have a working STATIC_ASSERT > just build local, will commit next. > > > Am

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
Still failing: cl : Ligne de commande warning D9002 : option '/arch:SSE2' inconnue ignorée audiotagger.cpp d:\mixxx-buildserver64\include\taglib\trefcounter.h(36) : warning C4005: 'NOMINMAX' : redéfinition de macro arguments de ligne de commande : voir la définition précédente de

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
in fact, both of them need to be replaced with TAGLIB_FILENAME_FROM_QSTRING(getFilename()) sb Le 16/10/2015 00:24, Sébastien Blaisot a écrit : > sorry, wrong line. > > I meant > https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 > >

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann
New version is up: https://github.com/mixxxdj/mixxx/commit/316e7e9900e03a7c331db6ebdf03d5c16c323651 Am 15.10.2015 um 22:00 schrieb Owen Williams: > Still failing: > > > cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' > soundsourcemediafoundation.cpp > >

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann
Is this available on VC without c++11 support? Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: > As we are in a #ifdef _WIN32, why not using native static_assert ? > https://msdn.microsoft.com/fr-fr/library/dd293588.aspx > > sb > > Le 15/10/2015 22:05, Daniel Schürmann a écrit : >> Thank you.

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
I finally got it compile on my machine. I sent a PR with all the changes I made : https://github.com/mixxxdj/mixxx/pull/743 sb Le 16/10/2015 00:31, Sébastien Blaisot a écrit : > in fact, both of them need to be replaced with > TAGLIB_FILENAME_FROM_QSTRING(getFilename()) > > sb > > Le

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Daniel Schürmann
Thank you. I have fixed the issue and have a working STATIC_ASSERT just build local, will commit next. Am 15.10.2015 um 22:00 schrieb Owen Williams: > Still failing: > > > cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' > soundsourcemediafoundation.cpp > >

[Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Owen Williams
Still failing: cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2' soundsourcemediafoundation.cpp c:\mixxx\environments\2.0-x64-release\include\taglib\trefcounter.h(36) : warning C4005: 'NOMINMAX' : macro redefinition command-line arguments : see previous definition

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
Probably you also need to patch this : https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 I have a link-time error (unresolved external symbol) for soundsourcemediafoundation sb Le 15/10/2015 23:59, Daniel Schürmann a écrit : >

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
I have no idea. It is available in Visual Studio 2010, 2012, 2013 and 2015 https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist but I don't know if it is dependant of an option at compile time. I know it works perfectly for me, out of the box (no special configuration for VC)

Re: [Mixxx-devel] 1.12 windows build fixing

2015-10-15 Thread Sébastien Blaisot
It seems to be compiling fine if you replace STATIC_ASSERT(sizeof(wchar_t) == sizeof(QChar)); with static_assert(sizeof(wchar_t) == sizeof(QChar), "wchar_t is not the same size than QChar"); and remove STATIC_ASSERT definition in src/util/assert.h sb Le 15/10/2015 23:41, Sébastien Blaisot

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-15 Thread Sébastien Blaisot
Le 15/10/2015 08:42, Daniel Schürmann a écrit : > Unfortunately I have no access to the build server (network timeout) > Since there are no recent windows builds builds on > http://downloads.mixxx.org/builds/1.12/ > I assume there is still an issue. Can one forward me the failing build > message?