Re: [Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Josep Maria Antolin
The fix worked for mixxx.cpp, but the whole compilation didn't succeed due to time limit. - Ran for 47 min 4 sec - https://travis-ci.org/mixxxdj/mixxx/jobs/319868872 Although the linux compile needed just 29 minutes for build and test and there's also these notable differences: Time to

Re: [Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Josep Maria Antolin
Ok, I've opened the pull request https://github.com/mixxxdj/mixxx/pull/1435 Changed the method signature as suggested, and fixed two other warnings, including the widgethider one. ​ -- Check out the vibrant tech community

Re: [Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Olaf Hering
On Thu, Dec 21, Sébastien BLAISOT wrote: > can anyone fix this ? While you guys fix build errors, please decide what kind of boolean src/util/widgethider.cpp::eventFilter() should return: true, of false, or "lass Dich überraschen". Thanks. Olaf signature.asc Description: PGP signature

Re: [Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Sébastien BLAISOT
ok, that makes sense, brew installed QT 5.9.3 on the last sucessful build and it now installs qt 5.10.0 which make our build fail. So it wil be the same whatever os you use, it's juste related to qt version. Do you have fun to work on this Josep ? in the meantime, I will see if I can update

Re: [Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Josep Maria Antolin
I saw it and I think the cause is that Qthread now has a create () method that is conflicting with our previous create () method in SingletonInstance, of whoch Statsmanager extends. We need to modify SingletonInstance and change the create method to createInstance () , for example. I don't have

[Mixxx-devel] travis MacOS build failing

2017-12-21 Thread Sébastien BLAISOT
Hi, our travis macOS build fails with the following error: src/mixxx.cpp:128:23: error: C++ requires a type specifier for all declarations StatsManager::create(); ^ can anyone fix this ? here is the full output for clang on this file: [CXX] src/mixxx.cpp src/mixxx.cpp:128:23: error: