Re: [Mixxx-devel] Another advocate for testing

2013-11-29 Thread Owen Williams
I updated the wiki page... is that enough explanation? The hard part about writing tests is setting up the environment and I don't think that's something I can explain easily. I can describe how I wrote mockedenginebackendtest.h if you like. On Wed, 2013-11-27 at 13:51 -0800, Sean M. Pappalardo

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread Sean M. Pappalardo - D.J. Pegasus
On 11/27/2013 07:20 AM, Owen Williams wrote: > It took me a whole day just to figure out how to > set up and tear down the engine backend, but it was worth it. Would you mind terribly updating the wiki page (http://mixxx.org/wiki/doku.php/unit_tests) with an explained example, maybe the one y

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread Gavin Swanson
Looks like there is a little post-processing required to convert gtest's xml to JTest format. http://stackoverflow.com/a/14074664/1006048 We also use jenkins to periodically run a large battery of tests on the code and spit the results to various formats that feed into SonarQube. We've found a lo

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread RJ Ryan
Hi Gavin, The test suite is cross platform (we use gtest/gmock). You can build it with scons test=1. Switching away from Jenkins would be a lot of work. We have Windows, Mac and Linux buildbots building every commit. Running the test suite on every build is definitely feasible. Last time I worked

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread Gavin Swanson
Typically you'd want to run the test suite against every potential push to master. And then periodically on master to catch anything that comes in as a result of merges etc. I haven't looked at the test suite yet. Will it only run under linux? That would seem like a supremely sub-optimal solution

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread Max Linke
On Wed, 2013-11-27 at 20:26 +0200, Tuukka Pasanen wrote: > > Can we also have jenkins build and run the test-suite automatically on > > every push to the master branch? That way it would be easier to detect > > accidental regressions. > Hello, > We are using buildbot and it's much more simpler to

Re: [Mixxx-devel] Another advocate for testing

2013-11-27 Thread Max Linke
I can only second that. I made the same experience when writing my extension to support multiply folders in the library. Can we also have jenkins build and run the test-suite automatically on every push to the master branch? That way it would be easier to detect accidental regressions. best Max