I wrote:
I found something strange in my test:
Error at line 2341764, col 41
Bad file format: 63240004.osm.gz
Exception in thread main java.lang.NullPointerException
at uk.me.parabola.mkgmap.combiners.FileInfo.getFileInfo
(FileInfo.java:136)
at
Marko,
If nobody opposes, I will commit the patch.
Fine, but why not hang on for a while and give people a chance to try
it out and report back before it gets committed.
Mark
___
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
Mark,
Marko,
If nobody opposes, I will commit the patch.
Fine, but why not hang on for a while and give people a chance to try
it out and report back before it gets committed.
Sure, it is a non-trivial change to the algorithm. What about one week?
If I forget, WanMil please remind
Hello Marko,
Sure, it is a non-trivial change to the algorithm. What about one week?
If I forget, WanMil please remind me. :-)
My rule of thumb for committing non-trivial changes goes along the
lines of:
if you receive negative reports, either fix the patch or convince the
reporter
I too ran into problems using the patch (on Austria from geofabrik):
java.lang.NullPointerException
at
uk.me.parabola.mkgmap.reader.osm.MultiPolygonRelation.cutOutInnerPolygons(MultiPolygonRelation.java:892)
at
Hi Felix, WanMil,
Maybe both Marko and me am using some other patches that break
something here?
The only other patch I have on top of r1584 default style is the
translation of traffic_calming=* in the POI file. No changes to the
code.
Could it be some hard-to-trigger race condition? I
The patch reduces the number of cuts that must be performed for each
inner polygon. The current code performs one cut for each inner polygon.
The patch reduces the number of cuts by selecting cut lines that hit
more than one inner polygon at once.
This has two advantages:
1. The artefacts on
Hi WanMil,
This has two advantages:
1. The artefacts on the cut lines in Mapsource are reduced because
there are less cut lines.
2. The performance of the mp code for large multipolygons is very
much dependend on how many cuts must be performed.
A third advantage: the image file might
