Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-13 Thread RocketMan
Will this patch be part of the regular release? RocketMan - Original Message - From: WanMil wmgc...@web.de To: Development list for mkgmap mkgmap-dev@lists.mkgmap.org.uk Sent: Thursday, August 29, 2013 9:22 PM Subject: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-04 Thread WanMil
ref, int_ref, nat_ref and ref_ref is already moved to the style file in the branch. They are composed to mkgmap:ref. exit:facility, exit:road_ref and exit:to might also be removed by assigning new tags mkgmap:exit_facility, mkgmap:exit_road_ref and mkgmap:exit_to. But the question is: are

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-04 Thread Henning Scholland
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Am 04.09.2013 20:16, schrieb WanMil: junction is used to detect roundabouts. We could map that to mkgmap:junction but I am not sure if that really helps? Maybe it would help in the point, that mkgmap internally only handels tags with mkgmap:*.

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-04 Thread WanMil
Do you know if remapping eg. oneway=* to mkgmap:oneway=* costs more runtime? In theory definitely yes, but I am not sure if the difference is noticeable. WanMil ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-03 Thread WanMil
] Move maxspeed calculations to style file Felix only downwards, is what everyone expects, but not what mkgmap did Felix so far. I critisized this quite often in the past Thanks Felix - that's what I wanted to know. I obviously overlooked your previous complaints! The style

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-03 Thread Felix Hartmann
couldn't the int_ref, nat_ref, exit:to and junction also be moved to the style-file? oneway seems to me the only thing, that cannot be moved to the style-file - or better would need some additional mkgmap:oneway command and be a bit more complicated (values like -1 or reverse, or 1) On

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-02 Thread Greg Troxel
Manfred Brenneisen manfred.brennei...@gmx.net writes: Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information included in OSM data: I think we do need tags for

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-02 Thread Henning Scholland
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 01.09.2013 23:29, schrieb Manfred Brenneisen: You do a great job, and I really appreciate your work Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-02 Thread Manfred Brenneisen
Hi, Am 01.09.2013 23:29, schrieb Manfred Brenneisen: You do a great job, and I really appreciate your work Thinking about maxspeed:practical, which can be used to initialize maxspeed in some cases, I thought about rural areas, which do not have any maxspeed, or maxspeed:practical information

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-09-01 Thread Manfred Brenneisen
An:Development list for mkgmap mkgmap-dev@lists.mkgmap.org.uk Betreff:Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file Felix only downwards, is what everyone expects, but not what mkgmap did Felix so far. I critisized this quite often in the past Thanks Felix - thats what I

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread Henning Scholland
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Toby, the patch shouldn't change that much. If you actually use - --ignore-maxspeed, then you havn't to change anything. If you actually don't use --ignore-maxspeed, then you'll need to add a rule like maxspeed=* { set mkgmap:maxspeed =

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread Felix Hartmann
only downwards, is what everyone expects, but not what mkgmap did so far. I critisized this quite often in the past Now you can make rules to actually only use maxspeed to decrease the road-speed The actual importance of maxspeed only downwards was in practice better then in theory, as

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread Toby Speight
0 In article 522050a9.5010...@gmail.com, 0 Felix Hartmann URL:mailto:extremecar...@gmail.com (Felix) wrote: Felix only downwards, is what everyone expects, but not what mkgmap did Felix so far. I critisized this quite often in the past Thanks Felix - that's what I wanted to know. I

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread WanMil
So what you really want to avoid is what was hapenning, now you can set it yourself... So the default should rather be: maxspeed=* maxspeedkmh() 110 highway=motorway { set mkgmap:road-speed-class = 7 } maxspeed=* mkgmap:road-speed-class!=* maxspeedkmh()

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread WanMil
Felix only downwards, is what everyone expects, but not what mkgmap did Felix so far. I critisized this quite often in the past Thanks Felix - that's what I wanted to know. I obviously overlooked your previous complaints! The style rules you present do look quite unwieldy - perhaps

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-30 Thread WanMil
Just to confirm - this affects only the *max* speed, correct? So if my defaults for single-track unclassified roads suggest 40mph, but tags say we're allowed to do up to 60mph (both quite reasonable here in Scotland, where the National Speed Limit is unattainable on many roads), then the map

[mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-29 Thread WanMil
The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class. This makes the ignore-maxspeeds option superfluous. Anyhow I have kept it to ignore the evaluation of the

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-29 Thread Steve Ratcliffe
Hi WanMil The patch moves the road speed calculations based on the maxspeed tag to the style file. It uses the new maxspeedkmh function to calculate the new internal tag mkgmap:road-speed-class. Have only glanced at the code, but I heartily approve of removing as many hard-wired tags from

Re: [mkgmap-dev] [PATCH v2] Move maxspeed calculations to style file

2013-08-29 Thread Toby Speight
Just to confirm - this affects only the *max* speed, correct? So if my defaults for single-track unclassified roads suggest 40mph, but tags say we're allowed to do up to 60mph (both quite reasonable here in Scotland, where the National Speed Limit is unattainable on many roads), then the map