Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-07 Thread Gerd Petermann
Hi Steve, this problem is still open. I think the patch is okay, only the tests are not. Gerd Date: Tue, 3 Feb 2015 13:27:35 + From: st...@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules Hi Gerd If you

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-03 Thread Steve Ratcliffe
Hi Gerd If you think it should be working we would need a method to reset the field current in all LinkedOps so that they are evaluated again for the same Element instance. Ahh, OK thanks I see. I will just create a new Element copy for that stage of the test then. ..Steve

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread A drian
I can confirm that all of these work with my example: http://files.mkgmap.org.uk/download/244/mkgmap.jar http://files.mkgmap.org.uk/download/245/mkgmap.jar http://files.mkgmap.org.uk/download/247/mkgmap.jar Adrian

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Steve Ratcliffe
Hi I found a place in the code which only dealt with a single OR. Changing that to deal with any number seems to fix the problem. There is however a problem that a test fails. It does not appear to be directly related to the fix, since it only occurs when resolving the same way with different

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Steve Ratcliffe
Hi Gerd @Steve: Please review, I've added a new field matched to WatchableTypeResult but I think the field found was already intended for this? Maybe you find a better place to fix this? The problem with OR leading to multiple matches is supposed to be handled by LinkedOp. Something does

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Gerd Petermann
Date: Mon, 2 Feb 2015 23:26:09 + From: st...@parabola.me.uk To: mkgmap-dev@lists.mkgmap.org.uk Subject: Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules Hi I found a place in the code which only dealt with a single OR. Changing that to deal with any number seems to fix

[mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Gerd Petermann
Hi all, as A drian pointed out here: http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html we have a bug in the style evaluation system. The attached patch makes sure that each rule is only evaluated once for one element. If I got it right the problem occurs with rules