Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread A drian
I can confirm that all of these work with my example: http://files.mkgmap.org.uk/download/244/mkgmap.jar http://files.mkgmap.org.uk/download/245/mkgmap.jar http://files.mkgmap.org.uk/download/247/mkgmap.jar Adrian

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Steve Ratcliffe
Hi I found a place in the code which only dealt with a single OR. Changing that to deal with any number seems to fix the problem. There is however a problem that a test fails. It does not appear to be directly related to the fix, since it only occurs when resolving the same way with different

Re: [mkgmap-dev] Commit: r3436: use not-contained filter to avoid duplicated values in route_ref,

2015-02-02 Thread A drian
Gerd, Thank you. I can confirm that r3436 works with my example. Adrian ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Steve Ratcliffe
Hi Gerd @Steve: Please review, I've added a new field matched to WatchableTypeResult but I think the field found was already intended for this? Maybe you find a better place to fix this? The problem with OR leading to multiple matches is supposed to be handled by LinkedOp. Something does

Re: [mkgmap-dev] Bug in handling of bus stops

2015-02-02 Thread Bernd Weigelt
Am Montag, 2. Februar 2015, 10:27:46 schrieb Gerd Petermann: Hi Bernd, you can enable logging with uk.me.parabola.mkgmap.osmstyle.RuleSet.level=FINE and look for messages containing this: skipping part of rule Hello Gerd Wow, made a fast test with my Bonn extract, 1 GB logfiles with

Re: [mkgmap-dev] Bug in handling of bus stops

2015-02-02 Thread Gerd Petermann
Hi Bernd, I think that is plausible. The problem should not appear often, else someone would have complained earlier. Gerd From: weigelt.be...@web.de To: mkgmap-dev@lists.mkgmap.org.uk Date: Mon, 2 Feb 2015 10:50:32 +0100 Subject: Re: [mkgmap-dev] Bug in handling of bus stops Am Montag,

Re: [mkgmap-dev] FW: Lines distorted

2015-02-02 Thread Gerd Petermann
Hi Dave, I agree that these options are difficult to understand. The options -- polygon-size-limits and -- min-size-polygon use the size of the bounding box of an object. The size is measured in Garmin units. With the style rules you specify the resolutions at which an object should be drawn.

Re: [mkgmap-dev] Firmware V4.00 on new Marine Devices

2015-02-02 Thread Gerd Petermann
Hi Jürgen, see link below. The jar file contains also the style files. http://files.mkgmap.org.uk/download/246/mkgmap.jar Gerd From: rheinskipper1...@gmx.de To: mkgmap-dev@lists.mkgmap.org.uk Date: Mon, 2 Feb 2015 16:06:55 +0100 Subject: [mkgmap-dev] Firmware V4.00 on new Marine Devices

[mkgmap-dev] Firmware V4.00 on new Marine Devices

2015-02-02 Thread RheinSkipper
Dear list Garmin recently released a major firmware update (v 4.0) for the Echomap and newest GPSmap marine series. http://newsroom.garmin.com/press-release/marine/garmin-gpsmap-and-echomap-pr oduct-lines-receive-new-features After the firmware update my current charts fail with a “map

Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Gerd Petermann
Hi Steve, reg. the failed test: I think you can change the test because StyledConverter doesn't do this (at least not now). If you think it should be working we would need a method to reset the field current in all LinkedOps so that they are evaluated again for the same Element instance. Gerd

Re: [mkgmap-dev] Public transport

2015-02-02 Thread Gerd Petermann
Hi all, I think (1) is still open. I have no idea if the proposed change will also work better for other countries? Gerd From: ar2988...@outlook.com To: mkgmap-dev@lists.mkgmap.org.uk Date: Sun, 1 Feb 2015 12:07:53 + Subject: [mkgmap-dev] Public transport I posted to the list last

[mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules

2015-02-02 Thread Gerd Petermann
Hi all, as A drian pointed out here: http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html we have a bug in the style evaluation system. The attached patch makes sure that each rule is only evaluated once for one element. If I got it right the problem occurs with rules

Re: [mkgmap-dev] Bug in handling of bus stops

2015-02-02 Thread Bernd Weigelt
Am Sonntag, 1. Februar 2015, 11:42:38 schrieb GerdP: This is clearly not intended and should be fixed. Hi FYI Franco fixed this in May 2014 in our style with this workaround https://github.com/berndw1960/aiostyles/commit/0209b139bd7ec07ff24a31d86ba30194b5b2f268 public_transport=platform

[mkgmap-dev] [Patch v2] avoid duplicate evaluation of rules

2015-02-02 Thread Gerd Petermann
Hi all, cosmetic change : always report the new rule-id field in the style stats. binary: http://files.mkgmap.org.uk/download/245/mkgmap.jar Gerd no-dup-rule-evaluation-v2.patch Description: Binary data ___

Re: [mkgmap-dev] Bug in handling of bus stops

2015-02-02 Thread Gerd Petermann
Hi Bernd, you can enable logging with uk.me.parabola.mkgmap.osmstyle.RuleSet.level=FINE and look for messages containing this: skipping part of rule Gerd From: weigelt.be...@web.de To: mkgmap-dev@lists.mkgmap.org.uk Date: Mon, 2 Feb 2015 10:19:13 +0100 Subject: Re: [mkgmap-dev] Bug in