Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

> On 19 Nov 2015, at 22:16, Michael Haupt wrote: > > Hi John, Paul, > > thanks for your reviews - they have helped me polish the code and > documentation some more and add some more tests. The result is at > http://cr.openjdk.java.net/~mhaupt/8139885/webrev.02 >

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

HI Michael, Nice work, not easy this area! It may be worth considering, as a separate issue, updating the example section in JavaDoc to be under @apiNote. I have a mild preference to maintain the 80 char limit for JavaDoc, to me it’s easier to read. For code i don’t mind a 100 or more limit.

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

Hi John, Paul, thanks for your reviews - they have helped me polish the code and documentation some more and add some more tests. The result is at http://cr.openjdk.java.net/~mhaupt/8139885/webrev.02 I noticed both of you emphasised how the Streams API helps the implementation - I second

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

Hi Vladimir, > Am 17.11.2015 um 13:08 schrieb Vladimir Ivanov : > Awesome! Looks really good, Michael! thank you very much. > src/java.base/share/classes/java/lang/invoke/MethodHandles.java: > if (!hasPrivateAccess() > || (specialCaller

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

On Nov 13, 2015, at 8:39 AM, Michael Haupt wrote: > > Dear all, > > please review this change. > RFE: https://bugs.openjdk.java.net/browse/JDK-8139885 > Corresponding JEP: https://bugs.openjdk.java.net/browse/JDK-8130227 > Webrev:

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

Awesome! Looks really good, Michael! src/java.base/share/classes/java/lang/invoke/MethodHandles.java: if (!hasPrivateAccess() || (specialCaller != lookupClass() + // ensure non-abstract methods in superinterfaces can be special-invoked +

RFR(L): 8139885: implement JEP 274: enhanced method handles

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8139885 Corresponding JEP: https://bugs.openjdk.java.net/browse/JDK-8130227 Webrev: http://cr.openjdk.java.net/~mhaupt/8139885/webrev.00/ Thanks, Michael -- Dr. Michael Haupt |