Re: Module Naming
You should have what type of device in the name too. The fact that it works with serial port is not interesting and can be made clear in a sub module if multiple communication medium exist. Device::Inverter::Aurora Be more specific in the top classes if you can. The idea is to have a name for your module and still let other people use the top same classification Device::Inverter::Solar::Aurora::PVI-3 later you can make it clear that you support serial communication if it has any importance Device::Inverter::Solar::Aurora::PVI-3::Protocol::Serial IMO, Device::Serial::Protocol::Aurora describes a device which purpose it to be a generic serial interface. It _really_ doesn't matter if the module name is a mouth full. Nadim.
Re: Module Naming
Aurora is a type of inverter and serial is type of aurora however if inheriting Device::Serial put that first Device::Serial::Inverter::Aurora --Original Message-- From: nadim khemir To: module-authors@perl.org Sent: Oct 5, 2010 2:58 AM Subject: Re: Module Naming You should have what type of device in the name too. The fact that it works with serial port is not interesting and can be made clear in a sub module if multiple communication medium exist. Device::Inverter::Aurora Be more specific in the top classes if you can. The idea is to have a name for your module and still let other people use the top same classification Device::Inverter::Solar::Aurora::PVI-3 later you can make it clear that you support serial communication if it has any importance Device::Inverter::Solar::Aurora::PVI-3::Protocol::Serial IMO, Device::Serial::Protocol::Aurora describes a device which purpose it to be a generic serial interface. It _really_ doesn't matter if the module name is a mouth full. Nadim. Sent from my BlackBerry® smartphone with Nextel Direct Connect
Re: Module Naming
I'm not sure including Solar or PVI-3 is going to be really appropriate as the protocol works for their wind inverters, and as far as I've seen it's the same protocol used in their 10, and even 100+kw models. Some models however also support an Ethernet port, so I'm not entirely sure whether that's web based, or terminal based or something. It doesn't inherit from SerialPort, it just makes use of SerialPort I'm leaning to Device::Inverter::Aurora::Serial that way at a later point if someone gets the urge to build an Ethernet module they can call theirs Device::Inverter::Aurora::TCP or something. How's that sound? On 05/10/10 21:11, Dana Hudes wrote: Aurora is a type of inverter and serial is type of aurora however if inheriting Device::Serial put that first Device::Serial::Inverter::Aurora --Original Message-- From: nadim khemir To: module-authors@perl.org Sent: Oct 5, 2010 2:58 AM Subject: Re: Module Naming You should have what type of device in the name too. The fact that it works with serial port is not interesting and can be made clear in a sub module if multiple communication medium exist. Device::Inverter::Aurora Be more specific in the top classes if you can. The idea is to have a name for your module and still let other people use the top same classification Device::Inverter::Solar::Aurora::PVI-3 later you can make it clear that you support serial communication if it has any importance Device::Inverter::Solar::Aurora::PVI-3::Protocol::Serial IMO, Device::Serial::Protocol::Aurora describes a device which purpose it to be a generic serial interface. It _really_ doesn't matter if the module name is a mouth full. Nadim. Sent from my BlackBerry® smartphone with Nextel Direct Connect
