Re: apr_memcache operation timeouts

2013-03-22 Thread Joshua Marantz
Thanks very much for doing this, Jeff. Unfortunately scanning your diff I think you wound up taking a snapshot of a patch I'd uploaded to the bug, but not updated after several subsequent bug fixes. The golden copies are in

Re: apr_memcache operation timeouts

2013-03-14 Thread Jeff Trawick
On Tue, Mar 12, 2013 at 1:56 PM, Jeff Trawick traw...@gmail.com wrote: On Mon, Mar 11, 2013 at 3:50 PM, Joshua Marantz jmara...@google.com wrote: ping! Please don't hesitate to push back and tell me if I can supply the patch or update in some easier-to-digest form. In particular, while I

Re: apr_memcache operation timeouts

2013-03-12 Thread Jeff Trawick
On Mon, Mar 11, 2013 at 3:50 PM, Joshua Marantz jmara...@google.com wrote: ping! Please don't hesitate to push back and tell me if I can supply the patch or update in some easier-to-digest form. In particular, while I have rigorously stress-tested this change using mod_pagespeed's unit

Re: apr_memcache operation timeouts

2013-03-11 Thread Joshua Marantz
ping! Please don't hesitate to push back and tell me if I can supply the patch or update in some easier-to-digest form. In particular, while I have rigorously stress-tested this change using mod_pagespeed's unit test, system-test, and load-test framework, I don't really understand what the

Re: apr_memcache operation timeouts

2012-11-01 Thread Joshua Marantz
I have completed a solution to this problem, which can be a drop-in update for the existing apr_memcache.c. It is now checked in for my module as http://code.google.com/p/modpagespeed/source/browse/trunk/src/third_party/aprutil/apr_memcache2.c . It differs from the solution in

Re: apr_memcache operation timeouts

2012-10-22 Thread Joshua Marantz
I've had some preliminary success with my own variant of apr_memcache.c (creatively called apr_memcache2.c). Rather than setting the socket timeout, I've been mimicing the timeout strategy I saw in apr_memcache_multgetp, by adding a new helper method: static apr_status_t

Re: apr_memcache operation timeouts

2012-10-19 Thread Joshua Marantz
Following up: I tried doing what I suggested above: patching that change into my own copy of apr_memcache.c It was first of all a bad idea to pull in only part of apr_memcache.c because that file changed slightly between 2.2 and 2.4 and our module works in both. I was successful making my own

apr_memcache operation timeouts

2012-10-17 Thread Joshua Marantz
Is there a mechanism to time out individual operations? If memcached freezes, then it appears my calls to 'get' will block until memcached wakes up. Is there any way to set a timeout for that call? I can repro this in my unit tests by sending a SIGSTOP to memcached before doing a 'get'? Here

Re: apr_memcache operation timeouts

2012-10-17 Thread Jeff Trawick
On Wed, Oct 17, 2012 at 3:36 PM, Joshua Marantz jmara...@google.com wrote: Is there a mechanism to time out individual operations? No, the socket connect timeout is hard-coded at 1 second and the socket I/O timeout is disabled. Bugzilla bug