Re: [Monetdb-developers] MonetDB: default - Activating the new implementation of BATsample.

2012-03-16 Thread Stefan Manegold
lsidir, (;-)) since it now seems to be dead code (correct me if I'm wrong), is there any reason to keep the deprecated implementation of BATsample around, or shouldn't we better clean up our code and remove the old BATsample (now BATsample_deprecated) entirely? Thanks, Stefan On Fri, Mar 16,

Re: [Monetdb-developers] MonetDB: default - Activating the new implementation of BATsample.

2012-03-16 Thread Lefteris
I just wanted to leave it a bit longer around to be sure that everything works correctly. Although the old BATsample (now BATsample_deprecated) was invoked to a couple of place only, I am just playing on the safe side. Once the tests show no errors and the performance is (according to my

Re: [Monetdb-developers] MonetDB: default - Activating the new implementation of BATsample.

2012-03-16 Thread Stefan Manegold
Ok. I suppose, prior to your checkin, you ran testing on your machine and found everthing working as fine as before your changes ;-) Stefan On Fri, Mar 16, 2012 at 02:10:38PM +0100, Lefteris wrote: I just wanted to leave it a bit longer around to be sure that everything works correctly.