Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.2010 04:52, schrieb Derek Scherger: On Sun, May 9, 2010 at 5:28 PM, Thomas Keller m...@thomaskeller.biz wrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable?

Re: [Monotone-devel] diff bug 20447

2010-05-10 Thread Thomas Keller
Am 10.05.2010 06:06, schrieb Derek Scherger: At the moment these changes result in slightly different diff output for additions and deletions which both now use /dev/null for one file (the source for adds and the target for deletes). There's a big comment in diff_output.cc that made this seem

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.2010 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw - @Tim: is this done? It needs a test using the

[Monotone-devel] [bug #7221] [NEED TEST] monotone cert should not require its target be on a branch

2010-05-10 Thread Stephen Leake
Update of bug #7221 (project monotone): Open/Closed:Accepted = In Test ___ Follow-up Comment #4: test updated in b19661370e3fc21fb0a1b3c060ce7acc48737912

Re: [Monotone-devel] What key does sync use?

2010-05-10 Thread Stephen Leake
hend...@topoi.pooq.com writes: The description of get_netsync_read_permitted (branch, key_identity) says Returns true if a peer authenticated as key key_identity should be allowed to read from your database certs, revisions, manifests, and files associated with branch;

[Monotone-devel] [bug #7220] [NEED TEST] Monotone handles deleted files very ungracefully

2010-05-10 Thread Stephen Leake
Update of bug #7220 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?7220 ___

[Monotone-devel] [bug #8535] [NEED TEST] monotone log has bad defaults outside a working directory

2010-05-10 Thread Stephen Leake
Update of bug #8535 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?8535 ___

[Monotone-devel] [bug #8549] handle tree-layout merge failure sensibly

2010-05-10 Thread Stephen Leake
Update of bug #8549 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?8549 ___

[Monotone-devel] [bug #8916] Default database location

2010-05-10 Thread Stephen Leake
Update of bug #8916 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?8916 ___

[Monotone-devel] [bug #9269] [NEED TEST] monotone log doesn't understand windows directory separator

2010-05-10 Thread Stephen Leake
Update of bug #9269 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?9269 ___

[Monotone-devel] [bug #12455] MT 0.16 can't access, if DB stored on NFS

2010-05-10 Thread Stephen Leake
Update of bug #12455 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?12455 ___

[Monotone-devel] bug#13604: undrop

2010-05-10 Thread Stephen Leake
'undrop' is a new command; see nvm.bugfest-2010.13604-stephen_leake The purpose of 'undrop' is to revoke a mistaken 'drop', before it is committed. There is an issue about how to deal with the '--recursive' option. Currently, 'nodrop' allows '--recursive', but ignores it. That's so a user can

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. Point proposals from me are noted for In test issues. If no one else objects, please close the issues I marked accordingly yourself: 1)

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: On Sun, May 9, 2010 at 5:28 PM, Thomas Keller m...@thomaskeller.biz wrote: * #13604: need 'undelete' ('undrop'?) - net.venge.monotone.bugfest-2010.13604-stephen_leake - patch looks largely cool, some minor objections: revert = not undrop; - is

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: mtn add is non-recursive by default but allows for --recursive if you want it. mtn revert is recursive by default and doesn't allow for an obvious way of being non-recursive (I believe --depth=N will stop the recursion at the specified depth). A

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread hendrik
On Mon, May 10, 2010 at 08:37:35AM -0400, Stephen Leake wrote: Derek Scherger de...@echologic.com writes: mtn add is non-recursive by default but allows for --recursive if you want it. mtn revert is recursive by default and doesn't allow for an obvious way of being non-recursive (I

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 6:24 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: It is a minor modification of revert; I factored out the common code. undrop just tells revert not to revert a file that is present in the workspace, because it had changes when it was dropped. Ahh I see.

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 6:21 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. I'll second that, you've done a great job of keeping

Re: [Monotone-devel] RFC: lua output redirection

2010-05-10 Thread Thomas Keller
Am 08.05.10 14:34, schrieb Thomas Keller: Cool, other opinions? If no one objects, I'd commit this change tonight together with a small test to mainline. Thomas. -- GPG-Key 0x160D1092 | tommyd3...@jabber.ccc.de | http://thomaskeller.biz Please note that according to the EU law on data

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 17:03, schrieb Derek Scherger: One thing I noticed in trying to fix the diff bug was this: $ mtn mv dir dir2 $ edit dir2/file $ mth revert dir2/file # only reverts content, leaves directory rename in place $ edit dir2/file $ mtn revert dir2 --depth=0 # should revert the rename

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw - @Tim: is this done? It needs a test using the

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread Thomas Keller
Am 10.05.10 06:21, schrieb Derek Scherger: mtn add is non-recursive by default but allows for --recursive if you want it. mtn revert is recursive by default and doesn't allow for an obvious way of being non-recursive (I believe --depth=N will stop the recursion at the specified depth). So,

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread Thomas Keller
Am 10.05.10 14:37, schrieb Stephen Leake: One solution would be for 'revert' to move clobbered files to _MTN/resolutions if --move-conflicting-files is given, as update does. I think not having --move-conflicting-paths here is a completly different issue and could arise for any implementation

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 17:08, schrieb Derek Scherger: On Mon, May 10, 2010 at 6:21 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. I'll

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: On Mon, May 10, 2010 at 6:24 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: It is a minor modification of revert; I factored out the common code. undrop just tells revert not to revert a file that is present in the workspace, because it

Re: [Monotone-devel] bugfest analysis - final points

2010-05-10 Thread Thomas Keller
Hi again! So I got comments on most things - lets check the final scores: 1) Assigned, but not (yet) closed issues: * #7221: [NEED TEST] monotone cert should not require its target be on a branch - net.venge.monotone.bugfest-2010.7221-stephen_leake - @Stephe: Please look at my

[Monotone-devel] [bug #29849] add --move-conflicting-paths to revert

2010-05-10 Thread Stephen Leake
URL: http://savannah.nongnu.org/bugs/?29849 Summary: add --move-conflicting-paths to revert Project: monotone Submitted by: stephen_leake Submitted on: Mon 10 May 2010 07:04:44 PM EDT Category: command line UI

[Monotone-devel] [bug #13597] monotone update -b newbranch exhibits incorrect behaviour

2010-05-10 Thread Stephen Leake
Update of bug #13597 (project monotone): Open/Closed: In Test = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?13597 ___

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Timothy Brownawell
On 05/10/2010 03:44 PM, Thomas Keller wrote: Am 10.05.10 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw -

[Monotone-devel] Why are io.popen() and os.execute() disabled again?

2010-05-10 Thread Thomas Keller
Hi! I'm in the process of improving our Lua documentation a bit, also in respect to the recent changes in print() / io.write() behaviour and I wanted to include a sentence or two about the above mentioned disabled functions. And then I started wondering why we disable these two functions at all

Re: [Monotone-devel] Why are io.popen() and os.execute() disabled again?

2010-05-10 Thread Timothy Brownawell
On 05/10/2010 06:40 PM, Thomas Keller wrote: Hi! I'm in the process of improving our Lua documentation a bit, also in respect to the recent changes in print() / io.write() behaviour and I wanted to include a sentence or two about the above mentioned disabled functions. And then I started

[Monotone-devel] Please review nvm.experiment.lua-output-redirection

2010-05-10 Thread Thomas Keller
Hi! I've committed my recent lua-related changes to the above mentioned branch. Please review that again, especially the documentation changes since I'm still not a native speaker... I also want to include some documentation why io.popen and os.execute is disabled (see the other mail) - if

[Monotone-devel] hello and thanx

2010-05-10 Thread J Decker
Nice to see lots of bugs squashed :) I have to thank you for developing a sane product. I have been coerced into using mercurial at work, and after coming from monotone, some of the things it makes me do are just insane. Merge, for instance, must be done through a workspace, so in order to

Re: [Monotone-devel] hello and thanx

2010-05-10 Thread Hugo Cornelis
Nice to hear that monotone is so much faster than git and mercurial for certain operations. Hugo On Mon, May 10, 2010 at 7:31 PM, J Decker d3c...@gmail.com wrote: Nice to see lots of bugs squashed :) I have to thank you for developing a sane product.   I have been coerced into using

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:47 PM, Stephen Leake stephen_le...@stephe-leake.org wrote: I don't know; --no-content to me sounds like don't revert content, just renmaes and other stuff. That's not the same as 'undrop', which does revert content if the file actually got deleted from the workspace.

Re: [Monotone-devel] bug#13604: undrop

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 5:53 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: drop --recursive dir1 (realize mistake) undrop dir1/file1 What would that do? Currently, this gives an error: mtn: warning: restriction excludes addition of 'dir1' but includes addition of

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:20 PM, Thomas Keller m...@thomaskeller.biz wrote: I think what he meant is the following: $ mtn mv a b $ edit b $ mtn revert b $ edit / save b again You end up with an unknown file b because of course your editor doesn't get the info that the rename was

Re: [Monotone-devel] to be recursive or non-recursive that is the question

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:10 PM, Thomas Keller m...@thomaskeller.biz wrote: $ mtn add a # non-recursive $ mtn add a/... # recusive $ mtn revert a # non-recursive $ mtn revert a/... # recursive I'm not sure how we'd represent a recursive revert of the entire workspace, maybe 'mtn

Re: [Monotone-devel] bugfest analysis - final points

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:53 PM, Thomas Keller m...@thomaskeller.biz wrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable? Patch looks ok, if you add tests for the