Re: [PATCH] Include instructions on how to build with sidebar support

2020-04-18 Thread Kevin J. McCarthy
On Sat, Apr 18, 2020 at 11:50:45AM -0400, Remco Rijnders wrote: --- INSTALL | 5 + 1 file changed, 5 insertions(+) diff --git a/INSTALL b/INSTALL Applied. Thanks. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP

[PATCH] Include instructions on how to build with sidebar support

2020-04-18 Thread Remco Rijnders
--- INSTALL | 5 + 1 file changed, 5 insertions(+) diff --git a/INSTALL b/INSTALL index dc410d54..fc41ac40 100644 --- a/INSTALL +++ b/INSTALL @@ -92,6 +92,11 @@ to ``configure'' to help it out, or change the default behavior: --enable-imap enable IMAP support +--enable-sidebar

Re: [Mutt] #3976: Sidebar picks first maildir after 'c' if chosen maildir name ends with '/'

2017-10-15 Thread Mutt
#3976: Sidebar picks first maildir after 'c' if chosen maildir name ends with '/' --+-- Reporter: ScarecrowRepair | Owner: mutt-dev Type: defect | Status: closed Priority: minor| Milestone: Component

[Mutt] #3976: Sidebar picks first maildir after 'c' if chosen maildir name ends with '/'

2017-10-10 Thread Mutt
#3976: Sidebar picks first maildir after 'c' if chosen maildir name ends with '/' -+-- Reporter: ScarecrowRepair | Owner: mutt-dev Type: defect | Status: new Priority: minor| Milestone: Component: mutt

Re: [Mutt] #3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts

2017-05-04 Thread Mutt
#3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts ---+- Reporter: jcdenton | Owner: Type: defect| Status: new Priority: major | Milestone: Component:|Version: Resolution

Re: [Mutt] #3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts

2017-05-04 Thread Mutt
#3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts ---+-- Reporter: jcdenton | Owner: Kevin McCarthy <kevin@…> Type: defect| Status: closed Priority: major | Mil

[Mutt] #3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts

2017-05-04 Thread Mutt
#3938: mutt-1.8.2: Ctrl+g on delete message confirmation results in negative sidebar counts -+-- Reporter: jcdenton | Owner: Type: defect| Status: new Priority: major | -+-- {{{ Package: mutt Version: 1.8.2-1

Connecting the dots... (Re: [Mutt] #3932: from address not changing with sidebar inbox)

2017-04-26 Thread Derek Martin
works, except the from address, if i change inbox using the > sidebar. I'm pretty sure you mean "mailbox" rather than "inbox" here... In internet mail, with a wide variety of mail systems, there is a concept of "inbox" which roughly equates to a singular

Re: [Mutt] #3932: from address not changing with sidebar inbox

2017-04-26 Thread Mutt
#3932: from address not changing with sidebar inbox ---+--- Reporter: ArchChris | Owner: mutt-dev Type: defect| Status: new Priority: major | Milestone: Component: header cache |Version

Re: [Mutt] #3932: from address not changing with sidebar inbox

2017-04-26 Thread Mutt
#3932: from address not changing with sidebar inbox ---+--- Reporter: ArchChris | Owner: mutt-dev Type: defect| Status: new Priority: major | Milestone: Component: header cache |Version

Re: [Mutt] #3932: from address not changing with sidebar inbox

2017-04-25 Thread Mutt
#3932: from address not changing with sidebar inbox ---+--- Reporter: ArchChris | Owner: mutt-dev Type: defect| Status: new Priority: major | Milestone: Component: header cache |Version

Re: [Mutt] #3932: from address not changing with sidebar inbox

2017-04-25 Thread Mutt
#3932: from address not changing with sidebar inbox ---+--- Reporter: ArchChris | Owner: mutt-dev Type: defect| Status: new Priority: major | Milestone: Component: header cache |Version

Re: [Mutt] #3932: from address not changing with sidebar inbox

2017-04-25 Thread Mutt
#3932: from address not changing with sidebar inbox ---+--- Reporter: ArchChris | Owner: mutt-dev Type: defect| Status: new Priority: major | Milestone: Component: header cache |Version

[Mutt] #3932: from address not changing with sidebar inbox

2017-04-22 Thread Mutt
#3932: from address not changing with sidebar inbox ---+-- Reporter: ArchChris | Owner: mutt-dev Type: defect | Status: new Priority: major | Milestone: Component: header cache

mutt: Fix sidebar references to the "new count" to be "unread". ...

2017-01-19 Thread Brendan Cully
changeset: 6907:b57c695b7923 user: Kevin McCarthy <ke...@8t8.us> date: Thu Jan 19 14:58:13 2017 -0800 link: http://dev.mutt.org/hg/mutt/rev/b57c695b7923 Fix sidebar references to the "new count" to be "unread". (closes #3908) %N in $sidebar_format and &q

[PATCH 4/4] doc: muttrc: add sidebar color objects

2017-01-09 Thread Simon Ruderich
quot;, " prompt ", " quoted ", " quoted\fIN\fP ", " .BR search ", " signature ", " status ", " tilde ", " tree ", " .BR underline . +If the sidebar is enabled the following objects are also valid: +.BR side

Re: [Mutt] #3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses

2017-01-07 Thread Mutt
#3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses --+- Reporter: matt+bugzilla@… | Owner: brendan Type: defect | Status: closed Priority: major| Milestone

Re: [PATCH] Make spool folder highlighting in the sidebar configurable

2016-12-03 Thread Till Smejkal
Hi, On Sat, 03 Dec 2016, Kevin J. McCarthy wrote: > [Richard, please excuse the direct Cc, but I'd appreciate your opinion > on this] > > On Fri, Dec 02, 2016 at 12:42:59PM -0800, Till Smejkal wrote: > > If there is a special color defined for the spool folder in the sideba

Re: [PATCH] Make spool folder highlighting in the sidebar configurable

2016-12-03 Thread Richard Russon
> [Richard, please excuse the direct Cc, No problem. I saw the patch and was waiting to see what you thought :-) > > $sidebar_always_highlight_spool > I am not wild about micro-options like this. I agree. If your audience is split 50:50, then you need an option. What proportion of Mutt's

Re: [PATCH] Make spool folder highlighting in the sidebar configurable

2016-12-03 Thread Kevin J. McCarthy
[Richard, please excuse the direct Cc, but I'd appreciate your opinion on this] On Fri, Dec 02, 2016 at 12:42:59PM -0800, Till Smejkal wrote: > If there is a special color defined for the spool folder in the sidebar, the > current behavior is to always use this color to highlight the spool

[PATCH] Make spool folder highlighting in the sidebar configurable

2016-12-02 Thread Till Smejkal
If there is a special color defined for the spool folder in the sidebar, the current behavior is to always use this color to highlight the spool folder in the sidebar. Accordingly, the folder is not highlighted with the color for new mails if it contains new mails or flagged mails if it contains

mutt: Change sidebar to only match $folder prefix on a $sidebar_...

2016-10-16 Thread Brendan Cully
changeset: 6822:18c3db1aa8c4 user: Kevin McCarthy <ke...@8t8.us> date: Sun Oct 16 15:44:17 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/18c3db1aa8c4 Change sidebar to only match $folder prefix on a $sidebar_divider_char. (closes #3887) The reporter had a $spo

Re: [Mutt] #3887: Spool file name beginning with $folder is truncated in sidebar

2016-10-16 Thread Mutt
#3887: Spool file name beginning with $folder is truncated in sidebar --+-- Reporter: mjbrown | Owner: mutt-dev Type: defect | Status: closed Priority: trivial | Milestone: Component: display |Version: 1.7.0 Resolution

[Mutt] #3887: Spool file name beginning with $folder is truncated in sidebar

2016-10-14 Thread Mutt
#3887: Spool file name beginning with $folder is truncated in sidebar -+-- Reporter: mjbrown | Owner: mutt-dev Type: defect | Status: new Priority: trivial | Milestone: Component: display |Version: 1.7.0 Keywords

Re: [Mutt] #3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses

2016-10-06 Thread Mutt
#3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses --+- Reporter: matt+bugzilla@… | Owner: brendan Type: defect | Status: new Priority: major| Milestone: Component

Re: [Mutt] #3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses

2016-10-02 Thread Mutt
#3864: mutt-1.7.0: mutt sidebar experiences screen corruption under tmux 2.2 w/ ncurses --+- Reporter: matt+bugzilla@… | Owner: Type: defect | Status: new Priority: major| Milestone: Component

Re: [Mutt] #3859: Errors in manual wrt sidebar stuff

2016-09-07 Thread Mutt
#3859: Errors in manual wrt sidebar stuff -+-- Reporter: chdiza | Owner: mutt-dev Type: defect | Status: closed Priority: major | Milestone: Component: doc |Version: Resolution: fixed | Keywords

Re: Sidebar patch and question

2016-09-06 Thread isdtor
might not make sense. I think the index > and pager are probably the only places set up to do this. I suppose it doesn't make sense to support it in other menus. Originally I thought it would be a good idea, and that was sort of sparked by the sidebar persisting into the compose menu. Thi

Re: Sidebar patch and question

2016-09-05 Thread Kevin J. McCarthy
On Tue, Sep 06, 2016 at 12:10:15AM +0100, isdtor wrote: > Several patches on the list referenced contrib/sample.muttrc-sidebar, > but it's not included in the 1.7.0 release. See attached for a simple > fix. The trivial update for Makefile.in is omitted. Thanks for the patch. > Here'

Sidebar patch and question

2016-09-05 Thread isdtor
Several patches on the list referenced contrib/sample.muttrc-sidebar, but it's not included in the 1.7.0 release. See attached for a simple fix. The trivial update for Makefile.in is omitted. Here's a question: these key bindings bind generic \CP sidebar-prev bind generic \CN sidebar-next

Re: Sidebar patches and plan

2016-08-25 Thread Antonio Radici
On Fri, Aug 26, 2016 at 12:47:13AM +0100, isdtor wrote: > Apologies for the very late reply ... > > I just ran into this issue when trying to upgrade from 1.5.24 to 1.6.2 on > Gentoo. 1.6.2 in portage includes the sidebar patch and a lot of other > patches from neomutt. The sideb

Re: Sidebar patches and plan

2016-08-25 Thread isdtor
Kevin J. McCarthy writes: > Hi Everyone, > > I'm shortly going to send a set of patches to commit the neomutt version > of the sidebar (with some fixes and cleanup). [...] > * Figure out if the "realpath" code added is actually needed. I nearly > pulled

Re: SIdebar updates

2016-08-03 Thread Consus
On 12:20 Wed 03 Aug, Michael Tatge wrote: > Hi, > > * On Wed, Aug 03, 2016 01:12PM +0300 Consus (con...@gmx.com) muttered: > > mutt with the sidebar supprt. When I'm reading email in mutt sidebar > > is not getting updated, but gets up-to-date seconds after I close the >

Re: Patches for behavior change for sidebar

2016-08-02 Thread Kevin J. McCarthy
On Tue, Aug 02, 2016 at 05:17:04PM -0700, Omen Wild wrote: > First, thanks for including sidebar in the official release. I find it > invaluable and allows me to use mutt in a work environment. Hi Omen, mutt-1.6.2 does not have the sidebar in it. Our default branch in the reposito

Patches for behavior change for sidebar

2016-08-02 Thread Omen Wild
First, thanks for including sidebar in the official release. I find it invaluable and allows me to use mutt in a work environment. I do have a couple quibbles with the default behavior and have attached two patches to tweak it. There are no configuration options for these patches and they soft

Re: [PATCH] Fix imap/sidebar update bug

2016-07-25 Thread Kevin J. McCarthy
On Mon, Jul 25, 2016 at 01:26:26PM +0100, Richard Russon wrote: > The sidebar's inbox occasionally shows zero/wrong value until the next > mail_check_stats event. > > If IMAP hasn't been asked for MESSAGES, don't update BUFFY->msg_count. Pushed (I rewrote the commit message bit, just to help me

Re: Sidebar pagedown/up and hidden entries

2016-07-09 Thread Richard Russon
On Fri, Jul 08, 2016 at 12:20:00PM -0700, Kevin J. McCarthy wrote: > Is there some way for you to unset the \Recent flag while setting \Seen > during sieve delivery? I haven't seen one, but I'll have a play around. > Alternatively, you may want to try unsetting $mail_check_recent, if you > only

Re: Sidebar pagedown/up and hidden entries

2016-07-08 Thread Kevin J. McCarthy
> new = (status->recent > 0); > > > does the sidebar open the mailboxes read-only for its status queries? > otherwise it's bound to reset the RECENT count on the first iteration. The sidebar is just using the BUFFY list, which is issuing a STATUS on each mailbox,

Re: Sidebar pagedown/up and hidden entries

2016-07-08 Thread Oswald Buddenhagen
On Thu, Jul 07, 2016 at 06:24:38PM -0700, Kevin J. McCarthy wrote: > else if (!olduv && !oldun) > /* first check per session, use recent. might need a flag for this. > */ > new = (status->recent > 0); > does the sidebar open the mailb

Re: Sidebar pagedown/up and hidden entries

2016-07-07 Thread Kevin J. McCarthy
On Thu, Jul 07, 2016 at 11:57:54PM +0100, Richard Russon wrote: > Yes, but it's a little involved. > > My mail's served by Dovecot over IMAP. I have some Sieve rules > filtering incoming mail. To reproduce the bug: > > - clear header cache > - receive an email that gets marked as "seen" and

Re: Sidebar pagedown/up and hidden entries

2016-07-07 Thread Richard Russon
On Thu, Jul 07, 2016 at 09:44:05AM -0700, Kevin J. McCarthy wrote: > I'm also thinking about making a small change ... Oh, you've already done it. Too slow. The patches look OK, and my quick tests work. > > I've also seen a very short-lived display issue. > This one is a bit scary. A quick

[PATCH 02] Change sidebar highlighted mailbox behavior.

2016-07-07 Thread Kevin J. McCarthy
9338e81be5370e4610e55de4abdb9b4859 Change sidebar highlighted mailbox behavior. Delay selecting the highlighted mailbox until prepare_mailbox(), to avoid a hidden mailbox being selected during the Buffy list population (in mutt_sb_notify_mailbox()). Change update_entries_visibility() to not automati

[PATCH 01] Fix sidebar pagedown/up when mailboxes on the end are hidden.

2016-07-07 Thread Kevin J. McCarthy
n McCarthy <ke...@8t8.us> # Date 1467920992 25200 # Thu Jul 07 12:49:52 2016 -0700 # Node ID 03d7909338e81be5370e4610e55de4abdb9b4859 # Parent 6f2fe8f32dabc5350920398af4595efeade27d1c Fix sidebar pagedown/up when mailboxes on the end are hidden. The pageup/pagedown code was setting the

mutt: Fix the sidebar TopIndex and BotIndex when $sidebar_new_ma...

2016-07-07 Thread Brendan Cully
changeset: 6717:6f2fe8f32dab user: Kevin McCarthy <ke...@8t8.us> date: Thu Jul 07 12:00:37 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/6f2fe8f32dab Fix the sidebar TopIndex and BotIndex when $sidebar_new_mail_only is set. When set, some of the entries can be hidd

Re: Sidebar pagedown/up and hidden entries

2016-07-07 Thread Kevin J. McCarthy
re HilIndex points at a hidden mailbox that then becomes visible). Do you see a problem with that? > I've also seen a very short-lived display issue. When the Sidebar is > first drawn, the last mailbox is coloured as containing new mail. > This is corrected (immediately) on the next redraw.

Re: Sidebar pagedown/up and hidden entries

2016-07-07 Thread Richard Russon
(open mailbox) Page up will select apple. The same is true for page down. The problem starts here because TopIndex/BotIndex can refer to hidden mailboxes. case OP_SIDEBAR_PAGE_DOWN: HilIndex = BotIndex; select_next (); break; I've also seen a very short-lived display issue. Whe

Re: Sidebar pagedown/up and hidden entries

2016-07-06 Thread Kevin J. McCarthy
8:22 2016 -0700 # Node ID 095e0d180a638762a173ec73cf402a75155ed237 # Parent 81e9c352e5d7e4909512437ed1fc4dea7ddadda5 Fix the sidebar TopIndex and BotIndex when $sidebar_new_mail_only is set. When set, some of the entries can be hidden, so a simple division by page_size to find the correct top/botto

Sidebar pagedown/up and hidden entries

2016-07-06 Thread Kevin J. McCarthy
Sorry, I realized today that I totally broke the page down/up functionality with $sidebar_new_mail_only when I ungrouped the hidden entries from the bottom. The reason I ungrouped it was because with sort order of "unsorted" and $sidebar_new_mail_only, the next/prev wasn't working because it

Re: [PATCH] Fix sidebar crash for non-existent mailbox

2016-07-06 Thread Kevin J. McCarthy
On Wed, Jul 06, 2016 at 05:29:33PM +0100, Richard Russon wrote: > If you to a non-existent mailbox, there will be no > Context. Pushed. Thank you Rich! -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP signature

mutt: Fix sidebar crash for non-existent mailbox

2016-07-06 Thread Brendan Cully
changeset: 6715:81e9c352e5d7 user: Richard Russon <r...@flatcap.org> date: Wed Jul 06 12:31:02 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/81e9c352e5d7 Fix sidebar crash for non-existent mailbox If you to a non-existent mailbox, there will be no Context. diffs (13

[PATCH] Fix sidebar crash for non-existent mailbox

2016-07-06 Thread Richard Russon
If you to a non-existent mailbox, there will be no Context. --- sidebar.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sidebar.c b/sidebar.c index 12971e5..3c2d9c0 100644 --- a/sidebar.c +++ b/sidebar.c @@ -886,6 +886,9 @@ void mutt_sb_set_open_buffy (void) OpnIndex = -1; + if

Re: Sidebar patches and plan

2016-07-02 Thread Kevin J. McCarthy
> fixing things over the next few weeks. My current todo list is: I've finally finished up this list. I'm sure there are still going to be issues to deal with, but for now I am considering it "integrated" and am going to move on to other things on my todo list. If you are a sidebar user

Re: [Mutt] #3847: In manual.xml, linkend="sidebar-format" without an associated id

2016-06-29 Thread Mutt
#3847: In manual.xml, linkend="sidebar-format" without an associated id -+-- Reporter: vinc17 | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: doc |Version:

[Mutt] #3847: In manual.xml, linkend="sidebar-format" without an associated id

2016-06-29 Thread Mutt
#3847: In manual.xml, linkend="sidebar-format" without an associated id +-- Reporter: vinc17 | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: doc |Version:

Re: [PATCH] Remove $sidebar_refresh_time from Sample Sidebar Config

2016-06-28 Thread Kevin J. McCarthy
On Tue, Jun 28, 2016 at 04:09:23PM +0300, Fahri Cihan Demirci wrote: > Remove $sidebar_refresh_time from Sample Sidebar Config > > The $sidebar_refresh_time option was removed with the changeset > 6677:1f840760e6e0. Remove it from the sample sidebar configuration as well, > so th

mutt: Remove $sidebar_refresh_time from Sample Sidebar Config

2016-06-28 Thread Brendan Cully
changeset: 6699:5bac9dacae1d user: Fahri Cihan Demirci <fcdemi...@fastmail.fm> date: Tue Jun 28 15:59:09 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/5bac9dacae1d Remove $sidebar_refresh_time from Sample Sidebar Config The $sidebar_refresh_time option was r

[PATCH] Remove $sidebar_refresh_time from Sample Sidebar Config

2016-06-28 Thread Fahri Cihan Demirci
# HG changeset patch # User Fahri Cihan Demirci <fcdemi...@fastmail.fm> # Date 1467118588 -10800 # Tue Jun 28 15:56:28 2016 +0300 # Node ID 3d228d98799143f8cf612f21aa5dd9d7b6cc7a48 # Parent b45c8ec1e54c7f20aee2b10ea2a423f7b5db63c6 Remove $sidebar_refresh_time from Sample Sidebar

mutt: Change sidebar to consistently use realpath for context an...

2016-06-23 Thread Brendan Cully
changeset: 6698:b45c8ec1e54c user: Kevin McCarthy <ke...@8t8.us> date: Thu Jun 23 12:38:07 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/b45c8ec1e54c Change sidebar to consistently use realpath for context and buffy comparison. The original sidebar patch contained

[PATCH] Change sidebar to consistently use realpath for context and buffy comparison.

2016-06-22 Thread Kevin J. McCarthy
The original sidebar patch contained a half-implemented attempt to use realpath() mailbox paths for comparison. (Presumably so the open mailbox remains highlighted despite symlink issues). Add realpath to the Context, and set it when opening a mailbox. Remove sidebar ifdef for the buffy member

mutt: Change sidebar next/prev-new to look at buffy->new too.

2016-06-22 Thread Brendan Cully
changeset: 6697:c8613259dc38 user: Kevin McCarthy <ke...@8t8.us> date: Wed Jun 22 09:20:39 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/c8613259dc38 Change sidebar next/prev-new to look at buffy->new too. Look at new in addition to msg_unread count, to account

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Aaron Schrab
At 08:17 -0700 14 Jun 2016, "Kevin J. McCarthy" wrote: I'll have more time later today to actually test this, but I think this patch should fix the problem. I moved the "new" flag resetting inside the status processing, and somehow missed the *giant* comment saying it wouldn't be

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Kevin J. McCarthy
On Tue, Jun 14, 2016 at 07:54:56AM -0700, Kevin J. McCarthy wrote: > On Tue, Jun 14, 2016 at 08:34:53AM -0400, Aaron Schrab wrote: > > Not sure if this is something that you're already looking into for the > > above-mentioned part 4, but this change causes problems in buffy operation > > for me. >

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Kevin J. McCarthy
On Tue, Jun 14, 2016 at 08:34:53AM -0400, Aaron Schrab wrote: > Not sure if this is something that you're already looking into for the > above-mentioned part 4, but this change causes problems in buffy operation > for me. > > With this change when I switch to a folder with new mail and read all

Re: [PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-14 Thread Aaron Schrab
At 14:19 -0700 08 Jun 2016, "Kevin J. McCarthy" wrote: Add new boolean option $mail_check_stats (default off) and $mail_check_stats_interval. The first turns extended buffy on. The second sets the amount of time in between extended buffy checks (defaulting to 60 seconds).

[PATCH 3 of 3] Make extended buffy independent of the sidebar.

2016-06-08 Thread Kevin J. McCarthy
notify the sidebar to redraw if a mailbox buffy value changes. Remove the #ifdefs around the extended buffy functions. The next patch will merge these functions with the basic functions and pass a parameter instead. Imap is a special case, because it sends out the status in one batch. Change

Re: [PATCH] limit sidebar width to prevent overflow

2016-06-07 Thread Kevin J. McCarthy
On Tue, Jun 07, 2016 at 06:29:34PM +0100, Richard Russon wrote: > Setting $sidebar_width to more than 128 would cause bad things to happen. > > First, give the users more than enough space. > Second, don't pad out short strings beyond the buffer Pushed. -- Kevin J. McCarthy GPG Fingerprint:

[PATCH] Sidebar -> Status line wrong length

2016-06-07 Thread Richard Russon
set sidebar_visible = yes set status_on_top = no When the Sidebar is enabled, $status_on_top unset and the pager active, the status line and the pager line are the wrong length. I've changed mutt_make_string_info() and menu_status_line() to take a cols parameter (max screen columns). Before

mutt: Fix sidebar buffy stats updating on mailbox close.

2016-06-05 Thread Brendan Cully
changeset: 6668:91608dca6f12 user: Kevin McCarthy <ke...@8t8.us> date: Sun Jun 05 18:05:41 2016 -0700 link: http://dev.mutt.org/hg/mutt/rev/91608dca6f12 Fix sidebar buffy stats updating on mailbox close. Move the mutt_sb_set_buffystats() call from mx_fastclose_m

Re: [Mutt] #3829: Add Sidebar Panel to Mutt

2016-06-04 Thread Mutt
#3829: Add Sidebar Panel to Mutt -+ Reporter: flatcap | Owner: mutt-dev Type: enhancement | Status: closed Priority: major | Milestone: Component: user interface |Version: Resolution

Re: Sidebar patches and plan

2016-06-02 Thread Richard Russon
iginal win-sidebar patch (I'll investigate when I have a second). > I gutted a chunk of your work on the manual, > I think it's a nice introduction, > which you probably don't want to abandon. You're right, I don't. > and am not sure it's needed in the manual so for now I

Re: Sidebar patches and plan

2016-06-02 Thread Oswald Buddenhagen
On Wed, Jun 01, 2016 at 12:36:08PM -0700, Kevin J. McCarthy wrote: > Of course, I could squash-merge the series, but I thought it would be > easier for Rich to see my changes if I started from his patch. > i'd still recommend that you squash it once rich has ack's the series. there is really no

Re: Sidebar patches and plan

2016-06-01 Thread Kevin J. McCarthy
On Wed, Jun 01, 2016 at 08:33:05AM +0100, Richard Russon wrote: > > I'm shortly going to ... commit ... the sidebar > > Let me be the first to say: "Holy , it's actually happening". :-) > > While I would like to commit the current set of patches now, I am not &

Re: Sidebar patches and plan

2016-06-01 Thread Kevin J. McCarthy
ment. > Can't it be reorganized in more logical commits? add new features to > buffy, add new mailbox operation to update buffy, add sidebar view, > etc. For features being developed normally, of course this would be the right way to go about it. This patch is a special case, having b

Re: Sidebar patches and plan

2016-06-01 Thread Damien Riegel
Hi, On Tue, May 31, 2016 at 08:26:30PM -0700, Kevin J. McCarthy wrote: > Hi Everyone, > > I'm shortly going to send a set of patches to commit the neomutt version > of the sidebar (with some fixes and cleanup). Good news that vanilla mutt is gaining such a feature. > The

Re: Sidebar patches and plan

2016-06-01 Thread Richard Russon
Hi Kevin, > I'm shortly going to ... commit ... the sidebar Let me be the first to say: "Holy , it's actually happening". > First, let me say thanks to Rich and thank you for driving the change. > While I would like to commit the current set of patches n

Re: [PATCH 8 of 8] Various fixes to the sidebar logic.

2016-06-01 Thread Kevin J. McCarthy
<ke...@8t8.us> # Date 1464748766 25200 # Tue May 31 19:39:26 2016 -0700 # Node ID f6be3ce526d4a49a300fc2853d10521ce044ee21 # Parent dad3729fc54fb1a15c253dd103117383a3e1054e Various fixes to the sidebar logic. Use strfcpy instead of strncpy. The current logic could write past the end of t

Re: [PATCH 7 of 8] Add "mutt_" prefix to global sidebar functions.

2016-05-31 Thread Kevin J. McCarthy
Add "mutt_" prefix to global sidebar functions. Also, remove unused sb_init declaration. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA # HG changeset patch # User Kevin McCarthy <ke...@8t8.us> # Date 1464744521 25200 # Tue May

Re: [PATCH 6 of 8] Clean up the sidebar manual.

2016-05-31 Thread Kevin J. McCarthy
, attached as a bz2). -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA 06-sidebar-fix-doc.patch.bz2 Description: Binary data signature.asc Description: PGP signature

Re: [PATCH 4 of 8] Fix sidebar check_sec.sh warnings.

2016-05-31 Thread Kevin J. McCarthy
ode ID 7a2f763782c918ebdec746dd8f02982920245a2c # Parent 717a06441fafe2c72ef607fc282226b1a1cac654 Fix sidebar check_sec.sh warnings. Use safe_malloc/FREE and the safe_strcat functions. diff --git a/sidebar.c b/sidebar.c --- a/sidebar.c +++ b/sidebar.c @@ -473,18 +473,16 @@ if (!b) return 0;

Re: [PATCH 3 of 8] Clean up building, sidebar draw logic.

2016-05-31 Thread Kevin J. McCarthy
;ke...@8t8.us> # Date 1464744516 25200 # Tue May 31 18:28:36 2016 -0700 # Node ID 717a06441fafe2c72ef607fc282226b1a1cac654 # Parent a20a351eb8aebad75dbd5ad7e9898a6537bdc47b Clean up building, sidebar draw logic. Fix the autoconf/makefile.am to be consistent. Create a global SidebarNeeds

Re: [PATCH 1 of 8] Sidebar patch from neomutt.

2016-05-31 Thread Kevin J. McCarthy
Due to the size of the patch, I am attaching it bzip2'ed. The original patch can also be viewed at https://github.com/neomutt/neomutt/commit/c796fa85f9cacefb69b8f7d8545fc9ba71674180 -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA 01-sidebar

Sidebar patches and plan

2016-05-31 Thread Kevin J. McCarthy
Hi Everyone, I'm shortly going to send a set of patches to commit the neomutt version of the sidebar (with some fixes and cleanup). First, let me say thanks to Rich for taking a large amount of time to clean up, fix, and document the patch. Also, for working to rebase the patch on top

[PATCH 0 of 8] Sidebar patch and fixes

2016-05-31 Thread Kevin J. McCarthy
This is a set of 8 patches. Patch 1 is the original neomutt sidebar patch from https://github.com/neomutt/neomutt/commit/c796fa85f9cacefb69b8f7d8545fc9ba71674180 Patch 2 removes and relocates some of the extra files included in the patch. Patch 3 has some initial fixes I made. I changed

Re: [Mutt] #3829: Add Sidebar Panel to Mutt

2016-05-11 Thread Mutt
#3829: Add Sidebar Panel to Mutt -+ Reporter: flatcap | Owner: mutt-dev Type: enhancement | Status: new Priority: major | Milestone: Component: user interface |Version: Resolution

Re: [Mutt] #3829: Add Sidebar Panel to Mutt

2016-05-10 Thread Mutt
#3829: Add Sidebar Panel to Mutt -+ Reporter: flatcap | Owner: mutt-dev Type: enhancement | Status: new Priority: major | Milestone: Component: user interface |Version: Resolution

Re: [Mutt] #3829: Add Sidebar Panel to Mutt

2016-04-05 Thread Mutt
#3829: Add Sidebar Panel to Mutt -+ Reporter: flatcap | Owner: mutt-dev Type: enhancement | Status: new Priority: major | Milestone: Component: user interface |Version: Resolution

[Mutt] #3829: Add Sidebar Panel to Mutt

2016-04-04 Thread Mutt
#3829: Add Sidebar Panel to Mutt +-- Reporter: flatcap | Owner: mutt-dev Type: enhancement | Status: new Priority: major | Milestone: Component: user interface |Version: Keywords

NeoMutt[4/4] - Sidebar

2016-03-07 Thread Richard Russon
The Sidebar shows a list of all your mailboxes. The list can be turned on and off, it can be themed and the list style can be configured. Beginner-friendly howto: https://flatcap.org/mutt/manual.html#intro-sidebar Full Reference: https://github.com/neomutt/neomutt/wiki/sidebar

Sidebar patches

2015-05-05 Thread İsmail Dönmez
Hi, Is there a possibility to merge mutt sidebar patches [0] ? I maintain a locally up to date version against latest mutt repo on Github[1]. Would be really nice to have this functionality upstream. Regards, ismail [0] http://www.lunar-linux.org/mutt-sidebar/ [1] https://github.com/ismail

Re: sidebar

2007-03-24 Thread Christoph Berg
Re: Elimar Riesebieter 2007-03-19 [EMAIL PROTECTED] The noted numbers don't reflect the sort of patching. I'll prepare a commented, unified diff against your latest experimental debian dir. Thanks. Unfortunately, the recent buffy-size/check_mbox_size change caused rather nasty conflicts in