Hi Ryan,
these changes are good rom my point of view.
I have ony one minor thing what I can't test since I have difficulties
to debug nant at the moment.
MSBuildProject.cs within DetermineProductVersion line 279
if (_productVerNode != null) {
Version _ver = new
Ah, good catches. I've made the changes in my tree and they are ready for
committing.
If I don't hear anything else, all of these changes that Dominik, Martin,
and myself have worked hard on will be committed tonight.
Thanks everyone :)
Ryan
On Sun, Aug 7, 2011 at 1:33 PM, Dominik Guder
: [nant-dev] Updates to MSBuild VSNet Tasks
Hey Dominik,
I saw your notes in the atlassian review and I see your point. It
would
probably make more sense to use the ToolsVersion property rather than
relying on the PropertyGroup/ProductVersion xml node. I just took a
look at
some
as well. I'd need to test it yet,
though.
Martin Aliger
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Wednesday, June 22, 2011 2:36 AM
Subject: Re: [nant-dev] Updates to MSBuild VSNet Tasks
Hey Dominik,
I saw your notes in the atlassian review
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Wednesday, June 22, 2011 2:36 AM
Subject: Re: [nant-dev] Updates to MSBuild VSNet Tasks
Hey Dominik,
I saw your notes in the atlassian review and I see your point. It would
probably make more sense to use the ToolsVersion
, June 22, 2011 2:36 AM
Subject: Re: [nant-dev] Updates to MSBuild VSNet Tasks
Hey Dominik,
I saw your notes in the atlassian review and I see your point. It would
probably make more sense to use the ToolsVersion property rather than
relying on the PropertyGroup/ProductVersion xml node. I
,
DirectoryInfo outputDir)
...
ToolsVersion should be more accurate as well. I'd need to test it yet,
though.
Martin Aliger
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Wednesday, June 22, 2011 2:36 AM
Subject: Re: [nant-dev] Updates to MSBuild VSNet Tasks
Hey
Hi,
Please see inline.
Thanks,
Ryan
On Jun 16, 2011, at 2:39 AM, Martin Aliger martin_ali...@gordic.cz wrote:
Hi Ryan, sln file handling is some kind of broken since VS2005. They
only work with 2002/2003. I would not spend to much time for now in
sln file handling in VS2005 and up.
Eww,
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Thursday, June 16, 2011 3:37 PM
To: Martin Aliger
Cc: Dominik Guder; nant-developers@lists.sourceforge.net
Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild VSNet Tasks
Importance: Low
Hi,
Please see inline
Hi,
Thanks for your reply. Inline comments below.
On Wed, Jun 15, 2011 at 2:05 AM, Dominik Guder o...@guder.org wrote:
Am 14.06.2011 05:14, schrieb Ryan Boggs:
Hi,
Just an update. I'm having issues with trying to process solution
files from .NET 2.0 and above with the solution task. I'm
Hi,
Just an update. I'm having issues with trying to process solution
files from .NET 2.0 and above with the solution task. I'm still
taking a look at it but it seems that the VS20** plugins in the
NAnt.MSBuild assembly are not being picked up by the solution task.
I'll keep checking...
Hmm,
On Mon, Jun 6, 2011 at 10:28 PM, Dominik Guder o...@guder.org wrote:
Am 07.06.2011 01:53, schrieb Ryan Boggs:
Hi,
Martin seems good with the diff I posted. Has anyone else reviewed it
since I posted it last saturday? The link to the patch is below.
Yes, I did.
One point it is not
12 matches
Mail list logo
