[Trimmed CC list as we're off topic]
Am Sonntag, 9. Juli 2006 22:05 schrieb Krzysztof Halasa:
... and where the maintainer doesn't seem to care to use it now that the
infrastructure is there. Sigh.
This is very different from what I proposed and doesn't fit very well.
We've been
On Sat, Jul 08, 2006 at 01:48:13AM +0900, YOSHIFUJI Hideaki / [EMAIL
PROTECTED](B wrote:
In article [EMAIL PROTECTED] (at Fri, 7 Jul 2006 11:54:25 +0400), Andrey
Savochkin [EMAIL PROTECTED] says:
On Fri, Jul 07, 2006 at 01:34:34PM +0900, YOSHIFUJI Hideaki / [EMAIL
PROTECTED](B wrote:
* David Miller [EMAIL PROTECTED] wrote:
The lockdep fixes are starting to cause us to go in and start adding
hard IRQ protection to many socket layer objects and I want this
thinking to end quickly :)
In earlier lockdep versions we had many such hacks, but in the current
upstream kernel
On Sun, 2006-07-09 at 23:37 +0200, Laurent Riffard wrote:
ei_start_xmit
please try this patch
---
drivers/net/8390.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-2.6.17-mm4/drivers/net/8390.c
On Fri, 2006-07-07 at 10:00 +0200, Patrick McHardy wrote:
Russell Stuart wrote:
Unfortunately you do things in the wrong order for ATM.
See: http://mailman.ds9a.nl/pipermail/lartc/2006q1/018314.html
for an overview of the problem, and then the attached email for
a detailed description of
On Tue, 4 Jul 2006, Andi Kleen wrote:
On Tuesday 04 July 2006 13:41, Jesper Dangaard Brouer wrote:
Actually the change happens between kernel version 2.6.15 and 2.6.16.
The timestamp optimizations are older. Don't remember the exact release,
but earlier 2.6.
What I'm saying is that,
Andrew,
this has been out for a couple of days - could you drop this into -mm /
push this along to Linus, please?
- Forwarded message from Michael S. Tsirkin [EMAIL PROTECTED] -
Please review:
git://www.mellanox.co.il/~git/infiniband mst-for-2.6.18
This has the following patch:
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm and on.
---
comment in mthca_qp.c makes it seem lockdep is the only reason WQ locks should
be initialized separately, but as Zach Brown and Roland pointed out, there are
other reasons, e.g. that mthca_wq_init is called from
On Mon, 2006-07-10 at 14:14 +0300, Michael S. Tsirkin wrote:
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm and on.
---
comment in mthca_qp.c makes it seem lockdep is the only reason WQ locks should
be initialized separately, but as Zach Brown and Roland pointed
Quoting r. Arjan van de Ven [EMAIL PROTECTED]:
Subject: Re: [PATCH] IB/mthca: comment fix
On Mon, 2006-07-10 at 14:14 +0300, Michael S. Tsirkin wrote:
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm and on.
---
comment in mthca_qp.c makes it seem lockdep is
David Miller [EMAIL PROTECTED] writes:
I'm a single developer BTW.
So am I, and I've been keeping the core networking and the sparc64
port afloat for more than 10 years.
I was just referring to your use of plural form.
I don't know about you, but I'm doing Linux (and other related) work
in
On Mon, 2006-07-10 at 14:31 +0300, Michael S. Tsirkin wrote:
Quoting r. Arjan van de Ven [EMAIL PROTECTED]:
Subject: Re: [PATCH] IB/mthca: comment fix
On Mon, 2006-07-10 at 14:14 +0300, Michael S. Tsirkin wrote:
Hi Andrew,
Here's a cosmetic patch for IB/mthca. Pls drop it into -mm
Quoting r. Arjan van de Ven [EMAIL PROTECTED]:
makes sense to me; my main concern is that we document the bug that was
there; unless you document such things.. these bugs tend to have a habit
of resurfacing later ;)
Right. Although lockdep will catch this one quickly :)
--
MST
-
To
Stefan Rompf [EMAIL PROTECTED] writes:
You've been asking for two independant flags of which one does not stop the
queue.
Actually I asked for only one flag which can be set independently of
others, and which would be visible to userspace. I provided a patch
as well. It didn't break anything.
Thomas Hellström wrote:
Does the noirqdebug option fix the problem?
Yes... but it breaks switching to a text console. I get an interesting
fluid effect on the screen (a bright static pattern), and the keyboard
locks up.
Marcus
signature.asc
Description: OpenPGP digital signature
On Mon, Jul 10, 2006 at 05:23:21PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED])
wrote:
After week vacations I'm pleased to announce following progress report.
Numbers for small packets (80 bytes) bulk sending:
* netchannel: 57 MB/sec, ~80% CPU usage
* socket: 22 MB/sec, ~90% CPU usage
Looking on the linux bonding driver, it seems to unconditionally (*)
assume that the enslaved device supports the set_mac_address call.
From reading the doc (Documentation/networking/bonding.txt) i understand that
it is **not** a must prerequisite for the active-backup mode, this is since
there
Marcus Better wrote:
Thomas Hellström wrote:
Does the noirqdebug option fix the problem?
Yes... but it breaks switching to a text console. I get an interesting
fluid effect on the screen (a bright static pattern), and the keyboard
locks up.
Marcus
Hi!
Are you _sure_ these are
Thomas Hellström wrote:
Does the noirqdebug option fix the problem?
Yes... but it breaks switching to a text console.
Are you _sure_ these are related?
Yes. (I tried a few times and it always crashed, whereas without
noirqdebug I've switched mode successfully hundreds of times.)
Without the
On Sat, 8 Jul 2006 14:05:08 +0200, Ivo Van Doorn wrote:
Since I didn't want to loose any tested because of the new field in
the net_device structure,
I have used the base_addr field instead and used the following access
functions:
This will horribly fail when you send something to master
OK, the following makes it clear what the function does, from its name.
More comments?
---
After recent changes, mthca_wq_init does not actually initialize the WQ as it
used to - it simply resets all index fields to their initial values. So,
let's rename it to mthca_wq_reset.
Signed-off-by:
Bpqether is encapsulating AX.25 frames into ethernet frames. There is a
virtual bpqether device paired with each ethernet devices, so it's normal
to pass through dev_queue_xmit twice for each frame which triggers the
locking detector.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
---
Jeff,
Please apply to #upstream-fixes.
Cheers,
Auke
---
There were some tso bugs that only showed up with heavy load and 16kB
pages that this patch fixes by making the driver's internal use count
of descriptors match the count that it was estimating it needed using
the DESC_NEEDED macro.
Hi,
I regret making a mistake yesterday, I forgot a comma.
Here now is the working patch.
[PATCH] airo: collapse debugging-messages in issuecommand to one line
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08
14:02:12.0 +0200
+++
On Sun, 9 Jul 2006 10:49:31 +0200
Stefan Rompf [EMAIL PROTECTED] wrote:
Am Freitag, 7. Juli 2006 23:33 schrieb Stephen Hemminger:
Not really. The flag code last major change was to do the dormant
stuff that HDLC wanted.
... and where the maintainer doesn't seem to care to use it now
Stephen Hemminger wrote:
On Sun, 9 Jul 2006 10:49:31 +0200
Stefan Rompf [EMAIL PROTECTED] wrote:
Am Freitag, 7. Juli 2006 23:33 schrieb Stephen Hemminger:
Not really. The flag code last major change was to do the dormant
stuff that HDLC wanted.
... and where the maintainer doesn't seem
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such configuration does not work,
because these drivers need a firmware, and it can't be loaded by
userspace loader when userspace is not running.
Is there better way of creating N/m config
Pavel Machek wrote:
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such configuration does not work,
because these drivers need a firmware, and it can't be loaded by
userspace loader when userspace is not running.
False, initramfs...
-
From: Or Gerlitz [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 16:43:36 +0300 (IDT)
Looking on the linux bonding driver, it seems to unconditionally (*)
assume that the enslaved device supports the set_mac_address call.
From reading the doc (Documentation/networking/bonding.txt) i understand that
From: Ralf Baechle [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 16:53:34 +0100
Bpqether is encapsulating AX.25 frames into ethernet frames. There is a
virtual bpqether device paired with each ethernet devices, so it's normal
to pass through dev_queue_xmit twice for each frame which triggers the
It's generally not a good idea to call request_region() on an address returned
by pci_iomap(), even less so on a MMIO address. And there was absolutely no
point in claiming the region already claimed by the PCI core, especially with
the same PCI generic owner's name. As this is the only case of
Or Gerlitz [EMAIL PROTECTED] wrote:
Looking on the linux bonding driver, it seems to unconditionally (*)
assume that the enslaved device supports the set_mac_address call.
From reading the doc (Documentation/networking/bonding.txt) i understand that
it is **not** a must prerequisite for the
- Forwarded message from Pavel Machek [EMAIL PROTECTED] -
zd1201 has nasty tendency to emit magicall anti-wifi cloud when it is
inserted into slot, but not used.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
--- linux-good/drivers/usb/net/zd1201.c 2006-03-30
David Miller [EMAIL PROTECTED] wrote:
[...]
Regardless of whether we add support for active-backup/bonding for
devices without this method, in the mean time the bonding
driver should check for whether that method is NULL and disallow
the bond configuration if it is.
That's what it does;
From: Jay Vosburgh [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 11:29:14 -0700
What network device drivers are there that don't permit ever
changing the device MAC address?
Good question.
Look at a driver such as 3c509.c, for example.
Sure, it will get the default eth_mac_addr() software
From: Jay Vosburgh [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 11:31:48 -0700
David Miller [EMAIL PROTECTED] wrote:
[...]
Regardless of whether we add support for active-backup/bonding for
devices without this method, in the mean time the bonding
driver should check for whether that method is
This patch let's BT_HIDP depend on instead of select INPUT.
This fixes the following warning during an s390 build:
-- snip --
...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP'
refer to undefined symbol 'INPUT'
...
-- snip --
A dependency on INPUT also
Jeff Garzik wrote:
Pavel Machek wrote:
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such configuration does not work,
because these drivers need a firmware, and it can't be loaded by
userspace loader when userspace is not running.
From: Auke Kok [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 11:29:30 -0700
Jeff Garzik wrote:
Pavel Machek wrote:
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such configuration does not work,
because these drivers need a firmware,
On Mon, 2006-07-10 at 11:47 -0700, David Miller wrote:
From: Auke Kok [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 11:29:30 -0700
Jeff Garzik wrote:
Pavel Machek wrote:
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such
Le 10.07.2006 10:40, Arjan van de Ven a écrit :
On Sun, 2006-07-09 at 23:37 +0200, Laurent Riffard wrote:
ei_start_xmit
please try this patch
---
drivers/net/8390.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-2.6.17-mm4/drivers/net/8390.c
Hi Adrian,
This patch let's BT_HIDP depend on instead of select INPUT.
This fixes the following warning during an s390 build:
-- snip --
...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol
'BT_HIDP' refer to undefined symbol 'INPUT'
...
-- snip --
A
Hello, Andrew!
Could you please drop the following in -mm and on to Linus?
---
The device address contains unsigned character arrays, which contain raw GID
addresses. The GIDs may not be naturally aligned, so do not cast them to
structures or unions.
Signed-off-by: Sean Hefty [EMAIL PROTECTED]
Hello Andrew!
Could you please drop the following in -mm and on to Linus?
---
If a user of the IB CM returns -ENOMEM from their connection callback,
simply drop the incoming REQ - do not attempt to send a reject. This should
allow the sender to retry the request.
Signed-off-by: Michael S.
On Mon, Jul 10, 2006 at 09:07:20PM +0200, Marcel Holtmann wrote:
Hi Adrian,
This patch let's BT_HIDP depend on instead of select INPUT.
This fixes the following warning during an s390 build:
-- snip --
...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol
Andrew, could you pls drop the following in -mm and on to Linus?
---
From: Vu Pham [EMAIL PROTECTED]
srp_unmap_data assumes req-fmr is NULL if the request is not mapped,
so we must clean it out in case of an error.
Signed-off-by: Vu Pham [EMAIL PROTECTED]
Signed-off-by: Michael S. Tsirkin
On Mon, Jul 10, 2006 at 08:51:58PM +0200, Arjan van de Ven wrote:
Besides, the initramfs runs long after the driver init routine
runs which is when the firmware needs to be available.
.. unless you use sysfs to do a fake hotunplug + replug the device, at
which point the driver init routine
On Monday 10 July 2006 19:53, you wrote:
Pavel Machek wrote:
Kconfig currently allows compiling IPW_2100 and IPW_2200 into kernel
(not as a module). Unfortunately, such configuration does not work,
because these drivers need a firmware, and it can't be loaded by
userspace loader when
OK, this is fine with both Arjan van de Ven and Roland Dreier, so -
Andrew, could you take this into -mm please?
---
After recent changes, mthca_wq_init does not actually initialize the WQ as it
used to - it simply resets all index fields to their initial values. So,
let's rename it to
The following changes since commit 120bda20c6f64b32e8bfbdd7b34feafaa5f5332e:
Linus Torvalds:
Linux 2.6.18-rc1
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream-fixes
Daniel Drake:
zd1211rw: usb_clear_halt not
These patches are to be queued for 2.6.19...
---
The following changes since commit b312d799b324e895745ffe148def234fc60d5b74:
Daniel Drake:
zd1211rw: usb_clear_halt not allowed in IRQ context
are found in the git repository at:
On Monday 10 July 2006 23:31, you wrote:
These patches are to be queued for 2.6.19...
---
The following changes since commit b312d799b324e895745ffe148def234fc60d5b74:
Daniel Drake:
zd1211rw: usb_clear_halt not allowed in IRQ context
are found in the git repository at:
Michael Buesch wrote:
On Monday 10 July 2006 23:31, you wrote:
Larry, I see that several patches from you got merged now.
Please make sure that you also submit patches for bcm43xx-d80211.
If you don't, your changes will all be lost, as soon as bcm43xx-d80211
is merged upstream and softmac is
Am Montag, 10. Juli 2006 14:01 schrieb Krzysztof Halasa:
You've got two independant flags of which one does not stop the queue.
Is it ok to set that flag without synchronization with other flags?
I.e, from within another module and without using cross-module locks,
as I've shown at the
Am Montag, 10. Juli 2006 18:56 schrieb Stephen Hemminger:
1. I think vlan code should never be using the state bits directly at all.
It makes the code error prone if the bits ever change, and it means
that the proper callbacks are not being done. The existing
vlan_transfer_operstate does what
From: Brian Haley [EMAIL PROTECTED]
Date: Fri, 09 Jun 2006 14:14:50 -0400
If IPv6 addresses are ordered by scope, then ipv6_dev_get_saddr() can
break-out of the device addr_list for() loop when the candidate source
address scope is less than the destination address scope.
Signed-off-by:
In article [EMAIL PROTECTED] (at Mon, 10 Jul 2006 15:00:45 -0700 (PDT)),
David Miller [EMAIL PROTECTED] says:
If IPv6 addresses are ordered by scope, then ipv6_dev_get_saddr() can
break-out of the device addr_list for() loop when the candidate source
address scope is less than the
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Mon, 10 Jul 2006 18:18:16 -0400 (EDT)
In article [EMAIL PROTECTED] (at Mon, 10 Jul 2006 15:00:45 -0700 (PDT)),
David Miller [EMAIL PROTECTED] says:
If IPv6 addresses are ordered by scope, then ipv6_dev_get_saddr() can
break-out of the
I see a reproducible oops in the current -git.
It occurs on an Fedora Core 5 box w/ 2.6.18-rc1-git (HEAD
e2b209509ca33743864846aef2e1b2afc21f7915). The topmost information
scrolls off the screen, so I don't know if its an oops or a BUG. What I
do see:
* FC5 boot proceeds normally,
Is there better way of creating N/m config option?
config IPW2100
tristate Intel PRO/Wireless 2100 Network Connection
- depends on NET_RADIO PCI
+ depends on NET_RADIO PCI MODULE_ONLY
depends on NET_RADIO PCI m
Jan Engelhardt
--
-
To unsubscribe from this list: send the
This patch contains the following possible cleanups:
- make the following needlessly global functions static:
- net/netfilter/nf_conntrack_core.c: nf_conntrack_register_cache()
- net/netfilter/nf_conntrack_core.c: nf_conntrack_unregister_cache()
- net/netfilter/nf_conntrack_core.c:
Am Sonntag, 9. Juli 2006 17:49 schrieb Ivo Van Doorn:
I have been quite busy lately, hence the reason for this late continuance
of the Hardware button support for Wireless cards discussion.
I have CC'ed the people who discussed this in earlier threads.
no problem. Look good, just one thing
An assert statement near the start of handle_irq_noise in the d80211 version of bcm43xx_main.c is
there to protect against out of bound addressing using variable bcm-noisecalc.nr_samples. The
arrays in question have a dimension of 8, thus the value must be 8. This patch mirrors the one
On Tuesday 11 July 2006 00:56, you wrote:
An assert statement near the start of handle_irq_noise in the d80211 version
of bcm43xx_main.c is
there to protect against out of bound addressing using variable
bcm-noisecalc.nr_samples. The
arrays in question have a dimension of 8, thus the
Michael Buesch wrote:
On Tuesday 11 July 2006 00:56, you wrote:
An assert statement near the start of handle_irq_noise in the d80211 version of bcm43xx_main.c is
there to protect against out of bound addressing using variable bcm-noisecalc.nr_samples. The
arrays in question have a dimension of
An assert statement near the start of handle_irq_noise in the d80211 version of
bcm43xx_main.c is
there to protect against out of bound addressing using variable
bcm-noisecalc.nr_samples. The
arrays in question have a dimension of 8, thus the value must be 8. This
patch mirrors the one
Delivery of AX.25 frame to the layer 3 protocols happens in softirq context
so locking needs to be bh-proof.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
diff --git a/net/ax25/ax25_iface.c b/net/ax25/ax25_iface.c
index 77ba07c..07ac020 100644
--- a/net/ax25/ax25_iface.c
+++
When establishing a new circuit in nr_rx_frame the locks are taken in a
different order than in the rest of the stack. This should be harmless
but triggers lockdep. Either way, reordering the code a little solves
the issue.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
diff --git
Michael S. Tsirkin wrote:
OK, this is fine with both Arjan van de Ven and Roland Dreier, so -
Andrew, could you take this into -mm please?
Signed-off-by: Michael S. Tsirkin [EMAIL PROTECTED]
Acked-by: Zach Brown [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe
Quoting r. Michael S. Tsirkin [EMAIL PROTECTED]:
Yes, -mm seems like a good way to get more review.
Andrew, am I using the right format to send things upstream to you?
There's really a set of independent patches, so it didn't make sense
to me to batch them up in a series. OK?
Maybe the addition
Hi Andrew,
Here's another infiniband patch that needs to go upstream.
---
From: Ira Weiny [EMAIL PROTECTED]
Set private data length for reject messages to the correct size.
Fix from openib svn r8483.
Signed-off-by: Sean Hefty [EMAIL PROTECTED]
Signed-off-by: Michael S. Tsirkin [EMAIL
Sorry, the last patch I sent was corrupted, here's an updated version:
---
commit 7289361d5f81463e4abb27334773750279547e8a
Author: Vu Pham [EMAIL PROTECTED]
Date: Mon Jul 10 22:38:14 2006 +0300
[PATCH] srp: fix fmr error handling
srp_unmap_data assumes req-fmr is NULL if the
From: Ralf Baechle [EMAIL PROTECTED]
Date: Tue, 11 Jul 2006 00:09:43 +0100
Delivery of AX.25 frame to the layer 3 protocols happens in softirq context
so locking needs to be bh-proof.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
Applied, thanks Ralf.
-
To unsubscribe from this list: send
On Wed, Jul 05, 2006 at 07:54:01AM -0400, linux-os (Dick Johnson) wrote:
running since 8:42pm yesterday. It's 8:37am now. It hasn't progressed
in any way. It hasn't quit. It hasn't timed out. It just sits there,
hung. This leads me to consider the possibility of a DOS, either
intentional
From: Ralf Baechle [EMAIL PROTECTED]
Date: Tue, 11 Jul 2006 00:14:46 +0100
When establishing a new circuit in nr_rx_frame the locks are taken in a
different order than in the rest of the stack. This should be harmless
but triggers lockdep. Either way, reordering the code a little solves
the
nr_destroy_socket takes the socket lock itself so it should better be
called with the socket unlocked.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
---
diff --git a/net/netrom/nr_timer.c b/net/netrom/nr_timer.c
index 75b72d3..ddba1c1 100644
--- a/net/netrom/nr_timer.c
+++
cancel_rearming_delayed_work{queue} is broken, because it is
possible to enter an infinite loop if:
We call the function on a work that is currently not executing or pending.
But, as this is a synchronization function and as its only purpose
is to synchronize the work, that should not loop
Hi John,
Please apply this to wireless-dev.
Note that this is the second try to submit this patch.
The first try contained a little bug. I'm sorry for that.
If you already applied the first one, I can provide an incremental patch.
Note2 that this patch depends on the
[PATCH]
From: Ralf Baechle [EMAIL PROTECTED]
Date: Tue, 11 Jul 2006 00:25:45 +0100
nr_destroy_socket takes the socket lock itself so it should better be
called with the socket unlocked.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
Applied, thanks Ralf.
-
To unsubscribe from this list: send the
On Tue, 11 Jul 2006 00:54:33 +0200
Michael Buesch [EMAIL PROTECTED] wrote:
Please apply this to wireless-dev.
Note that this is the second try to submit this patch.
The first try contained a little bug. I'm sorry for that.
If you already applied the first one, I can provide an incremental
On Tue, 11 Jul 2006 01:19:02 +0300
Michael S. Tsirkin [EMAIL PROTECTED] wrote:
Quoting r. Michael S. Tsirkin [EMAIL PROTECTED]:
Yes, -mm seems like a good way to get more review.
Andrew, am I using the right format to send things upstream to you?
There's really a set of independent
Use a cloned sk_buff for each netlink message sent to multiple listeners.
Earlier, the same skb, representing a netlink message, was being erroneously
reused for doing genetlink_unicast()'s (effectively netlink_unicast()) to
each listener on the per-cpu list of listeners. Since
Hi all,
For struct irda_device_info in irda.h:
struct irda_device_info {
__u32 saddr;/* Address of local interface */
__u32 daddr;/* Address of remote device */
charinfo[22]; /* Description */
__u8charset; /* Charset used for
Quoting r. Andrew Morton [EMAIL PROTECTED]:
Sure. Although I am a little surprised to be be receiving them while
Roland is in taking-time-off-but-not-really-doing-so mode.
Well, I don't know what's up either, but Roland acked patches explicitly
so I figured that's what he wants, too.
--
MST
David Miller [EMAIL PROTECTED] wrote:
Look at a driver such as 3c509.c, for example.
[...]
If the driver isn't setting up an explicit -set_mac_address handler,
it isn't going to be programming the RX MAC of the chip and therefore
not recognize packets to that new MAC as destined for it.
Implement finding of correct netchannel for buffer, default netchannel and
attach a netchannel to a socket
Signed-off-by: Kelly Daly [EMAIL PROTECTED]
---
diff -urp davem/include/linux/netchannel.h
kelly_new/include/linux/netchannel.h
--- davem/include/linux/netchannel.h2006-06-16
On Tue, Jul 11, 2006 at 03:39:25PM +1000, Kelly Daly ([EMAIL PROTECTED]) wrote:
Implement finding of correct netchannel for buffer, default netchannel and
attach a netchannel to a socket
Signed-off-by: Kelly Daly [EMAIL PROTECTED]
Hi Kelly.
You have a typo in the code commented below.
I
87 matches
Mail list logo
