On Thu, Jul 05, 2007 at 06:59:25PM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always managed to reproduce the problem
within half hour - so far it
- Forwarded message from Ranko Zivojnovic [EMAIL PROTECTED] -
Date: Thu, 05 Jul 2007 18:59:25 +0300
From: Ranko Zivojnovic [EMAIL PROTECTED]
Subject: Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added
to -mm tree
To: Jarek Poplawski [EMAIL PROTECTED]
Cc: [EMAIL
On Fri, Jul 06, 2007 at 08:14:20AM +0200, Jarek Poplawski wrote:
...
This new lockup bug you have just found needs some time
to figure out. BTW, I wonder if you had lockdep on
(CONFIG_PROVE_LOCKING or CONFIG_LOCK_ALLOC)?
Should be:
(CONFIG_PROVE_LOCKING or CONFIG_DEBUG_LOCK_ALLOC)?
Jarek P.
-
Yes those functions are large enough to be de-inlined. I would like to
shrink those to functions, by replacing the switch blocks with a simple
macros, since the mask registers are contiguous.
Will repost a patch based on your patch, after a bit of testing.
Thanks,
-Dhananjay
Stephen Hemminger
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 18:59 +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always
On Tue, 2007-07-03 at 22:20 -0400, jamal wrote:
On Tue, 2007-03-07 at 14:24 -0700, David Miller wrote:
[.. some useful stuff here deleted ..]
That's why you have to copy into a purpose-built set of memory
that is composed of pages that _ONLY_ contain TX packet buffers
and nothing else.
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
private allocations. Woudn't this save some
On Thu, 2007-07-05 at 17:15 -0700, David Miller wrote:
Also even with the scatterlist idea, we'd still need to do two
map calls, one for skb-data and one for the page vector.
We could make skb-shinfo(skb)-frags[0] the first segment and deprecate
skb-data and skb-len.
OK, you can stop hitting
On Thursday 05 July 2007 20:25:50 ext James Chapman wrote:
Rémi Denis-Courmont wrote:
By the way, couldn't encap_type be remove altogether (using two slightly
different callbacks for ESP) from udp_sock?
The notion of encap_type is needed for the setsockopt call so it would
have to stay in
From: Rusty Russell [EMAIL PROTECTED]
Date: Fri, 06 Jul 2007 17:43:46 +1000
On Thu, 2007-07-05 at 17:15 -0700, David Miller wrote:
Also even with the scatterlist idea, we'd still need to do two
map calls, one for skb-data and one for the page vector.
We could make skb-shinfo(skb)-frags[0]
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
Hi Auke,
Kok, Auke schrieb:
tg3.c:
if ((tp-tg3_flags TG3_FLAG_PCIX_TARGET_HWBUG) ||
(tp-tg3_flags2 TG3_FLG2_ICH_WORKAROUND))
is obviously _not_ easier to read than
if (tp-tg3_flags.pcix_target_hwbug || tp-tg3_flags.ich_workaround)
Yes, but what about:
Since there is no Kconfig variable RXRPC anywhere in the tree, and the
variable AF_RXRPC performs exactly the same function, remove the
reference to CONFIG_RXRPC from net/Makefile.
Signed-off-by: Robert P. J. Day [EMAIL PROTECTED]
---
diff --git a/net/Makefile b/net/Makefile
index
On Fri, Jul 06, 2007 at 11:08:35AM +0200, Jarek Poplawski wrote:
...
BSDs were sometimes recommended for specific jobs like mail etc.
but usually linux better fitted the needs. Especially well linux
appeared for an internet gateway/router/firewall/antispam thing,
and the main reasons were:
Hi,
This patch is for cdc subset to support Mavell vendor/product ID.
Jing Xiang
Signed-off-by: Jing Xiang[EMAIL PROTECTED]
diff -uNpr linux-2.6.21.5/driver/usb/net/cdc_subset.c
linux-2.6.21.5.t/driver/usb/net/cdc_subset.c
--- linux-2.6.21.5/driver/usb/net/cdc_subset.c 2007-06-14
Hi all,
This patch
- avoids 7990 blocking when no tx buffer is available,
- implements tx_bytes statistic that was missing
- sets skb-dev before calling netix_rx()
- improves readability and code efficiency in buffer rings initialisation
- avoids useless memset part for tx packets smaller than
On Thu, 2007-07-05 at 15:37 +0200, Patrick McHardy wrote:
Earlier filtering makes sense, especially for userspace. The other
part exceeds my wireless knowledge :)
No worries. I'll see if I can come up with a way to do earlier
filtering, but it's not actually required for the functionality. And
On Thu, 2007-07-05 at 09:53 -0400, jamal wrote:
This email captures the essence of the thread, so let me start here.
I dont know if i read well enough all the details, but i think i have a
good grasp of the discusion.
:)
The DoS issue is applicable IMO to any IPC. i.e
if i have access to
[NET]: Avoid copying writable clones in tunnel drivers
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
commit f9dcf4c066b67c80d81ed2de40f62169f3bb5cf0
tree c7cf908b9b97a9d9476fa7a96372305ec1478078
parent 720d6ee708b60d1f1f61484af02c900134de0651
author Patrick McHardy [EMAIL PROTECTED] Fri,
[please send networking patches to netdev]
Philippe De Muyter wrote:
Hi all,
Make netlink_seq_ops const
Might make more sense to do a big patch for all occurences of this
in net/:
# grep ^static struct seq_operations -r net/ | wc -l
76
-
To unsubscribe from this list: send the line
David Miller wrote:
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index f96ed76..6496e03 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2472,6 +2472,7 @@ static int addrconf_ifdown(struct net_device *dev, int
how)
write_unlock_bh(idev-lock);
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get that parameter out of the way - I will make the same
test on a real machine.
BTW, maybe it would be better to try with something more stable
On Fri, 2007-07-06 at 08:45 +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 18:59 +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running
Matt,
I have applied both changes (and updated the git tree) with a small
caveat on the second patch:
On Thu, 2007-05-07 at 17:59 -0700, Matt Carlson wrote:
The last change makes sure that new xmit_win values, as assigned by the
transmit queue wake code, will not be drastically larger than
Hi all,
When using the r8169 gigabit ethernet network driver under a Sun Entreprise
450, you will encounter a lot of kernel unaligned access on ip_rcv and
ip_fast_csum. The full report is available here :
http://www.mail-archive.com/debian-bugs-dist%40lists.debian.org/msg363433.htm
The
On Fri, Jul 06, 2007 at 02:52:11PM +0200, Patrick McHardy wrote:
[please send networking patches to netdev]
Philippe De Muyter wrote:
Hi all,
Make netlink_seq_ops const
Might make more sense to do a big patch for all occurences of this
in net/:
# grep ^static struct
On Fri, 2007-07-06 at 15:27 +0200, Patrick McHardy wrote:
Ranko Zivojnovic wrote:
Managed to get stuck on a normal machine as well (2.6.22-rc6-mm1 +
sch_htb patch) ... here's the log:
Can you post the script you're using to reproduce this please?
Attached.
R.
tc-crash.sh
Dave
Ok... This one was taken off the the system actually running the patch
so I know this one is correct. I just retested, turning on temporary
addresses as well, and the notification happen correctly.
I was expecting an ACK from Yoshifuji-san before you applied it so feel
free to wait for it.
Rémi Denis-Courmont wrote:
On Thursday 05 July 2007 20:25:50 ext James Chapman wrote:
Rémi Denis-Courmont wrote:
By the way, couldn't encap_type be remove altogether (using two slightly
different callbacks for ESP) from udp_sock?
The notion of encap_type is needed for the setsockopt call so
Ranko Zivojnovic wrote:
Managed to get stuck on a normal machine as well (2.6.22-rc6-mm1 +
sch_htb patch) ... here's the log:
Can you post the script you're using to reproduce this please?
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Hi all
Make all initialized struct seq_operations in net/ const
Signed-off-by: Philippe De Muyter [EMAIL PROTECTED]
diff -r 6c0a10cc415a net/802/tr.c
--- a/net/802/tr.c Thu Jul 5 16:10:16 2007 -0700
+++ b/net/802/tr.c Fri Jul 6 15:17:53 2007 +0200
@@ -567,7 +567,7 @@ static int
On Fri, 2007-07-06 at 14:47 +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get that parameter out of the way - I will make the same
test on a real machine.
Ranko Zivojnovic wrote:
BUG: spinlock lockup on CPU#0, swapper/0, c03eff80
[c01ed1fe] _raw_spin_lock+0x108/0x13c
[c02a8468] __qdisc_run+0x97/0x1b0
[c02a96f3] qdisc_watchdog+0x19/0x58
[c02fe5e7] __lock_text_start+0x37/0x43
[c02a9730] qdisc_watchdog+0x56/0x58
[c02a96da]
On Fri, 2007-06-07 at 17:32 +1000, Rusty Russell wrote:
[..some good stuff deleted here ..]
Hope that adds something,
It does - thanks.
I think i was letting my experience pollute my thinking earlier when
Dave posted. The copy-avoidance requirement is clear to me[1].
I had another issue
On Fri, 2007-07-06 at 16:21 +0200, Patrick McHardy wrote:
Ranko Zivojnovic wrote:
BUG: spinlock lockup on CPU#0, swapper/0, c03eff80
[c01ed1fe] _raw_spin_lock+0x108/0x13c
[c02a8468] __qdisc_run+0x97/0x1b0
[c02a96f3] qdisc_watchdog+0x19/0x58
[c02fe5e7] __lock_text_start+0x37/0x43
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1/atl1_main.c
@@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter *adapter)
On Fri, 2007-06-07 at 12:53 +0200, Johannes Berg wrote:
The genetlink stuff defintely makes sense. I'll have a closer look at
your patches this weekend.
Thanks. I know Zhang Rui will definitely appreciate that too :)
Patrick - please add an ACK from me when you review. The patches
look
Code will do local_irq_save() on it.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/macmace.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/macmace.c
+++ b/drivers/net/macmace.c
@@ -577,7 +577,7 @@ static irqreturn_t mace_interrupt(int irq, void
On Fri, 6 Jul 2007 19:05:25 +0400
Alexey Dobriyan [EMAIL PROTECTED] wrote:
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1/atl1_main.c
jamal wrote:
If the issue is usability of listing 1024 netdevices, i can think of
many ways to resolve it.
One way we can resolve the listing is with a simple tag to the netdev
struct i could say list netdevices for guest 0-10 etc etc.
This would be a useful feature, not only for
Hi. I will address the style issues and other things that Andrew
Morton pointed out---Thanks again for the feedback.
As far as the skb pool goes, I'm afraid my comment is misleading.
What this Patch Does
Even before this recent series of 12 patches to 2.6.22-rc4, the aoe
driver was
Following a discussion we had at OLS concerning L2 network namespace
performances and how the new macvlan driver could potentially improve
them, I've ported the macvlan patchset on top of Eric's net namespace
patchset on 2.6.22-rc4-mm2.
A little bit of history:
Some months ago, when we ran some
David Miller wrote:
Okay, but then using SG lists makes skbuff's much bigger.
fraglistscatterlistper skbuff
32 bit 8 20 +12 * 18 = +216!
64 bit 16 32 +16 * 18 = +288
So never mind...
I know,
On Thu, Jul 05, 2007 at 11:47:20AM -0500, jschopp wrote:
This is the third submission of the network driver for PS3.
The differences from the previous one are:
I notice that this mostly a cut-n-paste of a very old version
of the spidernet device driver. Please note that the old
spidernet had
Document the expectations about device MTU handling.
The documentation about oversize packet handling is probably too
loose.
IMHO devices should drop oversize packets for robustness,
but many devices allow it now. For example, if you set mtu to 1200
bytes, most ether devices will allow a 1500
Update the documentation about locking assumptions.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/Documentation/networking/netdevices.txt 2007-06-25 09:03:04.0
-0700
+++ b/Documentation/networking/netdevices.txt 2007-07-06 10:15:31.0
-0700
@@ -20,7 +20,6 @@
On Mon, 2 Jul 2007 14:37:06 +0100
Daniel J Blueman [EMAIL PROTECTED] wrote:
Hi Stephen,
When the sky2 driver initialises, it sets the the ISR timer register
(STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin
driver sets it to 400, irrespective of the clockspeed of the NIC
Hello!
I just got some Netxen 10Gbe CX4 adapters and put them into freshly
updated Fedora 7 64-bit systems. So far, I am not having much luck.
Kernel is: Official F7 2.6.21-1.3228.fc7
NIC:
01:00.0 Ethernet controller: NetXen Incorporated NXB-10GCX4 10 Gigabit Ethernet
PCIe Adapter with CX4
From: Williams, Mitch A [EMAIL PROTECTED]
Date: Fri, 6 Jul 2007 10:14:56 -0700
In my opinion, IOMMU table locking is the major issue with this type of
architecture. Since both Intel and AMD are touting IOMMUs for virtual-
ization support, this is an issue that's going to need a lot of
Ben Greear wrote:
Hello!
I just got some Netxen 10Gbe CX4 adapters and put them into freshly
updated Fedora 7 64-bit systems. So far, I am not having much luck.
Ahh, 22-pre-7 seems to work much better..no MSI errors and traffic
is passing fine.
Ben
--
Ben Greear [EMAIL PROTECTED]
Candela
I thought I would mention this on the small chance it was an accidental change.
The new __net_timestamp(skb) method uses ktime_get_real which
is exported GPL only.
Now, such evil modules must call net_enable_timestamp(), causing
all packets to be timestamped, not just the ones the evil
module
On Friday 06 July 2007, jing xiang wrote:
Hi,
This patch is for cdc subset to support Mavell vendor/product ID.
Jing Xiang
Signed-off-by: Jing Xiang[EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL PROTECTED]
diff -uNpr linux-2.6.21.5/driver/usb/net/cdc_subset.c
I know that Patrick needs this in order to unload his netfilter
patches on me, so I took care of this today.
There was a minor, trivial to resolve, conflict in netpoll.c
but otherwise everything went in perfectly during the rebase.
-
To unsubscribe from this list: send the line unsubscribe
Sky2 will hang under load due to lost IRQ. It is reproducible fastest on
Yukon EC chips, but others may have same problem.
This patch restores a couple of workarounds from 2.6.16 that reduce
the likely hood of failure. It is not possible to prove this is sufficient
to stop hangs.
* restart
Jeff Garzik wrote:
OK, just looked through the driver. I think its structured inside-out
from what it should be.
Comments:
* is a clear improvement from current e1000
* The multitude of tiny, fine-grained operations for MAC, NVM, PHY, etc.
is a signal that organization is backwards. You
Jeff Garzik wrote:
Kok, Auke wrote:
1a) We post an e1000e driver that implements support for all 8257x
(ich8/9, es2lan etc) devices.
1b) We post a patch that drops support for all of these devices in the
form of a pci-ID removal (no code removed) for e1000.
2) we post patches that remove
[BNX2]: Add bnx2_set_default_link().
Put existing code to setup the default link settings in this new
function. This makes it easier to support the remote PHY feature in
the next few patches.
Also change ETHTOOL_ALL_FIBRE_SPEED to include 2500Mbps if supported.
Signed-off-by: Michael Chan
[BNX2]: Add remote PHY bit definitions.
Add new fields in struct bnx2 and other bit definitions in shared
memory to support remote PHY.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
index 49a5de2..14c0a1e 100644
--- a/drivers/net/bnx2.h
+++
[BNX2]: Add support for remote PHY.
In blade servers, the Serdes PHY in 5708S can control the remote
copper PHY through autonegotiation on the backplane. This patch adds
the logic to interface with the firmware to control the remote PHY
autonegotiation and to handle remote PHY link events.
When
[BNX2]: Add ethtool support for remote PHY.
Modify the driver's ethtool_ops-get_settings and set_settings
functions to support remote PHY. Users control the remote copper
PHY settings by specifying link settings for the tp (twisted pair)
port.
The nway_reset function is also modified to support
[BNX2]: Modify link up message.
Modify the link up dmesg to report remote copper or Serdes link.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 514ad32..dc6dcf5 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -604,12 +604,21
[BNX2]: Reduce spurious INTA interrupts.
Spurious interrupts are often encountered especially on systems
using the 8259 PIC mode. This is because the I/O write to deassert
the interrupt is posted and won't get to the chip immediately. As
a result, the IRQ may remain asserted after the IRQ
[BNX2]: Enhance the heartbeat.
In addition to the periodic heartbeat, we're adding a heartbeat
request interrupt when the heartbeat is late. This is needed during
netpoll where the timer is not available. -rt kernels will also
benefit since the timer is not as accurate.
[ We discussed this
[BNX2]: Print management firmware version.
Add management firmware version for ethtool -i.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 3163868..a3ae3b0 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5546,11 +5546,7 @@
[BNX2]: Update version to 1.6.2.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index a3ae3b0..c590d8c 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -54,8 +54,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
65 matches
Mail list logo
