On 22-08-2007 19:03, Paul E. McKenney wrote:
On Wed, Aug 22, 2007 at 05:41:11PM +0200, Adrian Bunk wrote:
On Wed, Aug 22, 2007 at 05:30:13PM +0200, Gabriel C wrote:
Got it with a randconfig (
http://194.231.229.228/kernel/mm/2.6.23-rc3-mm1/r/randconfig-8 )
...
net/ipv4/fib_trie.c: In
On Fri, Aug 24, 2007 at 12:26:28PM -0700, Stephen Hemminger wrote:
On Fri, 24 Aug 2007 12:10:44 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 22-08-2007 20:08, Stephen Hemminger wrote:
There have been a lot of changes for 2.6.23, so here is a test release
of iproute2 that should
On Saturday 25 August 2007 06:31, Jeff Garzik wrote:
Laurent Pinchart wrote:
This patch splits the receive status in 8bit wide fields and convert the
packet length from little endian to CPU byte order.
Signed-off-by: Laurent Pinchart [EMAIL PROTECTED]
---
drivers/net/dm9000.c | 13
Fixes ancient ATM debug code to at least compile again.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/atm/signaling.c
===
--- net-2.6.24.orig/net/atm/signaling.c 2007-08-27 09:53:40.0 +0200
+++
From: Thomas Graf [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 10:05:37 +0200
Fixes ancient ATM debug code to at least compile again.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Patch applied, thanks Thomas!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
Hello,
Initially pkt_dev can be NULL this causes netif_subqueue_stopped to
oops. The patch below should cure it. But maybe the pktgen TX logic
should be reworked to better support the new multiqueue support.
Cheers
--ro
Signed-off-by: Robert Olsson
On Monday 27 August 2007 03:58, David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Sun, 26 Aug 2007 20:36:20 +0100
David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Fri, 24 Aug 2007 18:16:45 +0100
Does hardware interrupt mitigation really interact well
On Sat, 2007-08-25 at 17:09 -0700, Joe Perches wrote:
@@ -747,22 +741,15 @@ static int ariadne_rx(struct net_device *dev)
skb_copy_to_linear_data(skb, (char *)priv-rx_buff[entry],
pkt_len);
skb-protocol=eth_type_trans(skb,dev);
#if 0
(int)skb-len);
+{
+
On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen Hemminger wrote:
The following driver API is broken on any architecture with 64 bit addresses.
because of cast that loses high bits.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/isdn/capi/capidrv.c 2007-06-25
Stephen Hemminger [EMAIL PROTECTED] writes:
On Fri, 24 Aug 2007 19:55:47 +0400
Denis V. Lunev [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote:
From: Daniel Lezcano [EMAIL PROTECTED]
Doing this makes loopback.c a better example of how to do a
simple network device, and it removes the
On 22-08-2007 21:33, Stephen Hemminger wrote:
Add more kernel doc's for part of the network device API.
This is only a start, and needs more work.
Applies against net-2.6.24
...
+/**
+ * napi_disable - prevent NAPI from scheduling
+ * @n: napi context
+ *
+ * Resume NAPI from being
Hi,
$ git-reset --hard net-2.6.24-origin
HEAD is now at e2eb35e... [ATM]: Fix build errors after conversion to pr_debug()
$ make allyesconfig
...
$ make bzImage
...
CC drivers/net/82596.o
drivers/net/82596.c:1618:1: error: unterminated argument list invoking
macro DEB
drivers/net/82596.c:
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/drivers/net/82596.c
===
--- net-2.6.24.orig/drivers/net/82596.c 2007-08-27 14:43:16.0 +0200
+++ net-2.6.24/drivers/net/82596.c 2007-08-27 14:43:51.0
On 21-08-2007 12:56, Karl Meyer wrote:
fyi:
I do not know whether it is related to the problem, but since using
the version you told me there are these entries is my log:
frege Hangcheck: hangcheck value past margin!
...
BTW, I don't know wheter it's related too, but I think you should try
On Mon, 2007-08-27 at 15:32 +0300, Ilpo Järvinen wrote:
drivers/net/82596.c:1618:1: error: unterminated argument list invoking
macro DEB
Hmm, I would guess that [NET]: Introduce MAC_FMT/MAC_ARG broken it,
though didn't verify it.
The fix is left as an exercise of the reader (i.e., the
Hello,
Below some pktgen support to send into different TX queues.
This can of course be feed into input queues on other machines
Cheers
--ro
Signed-off-by: Robert Olsson [EMAIL PROTECTED]
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index
Introduces a module parameter to decide whether the physical
port link state is propagated to the network stack or not.
It makes sense not to take the physical port state into account
on machines with more logical partitions that communicate
with each other. This is always possible no matter what
Update last_rx in registered device struct instead of
in the dummy device.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
On Mon, 2007-08-27 at 12:54 +0200, Johannes Berg wrote:
Thanks for this patch though, I'd have done it otherwise.
I had it, it was just a s/EUI48/MAC/ and copy/paste thing.
There are also the arch, drivers/[^net], and net directories
that have a few of these.
The patch also added the missing )
Hi Andi,
Andi Kleen wrote:
Shay Goikhman [EMAIL PROTECTED] writes:
Dear Linux maintainers,
I'm doing :
setsockopt(s, SO_RCVTIMEO, t1 ); // set time-out
t1 on socket while block receiving on it
select(,,, fd_set_including(s), .., errs, t2); // block
David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Sun, 26 Aug 2007 20:36:20 +0100
David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Fri, 24 Aug 2007 18:16:45 +0100
Does hardware interrupt mitigation really interact well with NAPI?
It interacts quite excellently.
On Monday 27 August 2007 17:51, James Chapman wrote:
In the second half of my previous reply (which seems to have been
deleted), I suggest a way to avoid this problem without using hardware
interrupt mitigation / coalescing. Original text is quoted below.
I've seen the same and I'm
On Mon, 27 Aug 2007 13:02:26 +0200
Karsten Keil [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen Hemminger wrote:
The following driver API is broken on any architecture with 64 bit
addresses.
because of cast that loses high bits.
Signed-off-by: Stephen
On Mon, Aug 27, 2007 at 08:36:35AM +0200, Jarek Poplawski wrote:
On 22-08-2007 19:03, Paul E. McKenney wrote:
On Wed, Aug 22, 2007 at 05:41:11PM +0200, Adrian Bunk wrote:
On Wed, Aug 22, 2007 at 05:30:13PM +0200, Gabriel C wrote:
Got it with a randconfig (
Hello, It's not a job for pktgen.
Cheers
--ro
Signed-off-by: Robert Olsson [EMAIL PROTECTED]
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 18601af..975e887 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -164,7 +164,7 @@
#include
Jan-Bernd Themann wrote:
On Monday 27 August 2007 17:51, James Chapman wrote:
In the second half of my previous reply (which seems to have been
deleted), I suggest a way to avoid this problem without using hardware
interrupt mitigation / coalescing. Original text is quoted below.
I've
Recent NAPI changes require that napi_enable() is always matched with
a napi_disable(). This patch makes sure that this invariant holds for
e100. It also moves the netif_napi_add() call until after private
pointers have been intialized, though this might only be significant
for cases where netpoll
James Chapman wrote:
Recent NAPI changes require that napi_enable() is always matched with
a napi_disable(). This patch makes sure that this invariant holds for
e100. It also moves the netif_napi_add() call until after private
pointers have been intialized, though this might only be significant
On Mon, Aug 27, 2007 at 06:57:19PM +0200, Robert Olsson wrote:
Hello, It's not a job for pktgen.
Please also kill the do_softirq export while you're at it.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Frank Blaschka [EMAIL PROTECTED]
under memory pressure scatter gather mode switching messages must be
rate limited.
Signed-off-by: Frank Blaschka [EMAIL PROTECTED]
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
drivers/s390/net/qeth_main.c | 13 -
1 file changed, 8
From: Ursula Braun [EMAIL PROTECTED]
Problem:
A recovery thread must not be active when device is removed.
In qeth_remove_device() an interruptible wait operation is used
to wait until a qeth recovery thread is finished. If a user really
interrupts the ungroup operation of a qeth device while a
From: Heiko Carstens [EMAIL PROTECTED]
Signed-off-by: Heiko Carstens [EMAIL PROTECTED]
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
drivers/s390/net/qeth.h |4 ++--
drivers/s390/net/qeth_sys.c |8
2 files changed, 6 insertions(+), 6 deletions(-)
Index:
From: Ursula Braun [EMAIL PROTECTED]
Online setting of a qeth device may fail for instance because of:
- out-of-memory condition when allocating qdio queues
- IDX ACTIVATE problem
- ...
Such a device is still returned in a driver_for_each_device loop
processed in qeth_reboot_event(), which calls
From: Ursula Braun [EMAIL PROTECTED]
Exclusive usage of OSA-cards has been introduced. Even though Linux
does not make use of it, qeth should be prepared to receive a bad RC
for some initialization steps. A meaningful message is now given,
if an OSA-device is set online, even though the
--
qeth patches for 2.6.23-rc3:
- do not allow interruption of ungroup
- scatter gather mode: enforce rate limit
- don't return void function return values
- add tx checkumming for TSO/EDDP mode
- invoke qeth_clear_output_buffer only for allocated qdio queues.
- add specific message for
From: Klaus D. Wacker [EMAIL PROTECTED]
A network interface can get ARP packets even when the interface has
NOARP specified. In a HiperSockets environment this disturbs receiving
systems when packets are sent on the multicast queue. (E.g. TCP/IP on
z/VM issues messages reporting invalid data on
From: Frank Blaschka [EMAIL PROTECTED]
TSO requires tx checksumming. For non GSO frames in TSO/EDDP mode we
have to manually calculate the checksum.
Signed-off-by: Frank Blaschka [EMAIL PROTECTED]
Signed-off-by: Ursula Braun [EMAIL PROTECTED]
---
Subject: [patch 4/7] [PATCH] qeth: Announce tx
Milton Miller wrote:
On Jun 5, 2007, at 8:34 AM, David Acker wrote:
David, Milton,
This was the last communication on-topic for the proposed changes to fix e100 on
ARM. We're holding our breath here waiting for more, and would love to hear that
this issue and fixes hasn't died off.
David Miller wrote:
From: John Heffner [EMAIL PROTECTED]
Date: Sun, 26 Aug 2007 21:32:26 -0400
There are a few interesting things here. For one, the bursts caused by
TSO seem to be causing the receiver to do stretch acks. This may have a
negative impact on flow performance, but it's hard
Christoph Hellwig writes:
Hello, It's not a job for pktgen.
Please also kill the do_softirq export while you're at it.
Right seems like pktgen luckily was the only user.
Cheers
--ro
Signed-off-by: Robert Olsson [EMAIL PROTECTED]
diff --git
Kok, Auke wrote:
Milton Miller wrote:
On Jun 5, 2007, at 8:34 AM, David Acker wrote:
David, Milton,
This was the last communication on-topic for the proposed changes to fix
e100 on ARM. We're holding our breath here waiting for more, and would
love to hear that this issue and fixes hasn't
From: Jan-Bernd Themann [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 11:47:01 +0200
So the question is simply: Do we want drivers that need (benefit
from) a timer based polling support to implement their own timers
each, or should there be a generic support?
I'm trying to figure out how an
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 12:54:09 +0200
-- change macros to --
#define MAC_FMT %s
#define MAC_ARG(a) ({char __buf[18]; print_mac(a, buf); __buf})
I'm not sure we'd want that, but at the time you said it made the kernel
significantly smaller and I doubt
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 15:32:26 +0300 (EEST)
Hmm, I would guess that [NET]: Introduce MAC_FMT/MAC_ARG broken it,
though didn't verify it.
This will be the 4th or so build regression I'll have to clean up from
that patch.
I'm just going to revert it.
-
To
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 14:52:59 +0200
This fixes a typo in commit f98d4ca4986fec.
One of many.
At least 5 drivers didn't build because of this patch. And this is
incredibly trivial stuff. It's not like your changing the core
NAPI code for 20+ drivers,
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 08:44:17 -0700
The compound statement to hide the automatic works well.
As I explained in another reply, it doesn't work well.
It's undefined to reference that in-expression local
variable after the expression is done being evaluated.
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 12:54:09 +0200
#define MAC_FMT %s
#define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf); __buf;})
I don't think this works.
$ cat test_fmt.c
#include stdio.h
#include
From: James Chapman [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 16:51:29 +0100
To implement this, there's no need for timers, hrtimers or generic NAPI
support that others have suggested. A driver's poll() would set an
internal flag and record the current jiffies value when finding
workdone=0
Kok, Auke wrote:
James Chapman wrote:
Recent NAPI changes require that napi_enable() is always matched with
a napi_disable(). This patch makes sure that this invariant holds for
e100. It also moves the netif_napi_add() call until after private
pointers have been intialized, though this might
On Mon, 27 Aug 2007 13:57:42 -0700
Joe Perches [EMAIL PROTECTED] wrote:
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 12:54:09 +0200
#define MAC_FMT %s
#define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf);
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 13:57:42 -0700
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 12:54:09 +0200
#define MAC_FMT %s
#define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf);
From: James Chapman [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 22:03:15 +0100
Kok, Auke wrote:
James Chapman wrote:
nic = netdev_priv(netdev);
-netif_napi_add(netdev, nic-napi, e100_poll, E100_NAPI_WEIGHT);
nic-netdev = netdev;
nic-pdev = pdev;
nic-msg_enable =
On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
there are better approaches to this,
how about just calling:
print_mac(dev-dev_addr);
Sure, we'll have to split up printk() calls, but in the end it's
likely still smaller and better. And I think it's much cleaner
than this
From: Joe Perches [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 14:26:46 -0700
My original patch had the equivalent of
char* print_mac(char* buf, const char* addr) {
sprintf(buf,%02x:..., addr[0]...)
return buf;
}
and used:
David Miller wrote:
From: James Chapman [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 16:51:29 +0100
To implement this, there's no need for timers, hrtimers or generic NAPI
support that others have suggested. A driver's poll() would set an
internal flag and record the current jiffies value when
From: James Chapman [EMAIL PROTECTED]
Date: Mon, 27 Aug 2007 22:41:43 +0100
I don't recall saying anything in previous posts about this. Are you
confusing my posts with Jan-Bernd's?
Yes, my bad.
Jan-Bernd has been talking about using hrtimers to _reschedule_
NAPI. My posts are suggesting
Say Evgeniy, something I was curious about but forgot to ask you
earlier...
On Wednesday 08 August 2007 03:17, Evgeniy Polyakov wrote:
...All oerations are not atomic, since we do not care about precise
number of bios, but a fact, that we are close or close enough to the
limit.
... in
Adrian Bunk wrote:
This patch contains the planned removal of the eepro100 driver.
Signed-off-by: Adrian Bunk
you lost your e-mail address? :)
---
This patch has been sent on:
- 14 Aug 2007
- 29 Jul 2007
currently we won't have e100 fixed up for ARM in 2.6.23, so removing this for
On Wed, 22 Aug 2007, Bruce Cole wrote:
Shane wrote:
On Wed, Aug 22, 2007 at 09:39:47AM -0700, Bruce Cole wrote:
Shane, join the crowd :) Try the fix I just re-posted over here:
Bruce, gigabit speeds thanks for the pointer. This fix
works well for me though I just added the three or so
On Sun, 2007-26-08 at 19:04 -0700, David Miller wrote:
The transfer is much better behaved if we ACK every two full sized
frames we copy into the receiver, and therefore don't stretch ACK, but
at the cost of cpu utilization.
The rx coalescing in theory should help by accumulating more ACKs on
On Mon, Aug 27, 2007 at 02:58:05PM -0700, Kok, Auke wrote:
Adrian Bunk wrote:
...
This patch has been sent on:
- 14 Aug 2007
- 29 Jul 2007
currently we won't have e100 fixed up for ARM in 2.6.23, so removing this
for 2.6.24 sounds a bit premature. Maybe 2.6.25. Can you
Fix the bug that 'ifconfig eth0 down' would hang up, reported by Stefan
Assmann [EMAIL PROTECTED].
As we removed netif_poll_enable() from dev-open(), we should not use
netif_poll_disable() in dev-stop().
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED]
---
62 matches
Mail list logo
