Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

2007-08-28 Thread Joe Perches
On Tue, 2007-08-28 at 00:01 +, Linux Kernel Mailing List wrote: +NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK) +P: Paul Moore +M: [EMAIL PROTECTED] +L: netdev@vger.kernel.org +S: Maintained + Aren't there now 2 subsystems in MAINTAINERS for the same thing?

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Andrew Morton
On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote: ... WARNING: div64_64 [net/netfilter/xt_connbytes.ko] has no CRC! ... Patch below. Regards, Gabriel cu Adrian -- snip -- This patch

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 22:03:15 +0100 Kok, Auke wrote: James Chapman wrote: nic = netdev_priv(netdev); -netif_napi_add(netdev, nic-napi, e100_poll, E100_NAPI_WEIGHT); nic-netdev = netdev; nic-pdev = pdev;

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Sam Ravnborg
On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote: On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote: ... WARNING: div64_64 [net/netfilter/xt_connbytes.ko] has no CRC! ... Patch below.

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread Johannes Berg
On Mon, 2007-08-27 at 14:26 -0700, Joe Perches wrote: char* print_mac(char* buf, const char* addr) { sprintf(buf,%02x:..., addr[0]...) return buf; } and used: DECLARE_MAC_BUF(var); //same as char var[18]; printk(MAC_FMT, MAC_ARG(var,

Re: [PATCH 3/4] Net: ath5k, use short preamble for some rates

2007-08-28 Thread Johannes Berg
On Sat, 2007-08-25 at 03:58 -0400, Jiri Slaby wrote: ath5k, use short preamble for some rates 2, 5.5 and 11 in b/g are now in short preamble mode umm, mac80211 needs to be able to choose depending on the network. johannes signature.asc Description: This is a digitally signed message part

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 22:41:43 +0100 I don't recall saying anything in previous posts about this. Are you confusing my posts with Jan-Bernd's? Yes, my bad. Jan-Bernd has been talking about using hrtimers to _reschedule_ NAPI. My

[PATCH net-2.6.24] [NET]: DIV_ROUND_UP cleanup (part two)

2007-08-28 Thread Ilpo Järvinen
Hopefully captured all single statement cases under net/. I'm not too sure if there is some policy about #includes that are guaranteed (ie., in the current tree) to be available through some other #included header, so I just added linux/kernel.h to each changed file that didn't #include it

is traffic shaper genuinely obsolete?

2007-08-28 Thread Robert P. J. Day
given drivers/net/Kconfig: ... config SHAPER tristate Traffic Shaper (OBSOLETE) ... is that traffic shaper really obsolete to the point where it can be tossed. i have a patch ... rday -- Robert P. J. Day

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-28 Thread Evgeniy Polyakov
On Mon, Aug 27, 2007 at 02:57:37PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: Say Evgeniy, something I was curious about but forgot to ask you earlier... On Wednesday 08 August 2007 03:17, Evgeniy Polyakov wrote: ...All oerations are not atomic, since we do not care about precise

Re: is traffic shaper genuinely obsolete?

2007-08-28 Thread David Miller
From: Robert P. J. Day [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 05:54:57 -0400 (EDT) given drivers/net/Kconfig: ... config SHAPER tristate Traffic Shaper (OBSOLETE) ... is that traffic shaper really obsolete to the point where it can be tossed. i have a patch ... It's

Re: is traffic shaper genuinely obsolete?

2007-08-28 Thread Robert P. J. Day
On Tue, 28 Aug 2007, David Miller wrote: From: Robert P. J. Day [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 05:54:57 -0400 (EDT) given drivers/net/Kconfig: ... config SHAPER tristate Traffic Shaper (OBSOLETE) ... is that traffic shaper really obsolete to the point

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
On Monday 27 August 2007 22:37, David Miller wrote: From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 11:47:01 +0200 So the question is simply: Do we want drivers that need (benefit from) a timer based polling support to implement their own timers each, or should there be

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
Hi On Monday 27 August 2007 23:02, David Miller wrote: But there are huger fish to fry for you I think. Talk to your platform maintainers and ask for an interface for obtaining a flat static distribution of interrupts to cpus in order to support multiqueue NAPI better. In your previous

[PATCH 0/3] netxen bug fixes

2007-08-28 Thread dhananjay
3 bugfixes for netxen NIC driver: one removes firmware initialzation workaround, other fixes a crash during driver unload and third improves ethtool support. Generated against upstream-fixes branch. drivers/net/netxen/netxen_nic.h |2 +- drivers/net/netxen/netxen_nic_ethtool.c |

[PATCH 1/3] netxen: Avoid firmware load in PCI probe

2007-08-28 Thread dhananjay
Loading firmware during PCI probe can lead to incorrect initialization, rendering the card unusable until next reboot. This was introduced a while ago as a workaround for firmware bug, a better workaround was submitted for this a while ago. So removing original hack that loads firmware during

[PATCH 2/3] netxen: fix crashes during module unload

2007-08-28 Thread dhananjay
This patch fixes two problems during driver unload. The pci_disable_device() call is before firmware reload, causing reads and writes across PCI bus after disabling device. Second problem is the register window was wrong during firmware reload Signed-off by: Dhananjay Phadke [EMAIL PROTECTED]

[PATCH 3/3] netxen: ethtool fixes

2007-08-28 Thread dhananjay
This patch improves ethtool support for printing correct ring statistics, segmentation offload status, etc. Signed-off by: Dhananjay Phadke [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/netxen/netxen_nic.h === ---

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Jan-Bernd Themann
On Tuesday 28 August 2007 11:22, James Chapman wrote: So in this scheme what runs -poll() to process incoming packets? The hrtimer? No, the regular NAPI networking core calls -poll() as usual; no timers are involved. This scheme simply delays the napi_complete() from the driver so the

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread Evgeniy Polyakov
On Tue, Aug 28, 2007 at 01:48:20PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: I'm not sure if I understand your approach correctly. This approach may reduce the number of interrupts, but it does so by blocking the CPU for up to 1 jiffy (that can be quite some time on some platforms).

Re: [PATCH] isdn capi driver broken on 64 bit.

2007-08-28 Thread Karsten Keil
Hello Steven, On Mon, Aug 27, 2007 at 09:16:55AM -0700, Stephen Hemminger wrote: On Mon, 27 Aug 2007 13:02:26 +0200 Karsten Keil [EMAIL PROTECTED] wrote: On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen Hemminger wrote: The following driver API is broken on any architecture with 64 bit

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-08-28 Thread OBATA Noboru
Hi Dave, From: David Miller [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2) Date: Thu, 12 Jul 2007 13:24:48 -0700 (PDT) From: OBATA Noboru [EMAIL PROTECTED] Date: Thu, 12 Jul 2007 22:59:50 +0900 (JST) How do you think TCP timeouts in Linux can adapt

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Michael Matz
Hi, On Tue, 28 Aug 2007, Sam Ravnborg wrote: Googeling I did not find a good description of where __extension__ can be used so I fail to see where in the parse.y file I shal add the keyword. I think __extension__ may be used both as a part of an expression AND as part of a typedef (as in

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread Michael Buesch
On Monday 27 August 2007 23:11:50 David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 13:57:42 -0700 On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: From: Johannes Berg [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 12:54:09 +0200 #define MAC_FMT %s

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Adrian Bunk
On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote: On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote: ... WARNING: div64_64 [net/netfilter/xt_connbytes.ko] has no CRC! ... Patch below.

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Randy Dunlap
On Tue, 28 Aug 2007 10:43:15 +0200 Sam Ravnborg wrote: On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote: On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote: ... WARNING: div64_64

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread James Chapman
Jan-Bernd Themann wrote: On Tuesday 28 August 2007 11:22, James Chapman wrote: So in this scheme what runs -poll() to process incoming packets? The hrtimer? No, the regular NAPI networking core calls -poll() as usual; no timers are involved. This scheme simply delays the napi_complete() from

Re: [PATCH 3/4] Net: ath5k, use short preamble for some rates

2007-08-28 Thread Jiri Slaby
Johannes Berg napsal(a): On Sat, 2007-08-25 at 03:58 -0400, Jiri Slaby wrote: ath5k, use short preamble for some rates 2, 5.5 and 11 in b/g are now in short preamble mode umm, mac80211 needs to be able to choose depending on the network. Hmm, misleading log comment. It should be 'can now

Re: [PATCH] isdn capi driver broken on 64 bit.

2007-08-28 Thread Stephen Hemminger
On Tue, 28 Aug 2007 15:07:04 +0200 Karsten Keil [EMAIL PROTECTED] wrote: Hello Steven, On Mon, Aug 27, 2007 at 09:16:55AM -0700, Stephen Hemminger wrote: On Mon, 27 Aug 2007 13:02:26 +0200 Karsten Keil [EMAIL PROTECTED] wrote: On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen

cpufreq affects traffic control rates

2007-08-28 Thread DervishD
Hi all :) I noticed lately that my traffic control rates were being very slow, about 40% less than expected, and finally spotted the problem: cpufreq. Looks like HTB puts buckets according to the requested rate but assuming that the CPU is running at its default clock or something

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-08-28 Thread John Heffner
OBATA Noboru wrote: Is it correct that you think my problem can be addressed either by the followings? (1) Make the application timeouts longer. (Steve has shown that making an application timeouts twice the failover detection timeout would be a solution.) Right. Is there something

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-28 Thread Vlad Yasevich
Wei Yongjun wrote: A ootb chunk such as data in close state or init-ack in estab state will cause SCTP to enter dead loop. Look like this: (1) Endpoint A Endpoint B (Closed)(Closed) DATA - Kernel dead loop

[PATCH 2/5] Net: ath5k, switch to ioread/iowrite

2007-08-28 Thread Jiri Slaby
ath5k, switch to ioread/iowrite Do not use readl/writel, since iomap retval is platform dependent and needn't be virtual address awaited by readl/writel. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 64b9d0578668fe8c7a43eadace673bc3e57fc22b tree 4990ed95e4112d79830d306ab6ae7afb2235f190

[PATCH 3/5] Net: ath5k, use int as retval

2007-08-28 Thread Jiri Slaby
ath5k, use int as retval Convert some functions to return int and proper negative return value on error as we are used to. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470 tree 44cd0736147325e35c32274eb53bd543fb1510a9 parent

[PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-28 Thread Jiri Slaby
ath5k, license is GPLv2 The files are available only under GPLv2 since now. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 330c2ab9a53ddce27003218bd546034e8eeeff17 tree b24cecd991fbe3046d5c5269c61e0090427e4fd3 parent ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470 author Jiri Slaby [EMAIL

malformed captured packets

2007-08-28 Thread Toralf Förster
I use at home an DSL connection (stable Gentoo system), current kernel is 2.6.22-gentoo-r5. I attached 2 pcap files with the communication of the KDE program kscd with the CDDB server freedb.org, sniffed from interface ppp0 and eth0 respectively. The sniffed network stream over the ppp0

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Johannes Berg
On Tue, 2007-08-28 at 11:58 -0400, Jiri Slaby wrote: [...] There really is no need to CC netdev, those on linux-wireless don't need to get it twice (if they're also on netdev) and those on netdev aren't too concerned about wireless-dev (and if they are really need to sign up to linux-wireless)

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 09:22:36 +0100 I like this idea. A quick survey of other NAPI drivers doesn't show any that do an explicit napi_disable() at init, though they might do so from internal functions. Each driver would need to be

[PATCH 5/5] Net: ath5k, kconfig changes

2007-08-28 Thread Jiri Slaby
ath5k, kconfig changes - build 5120, 5111 and 5112 optionally - alter Kconfig text Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 0902114e92b19bc080780f21f98807688244fc8f tree d7b4a039e4d14ae73faf1b33907c38825d198461 parent 330c2ab9a53ddce27003218bd546034e8eeeff17 author Jiri Slaby

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

2007-08-28 Thread Joe Perches
On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote: If having both a labeled networking and NetLabel maintainer entry is a problem then how about the patch below? I don't think it is. -NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK) +NETWORKING [LABELED] (NetLabel/CIPSO,

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: obj-$(CONFIG_ATH5K) += ath5k.o -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ + ath5k_hw_phy.o ath5k_hw_inivals.o Btw, this

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ + ath5k_hw_phy.o ath5k_hw_inivals.o And while I'm at nitpicking :) ath5k_hw_phy.o

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: ath5k, license is GPLv2 The files are available only under GPLv2 since now. Is this really a good idea? Most of the reverse-engineering was done by the OpenBSD folks, and it would certainly be helpful to work together with them on

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote: +config ATH5K_AR5210 + bool Support AR5210 + depends on ATH5K + default y + +config ATH5K_AR5211 + bool Support AR5211 + depends on ATH5K + default y + +config ATH5K_AR5212 + bool Support AR5212 +

Re: Distributed storage.

2007-08-28 Thread Evgeniy Polyakov
On Fri, Aug 03, 2007 at 09:04:51AM +0400, Manu Abraham ([EMAIL PROTECTED]) wrote: On 7/31/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote: TODO list currently includes following main items: * redundancy algorithm (drop me a request of your own, but it is highly unlikley that

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Sam Ravnborg
It fixes a bug exposed by a -mm only patch, not by the net tree (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). But I'd like a better description, please. Which non-gcc parser are we talking about here? Something under ./scripts/. Well, please identify it, and describe

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Mike Frysinger
On 8/28/07, Sam Ravnborg [EMAIL PROTECTED] wrote: But I'd like a better description, please. Which non-gcc parser are we talking about here? Something under ./scripts/. Well, please identify it, and describe what the problem is, and how the proposed patch will address it. ...

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Larry Finger
Johannes Berg wrote: On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ +

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-28 Thread Evgeniy Polyakov
On Tue, Aug 28, 2007 at 10:27:59AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: We do not care about one cpu being able to increase its counter higher than the limit, such inaccuracy (maximum bios in flight thus can be more than limit, difference is equal to the number of CPUs - 1)

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Johannes Berg
On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ + ath5k_hw_phy.o

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-28 Thread Daniel Phillips
On Tuesday 28 August 2007 02:35, Evgeniy Polyakov wrote: On Mon, Aug 27, 2007 at 02:57:37PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: Say Evgeniy, something I was curious about but forgot to ask you earlier... On Wednesday 08 August 2007 03:17, Evgeniy Polyakov wrote: ...All

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Adrian Bunk
On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote: It fixes a bug exposed by a -mm only patch, not by the net tree (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). But I'd like a better description, please. Which non-gcc parser are we talking about here?

Re: [-mm patch] make types.h usable for non-gcc C parsers

2007-08-28 Thread Sam Ravnborg
On Tue, Aug 28, 2007 at 07:59:04PM +0200, Adrian Bunk wrote: On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote: It fixes a bug exposed by a -mm only patch, not by the net tree (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). But I'd like a better description,

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

2007-08-28 Thread Paul Moore
On Tuesday, August 28 2007 12:45:50 pm Joe Perches wrote: On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote: If having both a labeled networking and NetLabel maintainer entry is a problem then how about the patch below? I don't think it is. -NETWORKING [LABELED] (NetLabel, CIPSO,

[PATCH] netlink: use container_of instead

2007-08-28 Thread Denis Cheng
this could make future redesign of struct netlink_sock easier. Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- net/netlink/af_netlink.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 5681ce3..a78d962 100644 ---

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-28 Thread Roland Dreier
Sorry for the long latency, I was at the beach all last week. And direct data placement really does give you a factor of two at least, because otherwise you're stuck receiving the data in one buffer, looking at some of the data at least, and then figuring out where to copy it. And

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-28 Thread Luis R. Rodriguez
On 8/28/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: ath5k, license is GPLv2 The files are available only under GPLv2 since now. Is this really a good idea? Most of the reverse-engineering was done by the OpenBSD folks, and

[PATCH v3 1/8] Generic bitbanged MDIO library

2007-08-28 Thread Scott Wood
Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood [EMAIL PROTECTED] ---

[PATCH v3 3/8] fs_enet: Include linux/string.h from linux/fs_enet_pd.h

2007-08-28 Thread Scott Wood
It is needed for strstr(). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- include/linux/fs_enet_pd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h index 543cd3c..815c6f9 100644 --- a/include/linux/fs_enet_pd.h

[PATCH v3 4/8] fs_enet: Don't share the interrupt.

2007-08-28 Thread Scott Wood
This driver can't handle an interrupt immediately after request_irq (making it fail with CONFIG_DEBUG_SHIRQ), and has unshared interrupts on all hardware I'm aware of. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |2 +- 1 files changed, 1 insertions(+),

[PATCH v3 6/8] fs_enet: Align receive buffers.

2007-08-28 Thread Scott Wood
At least some hardware driven by this driver needs receive buffers to be aligned on a 16-byte boundary. This usually happens by chance, but it breaks if slab debugging is enabled. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 21 +++--

[PATCH v3 7/8] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-28 Thread Scott Wood
The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM platforms are dropped from arch/ppc (which will hopefully be soon), and

[PATCH v3 5/8] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-28 Thread Scott Wood
These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/mac-fcc.c | 25

[PATCH v3 8/8] fs_enet: sparse fixes

2007-08-28 Thread Scott Wood
Mostly a bunch of __iomem annotations. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 16 +- drivers/net/fs_enet/fs_enet.h | 30 +- drivers/net/fs_enet/mac-fcc.c | 60 ---

[PATCH v3 2/8] fs_enet: Whitespace cleanup.

2007-08-28 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-fec.c |1 - 4 files changed, 41 insertions(+),

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 13:19:03 +0200 I will try the following scheme (once we get hrtimers): Each device (queue) has a hrtimer. Schedule the timer in the poll function instead of reactivating IRQs when a high load situation has been detected and all

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 13:21:09 +0200 So I guess one solution is to force an HW interrupt when two many RQs are processed on the same CPU (when no IRQ pinning is used). This is something the driver has to handle. No, the solution is to lock the

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-08-28 Thread David Miller
From: OBATA Noboru [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 22:04:47 +0900 (JST) (1) Make the application timeouts longer. (Steve has shown that making an application timeouts twice the failover detection timeout would be a solution.) This is the only feasible solution to your

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-28 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 12:38:07 -0700 It seems that the NIC would also have to look into a TCP stream (and handle out of order segments etc) to find message boundaries for this to be equivalent to what an RDMA NIC does. It would work for data that

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-28 Thread David Miller
From: James Chapman [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 17:06:14 +0100 David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 09:22:36 +0100 [NET]: Make NAPI polling independent of struct net_device objects. This patch version works fine with e100 and

make bnx2.c use msleep()

2007-08-28 Thread Arjan van de Ven
bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an msleep so just make it do that instead... Signed-off-by: Arjan van de Ven [EMAIL PROTECTED] --- linux-2.6.23-rc2/drivers/net/bnx2.c.org

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-28 Thread Daniel Phillips
On Tuesday 28 August 2007 10:54, Evgeniy Polyakov wrote: On Tue, Aug 28, 2007 at 10:27:59AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: We do not care about one cpu being able to increase its counter higher than the limit, such inaccuracy (maximum bios in flight thus can be more

Re: make bnx2.c use msleep()

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote: bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an msleep so just make it do that instead... REG_WR(bp,

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread Joe Perches
On Mon, 2007-08-27 at 14:37 -0700, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] My original patch had the equivalent of char* print_mac(char* buf, const char* addr) { sprintf(buf,%02x:..., addr[0]...) return buf; } and used:

Re: make bnx2.c use msleep()

2007-08-28 Thread Michael Chan
On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an msleep so just make it do that instead... Signed-off-by: Arjan van de Ven [EMAIL

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev-priv usage

2007-08-28 Thread Roland Dreier
I take that back. Rejected -- it breaks infiniband build. To be more precise: drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open': drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV' it seems the problem is that T3CDEV() has

Re: make bnx2.c use msleep()

2007-08-28 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:11:19 -0700 On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 14:12:00 -0700 I've forward ported what I had. Option 1: DECLARE_MAC_BUF(var); printk(MAC_FMT, MAC_ARG(var, dev-dev_addr)); perhaps it looks nicer to remove the MAC_FMT and defines. Option 2:

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev-priv usage

2007-08-28 Thread Divy Le Ray
Roland Dreier wrote: I take that back. Rejected -- it breaks infiniband build. To be more precise: drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open': drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV' it seems the

Re: make bnx2.c use msleep()

2007-08-28 Thread Michael Chan
On Tue, 2007-08-28 at 22:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote: bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an msleep so

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread Joe Perches
On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote: Option 2: DECLARE_MAC_BUF(mac); printk(%s, print_mac(mac, dev-dev_addr)); Between them, 1 and 2 seem roughly the same, but I'm slightly leaning towards 2. 2 it is then. I thought you said Johannes' patch was reverted, but so

Re: make bnx2.c use msleep()

2007-08-28 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:21:30 -0700 This is a special case since we are resetting the chip. A read right after chip reset will hang the bus especially for A0 and A1 and that's why we need the msleep(). TG3 also has the same problem with chip reset.

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 14:30:33 -0700 I thought you said Johannes' patch was reverted, but so far it seems not. http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.24.git;a=summary Against what tree do you want a patch? No hurry of course. I'm

Re: make bnx2.c use msleep()

2007-08-28 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:11:19 -0700 On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: bnx2.c (incorrectly) sets current-state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an

Re: make bnx2.c use msleep()

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:21:30 -0700 This is a special case since we are resetting the chip. A read right after chip reset will hang the bus especially for A0 and A1 and that's why we

RE: [PATCH] e100 module loads 1/2 times

2007-08-28 Thread Brandeburg, Jesse
Willy Tarreau wrote: --- e100-3.5.17/src/e100.c.orig 2007-08-13 08:53:18 +0200 +++ e100-3.5.17/src/e100.c2007-08-13 09:24:56 +0200 @@ -2934,13 +2934,13 @@ printk(KERN_INFO PFX %s\n, DRV_COPYRIGHT); } #ifdef E100_USE_REBOOT_NOTIFIER - retval =

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-28 Thread Luis R. Rodriguez
On 8/28/07, Larry Finger [EMAIL PROTECTED] wrote: Johannes Berg wrote: On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o

Re: [PATCH] e100 module loads 1/2 times

2007-08-28 Thread Willy Tarreau
On Tue, Aug 28, 2007 at 02:43:23PM -0700, Brandeburg, Jesse wrote: Willy Tarreau wrote: --- e100-3.5.17/src/e100.c.orig 2007-08-13 08:53:18 +0200 +++ e100-3.5.17/src/e100.c 2007-08-13 09:24:56 +0200 @@ -2934,13 +2934,13 @@ printk(KERN_INFO PFX %s\n, DRV_COPYRIGHT);

Re: make bnx2.c use msleep()

2007-08-28 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu: On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:21:30 -0700 This is a special case since we are resetting the chip. A read right after

Re: make bnx2.c use msleep()

2007-08-28 Thread Michael Chan
On Tue, 2007-08-28 at 19:07 -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu: On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:21:30 -0700 This is

Re: make bnx2.c use msleep()

2007-08-28 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 16:27:12 -0700 [BNX2]: Add write posting comment. Add comment to explain why we cannot read back after chip reset before delaying. Signed-off-by: Michael Chan [EMAIL PROTECTED] Patch applied, thanks. - To unsubscribe from this

Re: [PATCH] netlink: use container_of instead

2007-08-28 Thread David Miller
From: Denis Cheng [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 03:12:04 +0800 this could make future redesign of struct netlink_sock easier. Signed-off-by: Denis Cheng [EMAIL PROTECTED] Seems reasonable, patch applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: pktgen multiqueue oops

2007-08-28 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 11:16:19 +0200 Initially pkt_dev can be NULL this causes netif_subqueue_stopped to oops. The patch below should cure it. But maybe the pktgen TX logic should be reworked to better support the new multiqueue support.

Re: pktgen Multiqueue support [PATCH]

2007-08-28 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 16:55:19 +0200 Below some pktgen support to send into different TX queues. This can of course be feed into input queues on other machines Signed-off-by: Robert Olsson [EMAIL PROTECTED] Thanks for implementing this Robert, patch

Re: Remove softirq scheduling from pktgen [PATCH]

2007-08-28 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 18:57:19 +0200 Hello, It's not a job for pktgen. Signed-off-by: Robert Olsson [EMAIL PROTECTED] Applied, thanks Robert. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

pktgen terminating condition

2007-08-28 Thread Mandeep Singh Baines
Hi, I am having some trouble using pktgen with certain NICs. When running pktgen on some NICs, the test stalls because the worker thread is waiting for the driver to free the last skb. If a send a few pings out the interface, the worker thread will eventually unblock. Below is the snippet of

Re: Remove softirq scheduling from pktgen [PATCH]

2007-08-28 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 20:22:26 +0200 Christoph Hellwig writes: Hello, It's not a job for pktgen. Please also kill the do_softirq export while you're at it. Right seems like pktgen luckily was the only user. Signed-off-by: Robert Olsson

Re: [PATCH net-2.6.24] [NET]: DIV_ROUND_UP cleanup (part two)

2007-08-28 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 12:59:59 +0300 (EEST) Hopefully captured all single statement cases under net/. I'm not too sure if there is some policy about #includes that are guaranteed (ie., in the current tree) to be available through some other #included

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-28 Thread David Miller
From: Michael Buesch [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 16:48:44 +0200 On Monday 27 August 2007 23:11:50 David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 13:57:42 -0700 On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: From: Johannes Berg

Re: pktgen terminating condition

2007-08-28 Thread David Miller
From: Mandeep Singh Baines [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 15:47:18 -0700 It seems that some drivers do not immediately free skbs on transmit complete. They will hold the skb until there are more packets to free. One example is the sis900 driver which uses TX_IDLE (tx state-machine

  1   2   >