Hi again,
Herbert Xu wrote:
On Thu, Nov 29, 2007 at 04:45:33PM -0500, John W. Linville wrote:
So, did the patch below fix the problem? Should I apply it?
I'm keen to find out the result too :)
Chances are it does make progress however we may still have the
general wireless/IP stack
Holger Hoffstaette a écrit :
Hi -
This regular Linux user and lkml lurker just noticed data corruption in
ftp'ed files and narrowed it down to vsftpd using sendfile(). So far this
has never caused problems in the past; I have not noticed this with
2.6.22.x but may have missed it. I do remember
This is the core.
* add the ctl_table_header on the struct net;
* make the unix_sysctl_register and _unregister clone the table;
* moves calls to them into per-net init and exit callbacks;
* move the .data pointer in the proper place.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
This looks very much like the patch for neighbors.
The path is also located on the stack and is prepared
inside the function. This time, the call to the registering
function is guarded with the RTNL lock, but I decided
to keep it on the stack not to litter the devinet.c file
with unneeded names
This looks very much like the patch for ipv4's devinet.
This is also intended to help us with the net namespaces
and saves the ipv6.ko size by ~320 bytes.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8b93593..37e2cc0 100644
On Sat, Dec 01, 2007 at 07:59:16AM +1100, Benjamin Herrenschmidt wrote:
On Fri, 2007-11-30 at 08:29 -0600, Olof Johansson wrote:
Hi,
On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote:
This adds support for the Agere ET1011c PHY as found on the AMCC Taishan
Quoting Eric W. Biederman ([EMAIL PROTECTED]):
Serge E. Hallyn [EMAIL PROTECTED] writes:
Hey Eric,
the patches look nice.
The hand-forcing of the passed-in net_ns into a copy of current-nsproxy
does make it seem like nsproxy may not be the best choice of what to
pass in.
On Fri, Nov 30, 2007 at 04:37:21PM -0800, Paul E. McKenney wrote:
The rcu_assign_pointer() primitive currently unconditionally executes
a memory barrier, even when a NULL pointer is being assigned. This
has lead some to avoid using rcu_assign_pointer() for NULL pointers,
which loses the
On Fri, 30 Nov 2007 08:48:15 -0500
Elvis Pranskevichus [EMAIL PROTECTED] wrote:
On Sun November 25 2007 04:57:42 pm Elvis Pranskevichus wrote:
On Sunday November 25 2007 04:25:06 pm Stephen Hemminger wrote:
Two important bits of data:
1) What is hardware (output of lspci and dmesg)
Hello.
Thank you for detailed explanation.
Samir Bellabes wrote:
By filtering, you should mean packets filtring, shouldn't you ?
because this hook is able to deny the accept() syscall for a process, so
it's a kind of filtring too.
Yes, you are right.
No, it's performed from the userspace.
Pavel Emelyanov [EMAIL PROTECTED] writes:
Hi, Herbert, guys.
Since you have accepted some net-namespaces-related work
from Eric (sysctl namespaces), I hope, that you can pay
some attention to further work in this direction.
This set makes the unix-sockets sysctls (currently this
includes
dma_addr_t is 64bit wide on some architectures (for example 64bit MIPS),
so it's not a good idea to use it for 32bit wide addresses in descriptors.
Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED]
---
drivers/net/lib82596.c | 50
1 files
Roland Dreier wrote:
- skb = netdev_alloc_skb(lro_mgr-dev, hlen);
+ skb = netdev_alloc_skb(lro_mgr-dev, hlen + NET_IP_ALIGN);
NET_IP_ALIGN should only be used if you're DMAing into the skb head.
Otherwise you should say 2. It would be nice to have another macro
for
Currently this call is used to register sysctls for devices
and for the default confs. The all sysctls are registered
separately.
Besides, the inet_device is passed to this function, but
it is not needed there at all - just the device name and
ifindex are required.
The fix is to make a
I moved the call to kmalloc() from the *t declaration into
the code (this is confusing when a variable is initialized
with the result of some call) and removed unneeded comment
near the error path. Just like I did with the neigh ctl-s.
Besides, I fixed the goto's and the labels - they were
The appropriate path is prepared right inside this function. It
is prepared similar to how the ctl tables were.
Since the path is modified, it is put on the stack, to avoid
possible races with multiple calls to neigh_sysctl_register() : it
is called by protocols and I didn't find any protection
This mainly removes the err variable, as this call always
return the same error code (-ENOBUFS).
Besides, I moved the call to kmalloc() from the *t declaration
into the code (this is confusing when a variable is initialized
with the result of some call) and removed unneeded comment near
the error
Hello!
After further investigations. The bug was just in front of us...
ifconfig down in combination with the test for || !netif_running() can
return a full quota and netif_rx_complete() done which causes the oops
in net_rx_action. Of course the load must be high enough to fill the
This will make all the sub-namespaces always use the
default value (10) and leave the tuning via sysctl
to the init namespace only.
Per-namespace tuning is coming.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index
Add the struct net * argument to both of them to use in
the future. Also make the register one return an error code.
It is useless right now, but will make the future patches
much simpler.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/net/af_unix.h
[snip]
+namespaces, path, table);
Hey Eric,
the patches look nice.
Agree ;)
The hand-forcing of the passed-in net_ns into a copy of current-nsproxy
does make it seem like nsproxy may not be the best choice of what to
pass in. Doesn't only
Dave/Herbert,
Here are a few intended for 2.6.25. The bulk of them are the beginnings
of support for 802.11n in mac80211. There is also a rework of the
support for devices which can run scans in hardware, and a couple of
additions to feature-removal-schedule.txt heralding the end of softmac.
Hello!
The rcu_assign_pointer() primitive currently unconditionally executes
a memory barrier, even when a NULL pointer is being assigned. This
has lead some to avoid using rcu_assign_pointer() for NULL pointers,
which loses the self-documenting advantages of rcu_assign_pointer()
This patch uses
On Fri, 30 Nov 2007 10:52:29 +0300
Vasily Averin [EMAIL PROTECTED] wrote:
Hi Ayaz,
While testing new OpenVZ kernel based on RHEL5.1 kernel 2.6.18-53.el5 we have
observed that node loads forcedeth driver too long:
Nov 28 14:04:19 ts49 kjournald starting. Commit interval 5 seconds
Nov
On Fri, Nov 30, 2007 at 02:35:43PM -0500, Andrew Gallatin wrote:
Isn't the value of 2 ethernet-specific (to round the 14-byte header up
to 16)? Given that the rest of the lro code is fairly careful to
calculate mac_hdr_len etc it seems as if it would be cleaner to make
this independent of
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
The do_setlink function is protected by rtnl, additional locks are
unnecessary,
and the set_operstate() function is called from protected parts. Locks removed
from both functions.
It doesn't look like in accordance with a comment to
Hi,
this commit:
[NET]: Move sock_valbool_flag to socket.c
The sock_valbool_flag() helper is used in setsockopt to
set or reset some flag on the sock. This helper is required
in the net/socket.c only, so move it there.
Besides, patch two places in sys_setsockopt() that
Serge E. Hallyn [EMAIL PROTECTED] writes:
Hey Eric,
the patches look nice.
The hand-forcing of the passed-in net_ns into a copy of current-nsproxy
does make it seem like nsproxy may not be the best choice of what to
pass in. Doesn't only net_sysctl_root-lookup() look at the argument?
I'm awfully sorry, but I noticed, that I sent the wrong patch
right after I pressed the Send button. The first version
contains a fatal error - the return code in register function
should be inverted (the if (net-unix_ctl != NULL) one). Otherwise
the registered table will be freed :(
Sorry. This
Quoting Eric W. Biederman ([EMAIL PROTECTED]):
The user interface is: register_net_sysctl_table and
unregister_net_sysctl_table. Very much like the current
interface except there is a network namespace parameter.
With this any sysctl registered with register_net_sysctl_table
will only
Prevent usage of flowi with not initialized fl_net in routing. This is
a temporary measure to simplify maintenance of the patchset.
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
net/ipv4/route.c |1 +
net/ipv6/fib6_rules.c |1 +
net/ipv6/ip6_fib.c|1 +
3 files changed,
On Fri, 2007-11-30 at 08:29 -0600, Olof Johansson wrote:
Hi,
On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote:
This adds support for the Agere ET1011c PHY as found on the AMCC Taishan
board.
The whole patch has whitespace messed up (tabs vs spaces).
Thanks for
As well as marking flows this indirectly marks the ipv4 routing cache
as every routing entry contains a flow.
It is useful to add the network namespace into flows as frequently
the routing information for ingoing and outgoing network packets is
collected into a flow structure which is then used
Hi!
On 05:00 Tue 27 Nov , Joerg Pommnitz wrote:
So, are you still sure you've tested such a case?
Well, the problem that triggered my investigation was
that the OLSR daemon (www.olsr.org) calculates the quality
of a link according to the packet loss for LQ HELLO packets
(UDP broadcast
On Fri, 2007-11-30 at 09:51 -0500, Paul Moore wrote:
On Thursday 29 November 2007 8:45:46 am Paul Moore wrote:
On Thursday 29 November 2007 5:34:59 am Herbert Xu wrote:
On Mon, Nov 26, 2007 at 07:55:12PM +, Paul Moore wrote:
Currently the netmask/prefix-length of an IPsec SPD entry
Hello.
Samir Bellabes wrote:
at security_socket_accept(), the user only accept the fact that the
application is able to go to sock-ops-accept(). That's the purpose of
this hook.
Yes. This hook can't perform filtering.
After, when packet are coming, we can catch them with
libnetfilter_queue,
On Thursday 29 November 2007 8:45:46 am Paul Moore wrote:
On Thursday 29 November 2007 5:34:59 am Herbert Xu wrote:
On Mon, Nov 26, 2007 at 07:55:12PM +, Paul Moore wrote:
Currently the netmask/prefix-length of an IPsec SPD entry is not
included in any of the SPD related audit
Robert Olsson wrote:
Hello!
After further investigations. The bug was just in front of us...
ifconfig down in combination with the test for || !netif_running() can
return a full quota and netif_rx_complete() done which causes the oops
in net_rx_action. Of course the load must be
I just tuned things a bit at vger, and now it is time to verify that nothing
broke seriously..
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 30 Nov 2007, Olof Johansson wrote:
On Fri, Nov 30, 2007 at 04:40:23PM +1100, Benjamin Herrenschmidt wrote:
+static int m88e_init(struct mii_phy *phy)
+{
+ printk(%s: Marvell 88E Ethernet\n, __FUNCTION__);
KERN_ level?
pr_
With kind regards,
Geert Uytterhoeven
On Sun November 25 2007 04:57:42 pm Elvis Pranskevichus wrote:
On Sunday November 25 2007 04:25:06 pm Stephen Hemminger wrote:
Two important bits of data:
1) What is hardware (output of lspci and dmesg) would be useful to know
which type
of board is involved.
uname -srvm:
Linux
Herbert Xu [EMAIL PROTECTED] writes:
On Thu, Nov 29, 2007 at 10:40:24AM -0700, Eric W. Biederman wrote:
Herbert we need this infrastructure most in net-2.6.25 (as not having
it is a current bottleneck to further development of the network
namespace) so these patches are against net-2.6.25.
On Thu, Nov 29, 2007 at 10:31:58PM -0500, John W. Linville wrote:
Dave/Herbert,
Here is another clutch of patches intended for 2.6.24.
Let me know if there are any problems!
Pulled. Thanks John!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
On Thu, Nov 29, 2007 at 10:45:41AM -0500, Vlad Yasevich wrote:
Hi Herbert
The following changes since commit a357dde9df33f28611e6a3d4f88265e39bcc8880:
Stephen Hemminger (1):
[TCP] illinois: Incorrect beta usage
are available in the git repository at:
On Fri, Nov 30, 2007 at 11:02:19PM +1100, Herbert Xu ([EMAIL PROTECTED]) wrote:
OK, this looks like a good change. However, we should also
change NETDEV_UP as well to recreate idev if it isn't there
and the MTU is big enough.
Ok, added netdev_up too.
Signed-off-by: Evgeniy Polyakov [EMAIL
* Herbert Xu [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 02:37:53PM +, David Howells wrote:
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO.
Signed-off-by: David Howells [EMAIL PROTECTED]
Patch applied to net-2.6. Thanks.
aimed at 2.6.24 merging,
On Wed, Nov 28, 2007 at 02:18:14PM +0300, Evgeniy Polyakov wrote:
Hi.
Avaid provided test application, so bug got fixed.
IPv6 addrconf removes ipv6 inner device from netdev each time cmu
changes and new value is less than IPV6_MIN_MTU (1280 bytes).
When mtu is changed and new value is
Chances are it does make progress however we may still have the
general wireless/IP stack alignment issue that we are still discussing.
Yeah, it's still on my list. I'll make a patch to WARN_ON unaligned data
in a packet... although this is a bit complicated. ath5k actually had a
bug with this
Quoting Wang Chen:
| (This patch base on PATCH 2/3.)
|
| UDP_MIB_INERRORS increment is in different way for IPv4
| and IPv6. For the consistence, change UDP6_INC_STATS_USER
| to UDP6_INC_STATS_BH.
|
| Signed-off-by: Wang Chen [EMAIL PROTECTED]
| ---
| udp.c |2 +-
| 1 files changed, 1
| (This patch base on PATCH 1/3.)
|
| Since we have macro IS_UDPLITE, we can use it.
|
| Signed-off-by: Wang Chen [EMAIL PROTECTED]
| ---
Acked-by: Gerrit Renker [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
Thanks again for all the work.
| UdpInDatagrams can be confusing because it counts packets that
| might be dropped later.
| Move UdpInDatagrams into recvmsg() as allowed by the RFC.
|
| Signed-off-by: Wang Chen [EMAIL PROTECTED]
| ---
Acked-by: Gerrit Renker [EMAIL PROTECTED]
-
To unsubscribe
Btw, the r8169 has NAPI enabled.
kernel config:
http://hoho.dyndns.org/~holger/dist/kernel-config-x86-2.6.23.9
dmesg:
http://hoho.dyndns.org/~holger/dist/dmesg
lspci -vv:
http://hoho.dyndns.org/~holger/dist/lspci
thanks
Holger
-
To unsubscribe from this list: send the line unsubscribe
Andrew Gallatin [EMAIL PROTECTED] wrote:
diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c
index ac3b1d3..91e9371 100644
--- a/net/ipv4/inet_lro.c
+++ b/net/ipv4/inet_lro.c
@@ -401,10 +401,11 @@ static struct sk_buff *lro_gen_skb(struc
int data_len = len;
int hdr_len =
On Fri, 30 Nov 2007 09:07:53 +0100, Eric Dumazet wrote:
CC to netdev, it might concern network guys
It is indeed related to network/r8169, more below.
Could you try with a test file containing unique patterns ?
Same result, here is new information.
- contrary to my first posting, the
On Sat, Dec 01, 2007 at 12:07:52PM +1100, Herbert Xu wrote:
On Fri, Nov 30, 2007 at 04:37:21PM -0800, Paul E. McKenney wrote:
The rcu_assign_pointer() primitive currently unconditionally executes
a memory barrier, even when a NULL pointer is being assigned. This
has lead some to avoid
On Fri, Nov 30, 2007 at 11:19:49AM +, Gerrit Renker wrote:
| csum_copy_err:
| - UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
| + UDP6_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
| skb_kill_datagram(sk, skb, flags);
|
| if (flags MSG_DONTWAIT)
|
Is it not the
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
...
@@ -858,6 +859,7 @@ static int do_setlink(struct net_device *dev, struct
On Nov 30, 2007, at 2:59 PM, Benjamin Herrenschmidt wrote:
On Fri, 2007-11-30 at 08:29 -0600, Olof Johansson wrote:
Hi,
On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt
wrote:
This adds support for the Agere ET1011c PHY as found on the AMCC
Taishan
board.
The whole
Currently this call is (ab)used similar to devinet one - it
registers sysctls for devices and for the default confs, while
the all sysctls are registered separately. But unlike its
devinet brother, the passed inet6_device is needed.
The fix is to make a __addrconf_sysctl_register(), which
Unlike previous ones, this patch is useful by its own,
as it decreases the vmlinux size :)
But it will be used later, when the per-namespace sysctl
is added.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c
index
[PATCH] remove extra memset from dn_fib_check_nh
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
net/decnet/dn_fib.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c
index 5413e1b..4aa9a42 100644
--- a/net/decnet/dn_fib.c
+++
Hi,
On Fri, Nov 30, 2007 at 04:40:24PM +1100, Benjamin Herrenschmidt wrote:
This adds support for the Agere ET1011c PHY as found on the AMCC Taishan
board.
The whole patch has whitespace messed up (tabs vs spaces).
-Olof
-
To unsubscribe from this list: send the line unsubscribe netdev in
On Fri, Nov 30, 2007 at 01:32:19AM +1100, Herbert Xu wrote:
Just to let you all know that I've just rebased net-2.6.25 so that it now
contains all of net-2.6 as it currently stands.
I've rebased it again.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~}
On Thu, Nov 29, 2007 at 04:35:43PM +, Steven Whitehouse wrote:
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Steven Whitehouse [EMAIL PROTECTED]
Patch applied. Thanks Pavel!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home
On Fri, 2007-11-30 at 07:56 +, Christoph Hellwig wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC
driver.
These PHY chips are used on PowerPC 440EPx boards.
The PHY code is based on the previous work by Stefan Roese
[EMAIL PROTECTED]
Is there a reason
On Fri, Nov 30, 2007 at 06:34:56PM +1100, Shaddy Baddah wrote:
OK... so I've applied patches left right and centre. As there have been
a few, I'll in-line them all at the bottom of this email.
The result is that there are no more unaligned access messages at all.
Good stuff! I was sort
On Wed, Nov 28, 2007 at 02:37:53PM +, David Howells wrote:
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO.
Signed-off-by: David Howells [EMAIL PROTECTED]
Patch applied to net-2.6. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~}
On Fri, Nov 30, 2007 at 03:25:16PM +0300, Evgeniy Polyakov wrote:
Ok, added netdev_up too.
Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED]
Applied to net-2.6. Thanks Evgeniy!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page:
On Thu, Nov 29, 2007 at 10:40:24AM -0700, Eric W. Biederman wrote:
Herbert we need this infrastructure most in net-2.6.25 (as not having
it is a current bottleneck to further development of the network
namespace) so these patches are against net-2.6.25.
I've applied them all to net-2.6.25
Ingo Molnar [EMAIL PROTECTED] wrote:
Patch applied to net-2.6. Thanks.
aimed at 2.6.24 merging, right?
Yep. net-2.6 is for 2.6.24 while net-2.6.25 is for 2.6.25.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page:
Hello.
Thank you for feedback.
I have some questions.
(1) Your module uses struct security_operations and
is registered with register_security().
TOMOYO also uses struct security_operations and
must be registered with register_security().
Can your module and TOMOYO coexist?
Hi,
On Fri, Nov 30, 2007 at 04:40:23PM +1100, Benjamin Herrenschmidt wrote:
+static int m88e_init(struct mii_phy *phy)
+{
+ printk(%s: Marvell 88E Ethernet\n, __FUNCTION__);
KERN_ level?
-Olof
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
Tetsuo Handa [EMAIL PROTECTED] writes:
Hello.
Thank you for feedback.
I have some questions.
(1) Your module uses struct security_operations and
is registered with register_security().
TOMOYO also uses struct security_operations and
must be registered with
This set of patches provides a basic infrastructure for routing and further
IPv4 virtualization. Initialize flowi with a init namespace. Proper namespace
setup will follow step-by-step.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
net: Initialize every fl_net member in struct flowi
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
---
drivers/infiniband/core/addr.c |2 ++
drivers/infiniband/hw/cxgb3/iwch_cm.c |3 ++-
drivers/net/bonding/bond_main.c|
Tetsuo Handa [EMAIL PROTECTED] writes:
Hello.
Samir Bellabes wrote:
at security_socket_accept(), the user only accept the fact that the
application is able to go to sock-ops-accept(). That's the purpose of
this hook.
Yes. This hook can't perform filtering.
By filtering, you should mean
From: Eric W. Biederman [EMAIL PROTECTED]
net: Initialize fl_net in structures allocated with dst_alloc
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
---
net/decnet/dn_route.c |2 ++
net/ipv4/route.c |4
2 files changed, 6
Thanks for your comments!
I'd like to better understand your dislike of the current implementation
of the data transfer from user space to kernel space.
Is it the fact that we use configfs?
I think, we had already a discussion about this (and we changed from
procfs to configfs).
Or don't you
Hi, Herbert, guys.
Since you have accepted some net-namespaces-related work
from Eric (sysctl namespaces), I hope, that you can pay
some attention to further work in this direction.
This set makes the unix-sockets sysctls (currently this
includes the sys/net/unix/max_dgram_qlen only) per net
Could the corruption be seen in a tcpdump trace prior to transmission
(ie taken on the sender) or was it only seen after the data passed out
the NIC?
rick jones
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Herbert Xu wrote:
Andrew Gallatin [EMAIL PROTECTED] wrote:
diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c
index ac3b1d3..91e9371 100644
--- a/net/ipv4/inet_lro.c
+++ b/net/ipv4/inet_lro.c
@@ -401,10 +401,11 @@ static struct sk_buff *lro_gen_skb(struc
int data_len = len;
- skb = netdev_alloc_skb(lro_mgr-dev, hlen);
+ skb = netdev_alloc_skb(lro_mgr-dev, hlen + NET_IP_ALIGN);
NET_IP_ALIGN should only be used if you're DMAing into the skb head.
Otherwise you should say 2. It would be nice to have another macro
for that I suppose.
It
On Fri, 30 Nov 2007 08:48:15 -0500
Elvis Pranskevichus [EMAIL PROTECTED] wrote:
On Sun November 25 2007 04:57:42 pm Elvis Pranskevichus wrote:
On Sunday November 25 2007 04:25:06 pm Stephen Hemminger wrote:
Two important bits of data:
1) What is hardware (output of lspci and dmesg)
Tetsuo Handa [EMAIL PROTECTED] writes:
Hello.
Thank you for detailed explanation.
Samir Bellabes wrote:
No, it's performed from the userspace. the goal is to don't touch the
network stack at all.
OK. One thing I'm worrying.
Use of userspace process assumes that it shall not be killed by
84 matches
Mail list logo
