pull-request: wireless-drivers 2015-06-01

2015-06-01 Thread Kalle Valo
Hi Dave, here are three more important fixes I'm hoping to get to 4.1 still, I hope I'm not too late with these. Please let me know if there are any problems. Kalle The following changes since commit aefa441b150279dd8d25658e018898a3fe9a6769: Merge tag 'iwlwifi-for-kalle-2015-05-21' of

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Enrico Mioso
Hello Greg, hello everyone reading. I am sorry If I wasn't specific enough - I'll be this time! :) Or I try at least. On Mon, 1 Jun 2015, Greg KH wrote: ==Date: Mon, 1 Jun 2015 02:59:17 ==From: Greg KH g...@kroah.com ==To: Enrico Mioso mrkiko...@gmail.com ==Cc: linux-...@vger.kernel.org,

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Frans Klaver
[cc: Willy Tarreau] On Mon, Jun 1, 2015 at 3:26 AM, starlight.201...@binnacle.cx wrote: Hello, Apoligies if I have submitted to the wrong lists. Encountered a regression in 2.6.32.66 relative to 2.6.32.65. Crash eight minutes after boot. Will responded with additional details if the

Re: pull-request: mac80211-next 2015-05-29

2015-06-01 Thread Johannes Berg
On Sun, 2015-05-31 at 17:35 -0700, David Miller wrote: Pulled, but there was a small conflict in include/net/mac80211.h which seemed trivially resolvable. Take a look and send me a fixup if I got it wrong, thanks. Looks good - it seems I managed to apply two different docbook fixes to the two

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Enrico Mioso
Thank you Oliver, thank you all for reading this thread and the attention. For a more detailed discussion and how we got here, you might google for the thread: Is this 32-bit NCM? and Is this 32-bit NCM?y (follow up). Where the y letter comes from a mistake of mine. The specification does only

[PATCH v4 21/25] time/posix-clock:Convert to the 64bit methods for k_clock and posix_clock_operations structure

2015-06-01 Thread Baolin Wang
This patch converts the posix clock operations over to the new methods with timespec64/itimerspec64 type to making them ready for 2038, and it is based on the ptp patch series. And also changes to the 64bit methods for k_clock structure, that converts the timespec/itimerspec type to

Re: [PATCH v2] xen: netback: fix printf format string warning

2015-06-01 Thread Wei Liu
On Mon, Jun 01, 2015 at 11:30:04AM +0100, Ian Campbell wrote: drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Oliver Neukum
On Mon, 2015-06-01 at 13:41 +0200, Enrico Mioso wrote: Thank you Oliver, thank you all for reading this thread and the attention. For a more detailed discussion and how we got here, you might google for the thread: Is this 32-bit NCM? and Is this 32-bit NCM?y (follow up). Where the y

[PATCH net] bnx2x: Move statistics implementation into semaphores

2015-06-01 Thread Yuval Mintz
Commit dff173de84958 (bnx2x: Fix statistics locking scheme) changed the bnx2x locking around statistics state into using a mutex - but the lock is being accessed via a timer which is forbidden. [If compiled with CONFIG_DEBUG_MUTEXES, logs show a warning about accessing the mutex in interrupt

[PATCH net-next v2 14/14] sfc: leak vports if a VF is assigned during PF unload

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com If any VF is assigned as the PF is unloaded, do not attempt to remove its vport or the vswitch. These will be removed if the driver binds to the PF again, as an entity reset occurs during probe. A 'force' flag is added to efx_ef10_pci_sriov_disable()

[PATCH net-next v2 13/14] sfc: force removal of VF and vport on driver removal

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com When the driver unloads, force the unbind and removal of any VFs in the host with the PF. The PF cannot remove vports and vswitches if they are still being used by a VF driver, and when unloading the sfc driver the removal order is not guaranteed, so

[PATCH net-next v2 10/14] sfc: suppress vadaptor stats when EVB is not present

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The raw_mask array is not initialised, so it needs to be explicitly set to zero in the 'else' branch. If the EVB capability is not present, a port cannot have multiple functions so the per-port MAC stats are correct and should match the corresponding

[PATCH net-next v2 11/14] sfc: don't update stats on VF when called in atomic context

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The ifenslave command to set up a bond runs in an atomic context, and it queries the stats on the devices that are being enslaved. A VF needs to make an MCDI call to update its stats, which is not allowed in atomic context. The releasing of the

[PATCH net-next v2 12/14] sfc: do not allow VFs to be destroyed if assigned to guests

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10_sriov.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c index

[PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-01 Thread Baolin Wang
This patch series changes the 32-bit time types (timespec/itimerspec) to the 64-bit types (timespec64/itimerspec64), since 32-bit time types will break in the year 2038. This patch series introduces new methods with timespec64/itimerspec64 type, and removes the old ones with timespec/itimerspec

[PATCH net-next v2 07/14] sfc: DMA the VF stats only when requested

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com Firmware does not support a periodic DMA of vadaptor-stats on VFs, so only update the stats buffer when stats are requested (when running ethtool -S or an ip/ifconfig command that reports stats). Signed-off-by: Shradha Shah ss...@solarflare.com ---

[PATCH net-next v2 06/14] sfc: display vadaptor statistics for all interfaces

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com All interfaces will display vadaptor statistics, so set all the relevant bits in the stats bitmask. Only functions with the LINKCTRL flag will see other stats, including (per-port) MAC stats. The vadaptor stats are from rx_unicast to tx_overflow.

[PATCH net-next v2 08/14] sfc: update netdevice statistics to use vadaptor stats

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The netdevice statistics (in /proc/net/dev) are per-function stats so they must use the vadaptor stats. Change the use of MAC stats to vadaptor stats, and remove any statistics that can only be measured per-port. All stats that are removed will be

[PATCH net-next v2 03/14] sfc: Implement ndo_gets_phys_port_id() for EF10 VFs

2015-06-01 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 11 +++ drivers/net/ethernet/sfc/ef10_sriov.c | 14 ++ drivers/net/ethernet/sfc/ef10_sriov.h | 3 +++ drivers/net/ethernet/sfc/efx.c| 1 +

[PATCH net-next v2 05/14] sfc: set the port-id when calling MC_CMD_MAC_STATS

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The port-id must be known so that the RMON level can be set for the collection of vadapter stats. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/mcdi_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH net-next v2 09/14] sfc: suppress ENOENT error messages from MC_CMD_MAC_STATS

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com MC_CMD_MAC_STATS can be called on a function before a vadaptor has been created, as the kernel can call into this through ndo_get_stats/ndo_get_stats64. If MC_CMD_MAC_STATS is called before the DMA queues have been setup, so that a vadaptor has not

[PATCH net-next v2 04/14] sfc: add port_ prefix to MAC stats

2015-06-01 Thread Shradha Shah
From: Daniel Pieczko dpiec...@solarflare.com The MAC stats are per-port and will only be displayed on the PF with control of the link (one per physical port). Vadapter stats will also be displayed for this PF, so distinguish the MAC stats by adding a prefix of port_. Signed-off-by: Shradha Shah

Re: [PATCH v2 net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Wei Liu
On Mon, Jun 01, 2015 at 11:30:24AM +0100, Ian Campbell wrote: When we come to tear things down in netback_remove() and generate the uevent it is possible that the xenstore directory has already been removed (details below). In such cases netback_uevent() won't be able to read the hotplug

[PATCH net-next v2 01/14] sfc: Add code to export port_num in netdev-dev_port

2015-06-01 Thread Shradha Shah
In the case where we have multiple functions (PFs and VFs), this sysfs entry is useful to identify the physical port corresponding to the function we are interested in. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 12 1 file changed, 8

[PATCH net-next v2 02/14] sfc: Add sysfs entry for flags (link control and primary)

2015-06-01 Thread Shradha Shah
On every adapter there will be one primary PF per adaptor and one link control PF per port. Signed-off-by: Shradha Shah ss...@solarflare.com --- drivers/net/ethernet/sfc/ef10.c | 58 - 1 file changed, 51 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/7] net: dsa: add new driver for ar8xxx family

2015-06-01 Thread Paul Bolle
Just a nit: a license mismatch. On Thu, 2015-05-28 at 18:42 -0700, Mathieu Olivari wrote: --- /dev/null +++ b/drivers/net/dsa/ar8xxx.c + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only

[Patch v3 30/36] net/mlx4: Cache irq_desc-affinity instead of irq_desc

2015-06-01 Thread Jiang Liu
The field 'affinity' in irq_desc won't change once the irq_desc data structure is created. So cache irq_desc-affinity instead of irq_desc. This also helps to hide struct irq_desc from device drivers. Signed-off-by: Jiang Liu jiang@linux.intel.com ---

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Ian Campbell
On Fri, 2015-05-29 at 18:38 +0100, Wei Liu wrote: On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: [...] if (be-vif != NULL) return 0; @@ -417,12 +409,23 @@ static int backend_create_xenvif(struct backend_info *be) return (err 0) ? err :

[RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-01 Thread Junling Zheng
Hi, Greg: We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL was expected. We tested it through the recvmsg01 testcase come from LTP testsuit. It set msg-msg_namelen to -1 and the recvmsg syscall returned errno 14, which is unexpected (errno 22 is expected): recvmsg014

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Oliver Neukum
On Mon, 2015-06-01 at 10:24 +0200, Enrico Mioso wrote: We are failing on some cases only because of the position we put the NDP part of the NCM frame. Infact, this 32-bit driver will work when the 16 bit one does, and fail when the 16 bit one does. I think the discussion would benefit from

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Enrico Mioso
On Mon, 1 Jun 2015, Oliver Neukum wrote: ==Date: Mon, 1 Jun 2015 14:00:22 ==From: Oliver Neukum oneu...@suse.com ==To: Enrico Mioso mrkiko...@gmail.com ==Cc: you...@gmail.com, Greg KH g...@kroah.com, linux-...@vger.kernel.org, ==netdev@vger.kernel.org ==Subject: Re: [cdc_ncm] guidance and

[PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Toshiaki Makita
Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by hardware. This patch adds GRO support for non-hardware-accelerated vlan and improves receive performance of

Re: [PATCH] xen: netback: fix error printf format string.

2015-06-01 Thread Ian Campbell
On Sun, 2015-05-31 at 21:26 -0700, David Miller wrote: From: Ian Campbell ian.campb...@citrix.com Date: Fri, 29 May 2015 17:22:04 +0100 drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument

Re: [PATCH net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Wei Liu
On Mon, Jun 01, 2015 at 09:52:45AM +0100, Ian Campbell wrote: On Fri, 2015-05-29 at 18:38 +0100, Wei Liu wrote: On Fri, May 29, 2015 at 05:24:53PM +0100, Ian Campbell wrote: [...] if (be-vif != NULL) return 0; @@ -417,12 +409,23 @@ static int backend_create_xenvif(struct

[PATCH net-next] cxgb4: remove unused fn to enable/disable db coalescing

2015-06-01 Thread Hariprasad Shenai
Remove unused function cxgb4_enable_db_coalescing() and cxgb4_disable_db_coalescing() Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 19 --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 2 -- 2 files changed, 21

Re: [PATCH RFC 2/3] dsa: Add support for multiple cpu ports.

2015-06-01 Thread Bjørn Mork
Andrew Lunn and...@lunn.ch writes: So the ports look like normal ports, and you configure then using the normal mechanisms. DSA does not use vlans. It uses an additional protocol header which the switch supports, to allow the CPU to direct packets out a specific port. Similarly, packets

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Willy Tarreau
Hi, On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote: [cc: Willy Tarreau] On Mon, Jun 1, 2015 at 3:26 AM, starlight.201...@binnacle.cx wrote: Hello, Apoligies if I have submitted to the wrong lists. Encountered a regression in 2.6.32.66 relative to 2.6.32.65.

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Oliver Neukum
On Mon, 2015-06-01 at 08:53 +0200, Enrico Mioso wrote: A 32-bit version of the driver (talking 32-bit NCM) is here: http://www.gstorm.eu/cdc_ncm.c I modified the original driver with the help of a very talented friend. It works: but there seem to be no real reasons to implement this properly.

[PATCH v2 net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread Ian Campbell
When we come to tear things down in netback_remove() and generate the uevent it is possible that the xenstore directory has already been removed (details below). In such cases netback_uevent() won't be able to read the hotplug script and will write a xenstore error node. A recent change to the

Re: [cdc_ncm] guidance and help refactoring cdc_ncm

2015-06-01 Thread Enrico Mioso
Thank you Oliver for the reply. On Mon, 1 Jun 2015, Oliver Neukum wrote: ==Date: Mon, 1 Jun 2015 09:48:26 ==From: Oliver Neukum oneu...@suse.com ==To: Enrico Mioso mrkiko...@gmail.com ==Cc: Greg KH g...@kroah.com, linux-...@vger.kernel.org, ==netdev@vger.kernel.org, you...@gmail.com

Re: [PATCH v6 2/8] tun: add tun_is_little_endian() helper

2015-06-01 Thread Michael S. Tsirkin
On Fri, Apr 24, 2015 at 02:24:38PM +0200, Greg Kurz wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Dave, could you please ack merging this through the virtio tree? --- drivers/net/tun.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH v2] xen: netback: fix printf format string warning

2015-06-01 Thread Ian Campbell
drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] (txreq.offset~PAGE_MASK) + txreq.size); ^ PAGE_MASK's

Re: [PATCH v6 3/8] macvtap: introduce macvtap_is_little_endian() helper

2015-06-01 Thread Michael S. Tsirkin
On Fri, Apr 24, 2015 at 02:24:48PM +0200, Greg Kurz wrote: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com Dave, could you pls ack merging this through the virtio tree? --- drivers/net/macvtap.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread starlight . 2015q2
Hi, I found the patch late yesterday and applied it. Running fine now for 12 hours under active load. Recommend the patch be rolled into the tarball, or a notation added to the release page as this one has severe consequences. Thank You! At 09:49 6/1/2015 +0200, Willy Tarreau wrote: Hi, On

[PATCH] ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()

2015-06-01 Thread Shawn Bohrer
From: Shawn Bohrer sboh...@rgmadvisors.com 421b3885bf6d56391297844f43fb7154a6396e12 udp: ipv4: Add udp early demux introduced a regression that allowed sockets bound to INADDR_ANY to receive packets from multicast groups that the socket had not joined. For example a socket that had joined

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg: Hi Johannes, IOW, I think something like this would make sense: That looks definitely cleaner :-) Though, my main concern was just to ensure that the aad length value is not zero. Ciao Stephan -- To unsubscribe from this list: send

[RFC net-next 1/3] net: infra for per-nexthop encap data

2015-06-01 Thread Robert Shearman
Having to add a new interface to apply encap onto a packet is a mechanism that works well today, allowing the setup of the encap to be done separately from the routes out of them, meaning that routing protocols and other user-space apps don't need to do anything special to add routes out of a new

[RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-01 Thread Robert Shearman
Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWST. It uses the encap data which will have been stored in the IP route to

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Toshiaki Makita
On 15/06/01 (月) 23:12, Eric Dumazet wrote: On Mon, 2015-06-01 at 21:55 +0900, Toshiaki Makita wrote: @@ -668,6 +753,9 @@ static int __init vlan_proto_init(void) if (err 0) goto err5; + for (i = 0; i ARRAY_SIZE(vlan_packet_offloads); i++) +

[RFC net-next 2/3] ipv4: storing and retrieval of per-nexthop encap

2015-06-01 Thread Robert Shearman
Parse RTA_ENCAP attribute for one path and multipath routes. The encap length is stored in a newly added field to fib_nh, nh_encap_len, although this is added to a padding hole in the structure so that it doesn't increase the size at all. The encap data itself is stored at the end of the array of

[RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-01 Thread Robert Shearman
In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an interface for each tunnel endpoint doesn't scale for the common MPLS use-cases where

Re: 2.6.32.66 tcp regression OOPs

2015-06-01 Thread Willy Tarreau
On Mon, Jun 01, 2015 at 11:32:19AM -0400, starlight.201...@binnacle.cx wrote: Hi, I found the patch late yesterday and applied it. Running fine now for 12 hours under active load. Thank you. Recommend the patch be rolled into the tarball, or a notation added to the release page as this

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Eric Dumazet
On Tue, 2015-06-02 at 01:03 +0900, Toshiaki Makita wrote: I didn't have that concern because there are already other similar offloads (eth, mpls_uc, mpls_mc). But indeed, they and this could slow down GRO stack. Right, but these mpls offloads are not installed on my kernels ;) And I

Re: [net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL

2015-06-01 Thread Robert Shearman
On 01/06/15 15:27, Thomas Graf wrote: Introduces a new Netlink attribute RTA_TUNNEL which allows routes to set tunnel transmit metadata and specify the tunnel endpoint or tunnel id on a per route basis. The route must point to a tunnel device which understands per skb tunnel metadata and has

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Johannes Berg
On Mon, 2015-06-01 at 15:49 +0200, Stephan Mueller wrote: The contents, now, that's a more interesting question. I believe it can never be all zeroes, since association request frames are not encrypted/protected and thus at least one byte in here must be non-zero. The MAC addresses are also

[PATCH] libceph: use kvfree() in ceph_put_page_vector()

2015-06-01 Thread Geliang Tang
Use kvfree() instead of open-coding it. Signed-off-by: Geliang Tang geliangt...@163.com --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 096d914..d4f5f22 100644 --- a/net/ceph/pagevec.c +++

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Donnerstag, 21. Mai 2015, 13:20:49 schrieb Johannes Berg: Hi Johannes, On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote: This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Looks fine - want me to run any

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Stephan Mueller
Am Montag, 1. Juni 2015, 15:42:41 schrieb Johannes Berg: Hi Johannes, On Mon, 2015-06-01 at 15:21 +0200, Stephan Mueller wrote: Just a short question on ieee80211_aes_ccm_encrypt, ieee80211_aes_ccm_decrypt, ieee80211_aes_gcm_encrypt, ieee80211_aes_gcm_decrypt, ieee80211_aes_gmac: can the aad

[PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac

2015-06-01 Thread clsoto
fix typo in mlx4_set_vf_mac Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com --- drivers/net/ethernet/mellanox/mlx4/cmd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c @@ -2687,7

[PATCH net] net/mlx4: double free of dev_vfs

2015-06-01 Thread clsoto
If user loads mlx4_core with num_vfs greater than supported then variable dev-dev_vfs is freed 2 times after unloading the driver. Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com --- drivers/net/ethernet/mellanox/mlx4/main.c |1 + 1 file changed, 1 insertion(+) ---

[PATCH net] net/mlx4: need to call close fw if alloc icm is called twice

2015-06-01 Thread clsoto
If mlx4_enable_sriov is called by adapter without this feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc icm is called twice without freeing the structures from the first time. Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com ---

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Eric Dumazet
On Mon, 2015-06-01 at 21:55 +0900, Toshiaki Makita wrote: @@ -668,6 +753,9 @@ static int __init vlan_proto_init(void) if (err 0) goto err5; + for (i = 0; i ARRAY_SIZE(vlan_packet_offloads); i++) + dev_add_offload(vlan_packet_offloads[i]); +

[net-next RFC 04/14] route: Extend flow representation with tunnel key

2015-06-01 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/flow.h

[net-next RFC 02/14] ip_tunnel: support per packet tunnel metadata

2015-06-01 Thread Thomas Graf
This allows to attach an ip_tunnel_info metadata structure to skbs via skb_shared_info to represent receive side tunnel information as well as transmit side encapsulation instructions. The new field is added to skb_shared_info as the field is typically immutable after it has been attached. A new

[net-next RFC 01/14] ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic

2015-06-01 Thread Thomas Graf
Rename the tunnel metadata data structures currently internal to OVS and make them generic for use by all IP tunnels. Both structures are kernel internal and will stay that way. Their members are exposed to user space through individual Netlink attributes by OVS. It will therefore be possible to

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-01 Thread Ivan Mikhaylov
On Mon, 1 June 2015 12:57 +0400 Ben Hutchings b...@decadent.org.uk wrote: On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: In ibm_emac.c in ethtool size of emac structure which passing through to driver is nailed down and not correlating with current emac_regs structure.

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Johannes Berg
On Mon, 2015-06-01 at 15:21 +0200, Stephan Mueller wrote: Just a short question on ieee80211_aes_ccm_encrypt, ieee80211_aes_ccm_decrypt, ieee80211_aes_gcm_encrypt, ieee80211_aes_gcm_decrypt, ieee80211_aes_gmac: can the aad parameter of these functions be zero? What do you mean by zero?

Re: [PATCH] sctp: fix ASCONF list handling

2015-06-01 Thread Neil Horman
On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu,

[net-next RFC 11/14] openvswitch: Use regular VXLAN net_device device

2015-06-01 Thread Thomas Graf
This gets rid of all OVS specific VXLAN code in the receive and transmit path by using a VXLAN net_device to represent the vport. Only a small shim layer remains which takes care of handling the VXLAN specific OVS Netlink configuration. Unexports vxlan_sock_add(), vxlan_sock_release(),

[net-next RFC 10/14] openvswitch: Abstract vport name through ovs_vport_name()

2015-06-01 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 -

[net-next RFC 09/14] openvswitch: Move dev pointer into vport itself

2015-06-01 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com ---

[net-next RFC 03/14] vxlan: Flow based tunneling

2015-06-01 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which it will populate a tunnel info structure for each packet received. The metadata structure will contain the outer header and tunnel header fields which have been stripped off. Layers further up in the stack such as routing, tc or

[net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-01 Thread Thomas Graf
This is the first series in a greater effort to bring the scalability and programmability advantages of OVS to the rest of the network stack and to get rid of as much OVS specific code as possible. This first series focuses on getting rid of OVS tunnel vports and use regular tunnel net_devices

[net-next RFC 07/14] vxlan: Factor out device configuration

2015-06-01 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2

[net-next RFC 14/14] arp: Associate ARP requests with tunnel info

2015-06-01 Thread Thomas Graf
Since ARP performs its own route lookup call, eventually returned tunnel metadata must be attached manually. Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/arp.c | 8 1 file changed, 8 insertions(+) diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 933a928..6cf0502 100644 ---

[net-next RFC 06/14] fib: Add fib rule match on tunnel id

2015-06-01 Thread Thomas Graf
This add the ability to select a routing table based on the tunnel id which allows to maintain separate routing tables for each virtual tunnel network. ip rule add from all tunnel-id 100 lookup 100 ip rule add from all tunnel-id 200 lookup 200 Signed-off-by: Thomas Graf tg...@suug.ch ---

[net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL

2015-06-01 Thread Thomas Graf
Introduces a new Netlink attribute RTA_TUNNEL which allows routes to set tunnel transmit metadata and specify the tunnel endpoint or tunnel id on a per route basis. The route must point to a tunnel device which understands per skb tunnel metadata and has been put into the respective mode.

[net-next RFC 12/14] vxlan: remove indirect call to vxlan_rcv() and vni member

2015-06-01 Thread Thomas Graf
With the removal of the special treating of OVS VXLAN vports, the indirect call to vxlan_rcv() can be avoided and the VNI member in vxlan_metadata can be removed. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 225 +---

[net-next RFC 13/14] openvswitch: Use regular GRE net_device instead of vport

2015-06-01 Thread Thomas Graf
From: Pravin Shelar pshe...@nicira.com Removes all of the OVS specific GRE code and makes OVS use a GRE net_device . Signed-off-by: Pravin B Shelar pshe...@nicira.com --- net/core/dev.c | 5 +- net/ipv4/ip_gre.c | 161 -

[net-next RFC 08/14] openvswitch: Allocate attach ip_tunnel_info for tunnel set action

2015-06-01 Thread Thomas Graf
Make use of the new skb tunnel metadata field by allocating a ip_tunnel_info per OVS tunnel set action and then attaching that metadata to each skb that passes the set action. The old egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method.

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-01 Thread Johannes Berg
On Mon, 2015-06-01 at 16:05 +0200, Johannes Berg wrote: Ok - here the length is kinda passed a part of the AAD buffer, but this is really just some arcane code that should be fixed to use a proper struct. The value there, even though it is __be16 and looks like it came from the data, is

Re: [PATCH] libceph: use kvfree() in ceph_put_page_vector()

2015-06-01 Thread Ilya Dryomov
On Mon, Jun 1, 2015 at 5:36 PM, Geliang Tang geliangt...@163.com wrote: Use kvfree() instead of open-coding it. Signed-off-by: Geliang Tang geliangt...@163.com --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c

Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

2015-06-01 Thread Ben Hutchings
On Sun, 2015-05-31 at 17:19 -0700, David Miller wrote: From: Ben Hutchings b...@decadent.org.uk Date: Sun, 31 May 2015 20:54:06 +0100 On Fri, 2015-05-22 at 16:15 -0400, David Miller wrote: From: Arun Parameswaran apara...@broadcom.com Date: Wed, 20 May 2015 14:35:30 -0700 When

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-01 Thread Ben Hutchings
On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote: On Mon, 1 June 2015 12:57 +0400 Ben Hutchings b...@decadent.org.uk wrote: On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: In ibm_emac.c in ethtool size of emac structure which passing through to driver is nailed down and

[PATCH net-next 3/5] rocker: install untagged VLAN (vid=0) support for each port

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com On port probe, install by default untagged VLAN support. This is equivalent to running the command: bridge vlan add vid 0 dev DEV self A user could, if they wanted, manaully removing untagged support from the port by running the command:

[PATCH net-next 2/5] rocker: cleanup vlan table on error adding vlan

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com Basic house keeping: If there is an error adding the router MAC for this vlan, removing the just installed VLAN table entry to leave device in same state as before failure. Signed-off-by: Scott Feldman sfel...@gmail.com ---

[PATCH net-next 4/5] rocker: install/remove router MAC for untagged VLAN when joining/leaving bridge

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com When the port joins a bridge, the port's internal VLAN ID needs to change to the bridge's internal VLAN ID. Likewise, when leaving the bridge, the internal VLAN ID reverts back the port's original internal VLAN ID. (The internal VLAN ID is used by device to

[PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com Remove support for legacy ndo ops .ndo_vlan_rx_add_vid/.ndo_vlan_rx_kill_vid. Rocker will use bridge_setlink/dellink exclusively for VLAN add/del operations. The legacy ops are needed if using 8021q driver module to setup VLANs on the port. But an

[PATCH net-next 1/5] rocker: zero allocate ports array

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com When allocating the array of rocker port pointers, zero the array values so we can test for !NULL to see if port is allocated/registered. We'll need this later when installing untagged VLAN support for each port, during port probe. It's a long story, but to

[PATCH net-next 0/5] rocker: enable by default untagged VLAN support

2015-06-01 Thread sfeldma
From: Scott Feldman sfel...@gmail.com This patch set is a followup to Simon Horman's RFC patch: [PATCH/RFC net-next] rocker: by default accept untagged packets Now, on port probe, we install untagged VLAN (vid=0) support for each port as the default. This is equivalent to the command:

[PATCH net] Netfilter fix for net

2015-06-01 Thread Pablo Neira Ayuso
Hi David, The following patch reverts the ebtables chunk that enforces counters that was introduced in the recently applied d26e2c9ffa38 ('Revert netfilter: ensure number of counters is 0 in do_replace()') since this breaks ebtables. You can pull this change from:

[PATCH net] Revert netfilter: ensure number of counters is 0 in do_replace()

2015-06-01 Thread Pablo Neira Ayuso
From: Bernhard Thaler bernhard.tha...@wvnet.at This partially reverts commit 1086bbe97a07 (netfilter: ensure number of counters is 0 in do_replace()) in net/bridge/netfilter/ebtables.c. Setting rules with ebtables does not work any more with 1086bbe97a07 place. There is an error message and no

Re: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

2015-06-01 Thread Arun Parameswaran
On 15-05-31 12:59 PM, Ben Hutchings wrote: On Fri, 2015-05-22 at 15:43 -0700, Arun Parameswaran wrote: Hi, The patch fixes 2 issues with 'ethtool' getting/setting parametres in the do_gset() do_sset() API's. I have pushed a patch to the Kernel to fix an issue in the handling of the

Re: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

2015-06-01 Thread Ben Hutchings
On Mon, 2015-06-01 at 10:14 -0700, Arun Parameswaran wrote: On 15-05-31 12:59 PM, Ben Hutchings wrote: On Fri, 2015-05-22 at 15:43 -0700, Arun Parameswaran wrote: Hi, The patch fixes 2 issues with 'ethtool' getting/setting parametres in the do_gset() do_sset() API's. I have pushed a

Re: [PATCH net] bnx2x: Move statistics implementation into semaphores

2015-06-01 Thread David Miller
From: Yuval Mintz yuval.mi...@qlogic.com Date: Mon, 1 Jun 2015 15:08:18 +0300 Commit dff173de84958 (bnx2x: Fix statistics locking scheme) changed the bnx2x locking around statistics state into using a mutex - but the lock is being accessed via a timer which is forbidden. [If compiled with

Re: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

2015-06-01 Thread Ben Hutchings
On Mon, 2015-06-01 at 12:12 -0700, Arun Parameswaran wrote: On 15-06-01 11:07 AM, Ben Hutchings wrote: On Mon, 2015-06-01 at 10:14 -0700, Arun Parameswaran wrote: On 15-05-31 12:59 PM, Ben Hutchings wrote: On Fri, 2015-05-22 at 15:43 -0700, Arun Parameswaran wrote: Hi, The patch fixes 2

[PATCH 2/2] geneve: allow user to specify TOS info for tunnel frames

2015-06-01 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- I have the corresponding iproute2 patch ready, but I am holding it for now to avoid confusion on the list and such... drivers/net/geneve.c | 18 ++ include/uapi/linux/if_link.h | 1 + 2 files changed, 15

[PATCH 1/2] geneve: allow user to specify TTL for tunnel frames

2015-06-01 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- I have the corresponding iproute2 patch ready, but I am holding it for now to avoid confusion on the list and such... drivers/net/geneve.c | 18 ++ include/uapi/linux/if_link.h | 1 + 2 files changed, 15

Re: [PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-06-01 Thread Andy Gospodarek
On Mon, Jun 01, 2015 at 01:25:04PM +0900, Simon Horman wrote: The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. Excellent idea and commonly used in many other hardware

Re: [PATCH net-next v2 01/14] sfc: Add code to export port_num in netdev-dev_port

2015-06-01 Thread David Miller
From: Shradha Shah ss...@solarflare.com Date: Mon, 1 Jun 2015 14:00:12 +0100 In the case where we have multiple functions (PFs and VFs), this sysfs entry is useful to identify the physical port corresponding to the function we are interested in. Signed-off-by: Shradha Shah

  1   2   >