Re: [PATCH 2/6] test_bpf: allow tests to specify an skb fragment.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 04:02 PM, Nicolas Schichan wrote: This introduce a new test-aux flag (FLAG_SKB_FRAG) to tell the populate_skb() function to add a fragment to the test skb containing the data specified in test-frag_data). Signed-off-by: Nicolas Schichan nschic...@freebox.fr Acked-by: Alexei

[PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Lucas Stach
The clocks are initially active and thus the device is marked active. This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() call at the end of probe then leaves us with an invalid refcount of -1, which in turn leads to the device staying in suspended state even though netdev open

Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

2015-08-03 Thread Murali Karicheri
On 07/31/2015 12:20 PM, Viresh Kumar wrote: On 31-07-15, 11:04, Murali Karicheri wrote: On 07/31/2015 04:38 AM, Viresh Kumar wrote: IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. IS_ERR_OR_NULL() is defined as

[PATCH net-next] act_bpf: properly support late binding of bpf action to a classifier

2015-08-03 Thread Daniel Borkmann
Since the introduction of the BPF action in d23b8ad8ab23 (tc: add BPF based action), late binding was not working as expected. I.e. setting the action part for a classifier only via 'bpf index num', where num is the index of an existing action, is being rejected by the kernel due to other missing

[PATCH] xen-netback: Allocate fraglist early to avoid complex rollback

2015-08-03 Thread Ross Lagerwall
Determine if a fraglist is needed in the tx path, and allocate it if necessary before setting up the copy and map operations. Otherwise, undoing the copy and map operations is tricky. This fixes a use-after-free: if allocating the fraglist failed, the copy and map operations that had been set up

Re: [PATCH 1/6] test_bpf: avoid oopsing the kernel when generate_test_data() fails.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 04:02 PM, Nicolas Schichan wrote: Signed-off-by: Nicolas Schichan nschic...@freebox.fr Acked-by: Alexei Starovoitov a...@plumgrid.com Acked-by: Daniel Borkmann dan...@iogearbox.net -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH net-next] virtio_net: add gro capability

2015-08-03 Thread Rick Jones
On 08/03/2015 06:37 AM, Michael S. Tsirkin wrote: Ideally this needs to also be tested on non-vxlan configs with gro in host, to make sure this doesn't cause regressions. Measured with the same instances on the same hardware and software, taking a path through the stack (public rather than

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Andrew Lunn
On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: The clocks are initially active and thus the device is marked active. This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() call at the end of probe then leaves us with an invalid refcount of -1, which in turn leads

Re: [PATCH] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-03 Thread Pravin Shelar
On Sat, Aug 1, 2015 at 6:31 PM, Glenn Griffin ggriffin.ker...@gmail.com wrote: openvswitch modifies the L4 checksum of a packet when modifying the ip address. When an IP packet is fragmented only the first fragment contains an L4 header and checksum. Prior to this change openvswitch would

Re: [PATCH 4/6] test_bpf: add module parameters to filter the tests to run.

2015-08-03 Thread Nicolas Schichan
On 08/03/2015 05:58 PM, Daniel Borkmann wrote: On 08/03/2015 04:02 PM, Nicolas Schichan wrote: When developping on the interpreter or a particular JIT, it can be insteresting to restrict the test list to a specific test or a s/insteresting/interesting/ [...] s/test_pbf/test_bpf/ [...]

Re: [patch] rds: fix an integer overflow test in rds_info_getsockopt()

2015-08-03 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Sat, 1 Aug 2015 15:33:26 +0300 len is a signed integer. We check that len is not negative, so it goes from zero to INT_MAX. PAGE_SIZE is unsigned long so the comparison is type promoted to unsigned long. ULONG_MAX - 4095 is a higher than

RX overrun errors building on several of our hosts

2015-08-03 Thread Dan Finn
After implementing a new monitoring tool I've noticed that several of our physical servers have increasing RX errors, all seem to be classified as overruns. The interfaces are Broadcom Corporation BCM57840 NetXtreme II 10 Gigabit Ethernet (rev 11) and we are using the bnx2x driver.  The are

RE: [PATCH net] udp: fix dst races with multicast early demux

2015-08-03 Thread Gregory Hoggarth
Hi, I have included this patch into my code and re-run our tests overnight, out of 644 iterations we did not see the kernel crash. Previous reproduction rate we would have expected 4-6 crashes in this time. So I think this fixes the issue we are seeing. Thanks, Greg

[PATCH net-next v2 2/2] gre: Remove support for sharing GRE protocol hook.

2015-08-03 Thread Pravin B Shelar
Support for sharing GREPROTO_CISCO port was added so that OVS gre port and kernel GRE devices can co-exist. After flow-based tunneling patches OVS GRE protocol processing is completely moved to ip_gre module. so there is no need for GRE protocol hook. Following patch consolidates GRE protocol

[PATCH net-next v2 0/2] GRE: Use flow based tunneling for OVS GRE vport.

2015-08-03 Thread Pravin B Shelar
Following patches make use of new flow based tunneling API from kernel. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were targeted for OVS. Most of GRE protocol code is now consolidated in ip_gre module. Pravin B Shelar

Re: [PATCH] fddi: Use a more more typical logging style

2015-08-03 Thread David Miller
From: Joe Perches j...@perches.com Date: Sun, 02 Aug 2015 21:27:45 -0700 Use macros that don't require fixed argument counts so format and arguments can be verified by the compiler. Miscellanea: o Remove a few #if uses to allow dynamic debug to always work o whitespace neatening

Re: [PATCH] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

2015-08-03 Thread David Miller
From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Mon, 3 Aug 2015 09:17:44 -0400 At switch setup, _mv88e6xxx_stats_wait was called without holding the SMI mutex. Fix this by requesting the lock for this call. Also, return the _mv88e6xxx_stats_wait code, since it may fail.

Re: [PATCH net-next 1/1] e1000: remove dead e1000_init_eeprom_params calls.

2015-08-03 Thread Jeff Kirsher
On Fri, Jul 24, 2015 at 2:40 PM, Francois Romieu rom...@fr.zoreil.com wrote: The device probe method e1000_probe calls e1000_init_eeprom_params itself so there's no reason to call it again from e1000_do_write_eeprom or e1000_do_read_eeprom. The sentence above assumes that

Re: [PATCH net-next 0/2] lwtunnel: encap locally-generated ipv4 packets

2015-08-03 Thread roopa
On 8/3/15, 9:39 AM, Robert Shearman wrote: Locally-generated IPv4 packets, such as from applications running on the host or traceroute/ping currently don't have lwtunnel output redirected encap applied. However, they should do in the same way as for forwarded packets and this patch series

Re: [PATCH] Add BQL support for 3c59x, based on patch from Tino Reichardt.

2015-08-03 Thread David Miller
From: Loganaden Velvindron lo...@elandsys.com Date: Fri, 31 Jul 2015 23:13:13 -0700 Tested on 3Com PCI 3c905C Tornardo by running Flent multiple times. Signed-off-by: Loganaden Velvindron lo...@elandsys.com Please format your Subject line correctly, it should be of the form: [PATCH

Re: [PATCH net-next] act_bpf: properly support late binding of bpf action to a classifier

2015-08-03 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Mon, 3 Aug 2015 16:21:57 +0200 Since the introduction of the BPF action in d23b8ad8ab23 (tc: add BPF based action), late binding was not working as expected. I.e. setting the action part for a classifier only via 'bpf index num', where num is

[PATCH net-next] bridge: mdb: fix vlan_enabled access when vlans are not configured

2015-08-03 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Instead of trying to access br-vlan_enabled directly use the provided helper br_vlan_enabled(). Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- Sorry, forgot to change this before sending the patch. net/bridge/br_mdb.c |

Re: [PATCH net-next] mpls: Use definition for reserved label checks

2015-08-03 Thread roopa
On 8/3/15, 9:50 AM, Robert Shearman wrote: In multiple locations there are checks for whether the label in hand is a reserved label or not using the arbritray value of 16. Factor this out into a #define for better maintainability and for documentation. Signed-off-by: Robert Shearman

Re: [PATCH] r8169: Permit users to change transmit and receive max pachet size

2015-08-03 Thread David Miller
From: Corcodel.marian corcodel.mar...@gmail.com Date: Tue, 04 Aug 2015 00:41:50 +0300 A this moment these param is only for test and not for large utilization. Then you can patch your local driver for testing. You change doesn't belong upstream. We're not going to litter drivers with

Re: [PATCH net-next] bridge: mdb: add/del entry on all vlans if vlan_filter is enabled and vid is 0

2015-08-03 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Mon, 3 Aug 2015 13:29:16 +0200 From: Satish Ashok sas...@cumulusnetworks.com Before this patch when a vid was not specified, the entry was added with vid 0 which is useless when vlan_filtering is enabled. This patch makes the entry to be

Re: [PATCH] fddi: Use a more more typical logging style

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 16:05 -0700, David Miller wrote: From: Joe Perches j...@perches.com Date: Sun, 02 Aug 2015 21:27:45 -0700 Use macros that don't require fixed argument counts so format and arguments can be verified by the compiler. Miscellanea: o Remove a few #if uses to

Re: [PATCH net-next] bridge: mdb: fix vlan_enabled access when vlans are not configured

2015-08-03 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Tue, 4 Aug 2015 01:19:58 +0200 From: Nikolay Aleksandrov niko...@cumulusnetworks.com Instead of trying to access br-vlan_enabled directly use the provided helper br_vlan_enabled(). Signed-off-by: Nikolay Aleksandrov

BUG: null dereference in __skb_recv_datagram

2015-08-03 Thread Brenden Blanco
Hi Folks, I just hit this one off of latest net-next tree, git hash 58da018053531b9cb91423a64f2a762ef0fe7456 I was running a set of tests from pyroute2 project: https://github.com/svinota/pyroute2 A simple `sudo make test skip_tests=test_stress` in there hits the issue every time. [

Re: [PATCH] 3c59x: Fix resource leaks in vortex_open

2015-08-03 Thread David Miller
From: Jia-Ju Bai baijiaju1...@163.com Date: Mon, 3 Aug 2015 11:18:12 +0800 When vortex_up is failed, the skb buffers allocated by __netdev_alloc_skb in vortex_open are not released, which may cause resource leaks. This bug has been submitted before. This patch modifies the error handling

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-08-03 Thread Jeff Kirsher
On Wed, 2015-07-29 at 14:31 -0700, David Miller wrote: From: Alex Williamson alex.william...@redhat.com Date: Wed, 29 Jul 2015 13:33:07 -0600 I expect that's because of this patch that's in Jeff's dev-queue branch:

[PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-03 Thread Richard Laing
Enable flow-based ECMP. Currently if equal-cost multipath is enabled the kernel chooses between equal cost paths for each matching packet, essentially packets are round-robined between the routes. This means that packets from a single flow can traverse different routes. If one of the routes

[PATCH 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin B Shelar
With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS use a ip_gre net_device. Minimal GRE vport is kept to handle compatibility with current userspace application. Signed-off-by: Pravin B Shelar pshe...@nicira.com

[net-next:master 173/173] net/bridge/br_mdb.c:493:8: error: 'struct net_bridge' has no member named 'vlan_enabled'

2015-08-03 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: e44deb2f0cce9183ca94d14effd4170a35eec31d commit: e44deb2f0cce9183ca94d14effd4170a35eec31d [173/173] bridge: mdb: add/del entry on all vlans if vlan_filter is enabled and vid is 0 config: sh-titan_defconfig

[PATCH 2/2] gre: Remove support for sharing GRE protocol hook.

2015-08-03 Thread Pravin B Shelar
Support for sharing GREPROTO_CISCO port was added so that OVS gre port and kernel GRE devices can co-exist. After flow-based tunneling patches OVS GRE protocol processing is completely moved to ip_gre module. so there is no need for GRE protocol hook. Following patch consolidates GRE protocol

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-08-03 Thread Joe Stringer
On 31 July 2015 at 19:08, Pravin Shelar pshe...@nicira.com wrote: On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer joestrin...@nicira.com wrote: +static void prepare_frag(struct vport *vport, struct sw_flow_key *key, +struct sk_buff *skb) +{ + unsigned int hlen =

[no subject]

2015-08-03 Thread Pravin B Shelar
Following patches make use of new flow based tunneling API from kernel. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were targeted for OVS. Most of GRE protocol code is now consolidated in ip_gre module. Pravin B Shelar

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread David Miller
From: Lucas Stach l.st...@pengutronix.de Date: Mon, 3 Aug 2015 17:50:11 +0200 The clocks are initially active and thus the device is marked active. This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() call at the end of probe then leaves us with an invalid refcount of -1,

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: The pr_debug family of functions turns into a no-op when -DDEBUG is not specified, opting instead to call no_printk, which gets compiled to a no-op (but retains gcc's nice warnings about printf-style arguments). The problem with

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 03 Aug 2015 21:02:21 -0700 On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: This patch replaces calls to net_dbg_ratelimited when !DEBUG with no_printk, keeping with the idiom of

Re: [PATCH net] udp: fix dst races with multicast early demux

2015-08-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Sat, 01 Aug 2015 12:14:33 +0200 From: Eric Dumazet eduma...@google.com Multicast dst are not cached. They carry DST_NOCACHE. As mentioned in commit f8864972126899 (ipv4: fix dst race in sk_dst_get()), these dst need special care before

Re: [PATCH net-next 0/2] lwtunnel: encap locally-generated ipv4 packets

2015-08-03 Thread David Miller
From: Robert Shearman rshea...@brocade.com Date: Mon, 3 Aug 2015 17:39:19 +0100 Locally-generated IPv4 packets, such as from applications running on the host or traceroute/ping currently don't have lwtunnel output redirected encap applied. However, they should do in the same way as for

[PATCH 2/4] net: switchdev: support static FDB addresses

2015-08-03 Thread Vivien Didelot
This patch adds a is_static boolean to the switchdev_obj_fdb structure, in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- include/net/switchdev.h | 1 + net/switchdev/switchdev.c | 2 +- 2 files changed, 2

net: dsa: support switchdev FDB objects

2015-08-03 Thread Vivien Didelot
This patchset refactors the DSA and mv88e6xxx code to use the switchdev FDB objects. The first two patches add minor but necessary changes to switchdev, the third one implements the switchdev glue in DSA for FDB routines, and the forth one refactors the FDB access functions in the mv88e6xxx code.

[PATCH 3/4] net: dsa: add support for switchdev FDB objects

2015-08-03 Thread Vivien Didelot
Remove the fdb_{add,del,getnext} function pointer in favor of new port_fdb_{add,del,getnext}. Implement the switchdev_port_obj_{add,del,dump} functions in DSA to support the SWITCHDEV_OBJ_PORT_FDB objects. These functions are called from switchdev_port_bridge_{get,set,del}link. Signed-off-by:

[PATCHv2 net-next 0/4] add meminfo, bist status and misc. fixes

2015-08-03 Thread Hariprasad Shenai
Hi, This patch series adds the following. Add support to dump memory address range of various hw modules Add support to dump edc bist status during ecc error Read correct bits of who am i register for T6 adapter and update T6 register range This patch series has been created against net-next

[PATCHv2 net-next 4/4] cxgb4: Update T6 register ranges

2015-08-03 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index

[PATCHv2 net-next 2/4] cxgb4: Add support to dump edc bist status

2015-08-03 Thread Hariprasad Shenai
Add support to dump edc bist status for ECC data errors Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 39 drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 5 ++-- 2 files changed, 42 insertions(+), 2

[PATCHv2 net-next 1/4] cxgb4: Add debugfs support to dump meminfo

2015-08-03 Thread Hariprasad Shenai
Add debug support to dump memory address ranges of various hardware modules of the adapter. Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 285 + drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 122

[PATCHv2 net-next 3/4] cxgb4/cxgb4vf: read the correct bits of PL Who Am I register

2015-08-03 Thread Hariprasad Shenai
Read the correct bits of PL Who Am I for the Source PF field which has changed in T6 Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 34 - drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 8 --

[PATCH net-next v2] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Wenyu Zhang
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet should be sampled even the prandom_u32() generate the number of UINT32_MAX. And none packet need be sampled when the probability is 0. Signed-off-by: Wenyu Zhang wen...@vmware.com --- net/openvswitch/actions.c |4

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Alexei Starovoitov
On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS use a ip_gre net_device. Minimal GRE vport is kept to handle compatibility with current

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread David Miller
From: Alexei Starovoitov alexei.starovoi...@gmail.com Date: Mon, 3 Aug 2015 21:23:40 -0700 On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS

Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame

2015-08-03 Thread David Miller
From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Sun, 2 Aug 2015 21:46:02 -0400 If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, an EDSA frame is prepended with a 802.1q header once queued. To fix this, push the VLAN tag to the payload if present, before

Re: [PATCH] xen-netback: Allocate fraglist early to avoid complex rollback

2015-08-03 Thread David Miller
From: Ross Lagerwall ross.lagerw...@citrix.com Date: Mon, 3 Aug 2015 15:38:03 +0100 Determine if a fraglist is needed in the tx path, and allocate it if necessary before setting up the copy and map operations. Otherwise, undoing the copy and map operations is tricky. This fixes a

Re: BUG: null dereference in __skb_recv_datagram

2015-08-03 Thread Brenden Blanco
[ 318.244596] BUG: unable to handle kernel NULL pointer dereference at 008e [ 318.245182] IP: [81455e7c] __skb_recv_datagram+0xbc/0x5a0 Replying to myself, and adding commit interested parties... I went through the git log for the function in question, and positively

Re: [PATCH net-next] mpls: Use definition for reserved label checks

2015-08-03 Thread David Miller
From: Robert Shearman rshea...@brocade.com Date: Mon, 3 Aug 2015 17:50:04 +0100 In multiple locations there are checks for whether the label in hand is a reserved label or not using the arbritray value of 16. Factor this out into a #define for better maintainability and for documentation.

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 9:59 PM, David Miller da...@davemloft.net wrote: From: Alexei Starovoitov alexei.starovoi...@gmail.com Date: Mon, 3 Aug 2015 21:23:40 -0700 On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: With addition of flow based tunneling, there is no need to have

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Alexei Starovoitov
On Mon, Aug 03, 2015 at 10:51:02PM -0700, Pravin Shelar wrote: On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov alexei.starovoi...@gmail.com wrote: On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: With addition of flow based tunneling, there is no need to have special GRE

[PATCH v2 net-next 0/2] RDS-TCP: Network namespace support

2015-08-03 Thread Sowmini Varadhan
This patch series contains the set of changes to correctly set up the infra for PF_RDS sockets that use TCP as the transport in multiple network namespaces. Patch 1 in the series is the minimal set of changes to allow a single instance of RDS-TCP to run in any (i.e init_net or other) net

[PATCH v2 net-next 2/2] RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.

2015-08-03 Thread Sowmini Varadhan
Register pernet subsys init/stop functions that will set up and tear down per-net RDS-TCP listen endpoints. Unregister pernet subusys functions on 'modprobe -r' to clean up these end points. Enable keepalive on both accept and connect socket endpoints. The keepalive timer expiration will ensure

[PATCH net-next 2/2] rocker: use netdev_err after register_netdev

2015-08-03 Thread sfeldma
From: Scott Feldman sfel...@gmail.com After successful register_netdev, we can use netdev_err rather the more generic dev_err. Signed-off-by: Scott Feldman sfel...@gmail.com --- drivers/net/ethernet/rocker/rocker.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 1/2] rocker: NULL port if port probe fails

2015-08-03 Thread sfeldma
From: Scott Feldman sfel...@gmail.com Set port to NULL if port probe fails so we don't try to remove partially initialized port on port probe err cleanup path. Signed-off-by: Scott Feldman sfel...@gmail.com --- drivers/net/ethernet/rocker/rocker.c |1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: This patch replaces calls to net_dbg_ratelimited when !DEBUG with no_printk, keeping with the idiom of all the other debug print helpers. Makes sense, thanks Jason. Perhaps

[PATCH net-next] net_sched: act_bpf: remove spinlock in fast path

2015-08-03 Thread Alexei Starovoitov
Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing. Also similar to gact/mirred there is a race between prog-filter and prog-tcf_action. Meaning that the program being replaced may use previous default action if it happened to return TC_ACT_UNSPEC. act_mirred race betwen

[PATCH v2 net-next 1/2] RDS-TCP: Make RDS-TCP work correctly when it is set up in a netns other than init_net

2015-08-03 Thread Sowmini Varadhan
Open the sockets calling sock_create_kern() with the correct struct net pointer, and use that struct net pointer when verifying the address passed to rds_bind(). Signed-off-by: Sowmini Varadhan sowmini.varad...@oracle.com --- v2: David Ahern comments. net/rds/bind.c|3 ++-

Re: [PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-03 Thread Stephen Hemminger
On Tue, 4 Aug 2015 13:28:47 +1200 Richard Laing richard.la...@alliedtelesis.co.nz wrote: diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index 5fa643b..7db9f72 100644 --- a/include/net/ip_fib.h +++ b/include/net/ip_fib.h @@ -117,6 +117,8 @@ struct fib_info { #ifdef

Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device instead of vport

2015-08-03 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov alexei.starovoi...@gmail.com wrote: On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote: With addition of flow based tunneling, there is no need to have special GRE vport. Removes all of the OVS specific GRE code and make OVS use a

Re: [patch net-next 1/2] rocker: enable support for scattered packets

2015-08-03 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Sun, 2 Aug 2015 20:56:37 +0200 From: Ido Schimmel ido...@mellanox.com rocker supports the transmission of scattered packets, so let the kernel know about it by setting the NETIF_F_SG bit in the device's features. Signed-off-by: Ido Schimmel

Re: [patch net-next 2/2] rocker: linearize skb in case frags would not fit into tx descriptor

2015-08-03 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Sun, 2 Aug 2015 20:56:38 +0200 Suggested-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org

Re: [PATCH net-next] virtio_net: add gro capability

2015-08-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 31 Jul 2015 18:25:17 +0200 From: Eric Dumazet eduma...@google.com Straightforward patch to add GRO processing to virtio_net. napi_complete_done() usage allows more aggressive aggregation, opted-in by setting

Re: [PATCH net-next 0/4] Stacked vlan TSO for virtual devices

2015-08-03 Thread David Miller
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Fri, 31 Jul 2015 15:03:23 +0900 Basically virtual devices do not need to segment double tagged packets. This patch set adds TSO feature for double tagged packets to several virtual devices, which can be realized by simply setting

Re: [PATCH net-next] ebpf: add skb-hash to offset map for usage in {cls,act}_bpf or filters

2015-08-03 Thread Alexei Starovoitov
On 8/2/15 6:09 PM, Tom Herbert wrote: I was thinking whether to add skb_get_hash(), but then concluded the raw skb-hash seems fine in this case: we can directly access the hash w/o extra eBPF helper function call, it's filled out by many NICs on ingress, and in case the entropy level would not

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-08-03 Thread Michal Simek
Hi, On 07/31/2015 11:53 PM, Nathan Sullivan wrote: On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-08-03 Thread Linus Walleij
On Thu, Jul 30, 2015 at 7:28 PM, Alban Bedel al...@free.fr wrote: Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS machines, and each machine type provides its own gpio.h. However only a handful really implement the GPIO API, most just forward everythings to gpiolib. The

Re: [PATCH] r8169: Permit users to change transmit and receive max pachet size

2015-08-03 Thread David Miller
From: Corcodel Marian corcodel.mar...@gmail.com Date: Mon, 3 Aug 2015 10:28:38 +0300 Realtek nic its very versatile and have more registers for optimise and solve different issues. I added 2 parameters rx_buf_sz and txpacketmax 1.Parameter rx_buf_sz represent Receive Packet Maximum size

[PATCH iproute2 net-next] iplink: bonding: add support for IFLA_BOND_TLB_DYNAMIC_LB

2015-08-03 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Add support to be able to set and show the value of tlb_dynamic_lb (IFLA_BOND_TLB_DYNAMIC_LB). Example: $ ip -d link show dev bond0 type bond 7: bond0: BROADCAST,MULTICAST,MASTER mtu 1500 qdisc noop state DOWN mode DEFAULT group default

[PATCH v1] netdev: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Wenyu Zhang
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet should be sampled even the prandom32() generate the number of UINT32_MAX. And none packet need be sampled when the probability is 0. Signed-off-by: Wenyu Zhang wen...@vmware.com --- net/openvswitch/actions.c |4 +++-

Re: [-4.2] rtlwifi: rtl8723be: Add module parameter for MSI interrupts

2015-08-03 Thread Kalle Valo
The driver code allows for the disabling of MSI interrupts; however the module_parm line was missed and the option fails to show with modinfo. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org [3.15+] Thanks, applied to wireless-drivers.git. Kalle

[PATCH] r8169: Permit users to change transmit and receive max pachet size

2015-08-03 Thread Corcodel Marian
Realtek nic its very versatile and have more registers for optimise and solve different issues. I added 2 parameters rx_buf_sz and txpacketmax 1.Parameter rx_buf_sz represent Receive Packet Maximum size and on this program is 16383 bytes, eg RTL 8101E use 16000 and user may use alls

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-08-03 Thread Ralf Baechle
On Mon, Aug 03, 2015 at 09:13:27AM +0200, Linus Walleij wrote: Very good job being done here. Reviewed-by: Linus Walleij linus.wall...@linaro.org I guess this better go in through the MIPS tree. Given all the OpenWRT ports using MIPS this is excellent progress for a large hobbyist

Re: [PATCH 3/6] test_bpf: test LD_ABS and LD_IND instructions on fragmented skbs.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 04:02 PM, Nicolas Schichan wrote: These new tests exercise various load sizes and offsets crossing the head/fragment boundary. Signed-off-by: Nicolas Schichan nschic...@freebox.fr Acked-by: Alexei Starovoitov a...@plumgrid.com Acked-by: Daniel Borkmann dan...@iogearbox.net -- To

Re: [PATCH] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

2015-08-03 Thread Guenter Roeck
On 08/03/2015 06:17 AM, Vivien Didelot wrote: At switch setup, _mv88e6xxx_stats_wait was called without holding the SMI mutex. Fix this by requesting the lock for this call. Also, return the _mv88e6xxx_stats_wait code, since it may fail. Signed-off-by: Vivien Didelot

Re: [PATCH 5/6] test_bpf: add more tests for LD_ABS and LD_IND.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 04:02 PM, Nicolas Schichan wrote: This exerces the LD_ABS and LD_IND instructions for various sizes and alignments. This also checks that X when used as an offset to a BPF_IND instruction first in a filter is correctly set to 0. Signed-off-by: Nicolas Schichan nschic...@freebox.fr

Re: [PATCH 6/6] test_bpf: add tests checking that JIT/interpreter sets A and X to 0.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 04:02 PM, Nicolas Schichan wrote: It is mandatory for the JIT or interpreter to reset the A and X registers to 0 before running the filter. Check that it is the case on various ALU and JMP instructions. Signed-off-by: Nicolas Schichan nschic...@freebox.fr Acked-by: Alexei

Re: [PATCHv6 RFT] net: fec: Ensure clocks are enabled while using mdio bus

2015-08-03 Thread Uwe Kleine-König
Hello, On Mon, Aug 03, 2015 at 03:50:23PM +0200, Andrew Lunn wrote: The problem is that on i.MX27 there are two clocks involved that both must be on to send a packet, while on i.MX6 it's only a single one (abstracted by having ipg-clock = ahb-clock). With the suggested patch only a single

Re: [PATCH 4/6] test_bpf: add module parameters to filter the tests to run.

2015-08-03 Thread Daniel Borkmann
On 08/03/2015 06:23 PM, Nicolas Schichan wrote: ... Btw, for the range test in prepare_bpf_tests(), you could also reject a negative lower bound index right there. I thought it was better to have all the sanity checks grouped in prepare_bpf_tests() (with the checking of the test_name and

Re: [PATCH] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-03 Thread Glenn Griffin
On Mon, Aug 03, 2015 at 09:25:53AM -0700, Pravin Shelar wrote: On Sat, Aug 1, 2015 at 6:31 PM, Glenn Griffin ggriffin.ker...@gmail.com wrote: openvswitch modifies the L4 checksum of a packet when modifying the ip address. When an IP packet is fragmented only the first fragment contains an

[PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-03 Thread Glenn Griffin
openvswitch modifies the L4 checksum of a packet when modifying the ip address. When an IP packet is fragmented only the first fragment contains an L4 header and checksum. Prior to this change openvswitch would modify all fragments, modifying application data in non-first fragments, causing

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Alan Stern
On Mon, 3 Aug 2015, Uwe [iso-8859-1] Kleine-K�nig wrote: Hello, I have no clue about runtime-pm, but I added a few people to Cc: who should know better ... Best regards Uwe On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas

Re: [patch net-next 2/2] rocker: linearize skb in case frags would not fit into tx descriptor

2015-08-03 Thread Scott Feldman
On Sun, Aug 2, 2015 at 11:56 AM, Jiri Pirko j...@resnulli.us wrote: Suggested-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Acked-by: Scott Feldman sfel...@gmail.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [patch net-next 1/2] rocker: enable support for scattered packets

2015-08-03 Thread Scott Feldman
On Sun, Aug 2, 2015 at 11:56 AM, Jiri Pirko j...@resnulli.us wrote: From: Ido Schimmel ido...@mellanox.com rocker supports the transmission of scattered packets, so let the kernel know about it by setting the NETIF_F_SG bit in the device's features. Signed-off-by: Ido Schimmel

Re: [ovs-dev] [PATCH v1] netdev: Make 100 percents packets sampled when sampling rate is 1.

2015-08-03 Thread Jesse Gross
On Mon, Aug 3, 2015 at 11:18 AM, Pravin Shelar pshe...@nicira.com wrote: On Mon, Aug 3, 2015 at 12:11 AM, Wenyu Zhang wen...@vmware.com wrote: When sampling rate is 1, the sampling probability is UINT32_MAX. The packet should be sampled even the prandom32() generate the number of UINT32_MAX.

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Joe Stringer
On 30 July 2015 at 04:57, Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes:

Re: [patch -master] netfilter: xt_CT: checking for IS_ERR() instead of NULL

2015-08-03 Thread Joe Stringer
On 3 August 2015 at 11:29, Joe Stringer joestrin...@nicira.com wrote: On 30 July 2015 at 04:57, Pablo Neira Ayuso pa...@netfilter.org wrote: On Tue, Jul 28, 2015 at 01:42:28AM +0300, Dan Carpenter wrote: We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error

[PATCH net-next 2/2] ipv4: apply lwtunnel encap for locally-generated packets

2015-08-03 Thread Robert Shearman
lwtunnel encap is applied for forwarded packets, but not for locally-generated packets. This is because the output function is not overridden in __mkroute_output, unlike it is in __mkroute_input. The lwtunnel state is correctly set on the rth through the call to rt_set_nexthop, so all that needs

[PATCH net-next 1/2] lwtunnel: set skb protocol and dev

2015-08-03 Thread Robert Shearman
In the locally-generated packet path skb-protocol may not be set and this is required for the lwtunnel encap in order to get the lwtstate. This would otherwise have been set by ip_output or ip6_output so set skb-protocol prior to calling the lwtunnel encap function. Additionally set skb-dev in

[PATCH net-next 0/2] lwtunnel: encap locally-generated ipv4 packets

2015-08-03 Thread Robert Shearman
Locally-generated IPv4 packets, such as from applications running on the host or traceroute/ping currently don't have lwtunnel output redirected encap applied. However, they should do in the same way as for forwarded packets and this patch series addresses that. Robert Shearman (2): lwtunnel:

[PATCH v2 net-next 4/4] fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks

2015-08-03 Thread Tom Herbert
Do WARN_ON_ONCE instead of WARN_ON in gue_gro_receive when the offload callcaks are bad (either don't exist or gro_receive is not specified). Signed-off-by: Tom Herbert t...@herbertland.com --- net/ipv4/fou.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/fou.c

[PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-08-03 Thread Tom Herbert
For GRO to work with sit we need gro_receive and gro_complete populated in the sit_offload structure. Signed-off-by: Tom Herbert t...@herbertland.com --- net/ipv6/ip6_offload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index

[PATCH v2 net-next 1/4] gro: Fix remcsum offload to deal with frags in GRO

2015-08-03 Thread Tom Herbert
The remote checksum offload GRO did not consider the case that frag0 might be in use. This patch fixes that by accessing headers using the skb_gro functions and not saving offsets relative to skb-head. Signed-off-by: Tom Herbert t...@herbertland.com --- drivers/net/vxlan.c | 23

  1   2   >