[PATCH net v3.16] r8169: Increase no descriptors on max.

2016-02-29 Thread Corcodel Marian
This patch increase rx/tx on maximum allowed 1024 4-duble-words descriptors. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH] Increase no descriptors on max.

2016-02-29 Thread Corcodel Marian
This patch increase rx/tx on maximum allowed 1024 4-duble-words descriptors. Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[net-next] arp: correct return value of arp_rcv

2016-02-29 Thread Zhang Shengju
Currently, arp_rcv() always return zero on a packet delivery upcall. To make its behavior more compliant with the way this API should be used, this patch changes this to let it return NET_RX_SUCCESS when the packet is proper handled, and NET_RX_DROP otherwise. Signed-off-by: Zhang Shengju

pull request: bluetooth-next 2016-03-01

2016-02-29 Thread Johan Hedberg
Hi Dave, Here's our main set of Bluetooth & 802.15.4 patches for the 4.6 kernel. - New Bluetooth HCI driver for Intel/AG6xx controllers - New Broadcom ACPI IDs - LED trigger support for indicating Bluetooth powered state - Various fixes in mac802154, 6lowpan and related drivers - New USB

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-29 Thread John Holland
On Mar 1, 2016, at 03:52, Brown, Aaron F wrote: > This throws a few checkpatch warnings, but I won't withhold my tested by for > these: > > total: 0 errors, 2 warnings, 0 checks, 21 lines checked > > Your patch has style problems, please review. > > NOTE: If any of

Re: [PATCH] [BACKPORT] [3.14.56] bnx2x: Don't notify about scratchpad parities

2016-02-29 Thread Greg KH
On Thu, Dec 10, 2015 at 02:37:34PM +0100, Patrick Schaaf wrote: > On Friday 06 November 2015 09:32:46 Greg KH wrote: > > On Thu, Nov 05, 2015 at 11:18:37AM +0100, Patrick Schaaf wrote: > > > bnx2x: Don't notify about scratchpad parities > > > > > > This is a (trivial) "backport" of

Re: linux-next: manual merge of the target-merge tree with the net-next tree

2016-02-29 Thread Stephen Rothwell
Hi Nicholas, On Mon, 29 Feb 2016 21:39:33 -0800 "Nicholas A. Bellinger" wrote: > > I'll include a note to Linus in target-pending/for-next-merge PULL > request, and will plan to wait until after DaveM's net-next is merged > for v4.6-rc0. The order doesn't really matter

Re: linux-next: manual merge of the target-merge tree with the net-next tree

2016-02-29 Thread Nicholas A. Bellinger
On Mon, 2016-02-29 at 17:39 +1100, Stephen Rothwell wrote: > Hi Nicholas, > > Today's linux-next merge of the target-merge tree got a conflict in: > > drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h > > between commit: > > ba9cee6aa67d ("cxgb4/iw_cxgb4: TOS support") > > from the net-next

Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround

2016-02-29 Thread Scott Wood
On 02/29/2016 09:17 AM, igal.liber...@freescale.com wrote: > From: Igal Liberman > > Errata dTSEC-A003 was fixed in P4080 rev 3.0. > Prior revisions are not supported, so the workaround can be removed. > > Signed-off-by: Igal Liberman

RE: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-29 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of John Holland > Sent: Thursday, February 18, 2016 3:11 AM > To: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org > Subject: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using > a

RE: [Intel-wired-lan] [PATCH] igb: Garbled output for "ethtool -m"

2016-02-29 Thread Brown, Aaron F
> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Doron Shikmoni [doron.shikm...@gmail.com] > Sent: Tuesday, February 16, 2016 11:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] igb: Garbled output for

Re: [PATCH] asm-generic: remove old nonatomic-io wrapper files

2016-02-29 Thread Yisen Zhuang
在 2016/2/26 22:29, Arnd Bergmann 写道: > The two header files got moved to include/linux, and most > users were already converted, this changes the remaining drivers > and removes the files. > > Signed-off-by: Arnd Bergmann > --- > drivers/dma/idma64.h

Re:LDPE/HDPE/TPE gloves etc.

2016-02-29 Thread Vivian
Dear Manager, This is Vivian from Ju County Mingbo Industry & Trade Co.,Ltd in China. Glad to hear that you're on the market for disposable PE gloves and aprons. We mainly produced LDPE/HDPE/TPE gloves,Two fingers gloves, PE aprons for more than eight years. Our products have been exported to

Re: [PATCH] asm-generic: remove old nonatomic-io wrapper files

2016-02-29 Thread Simon Horman
On Fri, Feb 26, 2016 at 03:29:05PM +0100, Arnd Bergmann wrote: > The two header files got moved to include/linux, and most > users were already converted, this changes the remaining drivers > and removes the files. > > Signed-off-by: Arnd Bergmann > --- > drivers/dma/idma64.h

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread John Fastabend
On 16-02-29 01:25 PM, Cong Wang wrote: > On Mon, Feb 29, 2016 at 10:58 AM, Jiri Pirko wrote: >> Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >>> On 16-02-27 08:28 PM, Cong Wang wrote: On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend

RE: [PATCH net-next 0/4] lan78xx: driver update

2016-02-29 Thread Woojung.Huh
> > This patch series add new ethtool functions of set_pauseparam & > get_pauseparam > > and MAINTAINERS entry. > > Series applied, thanks. Thanks. > Please fix your configuration such that your proper name appears in the > "From: " field of your outgoing emails. That is what ends up in the >

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 11:14 AM, Thomas Gleixner wrote: > On Mon, 29 Feb 2016, Peter Hurley wrote: >> On 02/29/2016 10:24 AM, Eric Dumazet wrote: Just to be clear if (time_before(jiffies, end) && !need_resched() && --max_restart) goto

[PATCH net v2] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Benjamin Poirier
The current reserved_tailroom calculation fails to take hlen and tlen into account. skb: [__hlen__|__data|__tlen___|__extra__] ^ ^ headskb_end_offset In this representation, hlen + data + tlen

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread David Miller
From: Ben Hutchings Date: Mon, 29 Feb 2016 22:34:38 + > On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: >> From: Simon Xiao >> Date: Thu, 25 Feb 2016 15:24:08 -0800 >> >> > This patch allows the user to set and retrieve speed and duplex of

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread Jouni Malinen
On Mon, Feb 29, 2016 at 05:30:20PM -0500, João Paulo Rechi Vita wrote: > I agree there is a difference in the logic here, thanks for taking the > time to point it out so clearly, and sorry for missing this. But AFAIU > userspace should not call RFKILL_OP_CHANGE with ev.type == > RFKILL_TYPE_ALL,

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread Ben Hutchings
On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: > From: Simon Xiao > Date: Thu, 25 Feb 2016 15:24:08 -0800 > > > This patch allows the user to set and retrieve speed and duplex of the > > hv_netvsc device via ethtool. > >  > > Example: > > $ ethtool eth0 > > Settings

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-02-29 Thread João Paulo Rechi Vita
Hello Jouni, On 26 February 2016 at 12:59, Jouni Malinen wrote: > On Mon, Feb 22, 2016 at 11:36:39AM -0500, João Paulo Rechi Vita wrote: >> Using a switch to handle different ev.op values in rfkill_fop_write() >> makes the code easier to extend, as out-of-range values can always be

Re: Question on switchdev

2016-02-29 Thread Andrew Lunn
On Mon, Feb 29, 2016 at 04:43:16PM -0500, Murali Karicheri wrote: Hi Murali Please can you get your email client to wrap lines at ~ 75 characters. > TI Keystone netcp h/w has a switch. It has n slave ports and 1 host > port. Currently the netcp driver disables the switch functionality > which

Re: [PATCH net-next 0/4] lan78xx: driver update

2016-02-29 Thread David Miller
From: Date: Thu, 25 Feb 2016 23:33:05 + > This patch series add new ethtool functions of set_pauseparam & > get_pauseparam > and MAINTAINERS entry. Series applied, thanks. Please fix your configuration such that your proper name appears in the "From: " field of

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread David Miller
From: Simon Xiao Date: Thu, 25 Feb 2016 15:24:08 -0800 > This patch allows the user to set and retrieve speed and duplex of the > hv_netvsc device via ethtool. > > Example: > $ ethtool eth0 > Settings for eth0: > ... > Speed: Unknown! > Duplex: Unknown! (255) > ...

[PATCH next 2/3] ipvlan: Implement L3-symmetric mode.

2016-02-29 Thread Mahesh Bandewar
From: Mahesh Bandewar Current packet processing from IPtables perspective is asymmetric for IPvlan L3 mode. On egress path, packets hit LOCAL_OUT and POST_ROUTING hooks in slave-ns as well as master's ns however during ingress path, LOCAL_IN and PRE_ROUTING hooks are hit only

[PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

2016-02-29 Thread Mahesh Bandewar
From: Mahesh Bandewar netif_receive_skb_core() dispatcher uses skb->dev device to send it to the packet-handlers (e.g. ip_rcv, ipv6_rcv etc). These packet handlers intern use the device passed to determine the net-ns to further process these packets. Now with the nomination

[PATCH next 1/3] dev: Add netif_get_l3_dev() helper

2016-02-29 Thread Mahesh Bandewar
From: Mahesh Bandewar This patch adds a l3_dev pointer and a helper function to retrieve that. During ingress L3 packet processing, this device will be used instead of skb->dev. Since l3_dev is initialized to self; l3_dev should be pointing to skb->dev so the normal packet

[PATCH next 0/3] IPvlan L3 symetric mode

2016-02-29 Thread Mahesh Bandewar
From: Mahesh Bandewar One of the major request (for enhancement) that I have received from various users of IPvlan in L3 mode is its inability to handle IPtables. In a typical IPvlan L3 setup where master is in default-ns and each slave is into different (slave) ns. In this

Re: [PATCH] 3c59x: mask LAST_FRAG bit from length field in ring

2016-02-29 Thread David Miller
From: Neil Horman Date: Thu, 25 Feb 2016 13:02:50 -0500 > Recently, I fixed a bug in 3c59x: > > commit 6e144419e4da11a9a4977c8d899d7247d94ca338 > Author: Neil Horman > Date: Wed Jan 13 12:43:54 2016 -0500 > > 3c59x: fix another page

Re: [Patch net-next v3 0/4] net_sched: update backlog for hierarchical qdisc's

2016-02-29 Thread David Miller
From: Cong Wang Date: Thu, 25 Feb 2016 14:54:59 -0800 > For hierarchical qdisc like HTB, we currently only update its qlen > but leave its backlog as zero: > > qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat > 0 ver 3.17 > Sent

Question on switchdev

2016-02-29 Thread Murali Karicheri
Hi Jiri, Scott, or other switchdev experts, TI Keystone netcp h/w has a switch. It has n slave ports and 1 host port. Currently the netcp driver disables the switch functionality which makes them appear as n nic ports. However we have requirement to add switch support in the driver. I have

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread Cong Wang
On Mon, Feb 29, 2016 at 10:58 AM, Jiri Pirko wrote: > Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >>On 16-02-27 08:28 PM, Cong Wang wrote: >>> On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend >>> wrote: On 16-02-26 09:39

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-02-29 Thread Sergei Shtylyov
On 02/28/2016 05:13 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx)

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-02-29 Thread Sergei Shtylyov
Hello. On 02/28/2016 06:41 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx,

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread David Miller
From: Thomas Gleixner Date: Mon, 29 Feb 2016 20:14:36 +0100 (CET) > On Mon, 29 Feb 2016, Peter Hurley wrote: >> Or flipping your argument on its head, why not just _always_ execute >> softirq in ksoftirqd? > > Which is what that change effectivley does. And that makes a lot

[PATCH 4/4] net: can: ifi: Add obscure bit swap for EFF frame IDs

2016-02-29 Thread Marek Vasut
In case of CAN2.0 EFF frame, the controller handles frame IDs in a rather bizzare way. The ID is split into an extended part, IDX[28:11] and standard part, ID[10:0]. In the TX path, the core first sends the top 11 bits of the IDX, followed by ID and finally the rest of IDX. In the RX path, the

[PATCH 1/4] net: can: ifi: Fix clock generator configuration

2016-02-29 Thread Marek Vasut
The clock generation does not match reality when using the CAN IP core outside of the FPGA design. This patch fixes the computation of values which are programmed into the clock generator registers. First, there are some off-by-one errors which manifest themselves only when communicating with

[PATCH 3/4] net: can: ifi: Fix RX and TX ID mask

2016-02-29 Thread Marek Vasut
The RX and TX ID mask for CAN2.0 is 11 bits wide. This patch fixes the incorrect mask, which caused the CAN IDs to miss the MSBit both on receive and transmit. Signed-off-by: Marek Vasut Cc: Marc Kleine-Budde Cc: Mark Rutland Cc: Oliver

[PATCH 0/4] Synchronise IFI CANFD driver with real world

2016-02-29 Thread Marek Vasut
Thus far, this driver was only tested on a hardware synthesised in the warm and safe insides of an FPGA, only against another IFI CANFD core. The real hardware arrived now and I tested the IFI CANFD driver against different, harsh, real-world CAN controller. This uncovered a few bugs, so here are

[PATCH 2/4] net: can: ifi: Fix TX DLC configuration

2016-02-29 Thread Marek Vasut
The TX DLC, the transmission length information, was not written into the transmit configuration register. When using the CAN core with different CAN controller, the receiving CAN controller will receive only the ID part of the CAN frame, but no data at all. This patch adds the TX DLC into the

[ANNOUNCE] NetDev 1.1 slides now available

2016-02-29 Thread Pablo Neira Ayuso
Hi, Today we're releasing the NetDev 1.1 slides, you can find them at: http://www.netdevconf.org/1.1/proceedings/ Regarding videos, we're still uploading (~40 hours), so it may take a little while until we make them public. Will send a short noticed once they are available. And short

Re: [PATCH] mrf24j40: fix security-enabled processing on inbound frames

2016-02-29 Thread Alan Ott
On 02/18/2016 01:34 PM, zopieux wrote: Fix the MRF24J40 handling of security-enabled frames so it does not block upon receiving such frames. Signed-off-by: Alexander Aring Reported-by: Alexandre Macabies Tested-by: Alexandre Macabies

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 11:13 -0800, Peter Hurley wrote: > On 02/29/2016 07:27 AM, Eric Dumazet wrote: > > On lun., 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > > > >> The reason why Eric's change is so effective for Eric's workload is > >> that it fixes the problem where NET_RX keeps getting

Re: [PATCH net-next V1 09/10] net/mlx5: Fix global UAR mapping

2016-02-29 Thread Saeed Mahameed
> > Well anyone can see that from the code. > > You have to explain why. In a simple words as partially explained in the commit message we want to have both mappings (NC and WC) available so upper layer can decide which to choose e.g. for SQs/QPs in some cases (Small Packets) and only when WC is

[net-next PATCH] net: relax setup_tc ndo op handle restriction

2016-02-29 Thread John Fastabend
I added this check in setup_tc to multiple drivers, if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO) Unfortunately restricting to TC_H_ROOT like this breaks the old instantiation of mqprio to setup a hardware qdisc. This patch relaxes the test to only check the type to make it equivalent

Re: [Patch net-next] net: remove skb_sender_cpu_clear()

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 10:55 -0800, Cong Wang wrote: > On Mon, Feb 29, 2016 at 10:50 AM, Daniel Borkmann > wrote: > > On 02/28/2016 05:19 AM, Cong Wang wrote: > >> > >> After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id > >> cohabitation") > >>

[PATCH net V1 4/7] net/mlx5e: Fix ethtool RX hash func configuration change

2016-02-29 Thread Saeed Mahameed
From: Tariq Toukan We should modify TIRs explicitly to apply the new RSS configuration. The light ndo close/open calls do not "refresh" them. Fixes: 2d75b2bc8a8c ('net/mlx5e: Add ethtool RSS configuration options') Signed-off-by: Tariq Toukan

[PATCH net V1 7/7] net/mlx5e: Provide correct packet/bytes statistics

2016-02-29 Thread Saeed Mahameed
From: Gal Pressman Using the HW VPort counters for traffic (rx/tx packets/bytes) statistics is wrong. This is because frames dropped due to steering or out of buffer will be counted as received. To fix that, we move to use the packet/bytes accounting done by the driver for

[PATCH net V1 0/7] Mellanox 100G mlx5 driver fixes

2016-02-29 Thread Saeed Mahameed
Hi Dave, This series has few bug fixes for the mlx5 Ethernet driver. Eran fixed a locking issue with time-stamping that could cause a soft-lockup when time-stamping is enabled. Gal fixed the rx/tx packets/bytes counters returned by the driver to actually went through the network stack. Tariq

[PATCH net V1 5/7] net/mlx5e: Correctly handle RSS indirection table when changing number of channels

2016-02-29 Thread Saeed Mahameed
From: Tariq Toukan Upon changing num_channels, reset the RSS indirection table to match the new value. Fixes: 2d75b2bc8a8c ('net/mlx5e: Add ethtool RSS configuration options') Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[PATCH net V1 6/7] net/mlx5e: Add rx/tx bytes software counters

2016-02-29 Thread Saeed Mahameed
From: Gal Pressman Sum up rx/tx bytes in software as we do for rx/tx packets, to be reported in upcoming statistics fix. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h|

[PATCH net V1 3/7] net/mlx5e: Fix soft lockup when HW Timestamping is enabled

2016-02-29 Thread Saeed Mahameed
From: Eran Ben Elisha Readers/Writers lock for SW timecounter was acquired without disabling interrupts on local CPU. The problematic scenario: * HW timestamping is enabled * Timestamp overflow periodic service task is running on local CPU and holding write_lock for SW

[PATCH net V1 1/7] net/mlx5e: Remove wrong poll CQ optimization

2016-02-29 Thread Saeed Mahameed
From: Tariq Toukan With the MLX5E_CQ_HAS_CQES optimization flag, the following buggy flow might occur: - Suppose RX is always busy, TX has a single packet every second. - We poll a single TX cqe and clear its flag. - We never arm it again as RX is always busy. - TX CQ flag

[PATCH net V1 2/7] net/mlx5e: Fix LRO modify

2016-02-29 Thread Saeed Mahameed
From: Tariq Toukan Ethtool LRO enable/disable is broken, as of today we only modify TCP TIRs in order to apply the requested configuration. Hardware requires that all TIRs pointing to the same RQ should share the same LRO configuration. For that all other TIRs' LRO fields

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Thomas Gleixner
On Mon, 29 Feb 2016, Peter Hurley wrote: > On 02/29/2016 10:24 AM, Eric Dumazet wrote: > >> Just to be clear > >> > >>if (time_before(jiffies, end) && !need_resched() && > >>--max_restart) > >>goto restart; > >> > >> aborts softirq *even if 0ns have

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 07:27 AM, Eric Dumazet wrote: > On lun., 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > >> The reason why Eric's change is so effective for Eric's workload is >> that it fixes the problem where NET_RX keeps getting new network packets >> so it keeps looping, servicing more NET_RX

Re: [PATCH net-next v3 0/5] bridge/ovs: avoid skb head copy on frame forwarding

2016-02-29 Thread pravin shelar
On Fri, Feb 26, 2016 at 1:45 AM, Paolo Abeni wrote: > Currently, while when an OVS or Linux bridge is used to forward frames towards > some tunnel device, a skb_head_copy() may occur if the ingress device do not > provide enough headroom for the tx encapsulation. > > This patch

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread Jiri Pirko
Mon, Feb 29, 2016 at 07:40:53PM CET, john.fastab...@gmail.com wrote: >On 16-02-27 08:28 PM, Cong Wang wrote: >> On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend >> wrote: >>> On 16-02-26 09:39 AM, Cong Wang wrote: On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend

Re: [Patch net-next] net: remove skb_sender_cpu_clear()

2016-02-29 Thread Cong Wang
On Mon, Feb 29, 2016 at 10:50 AM, Daniel Borkmann wrote: > On 02/28/2016 05:19 AM, Cong Wang wrote: >> >> After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id >> cohabitation") >> skb_sender_cpu_clear() becomes empty and can be removed. >> >> Cc: Eric

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 10:24 AM, Eric Dumazet wrote: > On lun., 2016-02-29 at 10:05 -0800, Peter Hurley wrote: > >> While I appreciate the attempt, that's not the problem. >> >> Just to be clear >> >> if (time_before(jiffies, end) && !need_resched() && >> --max_restart) >>

Re: [Patch net-next] net: remove skb_sender_cpu_clear()

2016-02-29 Thread Daniel Borkmann
On 02/28/2016 05:19 AM, Cong Wang wrote: After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id cohabitation") skb_sender_cpu_clear() becomes empty and can be removed. Cc: Eric Dumazet Signed-off-by: Cong Wang Wasn't the

Re: [PATCH] mrf24j40: fix security-enabled processing on inbound frames

2016-02-29 Thread Alan Ott
On 02/23/2016 04:29 AM, Alexander Aring wrote: Alan, do you have some comments about that? Currently the mrf24j40 goes into a deadlock if a frame with security enable bit is set. As you see, I helped myself to create this patch and solve this stupid default behaviour of mrf24j40. :-) Hi

Re: [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-29 Thread John Fastabend
On 16-02-27 08:28 PM, Cong Wang wrote: > On Fri, Feb 26, 2016 at 8:24 PM, John Fastabend > wrote: >> On 16-02-26 09:39 AM, Cong Wang wrote: >>> On Fri, Feb 26, 2016 at 7:53 AM, John Fastabend >>> wrote: diff --git a/include/net/pkt_cls.h

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Hannes Frederic Sowa
On 29.02.2016 19:08, Benjamin Poirier wrote: If you think we should write the expression with "if" instead of "min", instead of the current + skb->reserved_tailroom = skb_tailroom(skb) - + min_t(int, mtu, skb_tailroom(skb) - tlen); it should be: + if (mtu <

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 10:05 -0800, Peter Hurley wrote: > While I appreciate the attempt, that's not the problem. > > Just to be clear > > if (time_before(jiffies, end) && !need_resched() && > --max_restart) > goto restart; > > aborts

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Benjamin Poirier
On 2016/02/29 16:43, Hannes Frederic Sowa wrote: > On 29.02.2016 16:19, Benjamin Poirier wrote: > >On 2016/02/29 15:57, Daniel Borkmann wrote: > >[...] > >> > >>[ cutting the IPv4 part off as diff is the same ] > >> > >>>diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > >>>index 5ee56d0..c157edc

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 08:21 AM, Eric Dumazet wrote: > On lun., 2016-02-29 at 07:54 -0800, Peter Hurley wrote: > >> The current kernel is HZ=250 but this would occur on HZ=1000 as well. > > Right. But the problem with HZ=100 and HZ=250 is that the detection can > happens because jiffy granularity is too

[PATCH v2] socket.7: Document some BPF-related socket options

2016-02-29 Thread Craig Gallek
From: Craig Gallek Document the behavior and the first kernel version for each of the following socket options: SO_ATTACH_FILTER SO_ATTACH_BPF SO_ATTACH_REUSEPORT_CBPF SO_ATTACH_REUSEPORT_EBPF SO_DETACH_FILTER SO_DETACH_BPF SO_LOCK_FILTER Signed-off-by: Craig Gallek

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread David Miller
From: Peter Hurley Date: Mon, 29 Feb 2016 07:03:11 -0800 > However, I'm pointing out that Eric's sledgehammer approach to fixing > the NET_RX softirq bug is having significant side-effects in other > subsystems. Either your hardware can handle arbitrary latencies and

Re: [PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-29 Thread Tom Herbert
On Mon, Feb 29, 2016 at 2:23 AM, Jiri Benc wrote: > On Sat, 27 Feb 2016 12:54:52 -0800, Tom Herbert wrote: >> Yes, but RCO has not been specified for VXLAN-GPE either > > As far as I can see, RCO will just work with VXLAN-GPE. But I have no > problem disallowing them to be set

Re: [net] net: fix double free issue of skbuff

2016-02-29 Thread David Miller
From: 张胜举 Date: Mon, 29 Feb 2016 22:16:37 +0800 >> On Mon, 2016-02-29 at 12:22 +, Zhang Shengju wrote: >> > If skb_reorder_vlan_header() failed, skb is freed and NULL is returned. >> > Then at skb_vlan_untag(), it will free skbuff again which cause double

Re: [net] net: fix double free issue of skbuff

2016-02-29 Thread David Miller
From: Zhang Shengju Date: Mon, 29 Feb 2016 12:22:53 + > If skb_reorder_vlan_header() failed, skb is freed and NULL is returned. > Then at skb_vlan_untag(), it will free skbuff again which cause double > free. The 'skb' local variable in this case will be

Re: [PATCH v3 00/17] stmmac: enhance driver performances and update the version

2016-02-29 Thread Giuseppe CAVALLARO
Gents on top of these patches, there is a new train to enhance the stmmac to support the DWMAC_4.x chips. They will be proposed very soon and on top of this update (as soon as reviewed and merged). In our context, it has been very useful working with the same driver that runs fine on several

[PATCH] ethernet/atl1c: remove left over dead code

2016-02-29 Thread Eric Engestrom
Left over from c24588afc536a35c924d014f13b669b20ccf8553 ("atl1c: using fixed TXQ configuration for l2cb and l1c") Signed-off-by: Eric Engestrom --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH] net/ipv4: remove left over dead code

2016-02-29 Thread Eric Engestrom
8cc785f6f429c2a3fb81745dc142cbd72a462c4a ("net: ipv4: make the ping /proc code AF-independent") removed the code using it, but renamed this variable instead of removing it. Signed-off-by: Eric Engestrom --- net/ipv4/ping.c | 7 --- 1 file changed, 7 deletions(-)

[PATCH] net/rtnetlink: remove dead code

2016-02-29 Thread Eric Engestrom
3b766cd832328fcb87db3507e7b98cf42f21689d ("net/core: Add reading VF statistics through the PF netdevice") added that variable but it's never been used. Signed-off-by: Eric Engestrom --- net/core/rtnetlink.c | 9 - 1 file changed, 9 deletions(-) diff --git

INFORMAÇÃO IMPORTANTE RE: Consultoria de Investimento em sua Localidade.

2016-02-29 Thread Alecssandro
Oi Amigo, INFORMAÇÃO IMPORTANTE Nossa família está interessada em investir fundos em sua localidade. Mais informações para você se interessou. Saudações, Sir Henry Neville Lindley Keswick Presidente da Jardine Matheson Holdings Ltd https://en.wikipedia.org/wiki/Keswick_family

[PATCH 0/3] Enable Ethernet on STM32F429 EVAL board

2016-02-29 Thread Alexandre TORGUE
This series adds Ethernet support on STM32F429 SOC and enable it on Eval board: -Add Ethernet node in SOC file: -Define MII mode pinctrl -use Mixed burst and PBL 8 -Add system config node for glue. -Enable Ethernet for Eval board: -mii mode -connected to a PHY through MDIO. Note, this

[PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support

2016-02-29 Thread Alexandre TORGUE
Add Ethernet support (Synopsys MAC IP 3.50a) on stm32f429 SOC. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index bb7a736..af0367c 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++

[PATCH] net-sysfs: remove left over dead code

2016-02-29 Thread Eric Engestrom
This format hasn't been used since 04ed3e741d0f133e02bed7fa5c98edba128f90e7 ("net: change netdev->features to u32") Signed-off-by: Eric Engestrom --- net/core/net-sysfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c

[PATCH 3/3] ARM: dts: stm32f429: Enable Ethernet on Eval board

2016-02-29 Thread Alexandre TORGUE
MAC is connected to a PHY in MII mode. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index 1ae57fa..e345459 100644 --- a/arch/arm/boot/dts/stm32429i-eval.dts +++

Re: [PATCH v2 1/3] net: ipv4: Convert IP network timestamps to be y2038 safe

2016-02-29 Thread Arnd Bergmann
On Saturday 27 February 2016 00:32:15 Deepa Dinamani wrote: > ICMP timestamp messages and IP source route options require > timestamps to be in milliseconds modulo 24 hours from > midnight UT format. > > Add inet_current_timestamp() function to support this. The function > returns the required

[PATCH 1/3] ARM: dts: stm32f429: Add system config bank node

2016-02-29 Thread Alexandre TORGUE
Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 598362e..bb7a736 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot/dts/stm32f429.dtsi @@ -171,6 +171,11 @@

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 07:58 -0800, Peter Hurley wrote: > All that's happened is the first loop of NET_RX softirq has woken a > process; that is sufficient to abort softirq and defer it for ksoftirqd. > > That's why I'm saying this is a priority inversion, and one that > will happen a lot.

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 07:54 -0800, Peter Hurley wrote: > The current kernel is HZ=250 but this would occur on HZ=1000 as well. Right. But the problem with HZ=100 and HZ=250 is that the detection can happens because jiffy granularity is too coarse, since msecs_to_jiffies(2) -> 1 Following

[PATCH] stmmac: Fix 'eth0: No PHY found' regression

2016-02-29 Thread Gabriel Fernandez
This patch manages the case when you have an Ethernet MAC with a "fixed link", and not connected to a normal MDIO-managed PHY device. The test of phy_bus_name was not helpful because it was never affected and replaced by the mdio test node. Signed-off-by: Gabriel Fernandez

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 07:19 AM, Eric Dumazet wrote: > On lun., 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > >> Not the case. The softirq is raised from interrupt. >> >> Before Eric's change, when an interrupt raises a new softirq >> while processing another softirq, the new softirq is immediately >>

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Peter Hurley
On 02/29/2016 07:40 AM, Mike Galbraith wrote: > On Mon, 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > >>> If I'm listening properly, the root cause is that there is a timing >>> constraint involved, which is being exposed because one softirq raises >>> another (ew). >> >> Not the case. The

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Daniel Borkmann
On 02/29/2016 04:19 PM, Benjamin Poirier wrote: On 2016/02/29 15:57, Daniel Borkmann wrote: [...] [ cutting the IPv4 part off as diff is the same ] diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 5ee56d0..c157edc 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -1574,9 +1574,9

Re: [PATCH] mld, igmp: Fix reserved tailroom calculation

2016-02-29 Thread Hannes Frederic Sowa
On 29.02.2016 16:19, Benjamin Poirier wrote: On 2016/02/29 15:57, Daniel Borkmann wrote: [...] [ cutting the IPv4 part off as diff is the same ] diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 5ee56d0..c157edc 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -1574,9 +1574,9 @@

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Mike Galbraith
On Mon, 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > > If I'm listening properly, the root cause is that there is a timing > > constraint involved, which is being exposed because one softirq raises > > another (ew). > > Not the case. The softirq is raised from interrupt. Yeah, saw that on

[PATCH] fsl/fman: remove dTSEC-A003 Errata workaround

2016-02-29 Thread igal.liberman
From: Igal Liberman Errata dTSEC-A003 was fixed in P4080 rev 3.0. Prior revisions are not supported, so the workaround can be removed. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/fman_dtsec.c |8 1

[PATCH net 4/5] dwc_eth_qos: use DWCEQOS_MSG_DEFAULT

2016-02-29 Thread Lars Persson
From: Rabin Vincent Since debug is hardcoded to 3, the defaults in the DWCEQOS_MSG_DEFAULT macro are never used, which does not seem to be the intended behaviour here. Set debug to -1 like other drivers so that DWCEQOS_MSG_DEFAULT is actually used by default. Signed-off-by:

[PATCH net 1/5] dwc_eth_qos: fix race condition in dwceqos_start_xmit

2016-02-29 Thread Lars Persson
From: Rabin Vincent The xmit handler and the tx_reclaim tasklet had a race on the tx_free variable which could lead to a tx timeout if tx_free was updated after the tx complete interrupt. Signed-off-by: Rabin Vincent Signed-off-by: Lars Persson

[PATCH net 2/5] dwc_eth_qos: release descriptors outside netif_tx_lock

2016-02-29 Thread Lars Persson
To prepare for using the CMA, we can not be in atomic context when de-allocating DMA buffers. The tx lock was needed only to protect the hw reset against the xmit handler. Now we briefly grab the tx lock while stopping the queue to make sure no thread is inside or will enter the xmit handler.

[PATCH net 5/5] dwc_eth_qos: do phy_start before resetting hardware

2016-02-29 Thread Lars Persson
This reverts the changed init order from commit 3647bc35bd42 ("dwc_eth_qos: Reset hardware before PHY start") and makes another fix for the race. It turned out that the reset state machine of the dwceqos hardware requires PHY clocks to be present in order to complete the reset cycle. To plug the

[PATCH net 3/5] dwc_eth_qos: use GFP_KERNEL in dma_alloc_coherent()

2016-02-29 Thread Lars Persson
From: Rabin Vincent Since we are in non-atomic context here we can pass GFP_KERNEL to dma_alloc_coherent(). This enables use of the CMA. Signed-off-by: Rabin Vincent Signed-off-by: Lars Persson --- drivers/net/ethernet/synopsys/dwc_eth_qos.c

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-29 Thread Eric Dumazet
On lun., 2016-02-29 at 07:03 -0800, Peter Hurley wrote: > The reason why Eric's change is so effective for Eric's workload is > that it fixes the problem where NET_RX keeps getting new network packets > so it keeps looping, servicing more NET_RX softirq. You have very little idea of what is

[PATCH] fsl/fman: Initialize fman->dev earlier

2016-02-29 Thread igal.liberman
From: Igal Liberman Currently, in a case of error, dev_err is using fman->dev before its initialization and "(NULL device *)" is printed. This patch fixes this issue. Signed-off-by: Igal Liberman ---

  1   2   >