Re: [RFC PATCH 4/5] mlx4: add support for fast rx drop bpf program

On Tue, Apr 05, 2016 at 05:15:20PM +0300, Or Gerlitz wrote: > On 4/4/2016 9:50 PM, Alexei Starovoitov wrote: > >On Mon, Apr 04, 2016 at 08:22:03AM -0700, Eric Dumazet wrote: > >>A single flow is able to use 40Gbit on those 40Gbit NIC, so there is not > >>a single 10GB trunk used for a given flow.

[net-next 02/14] i40e: Enable Geneve offload for FW API ver > 1.4 for XL710/X710 devices

From: Anjali Singhai Jain This patch enables the Capability for XL710/X710 devices with FW API version higher than 1.4 to do geneve Rx offload. Change-ID: I9a8f87772c48d7d67dc85e3701d2e0b845034c0b Signed-off-by: Anjali Singhai Jain

[net-next 01/14] i40e: remove redundant check on vsi->active_vlans

From: Colin King active_vlans is an unsigned long array, hence a null check on this array is superfluous and can be removed. Detected with static analysis by smatch: drivers/net/ethernet/intel/i40e/i40e_debugfs.c:386 i40e_dbg_dump_vsi_seid() warn: this array is

[net-next 10/14] i40e: Fix for supported link modes in 10GBaseT PHY's

From: Avinash Dayanand 100baseT/Full is now listed and supported link mode for 10GBaseT PHY. This is a fix to list all the supported link modes of 10GBaseT PHY. Change-ID: If2be3212ef0fef85fd5d6e4550c7783de2f915e9 Signed-off-by: Avinash Dayanand

[net-next 05/14] i40e: Add new device ID for X722

From: Catherine Sullivan The new device ID is 0x37D3 and it should follow the same flows and branding string as for 0x37D0. Change-ID: Ia5ad4a1910268c4666a3fd46a7afffbec55b4fc2 Signed-off-by: Catherine Sullivan Tested-by: Andrew

[net-next 11/14] i40e: Lower some message levels

From: Mitch Williams These conditions can happen any time VFs are enabled or disabled and are not really indicative of fatal problems unless they happen continuously. Lower the log level so that people don't get scared. Change-ID:

[net-next 09/14] i40evf: Fix get_rss_aq

From: Catherine Sullivan We were passing in the seed where we should just be passing false because we want the VSI table not the pf table. Change-ID: I9b633ab06eb59468087f0c0af8539857e99f9495 Signed-off-by: Catherine Sullivan

[net-next 08/14] i40e: Disable link polling

From: Shannon Nelson Periodic link polling was added when the link events were found not to be trustworthy. This was the case early on, but was likely because the link event mask was being used incorrectly. As this has been fixed in recent code, we can disable the

[net-next 04/14] i40evf: Fix VLAN features

From: Mitch Williams Users of ethtool were being given the mistaken impression that this driver was able to change its VLAN tagging features, and were disappointed that this was not actually the case. Implement ndo_fix_features method so that we can adjust these flags

[net-next 12/14] i40e: Request PHY media event at reset time

From: Shannon Nelson Add the Media Not Available flag to the link event mask. It seems that event comes first if you have a DA cable pulled out, but there's no follow-up event for Link Down; if you're not looking for MEDIA_NA you will get no event, even though there's

[net-next 07/14] i40evf: Add longer wait after remove module

From: Mitch Williams Upon module remove, wait a little longer after requesting a reset before checking to see if the firmware responded. This change prevents double resets when the firmware is busy. Change-ID: Ieedc988ee82fac1f32a074bf4d9e4dba426bfa58 Signed-off-by:

[net-next 03/14] i40e: Remove unused variable

From: Mitch Williams This variable is vestigial, a remnant of the primordial code from which this driver spawned. We can safely remove it. Change-ID: I24e0fe338e7c7c50d27dc5515564f33caefbb93a Signed-off-by: Mitch Williams Signed-off-by:

[net-next 14/14] i40e/i40evf: Fix TSO checksum pseudo-header adjustment

From: Alexander Duyck With IPv4 and IPv6 now using the same format for checksums based on the length of the frame we need to update the i40e and i40evf drivers so that they correctly account for lengths greater than or equal to 64K. With this patch the driver should now

[net-next 13/14] i40e/i40evf: Bump patch from 1.5.1 to 1.5.2

From: Avinash Dayanand Signed-off-by: Avinash Dayanand Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-

[net-next 06/14] i40e: Make VF resets more reliable

From: Mitch Williams Clear the VFLR bit immediately after triggering a reset instead of waiting until after cleanup is complete. Make sure to trigger a reset every time, not just if the PF is up. These changes fix a problem where VF resets would get lost by the PF,

[net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2016-04-05

This series contains updates to i40e and i40evf only. Colin Ian King cleaned up a redundant NULL check which was found by static analysis. Anjali enables geneve receive offload for XL710/X710 devices. Mitch cleans up unused variable in i40e_vc_get_vf_resources_msg(). Fixed the driver to

Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void

Hi Andrew, Andrew Lunn writes: >> -- port_stp_update: bridge layer function invoked when a given switch port >> STP >> +- port_stp_state: bridge layer function invoked when a given switch port STP > > port_stp_state_set might be a better name, to make it clear it is > setting

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

Hi Andrew, Andrew Lunn writes: >> mutex_lock(>smi_mutex); >> -ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); >> +if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state)) >> +netdev_warn(ds->ports[port], "cannot load

[PATCH net-next V3 13/16] net: fec: detect tx int lost

If a tx int is lost, no need to reset the fec. Just mark the event and call napi_schedule. Signed-off-by: Troy Kisky --- v3: no change --- drivers/net/ethernet/freescale/fec_main.c | 38 ++- 1 file changed, 37 insertions(+), 1

[PATCH net-next V3 09/16] net: fec: eliminate calls to fec_enet_get_prevdesc

Eliminating calls to fec_enet_get_prevdesc shrinks the code a little. Signed-off-by: Troy Kisky --- v3: Change commit message s/unsigned status/unsigned int status/ as requested --- drivers/net/ethernet/freescale/fec_main.c | 37 +--

[PATCH net-next V3 14/16] net: fec: create subroutine reset_tx_queue

Create subroutine reset_tx_queue to have one place to release any queued tx skbs. Signed-off-by: Troy Kisky --- v3: change commit message --- drivers/net/ethernet/freescale/fec_main.c | 50 +++ 1 file changed, 25 insertions(+), 25

[PATCH net-next V3 05/16] net: fec: reduce interrupts

By clearing the NAPI interrupts in the NAPI routine and not in the interrupt handler, we can reduce the number of interrupts. We also don't need any status variables as the registers are still valid. Also, notice that if budget pkts are received, the next call to fec_enet_rx_napi will now

[PATCH net-next V3 10/16] net: fec: move restart test for efficiency

Move restart test to earlier in fec_txq() which saves one comparison. Signed-off-by: Troy Kisky --- v3: change commit message --- drivers/net/ethernet/freescale/fec_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH net-next V3 11/16] net: fec: clear cbd_sc after transmission to help with debugging

When the tx queue is dumped, it is easier to see that this entry is idle if cbd_sc is cleared after transmission. Signed-off-by: Troy Kisky --- v3: change commit message --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH net-next V3 12/16] net: fec: dump all tx queues in fec_dump

Dump all tx queues, not just queue 0. Also, disable fec interrupts first. The interrupts will be reenabled in fec_restart. Signed-off-by: Troy Kisky --- v3: no change --- drivers/net/ethernet/freescale/fec_main.c | 40 +-- 1 file

[PATCH net-next V3 03/16] net: fec: return IRQ_HANDLED if fec_ptp_check_pps_event handled it

fec_ptp_check_pps_event will return 1 if FEC_T_TF_MASK caused an interrupt. Don't return IRQ_NONE in this case. Signed-off-by: Troy Kisky --- v3: New patch, came from feedback from another patch. --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file

[PATCH net-next V3 16/16] net: fec: don't set cbd_bufaddr unless no mapping error

Not assigning cbd_bufaddr on error will prevent trying to unmap the error in case the FEC is reset. Signed-off-by: Troy Kisky --- v3: no change --- drivers/net/ethernet/freescale/fec_main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[PATCH net-next V3 15/16] net: fec: call dma_unmap_single on mapped tx buffers at restart

Make sure any pending tx buffers are unmapped when the fec is restarted. Signed-off-by: Troy Kisky --- v3: no change --- drivers/net/ethernet/freescale/fec_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH net-next V3 07/16] net: fec: don't clear all rx queue bits when just one is being checked

FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since tx/rx interrupts are now cleared in the napi routine and not the interrupt, it is not needed here any longer.

[PATCH net-next V3 08/16] net: fec: set cbd_sc without relying on previous value

Relying on the wrap bit of cdb_sc to stay valid once initialized when the controller also writes to this byte seems undesirable since we can easily know what the value should be. Signed-off-by: Troy Kisky --- v3: change commit message ---

[PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

FEC_ENET_TS_TIMER is not checked in the interrupt routine so there is no need to enable it. Signed-off-by: Troy Kisky --- v3: New patch Frank Li said "TS_TIMER should never be triggered." when discussing another patch. --- drivers/net/ethernet/freescale/fec.h |

[PATCH net-next V3 06/16] net: fec: split off napi routine with 3 queues

If we only have 1 tx/rx queue, we need not check the other queues. Signed-off-by: Troy Kisky --- v3: rebase changes only, fep is no longer passed as a parameter to fec_rxq/fec_txq --- drivers/net/ethernet/freescale/fec_main.c | 39 +--

[PATCH net-next V3 00/16] net: fec: cleanup and fixes

V3 has 1 dropped patch "net: fec: print more debug info in fec_timeout" 2 new patches 0002-net-fec-remove-unused-interrupt-FEC_ENET_TS_TIMER.patch 0003-net-fec-return-IRQ_HANDLED-if-fec_ptp_check_pps_even.patch 1 combined patch 0004-net-fec-pass-rxq-txq-to-fec_enet_rx-tx_queue-instead.patch The

[PATCH net-next V3 04/16] net: fec: pass rxq/txq to fec_enet_rx/tx_queue instead of queue_id

The queue_id is the qid member of struct bufdesc_prop. Passing rxq/txq will allow the macro FEC_ENET_GET_QUQUE to be removed in the next patch. Signed-off-by: Troy Kisky Acked-by: Fugang Duan --- v3: add Acked-by combine with "net: fec: pass

[PATCH net-next V3 01/16] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set

Before queue 0 was always checked if any queue caused an interrupt. It is better to just mark queue 0 if queue 0 has caused an interrupt. Signed-off-by: Troy Kisky Acked-by: Fugang Duan --- v3: add Acked-by ---

Re: [PATCH net-next] net: dsa: document missing functions

Hi Andrew, Andrew Lunn writes: > On Tue, Apr 05, 2016 at 11:22:40AM -0400, Vivien Didelot wrote: >> Add description for the missing port_vlan_prepare, port_fdb_prepare, >> port_fdb_dump functions in the DSA documentation. >> >> Signed-off-by: Vivien Didelot

Re: [RFC PATCH 5/6] ppp: define reusable device creation functions

On Tue, 5 Apr 2016 23:14:56 +0200 Guillaume Nault wrote: > On Tue, Apr 05, 2016 at 08:28:32AM -0700, Stephen Hemminger wrote: > > On Tue, 5 Apr 2016 02:56:29 +0200 > > Guillaume Nault wrote: > > > > > Move PPP device initialisation and registration

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

On Mon, Apr 04, 2016 at 01:45:02PM -0700, Cong Wang wrote: > I see your point, but calling __ip6_datagram_connect() seems overkill > here, we don't need to update so many things in the pmtu update context, > at least IPv4 doesn't do that either. I don't think you have to do that. > > So why just

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

On Tue, Apr 05, 2016 at 12:36:40PM -0300, Tom Herbert wrote: > On Tue, Apr 5, 2016 at 12:07 PM, Edward Cree wrote: > > On 05/04/16 05:32, Herbert Xu wrote: > >> On Mon, Apr 04, 2016 at 09:26:55PM -0700, Alexander Duyck wrote: > >>> The question I would have is what are you

Re: [PATCH v3 -next] net/core/dev: Warn on a too-short GRO frame

From: Aaron Conole Date: Sat, 2 Apr 2016 15:26:43 -0400 > From: Aaron Conole > > When signaling that a GRO frame is ready to be processed, the network stack > correctly checks length and aborts processing when a frame is less than 14 > bytes. However,

Re: [PATCH v2] net: remove unimplemented RTNH_F_PERVASIVE

From: Quentin Armitage Date: Sat, 2 Apr 2016 17:51:28 +0100 > Linux 2.1.68 introduced RTNH_F_PERVASIVE, but it had no implementation > and couldn't be enabled since the required config parameter wasn't in > any Kconfig file (see commit d088dde7b196 ("ipv4: obsolete

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

From: Cong Wang Date: Mon, 4 Apr 2016 13:45:02 -0700 > On Sat, Apr 2, 2016 at 7:33 PM, Martin KaFai Lau wrote: >> One thing to note is that this patch uses the addresses from the sk >> instead of iph when updating sk->sk_dst_cache. It is basically the >>

Re: [net-next PATCH 2/2 v4] ibmvnic: enable RX checksum offload

From: Thomas Falcon Date: Fri, 1 Apr 2016 17:20:35 -0500 > Enable RX Checksum offload feature in the ibmvnic driver. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

On Tue, Apr 05, 2016 at 11:24:34AM -0400, Vivien Didelot wrote: > The switchdev design implies that a software error should not happen in > the commit phase since it must have been previously reported in the > prepare phase. If an hardware error occurs during the commit phase, > there is nothing

Re: [net-next PATCH 1/2 v4] ibmvnic: map L2/L3/L4 header descriptors to firmware

From: Thomas Falcon Date: Fri, 1 Apr 2016 17:20:34 -0500 > Allow the VNIC driver to provide descriptors containing > L2/L3/L4 headers to firmware. This feature is needed > for greater hardware compatibility and enablement of checksum > and TCP offloading features.

Re: [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice

From: Thadeu Lima de Souza Cascardo Date: Fri, 1 Apr 2016 17:17:50 -0300 > When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set > before ip6_tnl_create2 is called. When register_netdevice is called, there > is no linkinfo attribute in the NEWLINK message

Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void

> -- port_stp_update: bridge layer function invoked when a given switch port STP > +- port_stp_state: bridge layer function invoked when a given switch port STP Hi Vivien port_stp_state_set might be a better name, to make it clear it is setting the state, not getting the current state, etc. Most

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

From: Edward Cree Date: Tue, 5 Apr 2016 16:07:49 +0100 > On the gripping hand, I feel like GRO+TSO is the wrong model for > speeding up forwarding/routing workloads. Instead we should be > looking into having lists of SKBs traverse the stack together, > splitting the list

Re: [PATCH net-next] net: dsa: document missing functions

On Tue, Apr 05, 2016 at 11:22:40AM -0400, Vivien Didelot wrote: > Add description for the missing port_vlan_prepare, port_fdb_prepare, > port_fdb_dump functions in the DSA documentation. > > Signed-off-by: Vivien Didelot Hi Vivien A few English

Re: [RESEND PATCH net-next v2 0/3] bcmgenet cleanups

From: Petri Gynther Date: Tue, 5 Apr 2016 13:59:58 -0700 > Three cleanup patches for bcmgenet. Series applied, thanks.

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 07:29 PM, David Miller wrote: > From: Daniel Borkmann > Date: Tue, 05 Apr 2016 23:53:52 +0200 > >> On 04/05/2016 11:36 PM, Bastien Philbert wrote: >>> This fixes error handling for the switch statement case >>> SCTP_CMD_SEND_PKT by making the error value of

Re: [net 0/3][pull request] Intel Wired LAN Driver Updates 2016-04-05

From: Jeff Kirsher Date: Tue, 5 Apr 2016 15:30:48 -0700 > This series contains updates to i40e and e1000. Pulled, thanks Jeff.

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

From: Daniel Borkmann Date: Tue, 05 Apr 2016 23:53:52 +0200 > On 04/05/2016 11:36 PM, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal the variable

Re: [RESEND PATCH net-next v2 3/3] net: bcmgenet: cleanup for dmadesc_set()

2016-04-05 14:00 GMT-07:00 Petri Gynther : > dmadesc_set() is used for setting the Tx buffer DMA address, length, > and status bits on a Tx ring descriptor when a frame is being Tx'ed. > > Always set the Tx buffer DMA address first, before updating the length > and status

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 06:12 PM, Marcelo Ricardo Leitner wrote: > On Tue, Apr 05, 2016 at 05:36:41PM -0400, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal the variable error due

[net 2/3] e1000: Do not overestimate descriptor counts in Tx pre-check

From: Alexander Duyck The current code path is capable of grossly overestimating the number of descriptors needed to transmit a new frame. This specifically occurs if the skb contains a number of 4K pages. The issue is that the logic for determining the descriptors needed

[net 1/3] i40e: fix errant PCIe bandwidth message

From: Jesse Brandeburg There was an error introduced with commit 3fced535079a ("i40e: X722 is on the IOSF bus and does not report the PCI bus info"), where code was added but the enabling flag is never set. CC: Anjali Singhai Jain CC:

[net 3/3] e1000: Double Tx descriptors needed check for 82544

From: Alexander Duyck The 82544 has code that adds one additional descriptor per data buffer. However we weren't taking that into account when determining the descriptors needed for the next transmit at the end of the xmit_frame path. This change takes that into account by

[net 0/3][pull request] Intel Wired LAN Driver Updates 2016-04-05

This series contains updates to i40e and e1000. Jesse fixes an issue where code was added by a previous commit but the flag to enable it was never set. Alex fixes the e1000 driver from grossly overestimated the descriptors needed to transmit a frame. The following are changes since commit

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On Tue, Apr 05, 2016 at 05:36:41PM -0400, Bastien Philbert wrote: > This fixes error handling for the switch statement case > SCTP_CMD_SEND_PKT by making the error value of the call > to sctp_packet_transmit equal the variable error due to > this function being able to fail with a error code. In >

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

On Tue, Apr 05, 2016 at 11:29:05AM +0200, Jesper Dangaard Brouer wrote: > > > > Of course, there are other pieces to accelerate: > > 12.71% ksoftirqd/1[mlx4_en] [k] mlx4_en_alloc_frags > > 6.87% ksoftirqd/1[mlx4_en] [k] mlx4_en_free_frag > > 4.20% ksoftirqd/1

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 05:53 PM, Daniel Borkmann wrote: > On 04/05/2016 11:36 PM, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal the variable error due to >> this function being

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 04/05/2016 11:36 PM, Bastien Philbert wrote: This fixes error handling for the switch statement case SCTP_CMD_SEND_PKT by making the error value of the call to sctp_packet_transmit equal the variable error due to this function being able to fail with a error code. In What actual issue have

[PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

This fixes error handling for the switch statement case SCTP_CMD_SEND_PKT by making the error value of the call to sctp_packet_transmit equal the variable error due to this function being able to fail with a error code. In addition allow the call to sctp_ootb_pkt_free afterwards to free up the no

Re: [PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply

On 05.04.2016 23:27, Bastien Philbert wrote: This adds protection from concurrenct users in the function icmpv6_echo_reply around the call to the function __in6_dev_get by locking/unlocking around this call with calls to the functions rtnl_lock and rtnl_unlock to protect against concurrent users

[PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply

This adds protection from concurrenct users in the function icmpv6_echo_reply around the call to the function __in6_dev_get by locking/unlocking around this call with calls to the functions rtnl_lock and rtnl_unlock to protect against concurrent users when calling this function in

Re: [RFC PATCH 6/6] ppp: add rtnetlink device creation support

On Tue, Apr 05, 2016 at 07:18:14PM +0200, walter harms wrote: > > > Am 05.04.2016 02:56, schrieb Guillaume Nault: > > @@ -1043,12 +1048,39 @@ static int ppp_dev_configure(struct net *src_net, > > struct net_device *dev, > > const struct ppp_config *conf) > > { > >

Re: [PATCH net-next 05/10] bnxt_en: Add get_eee() and set_eee() ethtool support.

On Tue, 2016-04-05 at 03:36 -0700, Michael Chan wrote: > On Tue, Apr 5, 2016 at 3:07 AM, Ben Hutchings wrote: [...] > > > +static int bnxt_get_eee(struct net_device *dev, struct ethtool_eee > > > *edata) > > > +{ > > > + struct bnxt *bp = netdev_priv(dev); > > > + > > >

Re: [RFC PATCH 5/6] ppp: define reusable device creation functions

On Tue, Apr 05, 2016 at 08:28:32AM -0700, Stephen Hemminger wrote: > On Tue, 5 Apr 2016 02:56:29 +0200 > Guillaume Nault wrote: > > > Move PPP device initialisation and registration out of > > ppp_create_interface(). > > This prepares code for device registration with

Re: [RFC PATCH 0/6] ppp: add rtnetlink support

.On Tue, Apr 05, 2016 at 08:27:45AM -0700, Stephen Hemminger wrote: > On Tue, 5 Apr 2016 02:56:17 +0200 > Guillaume Nault wrote: > > > The rtnetlink handlers implemented in this series are minimal, and can > > only replace the PPPIOCNEWUNIT ioctl. The rest of PPP ioctls

[RESEND PATCH net-next v2 3/3] net: bcmgenet: cleanup for dmadesc_set()

dmadesc_set() is used for setting the Tx buffer DMA address, length, and status bits on a Tx ring descriptor when a frame is being Tx'ed. Always set the Tx buffer DMA address first, before updating the length and status bits, i.e. giving the Tx descriptor to the hardware. The reason this is a

[RESEND PATCH net-next v2 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

1. Readability: Move nr_frags assignment a few lines down in order to bundle index -> ring -> txq calculations together. 2. Readability: Add parentheses around nr_frags + 1. 3. Minor fix: Stop the Tx queue and throw the error message only if the Tx queue hasn't already been stopped.

[RESEND PATCH net-next v2 2/3] net: bcmgenet: cleanup for bcmgenet_xmit_frag()

Add frag_size = skb_frag_size(frag) and use it when needed. Signed-off-by: Petri Gynther Acked-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[RESEND PATCH net-next v2 0/3] bcmgenet cleanups

Three cleanup patches for bcmgenet. Petri Gynther (3): net: bcmgenet: cleanup for bcmgenet_xmit() net: bcmgenet: cleanup for bcmgenet_xmit_frag() net: bcmgenet: cleanup for dmadesc_set() drivers/net/ethernet/broadcom/genet/bcmgenet.c | 27 -- 1 file changed, 17

[PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()"

This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7. Direct callers of __netpoll_setup() depend on it to set np->dev, so we can't simply move that assignment up to netpoll_stup(). Reported-by: Bart Van Assche Signed-off-by: Bjorn Helgaas

[PATCH net] bridge, netem: mark mailing lists as moderated

I moderate these (lightly loaded) lists to block spam. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 67d99dd..8355536 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH net-next v2 3/3] tipc: reduce transmission rate of reset messages when link is down

When a link is down, it will continuously try to re-establish contact with the peer by sending out a RESET or an ACTIVATE message at each timeout interval. The default value for this interval is currently 375 ms. This is wasteful, and may become a problem in very large clusters with dozens or

[PATCH net-next v2 1/3] tipc: eliminate buffer leak in bearer layer

When enabling a bearer we create a 'neigbor discoverer' instance by calling the function tipc_disc_create() before the bearer is actually registered in the list of enabled bearers. Because of this, the very first discovery broadcast message, created by the mentioned function, is lost, since it

[PATCH net-next v2 0/3] tipc: some small fixes

When running TIPC in large clusters we experience behavior that may potentially become problematic in the future. This series picks some low-hanging fruit in this regard, and also fixes a couple of other minor issues. v2: Corrected typos in commit #3, as per feedback from S. Shtylyov Jon Maloy

[PATCH net-next v2 2/3] tipc: stricter filtering of packets in bearer layer

Resetting a bearer/interface, with the consequence of resetting all its pertaining links, is not an atomic action. This becomes particularly evident in very large clusters, where a lot of traffic may happen on the remaining links while we are busy shutting them down. In extreme cases, we may even

[PATCH net-next] bpf, verifier: further improve search pruning

The verifier needs to go through every path of the program in order to check that it terminates safely, which can be quite a lot of instructions that need to be processed f.e. in cases with more branchy programs. With search pruning from f1bca824dabb ("bpf: add search pruning optimization to

Re: [PATCH net-next v2 0/3] udp: support SO_PEEK_OFF

From: Willem de Bruijn Date: Tue, 5 Apr 2016 12:41:13 -0400 > From: Willem de Bruijn > > Support peeking at a non-zero offset for UDP sockets. Match the > existing behavior on Unix datagram sockets. > > 1/3 makes the sk_peek_offset

Re: [net-next 00/18][pull request] 40GbE Intel Wired LAN Driver Updates 2016-04-05

From: Jeff Kirsher Date: Tue, 5 Apr 2016 13:17:17 -0700 > This series contains updates to i40e and i40evf only. This looks fine, pulled, thanks Jeff.

[net-next 09/18] i40e: Fix up return code

From: Jesse Brandeburg The i40e_common.c typically uses i40e_status as a return code, but got missed this one case. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 11/18] i40e: Assure that adminq is alive in debug mode

From: Shannon Nelson When dropping into debug mode in a failed probe, make sure that the AdminQ is left alive for possible hand debug of driver and firmware states. Move the mutex_init calls earlier in probe so that if init fails, the admin queue interface is still

[net-next 04/18] i40e/i40evf: Fix handling of boolean logic in polling routines

From: Alexander Duyck In the polling routines for i40e and i40evf we were using bitwise operators to avoid the side effects of the logical operators, specifically the fact that if the first case is true with "||" we skip the second case, or if it is false with "&&" we skip

[net-next 03/18] i40evf: remove dead code

From: Alan Cox The only error case is when the malloc fails, in which case the clean up loop does nothing at all, so remove it Signed-off-by: Alan Cox Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 13/18] i40e: Notify VFs of all resets

From: Mitch Williams Notify VFs in the reset interrupt handler, instead of the actual reset initiation code. This allows the VFs to get properly notified for all resets, including resets initiated by different PFs on the same physical device. Signed-off-by: Mitch

[net-next 12/18] i40e: Remove timer and task only if created

From: Shannon Nelson In some error scenarios, we may find ourselves trying to remove a non-existent timer or worktask. This causes the kernel some bit of consternation, so don't do it. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers

[net-next 06/18] i40e/i40evf: Fix casting in transmit code

From: Jesse Brandeburg Simple cast to fix a sparse warning. Fixes: commit 5453205cd097 ("i40e/i40evf: Enable support for SKB_GSO_UDP_TUNNEL_CSUM") Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers

[net-next 17/18] i40e: Change comment to reflect correct function name

From: Mitch Williams Minor correction in the comment to reflect the correct function name Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 15/18] i40e: Change unknown event error msg to ignore message

From: Shannon Nelson There's no real error in an unknown event from the Firmware, we're just posting a useful FYI notice, so this patch simply removes the "Error" word. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers

[net-next 08/18] i40e: Save off VSI resource count when updating VSI

From: Kevin Scott When updating a VSI, save off the number of allocated and unallocated VSIs as we do when adding a VSI. Signed-off-by: Kevin Scott Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 05/18] i40e/i40evf: Add support for bulk free in Tx cleanup

From: Alexander Duyck This patch enables bulk Tx clean for skbs. In order to enable it we need to pass the napi_budget value as that is used to determine if we are truly running in NAPI mode or if we are simply calling the routine from netpoll with a budget of 0. In order

[net-next 02/18] i40e/i40evf: Allow up to 12K bytes of data per Tx descriptor instead of 8K

From: Alexander Duyck >From what I can tell the practical limitation on the size of the Tx data buffer is the fact that the Tx descriptor is limited to 14 bits. As such we cannot use 16K as is typically used on the other Intel drivers. However artificially limiting

[net-next 07/18] i40e/i40evf: Remove I40E_MAX_USER_PRIORITY define

From: Catherine Sullivan This patch removes the duplicate definition of I40E_MAX_USER_PRIORITY in i40e.h that is not needed. Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 16/18] i40evf: Add additional check for reset

From: Mitch Williams If the driver happens to read a register during the time in which the device is undergoing reset, it will receive a value of 0xdeadbeef instead of a valid value. Unfortunately, the driver may misinterpret this as a valid value, especially if it's

[net-next 00/18][pull request] 40GbE Intel Wired LAN Driver Updates 2016-04-05

This series contains updates to i40e and i40evf only. Stefan converts dev_close() to ndo_stop() for ethtool offline self test, since dev_close() causes IFF_UP to be cleared which will remove the interface routes and addresses. Alex bumps up the size of the transmit data buffer to 12K rather than

[net-next 10/18] i40e: Remove MSIx only if created

From: Shannon Nelson When cleaning up the interrupt handling, clean up the IRQs only if we actually got them set up. There are a couple of error recovery paths that were violating this and causing the kernel a bit of indigestion. Signed-off-by: Shannon Nelson

[net-next 18/18] i40e/i40evf: Bump patch from 1.4.25 to 1.5.1

From: Catherine Sullivan Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--

  1   2   3   >