Re: off-by-one in DecodeQ931

On Mon, Apr 25, 2016 at 11:29 AM, Florian Westphal wrote: > -> sz (size_t) will underflow here > > I'd suggest to change the if (sz < 1) to if (sz < 2) to > resolve this, the while loop below has to be taken anyway. Thanks, Florian! Updated patch below: Signed-off-by: Toby

[REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

In testing with HiKey, we found that since commit 3f30b158eba5c60 (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of noise during network transfers: [ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988 [ 239.037310] asix

Re: [PATCH net-next] tcp: guarantee forward progress in tcp_sendmsg()

On Tue, May 3, 2016 at 12:49 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Under high rx pressure, it is possible tcp_sendmsg() never has a > chance to allocate an skb and loop forever as sk_flush_backlog() > would always return true. > > Fix this

[PATCH net-next] tcp: guarantee forward progress in tcp_sendmsg()

From: Eric Dumazet Under high rx pressure, it is possible tcp_sendmsg() never has a chance to allocate an skb and loop forever as sk_flush_backlog() would always return true. Fix this by calling sk_flush_backlog() only if one skb had been allocated and filled before last

[PATCH net-next v2] ipv6: add new struct ipcm6_cookie

From: Wei Wang In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local variables like hlimits, tclass, opt and dontfrag and pass them to corresponding functions like ip6_make_skb, ip6_append_data and xxx_push_pending_frames. This is not a good practice and

Re: [PATCHv4] netem: Segment GSO packets on enqueue

From: Neil Horman Date: Mon, 2 May 2016 12:20:15 -0400 > This was recently reported to me, and reproduced on the latest net kernel, > when attempting to run netperf from a host that had a netem qdisc attached > to the egress interface: ... > The problem occurs because

Re: [PATCH net-next] net: relax expensive skb_unclone() in iptunnel_handle_offloads()

From: Eric Dumazet Date: Sat, 30 Apr 2016 10:19:29 -0700 > From: Eric Dumazet > > Locally generated TCP GSO packets having to go through a GRE/SIT/IPIP > tunnel have to go through an expensive skb_unclone() > > Reallocating skb->head is a lot of

Re: pull request [net]: batman-adv 20160430

From: Antonio Quartulli Date: Sun, 1 May 2016 01:05:59 +0800 > this is another pull request intended for net. > > I know that I sent another batch a few days ago, but after having gone > through my queue I thought that merging these last 4 patches would still > be worth it

Re: [PATCH net] vlan: Propagate MAC address changes properly

From: Mike Manning Date: Sat, 30 Apr 2016 11:32:37 +0100 > The MAC address of the physical interface is only copied to the VLAN > when it is first created, resulting in an inconsistency after MAC > address changes of only newly created VLANs having an up-to-date MAC. > >

linux-next: manual merge of the net-next tree with Linus' tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ip_gre.c between commits: 2090714e1d6e ("gre: build header correctly for collect metadata tunnels") b7f8fe251e46 ("gre: do not pull header in ICMP error processing") from Linus' tree and commit:

Re: [PATCH] vhost_net: stop polling socket during rx processing

On 04/28/2016 02:19 PM, Jason Wang wrote: > On 04/27/2016 07:28 PM, Michael S. Tsirkin wrote: >> > On Tue, Apr 26, 2016 at 03:35:53AM -0400, Jason Wang wrote: >>> >> We don't stop polling socket during rx processing, this will lead >>> >> unnecessary wakeups from under layer net devices (E.g >>>

Re: [PATCH next] netdevice: shrink size of struct netdev_queue

From: Florian Westphal Date: Tue, 3 May 2016 03:29:09 +0200 > - trans_timeout is incremented when tx queue timed out (tx watchdog). > - tx_maxrate is set via sysfs > > Moving tx_maxrate to read-mostly part shrinks the struct by 64 bytes. > While at it, also move trans_timeout

Re: [PATCH net-next] ipv6: add new struct ipcm6_cookie

From: David Miller Date: Mon, 02 May 2016 22:39:45 -0400 (EDT) > From: Wei Wang > Date: Fri, 29 Apr 2016 17:31:12 -0700 > >> From: Wei Wang >> >> In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local >> variables

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

Thanks a lot. I feel it excited to contribute to the development of kernel. I’ll do better next time. > 在 2016年5月3日，06:19，Stephen Hemminger 写道： > > On Thu, 28 Apr 2016 15:50:47 +0100 > James Chapman wrote: > >> Yes, that looks like the

Re: [PATCH net-next] ipv6: add new struct ipcm6_cookie

From: Wei Wang Date: Fri, 29 Apr 2016 17:31:12 -0700 > From: Wei Wang > > In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local > variables like hlimits, tclass, opt and dontfrag and pass them to > corresponding > functions like

Re: [PATCH net-next v3 0/4] bridge: per-vlan stats

From: Nikolay Aleksandrov Date: Sat, 30 Apr 2016 10:25:25 +0200 > This set adds support for bridge per-vlan statistics. This looks a lot better, series applied, thanks!

Re: [PATCH next-next 0/7] net: Cleanup IPv6 ip tunnels

On Fri, Apr 29, 2016 at 5:12 PM, Tom Herbert wrote: > The IPv6 tunnel code is very different from IPv4 code. There is a lot > of redundancy with the IPv4 code, particularly in the GRE tunneling. > > This patch set cleans up the tunnel code to make the IPv6 code look > more

Re: [PATCH next] netdevice: shrink size of struct netdev_queue

On Tue, 2016-05-03 at 03:29 +0200, Florian Westphal wrote: > - trans_timeout is incremented when tx queue timed out (tx watchdog). > - tx_maxrate is set via sysfs > > Moving tx_maxrate to read-mostly part shrinks the struct by 64 bytes. > While at it, also move trans_timeout (it is out-of-place

[PATCH net] net: macb: Probe MDIO bus before registering netdev

The current sequence makes us register for a network device prior to registering and probing the MDIO bus which could lead to some unwanted consequences, like a thread of execution calling into ndo_open before register_netdev() returns, while the MDIO bus is not ready yet. Rework the sequence to

[PATCH next] netdevice: shrink size of struct netdev_queue

- trans_timeout is incremented when tx queue timed out (tx watchdog). - tx_maxrate is set via sysfs Moving tx_maxrate to read-mostly part shrinks the struct by 64 bytes. While at it, also move trans_timeout (it is out-of-place in the 'write-mostly' part). Signed-off-by: Florian Westphal

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

On Mon, May 2, 2016 at 4:18 PM, Tom Herbert wrote: > On Mon, May 2, 2016 at 3:54 PM, Alexander Duyck > wrote: >> On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: >>> On Apr 29, 2016, at 8:46 PM, Alexander Duyck

Re: [PATCH net-next] fq_codel: add batch ability to fq_codel_drop()

I have duplicated the issue on my own hardware. I would like to explore also upping the codel count in this scenario at some point, but: Acked-by: Dave Taht

Re: [PATCH net-next 0/4] net: hns: update DT properties according to Rob's comments

Hi David, Thanks for applying the patches. The series which i reposted is my misoperation. Please ignore them. Thanks, Yisen 在 2016/4/30 1:39, David Miller 写道: > From: Yisen Zhuang > Date: Thu, 28 Apr 2016 15:09:00 +0800 > >> There are some inappropriate properties

Re: [iproute2 1/1] man: tc-ife.8: man page for ife action

On 16-05-02 06:10 PM, Stephen Hemminger wrote: On Sat, 30 Apr 2016 06:58:04 -0400 Jamal Hadi Salim wrote: From: Lucas Bates Signed-off-by: Lucas Bates Signed-off-by: Jamal Hadi Salim Still waiting for a you

Re: [PATCH next-next 0/7] net: Cleanup IPv6 ip tunnels

From: Tom Herbert Date: Fri, 29 Apr 2016 17:12:14 -0700 > The IPv6 tunnel code is very different from IPv4 code. There is a lot > of redundancy with the IPv4 code, particularly in the GRE tunneling. > > This patch set cleans up the tunnel code to make the IPv6 code look >

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

On Mon, May 2, 2016 at 3:54 PM, Alexander Duyck wrote: > On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: >> >>> On Apr 29, 2016, at 8:46 PM, Alexander Duyck >>> wrote: >>> >>> On Fri, Apr 29, 2016 at 3:28 PM, Jarno

Re: [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd

Hi Hannes, >>> this patch series introduces a layer for IPv6 neighbour discovery. At first >>> it introduce the "ndisc_ops" to run a different handling for recv/send of >>> NA/NS messages. The use case for such ndisc operation is RFC 6775 [0]. >>> Which describes a different neighbour discovery

Re: [PATCH 0/2] sctp: Add GSO support

From: Marcelo Ricardo Leitner Date: Fri, 29 Apr 2016 18:33:31 -0300 > This patchset adds sctp GSO support. > > Performance tests indicates that increases throughput by 10% if using > bigger chunk sizes, specially if bigger than MTU. For small chunks, it > doesn't help

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: > >> On Apr 29, 2016, at 8:46 PM, Alexander Duyck >> wrote: >> >> On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >>> UDP tunnel segmentation code relies on the inner offsets

Performance suggestions for bridging module?

Hello! I have a network emulator module that acts a lot like an ethernet bridge. It is implemented roughly like this: Hook into the rx logic and steal packets in the rx-all logic, similar to how sniffers work. Then, it puts the packet onto a queue for transmit. A kernel thread services this

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

On Thu, 28 Apr 2016 15:50:47 +0100 James Chapman wrote: > Yes, that looks like the problem. > > The comments in l2tp.h which indicate that the csum attributes are u8 > values are wrong. Code in net/l2tp/l2tp_netlink.c accesses these > attributes using nla_get_flag(). > >

Re: [PATCH iproute2] tc: add bash-completion function

On Fri, 29 Apr 2016 10:27:11 +0200 Quentin Monnet wrote: > Add function for command completion for tc in bash, and update Makefile > to install it: > > - Under /usr/share/bash-completion/completions/ (default). > - Or under /etc/bash_completions.d/, which is the old

Re: [iproute2 1/1] man: tc-ife.8: man page for ife action

On Sat, 30 Apr 2016 06:58:04 -0400 Jamal Hadi Salim wrote: > From: Lucas Bates > > Signed-off-by: Lucas Bates > Signed-off-by: Jamal Hadi Salim Still waiting for a you to respond to my earlier suggestions about

Re: [Bug 117521] New: BUG: unable to handle kernel paging request at 000001a400015ff4

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). Thanks. It's probably a TIPC issue. On Mon, 02 May 2016 16:44:18 + bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=117521 > > Bug ID:

RE: [Intel-wired-lan] NULL dereference on v4.1.x while enabling VF

> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of William Dauchy > Sent: Monday, May 02, 2016 1:26 PM > To: NETDEV ; intel-wired-...@lists.osuosl.org > Cc: Alex Duyck > Subject:

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

> On Apr 29, 2016, at 8:46 PM, Alexander Duyck > wrote: > > On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >> UDP tunnel segmentation code relies on the inner offsets being set for >> an UDP tunnel GSO packet. The inner *_complete()

Re: [PATCH net-next 1/2] net: SOCKWQ_ASYNC_NOSPACE optimizations

On Mon, 2016-05-02 at 16:31 -0400, David Miller wrote: > From: Eric Dumazet > Date: Mon, 02 May 2016 13:23:27 -0700 > > > It looks like net/sunrpc/xprtsock.c should set SOCK_FASYNC > > even if it is not actually using fasync_list > > > > Could you try this quick hack to

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

> On Apr 29, 2016, at 6:42 PM, Tom Herbert wrote: > > On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >> UDP tunnel segmentation code relies on the inner offsets being set for >> an UDP tunnel GSO packet. The inner *_complete() functions will set

Re: [PATCH v2 0/3] drivers: net: xgene: fix: Get channel number from device binding

From: Iyappan Subramanian Date: Fri, 29 Apr 2016 11:10:12 -0700 > This patch set adds 'channel' property to get ethernet to CPU channel number, > thus decoupling the Linux driver from static resource selection. > > v2: Address review comments from v1 > - removed irq

Re: [PATCH net-next 1/2] net: SOCKWQ_ASYNC_NOSPACE optimizations

Mon, May 02, 2016 at 10:23:27PM CEST, eric.duma...@gmail.com wrote: >On Mon, 2016-05-02 at 21:12 +0200, Jiri Pirko wrote: >> Mon, May 02, 2016 at 06:22:18PM CEST, eric.duma...@gmail.com wrote: >> >On Mon, 2016-05-02 at 18:16 +0200, Jiri Pirko wrote: >> >> Mon, Apr 25, 2016 at 07:39:32PM CEST,

[PATCH net v2 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete().

The setting of the UDP tunnel GSO type is already performed by udp[46]_gro_complete(). Signed-off-by: Jarno Rajahalme --- drivers/net/geneve.c | 2 -- drivers/net/vxlan.c | 2 -- include/net/udp_tunnel.h | 9 - net/ipv4/fou.c | 2 -- 4 files changed, 15

[PATCH net v2 2/2] udp_offload: Set encapsulation before inner completes.

UDP tunnel segmentation code relies on the inner offsets being set for an UDP tunnel GSO packet, but the inner *_complete() functions will set the inner offsets only if 'encapsulation' is set before calling them. Currently, udp_gro_complete() sets 'encapsulation' only after the inner *_complete()

Re: [PATCH net-next 1/2] net: SOCKWQ_ASYNC_NOSPACE optimizations

From: Eric Dumazet Date: Mon, 02 May 2016 13:23:27 -0700 > It looks like net/sunrpc/xprtsock.c should set SOCK_FASYNC > even if it is not actually using fasync_list > > Could you try this quick hack to check if this is the right way ? Indeed, it tests the ASYNC bit

NULL dereference on v4.1.x while enabling VF

Hello, I am getting a NULL dereference on v4.1.x while enabling VF on a ixgbe ( Intel Corporation 82599ES 10-Gigabit) card during boot. It seems to be related to a race since I don't have the issue if I test it a few seconds after boot. I had the same issue while testing on v4.5.x What can I do

Re: [PATCH net-next 1/2] net: SOCKWQ_ASYNC_NOSPACE optimizations

On Mon, 2016-05-02 at 21:12 +0200, Jiri Pirko wrote: > Mon, May 02, 2016 at 06:22:18PM CEST, eric.duma...@gmail.com wrote: > >On Mon, 2016-05-02 at 18:16 +0200, Jiri Pirko wrote: > >> Mon, Apr 25, 2016 at 07:39:32PM CEST, eduma...@google.com wrote: > >> >SOCKWQ_ASYNC_NOSPACE is tested in

Re: [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd

On 02.05.2016 19:25, Marcel Holtmann wrote: > Hi Dave, > >> this patch series introduces a layer for IPv6 neighbour discovery. At first >> it introduce the "ndisc_ops" to run a different handling for recv/send of >> NA/NS messages. The use case for such ndisc operation is RFC 6775 [0]. >> Which

Re: [PATCH next-next 0/7] net: Cleanup IPv6 ip tunnels

On Mon, May 2, 2016 at 12:32 PM, Tom Herbert wrote: > On Fri, Apr 29, 2016 at 6:00 PM, Alexander Duyck > wrote: >> On Fri, Apr 29, 2016 at 5:12 PM, Tom Herbert wrote: >>> The IPv6 tunnel code is very different from IPv4

Re: [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions

On 20.04.2016 10:19, Alexander Aring wrote: > This patch exports some neighbour discovery functions which can be used > by 6lowpan neighbour discovery ops functionality then. > > Cc: David S. Miller > Cc: Alexey Kuznetsov > Cc: James Morris

Re: [PATCH v2] net: macb: do not scan PHYs manually

On Mon, May 02, 2016 at 12:08:50PM -0700, Florian Fainelli wrote: > On 02/05/16 11:36, Josh Cartwright wrote: > > On Fri, Apr 29, 2016 at 02:40:53PM +0200, Nicolas Ferre wrote: > > [..] > >>> static int macb_mii_init(struct macb *bp) > >>> { > >>> struct macb_platform_data *pdata; > >>>

Re: [PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space

On 20.04.2016 10:19, Alexander Aring wrote: > This patch makes the address length as argument for the > ndisc_opt_addr_space function. This is necessary to handle addresses > which don't use dev->addr_len as address length. Would it make sense for patch 4, 5 and 6 to add the operation to

Re: [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

On 20.04.2016 10:19, Alexander Aring wrote: > This patch introduces neighbour discovery ops callback structure. The > structure contains at first receive and transmit handling for NS/NA and > userspace option field functionality. > > These callback offers 6lowpan different handling, such as

Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le

On Mon, 2 May 2016, Johan Hedberg wrote: > Hi, > > On Fri, Apr 29, 2016, Julia Lawall wrote: > > --- a/net/bluetooth/mgmt.c > > +++ b/net/bluetooth/mgmt.c > > @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct > > hci_dev *hdev, void *data, > > conn =

Re: [PATCH next-next 0/7] net: Cleanup IPv6 ip tunnels

On Fri, Apr 29, 2016 at 6:00 PM, Alexander Duyck wrote: > On Fri, Apr 29, 2016 at 5:12 PM, Tom Herbert wrote: >> The IPv6 tunnel code is very different from IPv4 code. There is a lot >> of redundancy with the IPv4 code, particularly in the GRE

Re: [PATCH net-next 1/2] net: SOCKWQ_ASYNC_NOSPACE optimizations

Mon, May 02, 2016 at 06:22:18PM CEST, eric.duma...@gmail.com wrote: >On Mon, 2016-05-02 at 18:16 +0200, Jiri Pirko wrote: >> Mon, Apr 25, 2016 at 07:39:32PM CEST, eduma...@google.com wrote: >> >SOCKWQ_ASYNC_NOSPACE is tested in sock_wake_async() >> >so that a SIGIO signal is sent when needed. >> >

Re: [PATCH v2] net: macb: do not scan PHYs manually

On 02/05/16 11:36, Josh Cartwright wrote: > On Fri, Apr 29, 2016 at 02:40:53PM +0200, Nicolas Ferre wrote: > [..] >>> static int macb_mii_init(struct macb *bp) >>> { >>> struct macb_platform_data *pdata; >>> struct device_node *np; >>> - int err = -ENXIO, i; >>> + int err = -ENXIO;

Re: [PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac

On 20.04.2016 10:19, Alexander Aring wrote: > This patch adds the autoconfiguration if a valid 802.15.4 short address > is available for 802.15.4 6LoWPAN interfaces. > > Cc: David S. Miller > Cc: Alexey Kuznetsov > Cc: James Morris

Re: [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request

On 20.04.2016 10:19, Alexander Aring wrote: > Since we use exported function from ipv6 kernel module we don't need to > request the module anymore to have ipv6 functionality. > > Signed-off-by: Alexander Aring Acked-by: Hannes Frederic Sowa

Re: [PATCHv2 bluetooth-next 01/10] 6lowpan: add private neighbour data

Hello, On 20.04.2016 10:19, Alexander Aring wrote: > This patch will introduce a 6lowpan neighbour private data. Like the > interface private data we handle private data for generic 6lowpan and > for link-layer specific 6lowpan. > > The current first use case if to save the short address for a

Re: [PATCH v2] net: macb: do not scan PHYs manually

On Fri, Apr 29, 2016 at 02:40:53PM +0200, Nicolas Ferre wrote: [..] > > static int macb_mii_init(struct macb *bp) > > { > > struct macb_platform_data *pdata; > > struct device_node *np; > > - int err = -ENXIO, i; > > + int err = -ENXIO; > > > > /* Enable management port */ > >

[PATCH net v2 1/2] RDS:TCP: Synchronize rds_tcp_accept_one with rds_send_xmit when resetting t_sock

There is a race condition between rds_send_xmit -> rds_tcp_xmit and the code that deals with resolution of duelling syns added by commit 241b271952eb ("RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()"). Specifically, we may end up derefencing a null pointer in

[PATCH net v2 0/2] RDS: TCP: sychronization during connection startup

This patch series ensures that the passive (accept) side of the TCP connection used for RDS-TCP is correctly synchronized with any concurrent active (connect) attempts for a given pair of peers. Patch 1 in the series makes sure that the t_sock in struct rds_tcp_connection is only reset after any

[PATCH net v2 2/2] RDS: TCP: Synchronize accept() and connect() paths on t_conn_lock.

An arbitration scheme for duelling SYNs is implemented as part of commit 241b271952eb ("RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()") which ensures that both nodes involved will arrive at the same arbitration decision. However, this needs to be synchronized

Re: [PATCH net 2/2] RDS: TCP: Synchrnozize accept() and connect() paths on t_conn_lock.

On 5/2/2016 9:43 AM, Sowmini Varadhan wrote: On (05/02/16 09:33), Santosh Shilimkar wrote: + mutex_unlock(>t_conn_lock); Just wondering whether the spin_lock() would better here considering entry into rds_tcp_conn_connect() & rds_tcp_accept_one() might be from softirq context. Ignore it

Re: [PATCH net 1/2] RDS:TCP: Synchronize rds_tcp_accept_one with rds_send_xmit when resetting t_sock

On 5/2/2016 9:37 AM, Sowmini Varadhan wrote: On (05/02/16 09:20), Santosh Shilimkar wrote: rds_conn_transition(conn, RDS_CONN_DOWN, RDS_CONN_CONNECTING); + if (rs_tcp->t_sock) { + /* Need to resolve a duelling SYN between peers. +* We have an

Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le

Hi, On Fri, Apr 29, 2016, Julia Lawall wrote: > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct > hci_dev *hdev, void *data, > conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, >

[PATCH net-next] net: add __sock_wfree() helper

From: Eric Dumazet Hosts sending lot of ACK packets exhibit high sock_wfree() cost because of cache line miss to test SOCK_USE_WRITE_QUEUE We could move this flag close to sk_wmem_alloc but it is better to perform the atomic_sub_and_test() on a clean cache line, as it avoid

Re: VRF_DEVICE integration plan

On 4/28/16 11:16 AM, Elluru, Krishna Mohan wrote: I posted a few bug fix patches a week or two ago. Not sure what the status is with respect to 4.3 - 4.5 trees. MOHAN> Sure. Are those patches sent over netdev mailer list? yes. All patches for VRF - kernel and iproute2 - are sent to netdev.

Re: [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd

Hi Dave, > this patch series introduces a layer for IPv6 neighbour discovery. At first > it introduce the "ndisc_ops" to run a different handling for recv/send of > NA/NS messages. The use case for such ndisc operation is RFC 6775 [0]. > Which describes a different neighbour discovery handling

Re: [net PATCH 1/2] net: Disable segmentation if checksumming is not supported

On Mon, May 2, 2016 at 10:07 AM, Tom Herbert wrote: > On Mon, May 2, 2016 at 9:48 AM, Alexander Duyck > wrote: >> On Mon, May 2, 2016 at 9:33 AM, Tom Herbert wrote: >>> On Mon, May 2, 2016 at 9:25 AM, Alexander Duyck

Re: [PATCH net-next] fq_codel: add batch ability to fq_codel_drop()

On Mon, 02 May 2016 09:12:51 -0700 Eric Dumazet wrote: > On Mon, 2016-05-02 at 18:00 +0200, Jesper Dangaard Brouer wrote: > > > It is not that complicated, inside kfree_skb_list(), we just call > > skb_release_all(skb) on each SKB first, and then bulk free the SKB's > >

Re: [net PATCH 1/2] net: Disable segmentation if checksumming is not supported

On Mon, May 2, 2016 at 9:48 AM, Alexander Duyck wrote: > On Mon, May 2, 2016 at 9:33 AM, Tom Herbert wrote: >> On Mon, May 2, 2016 at 9:25 AM, Alexander Duyck wrote: >>> In the case of the mlx4 and mlx5 driver they do not

Re: [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode

On 05/02/2016 11:38 AM, Wang YanQing wrote: In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue"), the tests for enter/exit power-save mode were inverted. With this change applied, the wifi connection becomes much more stable. Fixes: a269913c52ad

[ethtool PATCH v7 2/2] ethtool: use netlink socket when AF_INET not available

From: David Decotigny To benefit from this, kernel commit 025c68186e07 ("netlink: add support for NIC driver ioctls") is needed. Signed-off-by: David Decotigny --- configure.ac | 2 +- ethtool.c| 7 +++ 2 files changed, 8 insertions(+), 1

[ethtool PATCH v7 1/2] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

From: David Decotigny More info with kernel commit 8d3f2806f8fb ("Merge branch 'ethtool-ksettings'"). Note: The new features implemented in this patch depend on kernel commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords"). Signed-off-by:

[ethtool PATCH v7 0/2] add support for new ETHTOOL_xLINKSETTINGS ioctls

From: David Decotigny [ this is a plain re-post, same v7 as the ones previously sent ] History: v7 added ref to related kernel commit in netlink ioctl patch description v6 re-added last patch, to use AF_NETLINK when AF_INET not available v5 rebased main

Re: [PATCHv4] netem: Segment GSO packets on enqueue

On Mon, 2016-05-02 at 12:20 -0400, Neil Horman wrote: > This was recently reported to me, and reproduced on the latest net kernel, > when attempting to run netperf from a host that had a netem qdisc attached > to the egress interface: Acked-by: Eric Dumazet Thanks Neil.

[PATCH net-next 03/12] net/mlx5: E-Switch, Replace vport spin lock with synchronize_irq()

From: Mohamad Haj Yahia Vport spin lock can be replaced with synchronize_irq() in the right place, this will remove the need of locking inside irq context. Locking in esw_enable_vport is not required since vport events are yet to be enabled, and at esw_disable_vport it is

[PATCH net-next 00/12] Mellanox 100G ethernet SRIOV Upgrades

Hi Dave, This series introduces new features and upgrades for mlx5 etherenet SRIOV, while the first patch provides a bug fixes for a compilation issue introduced buy the previous aRFS series for when CONFIG_RFS_ACCEL=y and CONFIG_MLX5_CORE_EN=n. SRIOV upgrades: - Use synchronize_irq

Re: [net PATCH 1/2] net: Disable segmentation if checksumming is not supported

On Mon, May 2, 2016 at 9:33 AM, Tom Herbert wrote: > On Mon, May 2, 2016 at 9:25 AM, Alexander Duyck wrote: >> In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum >> offload for tunnels. With this being the case we should disable

[PATCH net-next 01/12] net/mlx5e: Fix aRFS compilation dependency

From: Maor Gottlieb en_arfs.o should be compiled only if both CONFIG_MLX5_CORE_EN and CONFIG_RFS_ACCEL are enabled. Add MLX5_CORE_EN_RFS Kconfig that depends on both of them. Fixes: 1cabe6b0965e ('net/mlx5e: Create aRFS flow tables') Reported-by: Alexei Starovoitov

[PATCH net-next 08/12] net/mlx5: E-Switch, Enable/disable ACL tables on demand

From: Mohamad Haj Yahia Enable ingress/egress ACL tables only when we need to configure ACL rules. Disable ingress/egress ACL tables once all ACL rules are removed. All VF outgoing/incoming traffic need to go through the ingress/egress ACL tables. Adding/Removing these

[PATCH net-next 06/12] net/mlx5: E-Switch, Vport ingress/egress ACLs rules for VST mode

From: Mohamad Haj Yahia Configure ingress and egress vport ACL rules according to vlan and qos admin parameters. Ingress ACL flow table rules: 1) drop any tagged packet sent from the VF 2) allow other traffic (default behavior) Egress ACL flow table rules: 1) allow only

[PATCH net-next 02/12] net/mlx5: Flow steering, Add vport ACL support

From: Mohamad Haj Yahia Update the relevant flow steering device structs and commands to support vport. Update the flow steering core API to receive vport number. Add ingress and egress ACL flow table name spaces. Add ACL flow table support: * ACL (Access Control List) flow

[PATCH net-next 05/12] net/mlx5: E-Switch, Introduce VST vport ingress/egress ACLs

From: Mohamad Haj Yahia Create egress/ingress ACLs per VF vport at vport enable. Ingress ACL: - one flow group to drop all tagged traffic in VST mode. Egress ACL: - one flow group that allows only untagged traffic with smac that is equals to the

[PATCH net-next 07/12] net/mlx5: E-Switch, Vport ingress/egress ACLs rules for spoofchk

From: Mohamad Haj Yahia Configure ingress and egress vport ACL rules according to spoofchk admin parameters. Ingress ACL flow table rules: if (!spoofchk && !vst) allow all traffic. else : 1) one of the following rules : * if (spoofchk && vst) allow only untagged traffic

[PATCH net-next 12/12] net/mlx5: E-Switch, Implement trust vf ndo

From: Mohamad Haj Yahia - Add support to configure trusted vf attribute through trust_vf_ndo. - Upon VF trust setting change we update vport context to refresh allmulti/promisc or any trusted vf attributes that we didn't trust the VF for before. - Lock the eswitch state

[PATCH net-next 09/12] net/mlx5: E-Switch, Use vport event handler for vport cleanup

From: Mohamad Haj Yahia Remove the usage of explicit cleanup function and use existing vport change handler. Calling vport change handler while vport is disabled will cleanup the vport resources. Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed

[PATCH net-next 11/12] net/mlx5: E-Switch, Implement promiscuous rx modes vf request handling

From: Mohamad Haj Yahia Add promisc_change as a trigger to vport context change event. Add set vport promisc/allmulti functions to add vport to promiscuous flowtable rules. Upon promisc/allmulti rx mode vf request add the vport to the relevant promiscuous group

[PATCH net-next 10/12] net/mlx5: E-Switch, Add promiscuous and allmulti FDB flowtable groups

From: Mohamad Haj Yahia Add promiscuous and allmulti steering groups in FDB table. Besides the full match L2 steering rules group, we added two more groups to catch the "miss" rules traffic: * Allmulti group: One rule that forwards any mcast traffic coming from either

[PATCH net-next 04/12] net/mlx5: E-Switch, Fix error flow memory leak

From: Mohamad Haj Yahia Fix memory leak in case query nic vport command failed. Fixes: 81848731ff40 ('net/mlx5: E-Switch, Add SR-IOV (FDB) support') Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed Mahameed ---

Re: [PATCH net 2/2] RDS: TCP: Synchrnozize accept() and connect() paths on t_conn_lock.

On (05/02/16 09:33), Santosh Shilimkar wrote: > >+mutex_unlock(>t_conn_lock); > Just wondering whether the spin_lock() would better here considering > entry into rds_tcp_conn_connect() & rds_tcp_accept_one() might be > from softirq context. Ignore it if its not applicable. It's not from

[net-next PATCH v3 8/8] bnxt: Add support for segmentation of tunnels with outer checksums

This patch assumes that the bnxt hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP and GRE headers. I have been told by Michael Chan that this is working. Though this might be somewhat redundant for IPv6 as they

[PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode

In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue"), the tests for enter/exit power-save mode were inverted. With this change applied, the wifi connection becomes much more stable. Fixes: a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and

Re: [net PATCH 1/2] net: Disable segmentation if checksumming is not supported

On Mon, May 2, 2016 at 9:25 AM, Alexander Duyck wrote: > In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum > offload for tunnels. With this being the case we should disable GSO in > addition to the checksum offload features when we find that a device

[net-next PATCH v3 5/8] net/mlx4_en: Add support for inner IPv6 checksum offloads and TSO

>From what I can tell the ConnectX-3 will support an inner IPv6 checksum and segmentation offload, however it cannot support outer IPv6 headers. This assumption is based on the fact that I could see the checksum being offloaded for inner header on IPv4 tunnels, but not on IPv6 tunnels. For this

[net-next PATCH v3 6/8] net/mlx5e: Add support for UDP tunnel segmentation with outer checksum offload

This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP headers. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |7 ++-

[net-next PATCH v3 0/8] Fix Tunnel features and enable GSO partial for several drivers

This patch series is meant to allow us to get the best performance possible for Mellanox ConnectX-3/4 and Broadcom NetXtreme-C/E adapters in terms of VXLAN and GRE tunnels. The first 3 patches address issues I found in regards to GSO_PARTIAL and TSO_MANGLEID. The next 4 patches go through and

[net-next PATCH v3 1/8] gso: Do not perform partial GSO if number of partial segments is 1 or less

In the event that the number of partial segments is equal to 1 we don't really need to perform partial segmentation offload. As such we should skip multiplying the MSS and instead just clear the partial_segs value since it will not provide any gain to advertise the frame as being GSO when it is a

[net-next PATCH v3 7/8] net/mlx5e: Fix IPv6 tunnel checksum offload

The mlx5 driver exposes support for TSO6 but not IPv6 csum for hardware encapsulated tunnels. This leads to issues as it triggers warnings in skb_checksum_help as it ends up being called as we report supporting the segmentation but not the checksumming for IPv6 frames. This patch corrects that

[net-next PATCH v3 3/8] net: Fix netdev_fix_features so that TSO_MANGLEID is only available with TSO

This change makes it so that we will strip the TSO_MANGLEID bit if TSO is not present. This way we will also handle ECN correctly of TSO is not present. Signed-off-by: Alexander Duyck --- net/core/dev.c |4 1 file changed, 4 insertions(+) diff --git

  1   2   >