RE: [PATCH] Maxim/driver: Add driver for maxim ds26522

On Thu, 2016-06-23 at 10:59PM, David Miller wrote: > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, June 23, 2016 10:59 PM > To: Qiang Zhao > Cc: o...@buserror.net; linux-ker...@vger.kernel.org; netdev@vger.kernel.org; > Xiaobo

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

>We already know of one firmware bug you guys have which makes >it clear that the bnx2x is not doing hardware assisted GRO it is doing >something else since it performs much worse than GRO if the MSS is >less than what it would be based on the MTU. It's a bit nitpicky, isn't it? Claiming this

[PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

SMP does ECB crypto on stack buffers. This is complicated and fragile, and it will not work if the stack is virtually allocated. Switch to the crypto_cipher interface, which is simpler and safer. Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan

Re: esp: Fix ESN generation under UDP encapsulation

On Thu, Jun 23, 2016 at 11:52:45AM -0400, David Miller wrote: > > Does the ipv6 side need the same fix? Last I checked IPv6 didn't do IPsec UDP-encapsulation so we're safe for now. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH iproute2 0/6] Add support for vrf keyword

On 6/14/16 2:59 PM, David Ahern wrote: Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link, address, neigh, and route commands to improve the user experience listing data associated

[PATCH net-next] net: diag: Add support to filter on device index

Add support to inet_diag facility to filter sockets based on device index. If an interface index is in the filter only sockets bound to that index (sk_bound_dev_if) are returned. Signed-off-by: David Ahern --- include/uapi/linux/inet_diag.h | 1 + net/ipv4/inet_diag.c

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/vrf.c between commit: 52fe705b493d ("net: vrf: replace hard tab with space in assignment") from the net tree and commits: 671cd19ade97 ("net: vrf: ipv4 support for local traffic to local addresses")

[PATCH v3] net/mlx5: use mlx5_buf_alloc_node instead of mlx5_buf_alloc in mlx5_wq_ll_create

Commit 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on reader NUMA node") introduced mlx5_*_alloc_node() but missed changing some calling and warn messages. This patch introduces 2 changes: * Use mlx5_buf_alloc_node() instead of mlx5_buf_alloc() in mlx5_wq_ll_create()

[PATCH usbnet v2.1] mtu change needs to stop RX

When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. Signed-off-by: Soohoon Lee Reviewed-by: Kimball Murray diff

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On Thu, Jun 23, 2016 at 2:06 PM, Yuval Mintz wrote: Then again, if you're basically saying every HW-assisted offload on receive should be done under LRO flag, what would be the use case where a GRO-assisted offload would help? I.e., afaik LRO is

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

On Wed, Jun 22, 2016 at 11:41 PM, Herbert Xu wrote: > On Thu, Jun 23, 2016 at 11:48:25AM +0800, Herbert Xu wrote: >> >> No we never had such an API in the kernel. However, I see that >> rxkad does some pretty silly things and we should be able to avoid >> using the

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

On Thu, Jun 23, 2016 at 11:50:08PM +0200, Daniel Borkmann wrote: > On 06/23/2016 11:26 PM, Martin KaFai Lau wrote: > >We are still hatching out how to set this up in production. However, the > >situation is similar to removing the pinned file. s/pinned file/pinned cgroup-array/ > I presume you

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

On 06/23/2016 11:26 PM, Martin KaFai Lau wrote: On Thu, Jun 23, 2016 at 11:42:31AM +0200, Daniel Borkmann wrote: Hi Martin, [ sorry to jump late in here, on pto currently ] Thanks for reviewing. Could you describe a bit more with regards to pinning maps and how this should interact with

[PATCH 2/2] net: ethernet: dnet: use phy_ethtool_{get|set}_link_ksettings

There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/dnet.c | 24 ++-- 1 files changed, 2 insertions(+), 22

[PATCH 1/2] net: ethernet: dnet: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

Re: [PATCH net-next v2 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

On Thu, Jun 23, 2016 at 10:07:27PM +0200, Daniel Borkmann wrote: > On 06/23/2016 06:54 PM, Martin KaFai Lau wrote: > >On Thu, Jun 23, 2016 at 11:53:50AM +0200, Daniel Borkmann wrote: > >>>diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > >>>index 668e079..68753e0 100644 > >>>---

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

On 06/23/2016 11:13 PM, Tejun Heo wrote: Hello, On Thu, Jun 23, 2016 at 11:42:31AM +0200, Daniel Borkmann wrote: I presume it's a valid use case to pin a cgroup map, put fds into it and remove the pinned file expecting to continue to match on it, right? So lifetime is really until last prog

[PATCH usbnet v2] mtu change needs to stop RX

When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. Reviewed-by: kmur...@f5.com diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

On Thu, Jun 23, 2016 at 11:42:31AM +0200, Daniel Borkmann wrote: > Hi Martin, > > [ sorry to jump late in here, on pto currently ] Thanks for reviewing. > Could you describe a bit more with regards to pinning maps and how this > should interact with cgroups? The two specialized array maps we have

[PATCH net 2/3] net: bgmac: Start transmit queue in bgmac_open

The driver does not start the transmit queue in bgmac_open(). If the queue was stopped prior to closing then re-opening the interface, we would never be able to wake-up again. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus") Signed-off-by: Florian Fainelli

[PATCH net 3/3] net: bgmac: Remove superflous netif_carrier_on()

bgmac_open() calls phy_start() to initialize the PHY state machine, which will set the interface's carrier state accordingly, no need to force that as this could be conflicting with the PHY state determined by PHYLIB. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")

[PATCH net 0/3] net: bgmac: Random fixes

Hi all, This patch series fixes a few issues spotted by code inspection and actual testing. Thanks Florian Fainelli (3): net: bgmac: Fix SOF bit checking net: bgmac: Start transmit queue in bgmac_open net: bgmac: Remove superflous netif_carrier_on() drivers/net/ethernet/broadcom/bgmac.c

[PATCH net 1/3] net: bgmac: Fix SOF bit checking

We are checking for the Start of Frame bit in the ctl1 word, while this bit is set in the ctl0 word instead. Read the ctl0 word and update the check to verify that. Fixes: 9cde94506eac ("bgmac: implement scatter/gather support") Signed-off-by: Florian Fainelli ---

[PATCH net] bonding: fix 802.3ad aggregator reselection

Since commit 7bb11dc9f59d ("bonding: unify all places where actor-oper key needs to be updated."), the logic in bonding to handle selection between multiple aggregators has not functioned. This affects only configurations wherein the bonding slaves connect to two discrete

Re: [PATCH net-next v2 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

Hello, On Thu, Jun 23, 2016 at 11:42:31AM +0200, Daniel Borkmann wrote: > I presume it's a valid use case to pin a cgroup map, put fds into it and > remove the pinned file expecting to continue to match on it, right? So > lifetime is really until last prog using a cgroup map somewhere gets

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

>>> Then again, if you're basically saying every HW-assisted offload on >>> receive should be done under LRO flag, what would be the use case >>> where a GRO-assisted offload would help? >>> I.e., afaik LRO is superior to GRO in `brute force' - >>> it creates better packed packets and utilizes

Re: [PATCH net-next v2 1/4] cgroup: Add cgroup_get_from_fd

On Wed, Jun 22, 2016 at 02:17:29PM -0700, Martin KaFai Lau wrote: > Add a helper function to get a cgroup2 from a fd. It will be > stored in a bpf array (BPF_MAP_TYPE_CGROUP_ARRAY) which will > be introduced in the later patch. > > Signed-off-by: Martin KaFai Lau > Cc: Alexei

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

On 6/23/16 8:39 AM, Paolo Abeni wrote: On Thu, 2016-06-23 at 08:29 -0600, David Ahern wrote: On 6/23/16 8:20 AM, David Ahern wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 969913d..520b788 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1782,7 +1782,7 @@ static struct

[PATCH] ipmr/ip6mr: Initialize the last assert time of mfc entries.

This fixes wrong-interface signaling on 32-bit platforms for entries created when jiffies > 2^31 + MFC_ASSERT_THRESH. Signed-off-by: Tom Goff --- net/ipv4/ipmr.c | 4 +++- net/ipv6/ip6mr.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next v2 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

On 06/23/2016 06:54 PM, Martin KaFai Lau wrote: On Thu, Jun 23, 2016 at 11:53:50AM +0200, Daniel Borkmann wrote: diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 668e079..68753e0 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1062,6 +1062,10 @@ static int

Re: [PATCH net-next 0/2] qed*: coalesce parameters config support.

From: Sudarsana Reddy Kalluru Date: Tue, 21 Jun 2016 09:36:20 -0400 > The patch series adds the support for config/read of the adapter coalesce > parameters. Patch (1) adds the qed infrastructure/APIs for the support and > patch (2) adds the driver support for

Re: pull-request: wireless-drivers-next 2016-06-21

From: Kalle Valo Date: Tue, 21 Jun 2016 13:47:45 +0300 > I hope it's ok to send two pull requests the same day, both for net > and net-next? This is targeted to 4.8 so it is for net-next. Yeah that's fine. > Even though is this the first pull request for 4.8 we actually >

Re: pull-request: wireless-drivers 2016-06-21

From: Kalle Valo Date: Tue, 21 Jun 2016 13:27:16 +0300 > here is a pull request for 4.7, really small fixes this time, some of > them fix important regressions. Please let me know if there are any > problems. Applied, thanks.

Re: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings

From: Julia Lawall Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST) > PTR_ERR should normally access the value just tested by IS_ERR > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Tien Hock Loh > Signed-off-by: Julia Lawall

Re: [PATCH v4 00/19] CALIPSO Implementation

From: Huw Davies Date: Tue, 21 Jun 2016 10:55:48 +0100 > On Tue, Jun 21, 2016 at 05:39:28AM -0400, David Miller wrote: >> From: Huw Davies >> Date: Mon, 20 Jun 2016 14:36:40 +0100 >> >> > This patch series implements RFC 5570 - Common Architecture

Re: [PATCH] net: vrf: replace hard tab with space in assignment

From: Chris Packham Date: Tue, 21 Jun 2016 15:39:43 +1200 > The assignment of rth->dst.output in vrf_rt6_create() and > vrf_rtable_create() used a hard tab before the '='. The neighboring > assignments did not. Make the assignment of rth->dst.output consistent

Re: [PATCH] geneve: fix tx_errors statistics

From: Haishuang Yan Date: Tue, 21 Jun 2016 16:26:49 +0800 > Tx errors present summation of errors encountered while transmitting > packets. > > Signed-off-by: Haishuang Yan Applied.

Re: [PATCH net-next] net: dsa: b53: Fix statistics readings

From: Florian Fainelli Date: Mon, 20 Jun 2016 18:26:53 -0700 > Due to a typo we would always be using the MIB counter width of the > first element of the counter array instead of the current element, and > we would always be accessing the register statistics with a 64-bits

Re: [PATCH net-next] ti_cpsw: Check for disabled child nodes

From: Ben Hutchings Date: Tue, 21 Jun 2016 01:16:31 +0100 > Dual MAC devices don't necessarily have both MACs wired up, so ignore > those that are disabled. > > Signed-off-by: Ben Hutchings Applied.

Re: of_mdio: Enable fixed PHY support if driver is a module

From: Ben Hutchings Date: Tue, 21 Jun 2016 01:10:55 +0100 > The fixed_phy driver doesn't have to be built-in, and it's > important that of_mdio supports it even if it's a module. > > Signed-off-by: Ben Hutchings Applied.

Re: [PATCH net] netem: fix a use after free

From: Eric Dumazet Date: Mon, 20 Jun 2016 15:00:43 -0700 > From: Eric Dumazet > > If the packet was dropped by lower qdisc, then we must not > access it later. > > Save qdisc_pkt_len(skb) in a temp variable. > > Fixes: 2f5fb43f ("net_sched:

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > There is code duplication of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment

[ PATCH] usbnet.c mtu change needs to stop RX

When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 61ba464..e03e3e6 100644 ---

Re: [PATCH] Bridge: Fix ipv6 mc snooping if it has no ipv6 address.

Hi Daniel, Thanks for submitting this patch here :). On Thu, Jun 23, 2016 at 11:28:55AM +0200, daniel wrote: > The bridge is falsly dropping ipv6 mulitcast packets > if there is no ipv6 address assigned on the brigde and no > external mld querier is present. and if the bridge internal querier

Re: [PATCH v2 2/2] netfilter/nflog: nflog-range does not truncate packets (userspace)

On Tue, Jun 21, 2016 at 03:02:16PM -0400, Vishwanath Pai wrote: > netfilter/nflog: nflog-range does not truncate packets > > The option --nflog-range has never worked, but we cannot just fix this > because users might be using this feature option and their behavior would > change. Instead add a

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > There is code duplication of a masked ethernet address comparison here > so make it a separate function instead. > > Miscellanea: > > o Neaten alignment of FWINV macro uses to make it clearer for the reader Applied, thanks. >

[iproute PATCH v3 6/6] misc/ifstat: simplify unsigned value comparison

By directly comparing the value of both unsigned variables, casting to signed becomes unnecessary. This also fixes for compiling with older versions of gcc (at least <=3.4.6) which emit the following warning: | ifstat.c: In function `update_db': | ifstat.c:542: warning: comparison is always

[iproute PATCH v3 5/6] Makefile: Allow to override CC

This makes it easier to build iproute2 with a custom compiler. While at it, make HOSTCC default to the value of CC if not explicitly set elsewhere. Signed-off-by: Phil Sutter --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile

[iproute PATCH v3 2/6] Use C99 style initializers everywhere

This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. One notable exception is the initialization of union bpf_attr in tc/tc_bpf.c: changing it would break for older gcc versions (at least <=3.4.6). Calls to memset for struct rtattr pointer

[iproute PATCH v3 1/6] tc: m_action: Improve conversion to C99 style initializers

This improves my initial change in the following points: - Flatten embedded struct's initializers. - No need to initialize variables to zero as the key feature of C99 initializers is to do this implicitly. - By relocating the declaration of struct rtattr *tail, it can be initialized at the

[iproute PATCH v3 3/6] Replace malloc && memset by calloc

This only replaces occurrences where the newly allocated memory is cleared completely afterwards, as in other cases it is a theoretical performance hit although code would be cleaner this way. Signed-off-by: Phil Sutter --- Changes since v2: - Fix checkpatch errors. --- genl/genl.c

[iproute PATCH v3 4/6] No need to initialize rtattr fields before parsing

Since parse_rtattr_flags() calls memset already, there is no need for callers to do so themselves. Signed-off-by: Phil Sutter --- ip/ipaddress.c | 2 +- tc/tc_class.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index

[iproute PATCH v3 0/6] Big C99 style initializer rework

This is v3 of my C99-style initializer related patch series. The changes since v2 are: - Flattened embedded struct's initializers: Since the field names are very short, I figured it makes more sense to keep indenting low. Also, the same style is already used in ip/xfrm_policy.c so take that

Re: [PATCH v2 1/2] netfilter/nflog: nflog-range does not truncate packets

On Tue, Jun 21, 2016 at 02:58:46PM -0400, Vishwanath Pai wrote: > netfilter/nflog: nflog-range does not truncate packets > > li->u.ulog.copy_len is currently ignored by the kernel, we should truncate > the packet to either li->u.ulog.copy_len (if set) or copy_range before > sending it to

[4.6] kernel BUG at net/ipv6/raw.c:592

Found this logs after a Trinity run. kernel BUG at net/ipv6/raw.c:592! [ cut here ] invalid opcode: [#1] SMP Modules linked in: udp_diag dccp_ipv6 dccp_ipv4 dccp sctp af_key tcp_diag inet_diag ip6table_filter xt_NFLOG nfnetlink_log xt_comment xt_statistic

Re: [PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

On Wed, Jun 22, 2016 at 9:17 PM, Yuval Mintz wrote: >> Then again, if you're basically saying every HW-assisted offload on >> receive should be done under LRO flag, what would be the use case >> where a GRO-assisted offload would help? > >> I.e., afaik LRO is superior to

Re: [PATCH net-next v2 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

On Thu, Jun 23, 2016 at 11:53:50AM +0200, Daniel Borkmann wrote: > >diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > >index 668e079..68753e0 100644 > >--- a/kernel/bpf/verifier.c > >+++ b/kernel/bpf/verifier.c > >@@ -1062,6 +1062,10 @@ static int check_map_func_compatibility(struct >

Re: [PATCH net-next V2 07/10] ethtool: Add 50G baseSR2 link mode

On Thu, Jun 23, 2016 at 7:02 AM, Saeed Mahameed wrote: > From: Gal Pressman > > Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT bit. > > Signed-off-by: Gal Pressman > Signed-off-by: Saeed Mahameed > Cc: Ben Hutchings

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

On 06/23/2016 03:09 PM, Sergei Shtylyov wrote: +static void can_dellink(struct net_device *dev, struct list_head *head) +{ +return; Why? http://marc.info/?l=linux-can=146651600421205=2 The same reason as for commit 993e6f2fd. I was asking just about the useless *return*

Re: [PATCH net-next 0/4] net_sched: bulk dequeue and deferred drops

On Wed, Jun 22, 2016 at 6:49 PM, Eric Dumazet wrote: > On Wed, 2016-06-22 at 17:44 +0200, Jesper Dangaard Brouer wrote: >> On Wed, 22 Jun 2016 07:55:43 -0700 >> Eric Dumazet wrote: >> >> > On Wed, 2016-06-22 at 16:47 +0200, Jesper Dangaard Brouer

Re: [Patch net 0/2] net_sched: bug fixes for ife action

From: Cong Wang Date: Mon, 20 Jun 2016 13:37:17 -0700 > Cong Wang (2): > act_ife: only acquire tcf_lock for existing actions > act_ife: acquire ife_mod_lock before reading ifeoplist Series applied, thanks.

Re: [PATCH] mpls: Add missing RCU-bh read side critical section locking in output path

From: Lennert Buytenhek Date: Mon, 20 Jun 2016 21:05:27 +0300 > From: David Barroso > > When locally originated IP traffic hits a route that says to push > MPLS labels, we'll get a call chain dst_output() -> lwtunnel_output() > -> mpls_output() ->

[PATCH net-next V2 05/10] net/mlx5e: Support adaptive RX coalescing

From: Gil Rockah Striving for high message rate and low interrupt rate. Usage: ethtool -C adaptive-rx on/off Signed-off-by: Gil Rockah Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed CC:

[PATCH net-next V2 00/10] Mellanox 100G mlx5e Ethernet extensions

Hi Dave, This series includes multiple features extensions for mlx5 Ethernet netdevice driver. Namely, TX Rate limiting, RX interrupt moderation, ethtool settings. TX Rate limiting: - ConnectX-4 rate limiting infrastructure - Set max rate NDO support RX interrupt moderation:

Re: esp: Fix ESN generation under UDP encapsulation

From: Steffen Klassert Date: Thu, 23 Jun 2016 12:40:07 +0200 > On Thu, Jun 23, 2016 at 04:25:21AM +, Blair Steven wrote: >> This change tests okay in my setup. >> >> Thanks very much >> -Blair > > David, can you please take this patch directly in the net tree?

[PATCH net-next V2 10/10] net/mlx5e: Report correct auto negotiation and allow toggling

From: Gal Pressman Previous to this patch auto negotiation was reported off although it was on by default in hardware. This patch reports the correct information to ethtool and allows the user to toggle it on/off. Added another parameter to set port proto function in order to

[PATCH net-next V2 04/10] net/mlx5e: CQE based moderation

From: Tariq Toukan In this mode the moderation timer will restart upon new completion (CQE) generation rather than upon interrupt generation. The outcome is that for bursty traffic the period timer will never expire and thus only the moderation frames counter will dictate

[PATCH net-next V2 03/10] net/mlx5e: Introduce net device priv flags infrastructure

From: Gal Pressman Introduce an infrastructure for getting/setting private net device flags. Currently a 'nop' priv flag is added, following patches will override the flag will actual feature specific flags. Signed-off-by: Gal Pressman Signed-off-by:

[PATCH net-next V2 07/10] ethtool: Add 50G baseSR2 link mode

From: Gal Pressman Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT bit. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Cc: Ben Hutchings Cc: David Decotigny ---

[PATCH net-next V2 08/10] net/mlx5e: Add missing 50G baseSR2 link mode

From: Gal Pressman Add MLX5E_50GBASE_SR2 as ETHTOOL_LINK_MODE_5baseSR2_Full_BIT. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Cc: Ben Hutchings Cc: David Decotigny ---

[PATCH net-next V2 06/10] net/mlx5e: Toggle link only after modifying port parameters

From: Gal Pressman Add a dedicated function to toggle port link. It should be called only after setting a port register. Toggle will set port link to down and bring it back up in case that it's admin status was up. Signed-off-by: Gal Pressman

[PATCH net-next V2 02/10] net/mlx5e: Add TXQ set max rate support

From: Yevgeny Petrilin Implement set_maxrate ndo. Use the rate index from the hardware table to attach to channel SQ/TXQ. In case of failure to configure new rate, the queue remains with unlimited rate. We save the configuration on priv structure and apply it each time

[PATCH net-next V2 09/10] net/mlx5e: Use new ethtool get/set link ksettings API

From: Gal Pressman Use new get/set link ksettings and remove get/set settings legacy callbacks. This allows us to use bitmasks longer than 32 bit for supported and advertised link modes and use modes that were previously not supported. Signed-off-by: Gal Pressman

[PATCH net-next V2 01/10] net/mlx5: Rate limit tables support

From: Yevgeny Petrilin Configuring and managing HW rate limit tables. The HW holds a table of rate limits, each rate is associated with an index in that table. Later a Send Queue uses this index to set the rate limit. Multiple Send Queues can have the same rate limit,

vmw_vsock sk_ack_backlog double decrement bug

Hi Jorgen, virtio-vsock doesn't use vsock_pending_work() but I may have spotted a problem that affects the VMCI transport. I'm not sending a patch because I can't test it. 1. During vsock_accept() listener->sk_ack_backlog is decremented. 2. vsock_pending_work() will decrement

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: > we can't separate CPU and HW stats there. In some cases (or ASICs) HW > counters do > not include CPU generated packetsyou will have to add CPU > generated pkt counters to the > hw counters for

[PATCH] vsock: make listener child lock ordering explicit

There are several places where the listener and pending or accept queue child sockets are accessed at the same time. Lockdep is unhappy that two locks from the same class are held. Tell lockdep that it is safe and document the lock ordering. Originally Claudio Imbrenda

Re: [PATCH] dsa: mv88e6xxx: hide unused functions

Hi, Arnd Bergmann writes: > When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused > functions whose only callers are all inside of an #ifdef: > > drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but > not used [-Werror=unused-function] >

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

we can't separate CPU and HW stats there. In some cases (or ASICs) HW counters do not include CPU generated packetsyou will have to add CPU generated pkt counters to the hw counters for such virtual device stats. >>> Can you please provide and example how that could

Re: [PATCH] Maxim/driver: Add driver for maxim ds26522

From: Zhao Qiang Date: Thu, 23 Jun 2016 09:09:45 +0800 > +MODULE_DESCRIPTION(DRV_DESC); There is no definition of DRV_DESC, so this makes it look like you didn't even compile this driver.

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

On Thu, 2016-06-23 at 08:29 -0600, David Ahern wrote: > On 6/23/16 8:20 AM, David Ahern wrote: > >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > >> index 969913d..520b788 100644 > >> --- a/net/ipv6/route.c > >> +++ b/net/ipv6/route.c > >> @@ -1782,7 +1782,7 @@ static struct rt6_info > >>

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

On 6/23/16 8:20 AM, David Ahern wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 969913d..520b788 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1782,7 +1782,7 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net, }; struct fib6_table *table;

Re: [PATCH net-next 0/4] net_sched: bulk dequeue and deferred drops

On Wed, 22 Jun 2016 09:49:48 -0700 Eric Dumazet wrote: > On Wed, 2016-06-22 at 17:44 +0200, Jesper Dangaard Brouer wrote: > > On Wed, 22 Jun 2016 07:55:43 -0700 > > Eric Dumazet wrote: > > > > > On Wed, 2016-06-22 at 16:47 +0200, Jesper

Re: [PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

On 6/23/16 7:25 AM, Paolo Abeni wrote: with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded

[PATCH] dsa: mv88e6xxx: hide unused functions

When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused functions whose only callers are all inside of an #ifdef: drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function] drivers/net/dsa/mv88e6xxx.c:3244:12:

Re: rstpd implementation

On 06/22/2016 08:12 PM, Stephen Hemminger wrote: On Wed, 22 Jun 2016 12:44:52 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: Phil writes: Hi, When looking for an RSTP daemon I found Stephen Hemminger's

[PATCH net-next 3/5] phy: separate swphy state validation from register generation

Separate out the generation of MII registers from the state validation. This allows us to simplify the error handing in fixed_phy() by allowing earlier error detection. Reviewed-by: Florian Fainelli Signed-off-by: Russell King ---

[PATCH net-next 1/5] phy: move fixed_phy MII register generation to a library

Move the fixed_phy MII register generation to a library to allow other software phy implementations to use this code. Reviewed-by: Florian Fainelli Signed-off-by: Russell King --- drivers/net/phy/Kconfig | 4 ++ drivers/net/phy/Makefile

[PATCH net-next 0/5] Initial SFP support patches

Hi David, Please review and merge this initial patch set, which is part of a larger set previously posted adding SFP support to phy and mvneta. This initial set are focused on cleaning up and reorganising the fixed-phy code to allow the core software-phy code to be re-used. These are based on

[PATCH net-next 2/5] phy: convert swphy register generation to tabular form

Convert the swphy register generation to tabular form which allows us to eliminate multiple switch() statements. This results in a smaller object code size, more efficient, and easier to add support for faster speeds. Before: Idx Name Size VMA LMA File off Algn 0

[PATCH net-next 4/5] phy: generate swphy registers on the fly

Generate software phy registers as and when requested, rather than duplicating the state in fixed_phy. This allows us to eliminate the duplicate storage of of the same data, which is only different in format. As fixed_phy_update_regs() no longer updates register state, rename it to

[PATCH net-next 5/5] phy: improve safety of fixed-phy MII register reading

There is no prevention of a concurrent call to both fixed_mdio_read() and fixed_phy_update_state(), which can result in the state being modified while it's being inspected. Fix this by using a seqcount to detect modifications, and memcpy()ing the state. We remain slightly naughty here, calling

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

On Thu, Jun 23, 2016 at 12:38:48PM +0200, Henrik Austad wrote: > Richard: is it fair to assume that if ptp4l is running and is part of a PTP > domain, ktime_get() will return PTP-adjusted time for the system? No. > Or do I also need to run phc2sys in order to sync the system-time > to PTP-time?

[PATCH net v2] ipv6: enforce egress device match in per table nexthop lookups

with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded due to egress device mismatch and no

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On 23.06.16 15:36, Grygorii Strashko wrote: TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using

Re: [PATCH net] ipv6: allows gracefull fallback from table lookup

On Thu, 2016-06-23 at 15:11 +0200, Paolo Abeni wrote: > with the commit 8c14586fc320 ("net: ipv6: Use passed in table for > nexthop lookups"), net hop lookup is first performed on route creation > in the passed-in table. > However device match is not enforced in table lookup, so the found > route

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

On 6/23/2016 4:01 PM, Oliver Hartkopp wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a

[PATCH net] ipv6: allows gracefull fallback from table lookup

with the commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups"), net hop lookup is first performed on route creation in the passed-in table. However device match is not enforced in table lookup, so the found route can be later discarded due to egress device mismatch and no

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

On 06/23/2016 02:55 PM, Sergei Shtylyov wrote: Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

On 23.06.16 15:36, Grygorii Strashko wrote: TI CPDMA currently uses a bitmap for tracking descriptors alloactions allocations, but The genalloc already handles the same and can be used as with special memory (SRAM) as with DMA cherent memory chank (dma_alloc_coherent()). Hence, switch to using

  1   2   >