Re: [PATCH bpf 2/3] bpf: fix build issues on um due to mising bpf_perf_event.h

2017-12-11 Thread Richard Weinberger
Am Dienstag, 12. Dezember 2017, 02:25:31 CET schrieb Daniel Borkmann: > Since c895f6f703ad ("bpf: correct broken uapi for > BPF_PROG_TYPE_PERF_EVENT program type") um (uml) won't build > on i386 or x86_64: > > [...] > CC init/main.o > In file included from

Re: [PATCH net-next 2/3] net: dsa: mediatek: combine MediaTek tag with VLAN tag

2017-12-11 Thread Sean Wang
On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote: > > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, > > { > > struct dsa_port *dp = dsa_slave_to_port(dev); > > u8 *mtk_tag; > > + bool is_vlan_skb = true; > > .. > > > + /* Mark tag attribute on

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-11 Thread Sean Wang
Hi, Andrew All sounds reasonable. All will be fixed in the next version. Sean On Thu, 2017-12-07 at 16:24 +0100, Andrew Lunn wrote: > > static void > > +mt7530_port_set_vlan_unware(struct dsa_switch *ds, int port) > > +{ > > + struct mt7530_priv *priv = ds->priv; > > + int i; > >

[PATCH v2 1/3] PCI: Add pcim_set_mwi(), a device-managed pci_set_mwi()

2017-12-11 Thread Heiner Kallweit
Add pcim_set_mwi(), a device-managed version of pci_set_mwi(). First user is the Realtek r8169 driver. Signed-off-by: Heiner Kallweit Acked-by: Bjorn Helgaas --- v2: - Reorder calls - Adjust and commit message --- drivers/pci/pci.c | 25

[PATCH v2 3/3] r8169: remove netif_napi_del in probe error path

2017-12-11 Thread Heiner Kallweit
netif_napi_del is called implicitely by free_netdev, therefore we don't have to do it explicitely. When the probe error path is reached, the net_device isn't registered yet. Therefore reordering the call to netif_napi_del shouldn't cause any issues. Signed-off-by: Heiner Kallweit

[PATCH v2 2/3] r8169: switch to device-managed functions in probe

2017-12-11 Thread Heiner Kallweit
Simplify probe error path and remove callback by using device-managed functions. rtl_disable_msi isn't needed any longer because the release callback of pcim_enable_device does this implicitely. Signed-off-by: Heiner Kallweit --- v2: - no changes ---

[PATCH v2 0/3] r8169: extend PCI core and switch to device-managed functions in probe

2017-12-11 Thread Heiner Kallweit
Probe error path and remove callback can be significantly simplified by using device-managed functions. To be able to do this in the r8169 driver we need a device-managed version of pci_set_mwi first. v2: Change patch 1 based on Björn's review comments and add his Acked-by. Heiner Kallweit (3):

Re: [PATCH] ptr_ring: add barriers

2017-12-11 Thread George Cherian
Hi David, On 12/11/2017 09:23 PM, David Miller wrote: From: "Michael S. Tsirkin" Date: Tue, 5 Dec 2017 21:29:37 +0200 Users of ptr_ring expect that it's safe to give the data structure a pointer and have it be available to consumers, but that actually requires an smb_wmb or

Re: [RFC][PATCH] new byteorder primitives - ..._{replace,get}_bits()

2017-12-11 Thread Al Viro
On Mon, Dec 11, 2017 at 08:02:24PM -0800, Jakub Kicinski wrote: > On Mon, 11 Dec 2017 15:54:22 +, Al Viro wrote: > > Essentially, it gives helpers for work with bitfields in fixed-endian. > > Suppose we have e.g. a little-endian 32bit value with fixed layout; > > expressing that as a bitfield

[PATCH v5 0/3] Add andestech atcpit100 timer

2017-12-11 Thread Rick Chen
Changelog v5: - Patch 1/3: Changes - Patch 2/3: New - Patch 3/3: Changes [Patch 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer 1 No need to split out the Makefile patch from the actual driver. Suggested by Arnd Bergmann 2 Add of_clk.name = "PCLK" to be explicit on

[PATCH v5 2/3] clocksource/drivers/atcpit100: VDSO support

2017-12-11 Thread Rick Chen
VDSO needs real-time cycle count to ensure the time accuracy. Unlike others, nds32 architecture does not define clock source, hence VDSO needs atcpit100 offering real-time cycle count to derive the correct time. Signed-off-by: Vincent Chen Signed-off-by: Rick Chen

[PATCH v5 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc

2017-12-11 Thread Rick Chen
Add a document to describe Andestech atcpit100 timer and binding information. Signed-off-by: Rick Chen Signed-off-by: Greentime Hu Acked-by: Rob Herring --- .../bindings/timer/andestech,atcpit100-timer.txt | 33

[PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2017-12-11 Thread Rick Chen
ATCPIT100 is often used on the Andes architecture, This timer provide 4 PIT channels. Each PIT channel is a multi-function timer, can be configured as 32,16,8 bit timers or PWM as well. For system timer it will set channel 1 32-bit timer0 as clock source and count downwards until underflow and

[PATCH net-next] tcp/dccp: avoid one atomic operation for timewait hashdance

2017-12-11 Thread Eric Dumazet
From: Eric Dumazet First, rename __inet_twsk_hashdance() to inet_twsk_hashdance() Then, remove one inet_twsk_put() by setting tw_refcnt to 3 instead of 4, but adding a fat warning that we do not have the right to access tw anymore after inet_twsk_hashdance() Signed-off-by:

Re: [PATCH net] tcp md5sig: Use skb's saddr when replying to an incoming segment

2017-12-11 Thread Eric Dumazet
On Mon, 2017-12-11 at 00:05 -0800, Christoph Paasch wrote: > The MD5-key that belongs to a connection is identified by the peer's > IP-address. When we are in tcp_v4(6)_reqsk_send_ack(), we are > replying > to an incoming segment from tcp_check_req() that failed the seq- > number > checks. > >

Re: [RFC][PATCH] new byteorder primitives - ..._{replace,get}_bits()

2017-12-11 Thread Jakub Kicinski
On Mon, 11 Dec 2017 15:54:22 +, Al Viro wrote: > Essentially, it gives helpers for work with bitfields in fixed-endian. > Suppose we have e.g. a little-endian 32bit value with fixed layout; > expressing that as a bitfield would go like > struct foo { > unsigned foo:4;

[BUG] 3com/3c59x: two possible sleep-in-atomic bugs

2017-12-11 Thread Jia-Ju Bai
According to drivers/net/ethernet/3com/3c59x.c, the kernel module may sleep in the interrupt handler. The function call paths are: boomerang_interrupt (interrupt handler) vortex_error vortex_up pci_set_power_state --> may sleep pci_enable_device --> may sleep vortex_interrupt

Setting large MTU size on slave interfaces may stall the whole system

2017-12-11 Thread Qing Huang
(resend this email in text format) Hi, We found an issue with the bonding driver when testing Mellanox devices. The following test commands will stall the whole system sometimes, with serial console flooded with log messages from the bond_miimon_inspect() function. Setting mtu size to be

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Masami Hiramatsu
Hi Russell, 2017-12-11 22:46 GMT+09:00 Russell King - ARM Linux : > On Mon, Dec 11, 2017 at 10:34:17PM +0900, Masami Hiramatsu wrote: >> IMHO, even if we use SPDX license identifier, I recommend to use >> C-style comments as many other files do, since it is C code. >> If

Re: [PATCH net-next] libbpf: add function to setup XDP

2017-12-11 Thread Daniel Borkmann
On 12/10/2017 10:07 PM, David Ahern wrote: > On 12/10/17 1:34 PM, Eric Leblond wrote: >>> Would it be possible to print out or preferably return to the caller >>> the ext ack error message? A couple of drivers are using it for XDP >>> mis-configuration reporting instead of printks. We should

Re: [PATCH net-next v4 0/2] bpf/tracing: allow user space to query prog array on the same tp

2017-12-11 Thread Daniel Borkmann
On 12/11/2017 08:39 PM, Yonghong Song wrote: > Commit e87c6bc3852b ("bpf: permit multiple bpf attachments > for a single perf event") added support to attach multiple > bpf programs to a single perf event. Given a perf event > (kprobe, uprobe, or kernel tracepoint), the perf ioctl interface > is

Re: [PATCH v3 net-next 0/9] net: Generic network resolver backend and ILA resolver

2017-12-11 Thread David Miller
From: Tom Herbert Date: Mon, 11 Dec 2017 14:16:17 -0800 > How can we build a system that allows an unlimited number of > resolutions without drop? IPV4 routing solves this with a prefixed trie, for example. The fundamental backing datastructure for the switching or

Re: [PATCH v3 17/33] nds32: VDSO support

2017-12-11 Thread Vincent Chen
2017-12-08 20:14 GMT+08:00 Mark Rutland : > On Fri, Dec 08, 2017 at 07:54:42PM +0800, Greentime Hu wrote: >> 2017-12-08 18:21 GMT+08:00 Mark Rutland : >> > On Fri, Dec 08, 2017 at 05:12:00PM +0800, Greentime Hu wrote: >> >> +static int

linux-next: build failure after merge of the mac80211-next tree

2017-12-11 Thread Stephen Rothwell
Hi Johannes, After merging the mac80211-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/mediatek/mt76/mt76x2_main.c:539:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .wake_tx_queue =

Re: [PATCH] selftests: bpf: Adding config fragment CONFIG_CGROUP_BPF=y

2017-12-11 Thread Daniel Borkmann
On 12/11/2017 08:25 PM, Naresh Kamboju wrote: > CONFIG_CGROUP_BPF=y is required for test_dev_cgroup test case. > > Signed-off-by: Naresh Kamboju Applied to bpf-next, thanks Naresh!

[PATCH v2] igb: Free IRQs when device is hotplugged

2017-12-11 Thread Lyude Paul
Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon hotplugging my kernel would immediately crash due to igb: [ 680.825801] kernel BUG at drivers/pci/msi.c:352! [ 680.828388] invalid opcode: [#1] SMP [ 680.829194] Modules linked in: igb(O) thunderbolt i2c_algo_bit

[PATCH bpf 0/3] Misc BPF fixes

2017-12-11 Thread Daniel Borkmann
Couple of outstanding fixes for BPF tree: 1) fixes a perf RB corruption, 2) and 3) fixes a few build issues from the recent bpf_perf_event.h uapi corrections. Thanks! Daniel Borkmann (3): bpf: fix corruption on concurrent perf_event_output calls bpf: fix build issues on um due to mising

[PATCH bpf 3/3] bpf: fix broken BPF selftest build

2017-12-11 Thread Daniel Borkmann
At least on x86_64, the kernel's BPF selftests seemed to have stopped to build due to 618e165b2a8e ("selftests/bpf: sync kernel headers and introduce arch support in Makefile"): [...] In file included from test_verifier.c:29:0: ../../../include/uapi/linux/bpf_perf_event.h:11:32: fatal

[PATCH bpf 2/3] bpf: fix build issues on um due to mising bpf_perf_event.h

2017-12-11 Thread Daniel Borkmann
Since c895f6f703ad ("bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type") um (uml) won't build on i386 or x86_64: [...] CC init/main.o In file included from ../include/linux/perf_event.h:18:0, from ../include/linux/trace_events.h:10,

[PATCH bpf 1/3] bpf: fix corruption on concurrent perf_event_output calls

2017-12-11 Thread Daniel Borkmann
When tracing and networking programs are both attached in the system and both use event-output helpers that eventually call into perf_event_output(), then we could end up in a situation where the tracing attached program runs in user context while a cls_bpf program is triggered on that same CPU

linux-next: manual merge of the net-next tree with the net tree

2017-12-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/meson-gxl.c between commit: f1e2400a80ff ("net: phy: meson-gxl: detect LPA corruption") from the net tree and commit: 80274abafc60 ("net: phy: remove generic settings for callbacks config_aneg and

[PATCH iproute2 net-next v2 1/4] ss: Replace printf() calls for "main" output by calls to helper

2017-12-11 Thread Stefano Brivio
This is preparation work for output buffering, which will allow us to use optimal spacing and alignment of logical "columns". The new out() function is just a re-implementation of a typical libc's printf(), except that the return value of vfprintf() is ignored as no callers use it. This

[PATCH iproute2 net-next v2 3/4] ss: Buffer raw fields first, then render them as a table

2017-12-11 Thread Stefano Brivio
This allows us to measure the maximum field length for each column before printing fields and will permit us to apply optimal field spacing and distribution. Structure of the output buffer with chunked allocation is described in comments. Output is still unchanged, original spacing is used.

[PATCH iproute2 net-next v2 4/4] ss: Implement automatic column width calculation

2017-12-11 Thread Stefano Brivio
Group fitting fields into lines and space them equally using the remaining screen width for each line. If columns don't fit on one line, break them into the least possible amount of lines and keep them aligned across lines. This is done by: - recording the length of the longest item in each

[PATCH iproute2 net-next v2 2/4] ss: Introduce columns lightweight abstraction

2017-12-11 Thread Stefano Brivio
Instead of embedding spacing directly while printing contents, logically declare columns and functions to buffer their content, to print left and right spacing around fields, to flush them to screen, and to print headers. This makes it a bit easier to handle layout changes and prepares for full

[PATCH iproute2 net-next v2 0/4] Abstract columns, properly space and wrap fields

2017-12-11 Thread Stefano Brivio
Currently, 'ss' simply subdivides the whole available screen width between available columns, starting from a set of hardcoded amount of spacing and growing column widths. This makes the output unreadable in several cases, as it doesn't take into account the actual content width. Fix this by

Re: [PATCH] igb: Free IRQs when device is hotplugged

2017-12-11 Thread Lyude Paul
On Mon, 2017-12-11 at 16:34 -0800, Stephen Hemminger wrote: > On Mon, 11 Dec 2017 18:45:02 -0500 > Lyude Paul wrote: > > > Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon > > hotplugging my kernel would immediately crash due to igb: > > > > [

RE: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-11 Thread Banerjee, Debabrata
> From: Pablo Neira Ayuso [mailto:pa...@netfilter.org] > On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote: > > + } else { > > + /* Implicit handling for NF_STOLEN, as well as any other > > +* non conventional verdicts. > > +*/ > > +

Re: [PATCH] igb: Free IRQs when device is hotplugged

2017-12-11 Thread Stephen Hemminger
On Mon, 11 Dec 2017 18:45:02 -0500 Lyude Paul wrote: > Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon > hotplugging my kernel would immediately crash due to igb: > > [ 680.825801] kernel BUG at drivers/pci/msi.c:352! > [ 680.828388] invalid opcode:

[PATCH net-next v3 5/6] net: qualcomm: rmnet: Allow to configure flags for new devices

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Add an option to configure the rmnet aggregation and command features on device creation. This is achieved by using the vlan flags option. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 16 +--- 1 file

[PATCH net-next v3 1/6] net: qualcomm: rmnet: Remove the rmnet_map_results enum

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Only the success and consumed entries were actually in use. Use standard error codes instead. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 15 +++ drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h

[PATCH net-next v3 0/6] net: qualcomm: rmnet: Configuration options

2017-12-11 Thread Subash Abhinov Kasiviswanathan
This series adds support for configuring features on rmnet devices. The rmnet specific features to be configured here are aggregation and control commands. Patch 1 is a cleanup of return codes in the transmit path. Patch 2 removes some redundant ingress and egress macros. Patch 3 restricts the

[PATCH net-next v3 2/6] net: qualcomm: rmnet: Remove the some redundant macros

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Multiplexing is always enabled when transmiting from a rmnet device, so remove the redundant egress macros. De-multiplexing is always enabled when receiving packets from a rmnet device, so remove those ingress macros. Signed-off-by: Subash Abhinov Kasiviswanathan ---

[PATCH net-next v3 6/6] net: qualcomm: rmnet: Allow to configure flags for existing devices

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Add an option to configure the mux id, aggregation and commad feature for existing rmnet devices. Implement the changelink netlink operation for this. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 40

[PATCH net-next v3 4/6] net: qualcomm: rmnet: Process packets over ethernet

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Add support to send and receive packets over ethernet. An example of usage is testing the data path on UML. This can be achieved by setting up two UML instances in multicast mode and associating rmnet over the UML ethernet device. Signed-off-by: Subash Abhinov Kasiviswanathan

[PATCH net-next v3 3/6] net: qualcomm: rmnet: Allow only one rmnet dev per muxid per real dev

2017-12-11 Thread Subash Abhinov Kasiviswanathan
Upon de-multiplexing data from one real dev, the packets can be sent to an unique rmnet device for a given mux id. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-11 Thread Pablo Neira Ayuso
Hi, Thanks for catching up this, see below. On Mon, Dec 11, 2017 at 06:30:24PM -0500, Debabrata Banerjee wrote: > A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value > and a potential kernel panic via double free of skb's > > This was broken by commit 7034b566a4e7

Re: [PATCH iproute2 net-next 0/4] Abstract columns, properly space and wrap fields

2017-12-11 Thread Stephen Hemminger
On Fri, 8 Dec 2017 18:07:19 +0100 Stefano Brivio wrote: > Currently, 'ss' simply subdivides the whole available screen width > between available columns, starting from a set of hardcoded amount > of spacing and growing column widths. > > This makes the output unreadable in

Re: [PATCH iproute2 1/1] ss: remove duplicate assignment

2017-12-11 Thread Stephen Hemminger
On Mon, 11 Dec 2017 16:24:31 -0500 Roman Mashak wrote: > Signed-off-by: Roman Mashak Applied and added Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output")

[PATCH] igb: Free IRQs when device is hotplugged

2017-12-11 Thread Lyude Paul
Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon hotplugging my kernel would immediately crash due to igb: [ 680.825801] kernel BUG at drivers/pci/msi.c:352! [ 680.828388] invalid opcode: [#1] SMP [ 680.829194] Modules linked in: igb(O) thunderbolt i2c_algo_bit

[PATCH net-next] tcp: allow TLP in ECN CWR

2017-12-11 Thread Yuchung Cheng
From: Neal Cardwell This patch enables tail loss probe in cwnd reduction (CWR) state to detect potential losses. Prior to this patch, since the sender uses PRR to determine the cwnd in CWR state, the combination of CWR+PRR plus tcp_tso_should_defer() could cause unnecessary

Re: [PATCH net-next v5 2/2] net: thunderx: add timestamping support

2017-12-11 Thread Richard Cochran
On Mon, Dec 11, 2017 at 05:14:31PM +0300, Aleksey Makarov wrote: > @@ -880,6 +889,46 @@ static void nic_pause_frame(struct nicpf *nic, int vf, > struct pfc *cfg) > } > } > > +/* Enable or disable HW timestamping by BGX for pkts received on a LMAC */ > +static void

[Patch net-next] net_sched: switch to exit_batch for action pernet ops

2017-12-11 Thread Cong Wang
Since we now hold RTNL lock in tc_action_net_exit(), it is good to batch them to speedup tc action dismantle. Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Cong Wang --- include/net/act_api.h | 13 ++---

[PATCH] Fix handling of verdicts after NF_QUEUE

2017-12-11 Thread Debabrata Banerjee
A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value and a potential kernel panic via double free of skb's This was broken by commit 7034b566a4e7 ("netfilter: fix nf_queue handling") and subsequently fixed in v4.10 by commit c63cbc460419 ("netfilter: use switch() to handle

Re: [PATCH net-next v5 2/2] net: thunderx: add timestamping support

2017-12-11 Thread Richard Cochran
On Mon, Dec 11, 2017 at 05:14:31PM +0300, Aleksey Makarov wrote: > diff --git a/drivers/net/ethernet/cavium/thunder/nic.h > b/drivers/net/ethernet/cavium/thunder/nic.h > index 4a02e618e318..204b234beb9d 100644 > --- a/drivers/net/ethernet/cavium/thunder/nic.h > +++

[PATCH v3] net: ethernet: arc: fix error handling in emac_rockchip_probe

2017-12-11 Thread Branislav Radocaj
If clk_set_rate() fails, we should disable clk before return. Found by Linux Driver Verification project (linuxtesting.org). Changes since v2 [1]: * Merged with latest code changes Changes since v1: Update made thanks to David's review, much appreciated David. * Improved inconsistent failure

Re: [PATCH 1/3] PCI: introduce a device-managed version of pci_set_mwi

2017-12-11 Thread Bjorn Helgaas
On Sun, Dec 10, 2017 at 12:43:48AM +0100, Heiner Kallweit wrote: > Introduce a device-managed version of pci_set_mwi. First user is the > Realtek r8169 driver. > > Signed-off-by: Heiner Kallweit With the subject and changelog as follows and the code reordering below,

Re: [PATCH v3 net-next 0/9] net: Generic network resolver backend and ILA resolver

2017-12-11 Thread Tom Herbert
On Mon, Dec 11, 2017 at 2:16 PM, Tom Herbert wrote: > On Mon, Dec 11, 2017 at 1:34 PM, David Miller wrote: >> From: Tom Herbert >> Date: Mon, 11 Dec 2017 12:38:28 -0800 >> >>> DOS mitigations: >>> >>> - The number of outstanding

Re: Huge memory leak with 4.15.0-rc2+

2017-12-11 Thread Paweł Staszewski
W dniu 2017-12-11 o 23:15, John Fastabend pisze: On 12/11/2017 01:48 PM, Paweł Staszewski wrote: W dniu 2017-12-11 o 22:23, Paweł Staszewski pisze: Hi I just upgraded some testing host to 4.15.0-rc2+ kernel And after some time of traffic processing - when traffic on all ports reach about

Re: Huge memory leak with 4.15.0-rc2+

2017-12-11 Thread John Fastabend
On 12/11/2017 01:48 PM, Paweł Staszewski wrote: > > > W dniu 2017-12-11 o 22:23, Paweł Staszewski pisze: >> Hi >> >> >> I just upgraded some testing host to 4.15.0-rc2+ kernel >> >> And after some time of traffic processing - when traffic on all ports >> reach about 3Mpps - memleak started. >>

Re: [PATCH v3 net-next 0/9] net: Generic network resolver backend and ILA resolver

2017-12-11 Thread Tom Herbert
On Mon, Dec 11, 2017 at 1:34 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 11 Dec 2017 12:38:28 -0800 > >> DOS mitigations: >> >> - The number of outstanding resolutions is limited by the size of the >> table >> - Timeout of pending entries

Re: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise

2017-12-11 Thread Willem de Bruijn
On Mon, Dec 11, 2017 at 4:44 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 11, 2017 at 04:25:26PM -0500, Willem de Bruijn wrote: >> Note that UFO was removed in 4.14 and that skb_warn_bad_offload >> can happen for various types of packets, so there may be multiple >>

Re: [PATCH v5] leds: trigger: Introduce a NETDEV trigger

2017-12-11 Thread Jacek Anaszewski
Hi Ben, Thanks for the update. On 12/10/2017 10:17 PM, Ben Whitten wrote: > This commit introduces a NETDEV trigger for named device > activity. Available triggers are link, rx, and tx. > > Signed-off-by: Ben Whitten > > --- > Changes in v5: > Adjust header comment

Re: Huge memory leak with 4.15.0-rc2+

2017-12-11 Thread Paweł Staszewski
W dniu 2017-12-11 o 22:23, Paweł Staszewski pisze: Hi I just upgraded some testing host to 4.15.0-rc2+ kernel And after some time of traffic processing - when traffic on all ports reach about 3Mpps - memleak started. Graph attached from memory usage: https://ibb.co/idK4zb HW config:

Re: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise

2017-12-11 Thread Greg Kroah-Hartman
On Mon, Dec 11, 2017 at 04:25:26PM -0500, Willem de Bruijn wrote: > Note that UFO was removed in 4.14 and that skb_warn_bad_offload > can happen for various types of packets, so there may be multiple > independent bug reports. I'm investigating two other non-UFO reports > just now. Meta-comment,

Re: [PATCH v3 net-next 0/9] net: Generic network resolver backend and ILA resolver

2017-12-11 Thread David Miller
From: Tom Herbert Date: Mon, 11 Dec 2017 12:38:28 -0800 > DOS mitigations: > > - The number of outstanding resolutions is limited by the size of the > table > - Timeout of pending entries limits the number of netlink resolution > messages > - Packets are not queued that

Huge memory leak with 4.15.0-rc2+

2017-12-11 Thread Paweł Staszewski
Hi I just upgraded some testing host to 4.15.0-rc2+ kernel And after some time of traffic processing - when traffic on all ports reach about 3Mpps - memleak started. Graph attached from memory usage: https://ibb.co/idK4zb HW config: Intel E5 8x Intel 82599 (used ixgbe driver from

Re: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise

2017-12-11 Thread David Miller
From: Joseph Salisbury Date: Mon, 11 Dec 2017 15:35:34 -0500 > A kernel bug report was opened against Ubuntu [0].  It was found that > reverting the following commit resolved this bug: > > commit b2504a5dbef3305ef41988ad270b0e8ec289331c > Author: Eric Dumazet

Re: [REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise

2017-12-11 Thread Willem de Bruijn
On Mon, Dec 11, 2017 at 3:35 PM, Joseph Salisbury wrote: > Hi Eric, > > A kernel bug report was opened against Ubuntu [0]. It was found that > reverting the following commit resolved this bug: The recorded trace in that bug is against 4.10.0 with some backports.

[PATCH iproute2 1/1] ss: remove duplicate assignment

2017-12-11 Thread Roman Mashak
Signed-off-by: Roman Mashak --- misc/ss.c | 1 - 1 file changed, 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 90da93e..da52d5e 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -2306,7 +2306,6 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-12-11 Thread Sebastian Sjoholm
Hi, Sorry for the re-email of the patch below, clearly a beginners mistake of me not to clear my tmp/ folder. Please disregard this. Regards, Sebastian > On Dec 11, 2017, at 21:12 , ssjoh...@mac.com wrote: > > From: Sebastian Sjoholm > > Quectel BG96 is an Qualcomm

[PATCH ipsec-next] xfrm: check for xdo_dev_state_free

2017-12-11 Thread Shannon Nelson
The current XFRM code assumes that we've implemented the xdo_dev_state_free() callback, even if it is meaningless to the driver. This patch adds a check for it before calling, as done in other APIs, and is done for the xdo_state_offload_ok() callback. Also, we add a check for the required add and

[PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. Signed-off-by: Sebastian Sjoholm Acked-by: Bjørn Mork --- [The corresponding

[REGRESSION][4.13.y][4.14.y][v4.15.y] net: reduce skb_warn_bad_offload() noise

2017-12-11 Thread Joseph Salisbury
Hi Eric, A kernel bug report was opened against Ubuntu [0].  It was found that reverting the following commit resolved this bug: commit b2504a5dbef3305ef41988ad270b0e8ec289331c Author: Eric Dumazet Date:   Tue Jan 31 10:20:32 2017 -0800     net: reduce

[PATCH v3 net-next 1/9] lwt: Add net to build_state argument

2017-12-11 Thread Tom Herbert
Users of LWT need to know net if they want to have per net operations in LWT. Signed-off-by: Tom Herbert --- include/net/lwtunnel.h| 6 +++--- net/core/lwt_bpf.c| 2 +- net/core/lwtunnel.c | 4 ++-- net/ipv4/fib_semantics.c | 13 -

[PATCH v3 net-next 7/9] ila: Resolver mechanism

2017-12-11 Thread Tom Herbert
Implement an ILA resolver. This uses LWT to implement the hook to a userspace resolver and tracks pending unresolved address using the backend net resolver. The idea is that the kernel sets an ILA resolver route to the SIR prefix, something like: ip route add ::/64 encap ila-resolve \

[PATCH v3 net-next 9/9] ila: add netlink control ILA resolver

2017-12-11 Thread Tom Herbert
Add a netlink family to processe netlinkf for the ILA resolver. This calls the net resolver netlink functions. Signed-off-by: Tom Herbert --- include/uapi/linux/ila.h| 11 net/ipv6/ila/ila.h | 8 ++ net/ipv6/ila/ila_main.c | 26

[PATCH v3 net-next 6/9] net: Generic resolver backend

2017-12-11 Thread Tom Herbert
This patch implements the backend of a resolver, specifically it provides a means to track unresolved addresses and expire entries based on timeout. The resolver is mostly a frontend to an rhashtable where the key of the table is whatever address type or object is tracked. A resolver instance is

[PATCH v3 net-next 5/9] ila: Flush netlink command to clear xlat table

2017-12-11 Thread Tom Herbert
Add ILA_CMD_FLUSH netlink command to clear the ILA translation table. Signed-off-by: Tom Herbert --- include/uapi/linux/ila.h | 1 + net/ipv6/ila/ila.h | 1 + net/ipv6/ila/ila_main.c | 6 + net/ipv6/ila/ila_xlat.c | 62

[PATCH v3 net-next 8/9] resolver: add netlink control

2017-12-11 Thread Tom Herbert
Add interfaces into resolver backend that can be used to provide netlink. The interface includes fucntions to support the common netlink commands (get, add, list, delete, and flush). The frontend that is using the resolver implements the actual netlink interfaces for its service and calls the

[PATCH v3 net-next 4/9] ila: create main ila source file

2017-12-11 Thread Tom Herbert
Create a main ila file that contains the module intialization functions as well as netlink definitions. Previously these were defined in ila_xlat and ila_common. This approach allows better extensibility. Signed-off-by: Tom Herbert --- net/ipv6/ila/Makefile | 2 +-

[PATCH v3 net-next 3/9] ila: Call library function alloc_bucket_locks

2017-12-11 Thread Tom Herbert
To allocate the array of bucket locks for the hash table we now call library function alloc_bucket_spinlocks. Signed-off-by: Tom Herbert --- net/ipv6/ila/ila_xlat.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git

[PATCH v3 net-next 0/9] net: Generic network resolver backend and ILA resolver

2017-12-11 Thread Tom Herbert
This patch implements generic in-kernel network resolver. The idea is that an LWT "resolver" route is set in the kernel to cover some prefix. When a packet hits the route a netlink message is fired to request resolution and pending resolutions are tracked in a table. Route resolution works in the

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread Bjørn Mork
ssjoh...@mac.com writes: > From: Sebastian Sjoholm > > From: Sebastian Sjoholm > > Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. > The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. > > Signed-off-by: Sebastian

[PATCH v3 net-next 2/9] ila: Fix use of rhashtable walk in ila_xlat.c

2017-12-11 Thread Tom Herbert
Perform better EAGAIN handling, handle case where ila_dump_info fails and we miss mis objects in the dump, and add a skip index to skip over ila entires in a list on a rhashtable node that have already been visited (by a previous call to ila_nl_dump). Signed-off-by: Tom Herbert

Re: [PATCH next] ipvlan: add L2 check for packets arriving via virtual devices

2017-12-11 Thread David Miller
From: Mahesh Bandewar (महेश बंडेवार) Date: Mon, 11 Dec 2017 11:38:04 -0800 > On Mon, Dec 11, 2017 at 8:15 AM, David Miller wrote: >> From: Mahesh Bandewar >> Date: Thu, 7 Dec 2017 15:15:43 -0800 >> >>> From: Mahesh Bandewar

[PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm From: Sebastian Sjoholm Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. Signed-off-by: Sebastian Sjoholm --- [The

[PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The USB id is added to qmi_wwan.c to allow QMI communication with the BG96. Signed-off-by:

Re: [PATCH] selftests: bpf: Adding config fragment CONFIG_CGROUP_BPF=y

2017-12-11 Thread Roman Gushchin
Hi Naresh, Looks good! Thanks! On Tue, Dec 12, 2017 at 12:55:23AM +0530, Naresh Kamboju wrote: > CONFIG_CGROUP_BPF=y is required for test_dev_cgroup test case. > > Signed-off-by: Naresh Kamboju > --- > tools/testing/selftests/bpf/config | 1 + > 1 file changed, 1

Re: [PATCH] Revert "ravb: add workaround for clock when resuming with WoL enabled"

2017-12-11 Thread Sergei Shtylyov
Hello! On 12/11/2017 11:54 AM, Geert Uytterhoeven wrote: This reverts commit fbf3d034f2ff6264183cfa6845770e8cc2a986c8. As of commit 560869100b99a3da ("clk: renesas: cpg-mssr: Restore module clocks during resume"), the workaround is no longer needed. Signed-off-by: Geert Uytterhoeven

[PATCH net-next v4 1/2] bpf/tracing: allow user space to query prog array on the same tp

2017-12-11 Thread Yonghong Song
Commit e87c6bc3852b ("bpf: permit multiple bpf attachments for a single perf event") added support to attach multiple bpf programs to a single perf event. Although this provides flexibility, users may want to know what other bpf programs attached to the same tp interface. Besides getting

[PATCH net-next v4 2/2] bpf/tracing: add a bpf test for new ioctl query interface

2017-12-11 Thread Yonghong Song
Added a subtest in test_progs. The tracepoint is sched/sched_switch. Multiple bpf programs are attached to this tracepoint and the query interface is exercised. Signed-off-by: Yonghong Song Acked-by: Alexei Starovoitov Acked-by: Peter Zijlstra (Intel)

[PATCH net-next v4 0/2] bpf/tracing: allow user space to query prog array on the same tp

2017-12-11 Thread Yonghong Song
Commit e87c6bc3852b ("bpf: permit multiple bpf attachments for a single perf event") added support to attach multiple bpf programs to a single perf event. Given a perf event (kprobe, uprobe, or kernel tracepoint), the perf ioctl interface is used to query bpf programs attached to the same trace

Re: [PATCH next] ipvlan: add L2 check for packets arriving via virtual devices

2017-12-11 Thread महेश बंडेवार
On Mon, Dec 11, 2017 at 8:15 AM, David Miller wrote: > From: Mahesh Bandewar > Date: Thu, 7 Dec 2017 15:15:43 -0800 > >> From: Mahesh Bandewar >> >> Packets that don't have dest mac as the mac of the master device should >> not be

Re: RFC(v2): Audit Kernel Container IDs

2017-12-11 Thread Steve Grubb
On Monday, December 11, 2017 11:30:57 AM EST Eric Paris wrote: > > Because a container doesn't have to use namespaces to be a container > > you still need a mechanism for a process to declare that it is in > > fact > > in a container, and to identify the container. > > I like the idea but I'm

Re: [PATCH v2] vsock.7: document VSOCK socket address family

2017-12-11 Thread Michael Kerrisk (man-pages)
On 12/06/2017 03:06 PM, Jorgen S. Hansen wrote: > >> On Dec 5, 2017, at 11:56 AM, Stefan Hajnoczi wrote: >> >> The AF_VSOCK address family has been available since Linux 3.9 without a >> corresponding man page. >> >> This patch adds vsock.7 and describes its use along the

Re: [PATCH v2] vsock.7: document VSOCK socket address family

2017-12-11 Thread Michael Kerrisk (man-pages)
Hello Stefan, Thanks for this page! I have applied your patch, and made a few tweaks, but I have some minor questions. Please see below. On 12/05/2017 11:56 AM, Stefan Hajnoczi wrote: > The AF_VSOCK address family has been available since Linux 3.9 without a > corresponding man page. > > This

[PATCH] selftests: bpf: Adding config fragment CONFIG_CGROUP_BPF=y

2017-12-11 Thread Naresh Kamboju
CONFIG_CGROUP_BPF=y is required for test_dev_cgroup test case. Signed-off-by: Naresh Kamboju --- tools/testing/selftests/bpf/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config index

[PATCH] net/tls: Fix inverted error codes to avoid endless loop

2017-12-11 Thread r . hering
sendfile() calls can hang endless with using Kernel TLS if a socket error occurs. Socket error codes must be inverted by Kernel TLS before returning because they are stored with positive sign. If returned non-inverted they are interpreted as number of bytes sent, causing endless looping of the

Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-11 Thread David Miller
From: Linus Walleij Date: Sun, 10 Dec 2017 23:45:58 +0100 > diff --git a/drivers/net/ethernet/cortina/Kconfig > b/drivers/net/ethernet/cortina/Kconfig > new file mode 100644 > index ..7d279ac4357d > --- /dev/null > +++ b/drivers/net/ethernet/cortina/Kconfig

  1   2   3   >