On Wed, Aug 29, 2018 at 07:06:09PM +0200, Hans de Goede wrote:
> > What a nice stuff, thanks!
> >
> > Reviewed-by: Andy Shevchenko
>
> Thank you (and also thank you for the other reviews)
>
> > Btw, you probably better to refer to
> > https://bugzilla.
to hardware where the r8169 actually needs
> the pmc_plt_clk_4 I have not been able to test this, hence it is marked
> as RFC for now.
>
What a nice stuff, thanks!
Reviewed-by: Andy Shevchenko
Btw, you probably better to refer to
https://bugzilla.kernel.org/show_bug.cgi?id=196861 which
you encounter this null pointer deref?
>
> Is this happen even when there is not wifi firmware?
> boot without any firmware in the filesystem and then trigger a reboot
Something like the above I had noticed for a long (couple of kernel
releases?) time, but wasn't a big priority to me.
Though, I can test this on my side.
P.S. I think rmmod or echo > unbind will trigger that as well.
--
With Best Regards,
Andy Shevchenko
On Tue, May 22, 2018 at 6:30 AM, Yisheng Xie <xieyishe...@huawei.com> wrote:
>> But it's up tu Loca.
Shame on me. I meant Luca, of course!
Luca, sorry.
> OK, I will change it if Loca agree your opinion.
--
With Best Regards,
Andy Shevchenko
t;
bt_force_... = ret;
But it's up tu Loca.
>
> ret = 0;
--
With Best Regards,
Andy Shevchenko
ion, ARRAY_SIZE(cudbg_region),
> region_name);
> + if (rc < 0)
> + return rc;
>
> - found = 0;
> + idx = rc;
Is found still in use after this?
If so, is it initialized properly now?
--
With Best Regards,
Andy Shevchenko
v, "unable to find platform device for %s\n",
> + of_node_full_name(node));
Sorry, isn't %pOF works for this?
--
With Best Regards,
Andy Shevchenko
se {
> + kthread_run(device_shutdown_child_task,
> + , "device_shutdown.%s",
> + dev_name(dev));
> + }
> + }
Can't we just use device_for_each_child() instead?
> + wait_for_completion();
> + }
> + device_shutdown_one(dev);
> + device_unlock(dev);
> +}
--
With Best Regards,
Andy Shevchenko
time.
But this is kinda synthetic test, right?
If you run in a normal use case where kernel not only collecting logs,
but doing something else, especially with frequent userspace
interaction, would be trend the same?
--
With Best Regards,
Andy Shevchenko
g on your side should be done.
--
With Best Regards,
Andy Shevchenko
target so that a bit of common code can be better reused
>> at the end of this function.
>
> Please stop mindlessly sending patching Markus.
>
> How about looking at the code being modified and
> thinking about what it does?
You have a strong nerve, I gave up on him and would rather simple ban.
--
With Best Regards,
Andy Shevchenko
On Thu, 2018-03-01 at 21:36 +0100, Heiner Kallweit wrote:
> Am 01.03.2018 um 21:15 schrieb Andy Shevchenko:
> > On Thu, 2018-03-01 at 20:54 +0100, Heiner Kallweit wrote:
> > > Am 01.03.2018 um 12:27 schrieb Andy Shevchenko:
> > > > - rc = pci_re
On Thu, 2018-03-01 at 21:01 +0100, Heiner Kallweit wrote:
> Am 01.03.2018 um 12:27 schrieb Andy Shevchenko:
> > Next step might be a conversion of RTL_Wxx() / RTL_Rxx() macros
> > to inline functions for sake of type checking.
^
> > /* write/read MMIO register */
&g
On Thu, 2018-03-01 at 20:54 +0100, Heiner Kallweit wrote:
> Am 01.03.2018 um 12:27 schrieb Andy Shevchenko:
> > - rc = pci_request_regions(pdev, MODULENAME);
> > + rc = pcim_iomap_regions(pdev, BIT(region), MODULENAME);
> > if (rc < 0) {
> > - ne
This is a follow up to the commit
4c45d24a759d ("r8169: switch to device-managed functions in probe")
to move towards managed resources even more.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
driver
for sake of type checking.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- rebased on top of last r8169.c changes
drivers/net/ethernet/realtek/r8169.c | 865 ++-
1 file changed, 335 insert
for sake of type checking.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- rebased on top of latest linux-next
drivers/net/ethernet/realtek/r8169.c | 865 ++-
1 file changed, 335 insert
This is a follow up to the commit
4c45d24a759d ("r8169: switch to device-managed functions in probe")
to move towards managed resources even more.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
driver
bail in the loop, indeed.
>
> Reviewed-by: Alexey Dobriyan <adobri...@gmail.com>
Since the author is okay with the change, I'm following:
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
ff;
> + ether_addr_copy(vf->data.tcp_spec.dst_mac,
> key->dst);
Instead, keep two pointers:
... *pointer_mask = >mask.tcp_spec;
... *pointer_data = >data.tcp_spec;
--
With Best Regards,
Andy Shevchenko
On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King
<colin.k...@canonical.com> wrote:
> On 16/02/18 16:51, Andy Shevchenko wrote:
>> On Thu, Feb 15, 2018 at 9:42 PM, Colin King <colin.k...@canonical.com> wrote:
>>> + fi
i = 0; i < 4; i++)
> + filter->f.mask.tcp_spec.src_ip[i] |=
>
> cpu_to_be32(0x);
Ditto.
> + memcpy(>f.data.tcp_spec.src_ip,
> + >src.s6_addr32,
Ditto.
> + sizeof(filter->f.data.tcp_spec.src_ip));
--
With Best Regards,
Andy Shevchenko
for sake of type checking.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/realtek/r8169.c | 877 ++-
1 file changed, 341 insertions(+), 536 deletions(-)
diff --git a
This is a follow up to the commit
4c45d24a759d ("r8169: switch to device-managed functions in probe")
to move towards managed resources even more.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
driver
On Sun, 2018-02-04 at 21:29 +0200, Andy Shevchenko wrote:
> This is a follow up to the commit
>
> 4c45d24a759d ("r8169: switch to device-managed functions in probe")
>
> to move towards managed resources even more.
>
Oops, sorry, it's not ready-yet version.
&g
This is a follow up to the commit
4c45d24a759d ("r8169: switch to device-managed functions in probe")
to move towards managed resources even more.
Cc: Heiner Kallweit <hkallwe...@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
driver
read
> - q = >ack_wait_queue;
> spin_lock_irqsave(>lock, flags);
>
> skb_queue_walk(q, skb) {
--
With Best Regards,
Andy Shevchenko
On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote:
>
> On 12/21/2017 03:40 PM, Andy Shevchenko wrote:
> > Replace sscanf() with mac_pton().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
>
> Acked-by: Hauke Mehrtens <ha..
data->rxring, data->rxdma);
> - dma_free_coherent(0,
> + dma_free_coherent(>pdev->dev,
> TSI108_TXRING_LEN * sizeof(tx_desc),
> data->txring, data->txdma);
>
> @@ -1576,6 +1579,7 @@ tsi108_init_one(struct platform_device *pdev)
> printk("tsi108_eth%d: probe...\n", pdev->id);
> data = netdev_priv(dev);
> data->dev = dev;
> + data->pdev = pdev;
>
>
> pr_debug("tsi108_eth%d:regs:phyresgs:phy:irq_num=0x%x:0x%x:0x%x:0x%x\n",
> pdev->id, einfo->regs, einfo->phyregs,
> --
> 2.14.2
>
--
With Best Regards,
Andy Shevchenko
ds on size in the call sites that do not have those
> yet -
> that'll require comments from maintainers of the code in question in some
> cases.
>
> Objections?
Not at all!
--
With Best Regards,
Andy Shevchenko
p above pattern (same
style over the piece of code / function).
> return;
> }
> if (*addr->sas_addr.prv) {
> --
> 2.15.1
>
P.S. I'm wondering what would be first, Markus starts looking into the
actual code, or most (all) of the maintainers just ban him.
--
With Best Regards,
Andy Shevchenko
.cocci
> 0-day tested with no failures.
>
Makes sense.
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
> Suggested-by: Luis R. Rodriguez <mcg...@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
> ---
> .../net/wireless/broadcom/brcm8021
Replace sscanf() with mac_pton().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- use negative condition to be consistent with the rest code
drivers/firmware/broadcom/Kconfig | 1 +
drivers/firmware/broadcom/bcm47xx_sprom.c | 18 +++---
2
, thanks for taking care of update.
David, please, consider this one to be applied.
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Signed-off-by: Jie Deng <jied...@synopsys.com>
> ---
> drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 24 +++---
Get rid of yet another custom hex_dump_to_buffer().
The output is slightly changed, i.e. each byte followed by white space.
Note, we don't use print_hex_dump() here since the original code uses
nedev_dbg().
Acked-by: Tom Lendacky <thomas.lenda...@amd.com>
Signed-off-by: Andy Shev
On Tue, 2017-12-19 at 11:21 -0800, Randy Dunlap wrote:
> On 12/19/2017 10:10 AM, Andy Shevchenko wrote:
> > Use
> > %pM to print MAC
> > mac_pton() to convert it from ASCII to binary format, and
> > ether_addr_copy() to copy.
> >
> > Signed-
On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote:
> On 12/19/2017 10:31 AM, Andy Shevchenko wrote:
> > Replace sscanf() with mac_pton().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
>
> You don't need to select GENER
Replace copy_from_user() + sscanf() with mac_pton_from_user().
While here, replace memcpy(..., ETH_ALEN) with ether_addr_copy().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 18 ++
1 file chan
Some drivers are getting MAC from user space. Make a helper for them.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
include/linux/kernel.h | 1 +
lib/net_utils.c| 12
2 files changed, 13 insertions(+)
diff --git a/include/linux/kernel.h b/i
Replace copy_from_user() + mac_pton() with mac_pton_from_user().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/r
We have not been caring about garbage at the end of input string and this
change doesn't affect it. What we prevent here is possibility to go over
boundaries when input string is not NULL terminated at all.
Allow mac_pton() work on non-NULL terminated strings.
Signed-off-by: Andy Shevchenko
Replace sscanf() with mac_pton().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c
b/drivers/net/ethernet/
Replace sscanf() with mac_pton().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/bonding/bond_options.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/bonding/bond_options.c
b/drivers/net/bonding/bond_options.c
Use
%pM to print MAC
mac_pton() to convert it from ASCII to binary format, and
ether_addr_copy() to copy.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
net/bridge/br_sysfs_br.c | 13 +++--
1 file changed, 3 insertions(+), 10 del
Get rid of yet another custom hex_dump_to_buffer().
The output is slightly changed, i.e. each byte followed by white space.
Note, we don't use print_hex_dump() here since the original code uses
nedev_dbg().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drive
Get rid of yet another custom hex_dump_to_buffer().
The output is slightly changed, i.e. each byte followed by white space.
Note, we don't use print_hex_dump() here since the original code uses
nedev_dbg().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drive
On Tue, 2017-12-19 at 07:17 -0500, Sinan Kaya wrote:
> On 12/19/2017 5:45 AM, Andy Shevchenko wrote:
> > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote:
> > >
> > pci_get_bus_and_slot() still might be useful for the wired devices
> > in
> > SoC whe
slot() function in favor of
> pci_get_domain_bus_and_slot().
>
Where this idea come from?
pci_get_bus_and_slot() still might be useful for the wired devices in
SoC where we know for sure that domain == 0.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c
> index a319bf1e49de..ef5c16dfabfa 100644
Acked-by: Andy Shevchenko <andy.shevche...@gmail.com>
for PDx86 changes.
--
With Best Regards,
Andy Shevchenko
On Tue, 2017-11-28 at 14:19 +0200, Andy Shevchenko wrote:
> On Tue, 2017-11-28 at 09:43 +0100, Marcel Holtmann wrote:
> > Hi Andy,
> >
> > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for
> > > current
> > > users, which are many of
Instead of open coding byte-by-byte printing, re-use %*ph specifier.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
net/bluetooth/hci_debugfs.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/net/bluetooth/hci_debugfs.c
rstand what's wrong
with carrying patch against seq_file.h? Is it "person non grata"?
[1]: https://marc.info/?l=linux-bluetooth=151138535801354=2
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
up of hci_debugfs.c
Andy Shevchenko (2):
seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro
Bluetooth: Re-use DEFINE_SHOW_ATTRIBUTE() macro
include/linux/seq_file.h| 13 +++
net/bluetooth/hci_debugfs.c | 193
2 files changed, 29 inserti
The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current
users, which are many of them, and for new comers to decrease code
duplication.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
include/linux/seq_file.h | 13 +
1 file changed, 13 inse
...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
net/bluetooth/hci_debugfs.c | 193
1 file changed, 16 insertion
:310: recipe for target
'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed
Seems like something happened with W=1 and wrong kernel doc format.
As a quick fix remove dubious /** in the code.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/wi
On Wed, 2017-11-22 at 14:13 -0800, Randy Dunlap wrote:
> On 11/22/2017 02:04 PM, Randy Dunlap wrote:
> > On 11/22/2017 01:15 PM, Andy Shevchenko wrote:
> > > This macro deduplicates a lot of similar code across the
> > > hci_debugfs.c
> > > module. Targeting
This macro deduplicates a lot of similar code across the hci_debugfs.c
module. Targeting to be moved to seq_file.h eventually.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
net/bluetooth/hci_debugfs.c | 184 +---
1 file chang
Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
While this looks okay per se now, it would be good if you put version
of the patch and add a changelog to it.
I think no need to resend this one, just for your information.
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com&
It looks like the best place in MAINTAINERS data base to cover this
orphaned module.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0630482e701b..474321873fc1
This removes custom flag handling.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h| 3 +-
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 42 +-
2 files changed, 17 insertions(+), 28 del
On Fri, 2017-10-13 at 20:02 +0300, Andy Shevchenko wrote:
> This removes custom flag handling.
Please, discard this one, slipped to early.
>
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> ---
> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h
This removes custom flag handling.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h| 3 +-
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 42 +-
2 files changed, 17 insertions(+), 28 del
The sysfs enabled value is a boolean, so kstrtobool() is a better fit
for parsing the input string since it does the range checking for us.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/s390/net/qeth_l2_sys.c | 13 +
1 file changed, 5 insertions
On Tue, Oct 3, 2017 at 4:22 AM, Jérémy Lefaure
<jeremy.lefa...@lse.epita.fr> wrote:
> On Mon, 2 Oct 2017 16:07:36 +0300
> Andy Shevchenko <andy.shevche...@gmail.com> wrote:
>
>> > + {_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0),
>> > 26
ore0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26,
> 192,
> +32},
For all such cases I would rather put on one line disregard checkpatch
warning for better readability.
--
With Best Regards,
Andy Shevchenko
On Mon, 2017-10-02 at 13:38 +0300, Mika Westerberg wrote:
> These messages are all 32-byte aligned and they should be packed
Obviously 32-bit.
Other than that,
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> without
> the __packed attribute just fine.
is done automatically (as those systems
> have
> the networking service enabled by default). For Linux to Linux
> connection
> one host needs to load the networking driver first (so that the other
> side
> can locate the networking service and load the corresponding driver).
Looks awesome!
Re
ttribute irst_timeout_attr = {
> +static const struct device_attribute irst_timeout_attr = {
> .attr = { .name = "wakeup_time", .mode = 0600 },
> .show = irst_show_wakeup_time,
> .store = irst_store_wakeup_time
> --
> 1.9.1
>
--
With Best Regards,
Andy Shevchenko
ing to be v3, just to mention that IIRC we better not to
use PCI DMA mapping API in favour of generic DMA mapping API.
Can you please double check this?
--
With Best Regards,
Andy Shevchenko
-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
- resend after v4.13-rc1 is out
drivers/isdn/hardware/eicon/divacapi.h | 16 +--
drivers/isdn/hardware/eicon/message.c | 247 -
2 files changed, 58 insertions(+), 205 deletions(-)
diff --git a/d
On Fri, Jul 14, 2017 at 10:37 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko
> <andy.shevche...@gmail.com> wrote:
>> On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann <a...@arndb.de> wrote:
>>> gcc points out a poss
+ b/drivers/platform/x86/alienware-wmi.c
> @@ -421,7 +421,7 @@ static DEVICE_ATTR(lighting_control_state, 0644,
> show_control_state,
> static int alienware_zone_init(struct platform_device *dev)
> {
> int i;
> - char buffer[10];
> + char buffer[13];
> char *name;
>
> if (interface == WMAX) {
> --
> 2.9.0
>
--
With Best Regards,
Andy Shevchenko
est_interrupt(struct acpi_resource *ares,
> char ev_name[5];
> sprintf(ev_name, "_%c%02X",
> agpio->triggering == ACPI_EDGE_SENSITIVE ?
> 'E' : 'L',
> - pin);
> + (u8)pin);
> if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name,
> _handle)))
> handler = acpi_gpio_irq_handler;
> }
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/isdn/hardware/eicon/divacapi.h | 16 +--
drivers/isdn/hardware/eicon/message.c | 247 -
2 files changed, 58 insertions(+), 205 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/divacap
ymbol doesn't even exist in th net-next tree.
It looks like the patch is done against UUID tree.
Cc'ed Christoph.
--
With Best Regards,
Andy Shevchenko
m_guid' was not declared. Should it be
> static?"
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 2 +-
> 1 file changed, 1
On Sat, Jun 10, 2017 at 10:27 PM, Arend van Spriel
<arend.vanspr...@broadcom.com> wrote:
> On 03-06-17 17:36, Andy Shevchenko wrote:
>> On Sat, Jun 3, 2017 at 1:29 AM, Peter S. Housel <hou...@acm.org> wrote:
The following looks good to me.
Feel free to add
Reviewe
Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify
error path and fix potentially wrong assingment if ->probe() fails.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
net/rfkill/rfkill-gpio.c | 5 +
1 file changed, 1 insertion(+), 4
On Wed, Jun 7, 2017 at 11:45 AM, Mario Molitor <mario_moli...@web.de> wrote:
> exit:
> - return ret;
> + if (likely(ret == 0))
> + return 1;
> + else
> + return 0;
else is redundant.
--
With Best Regards,
Andy Shevchenko
On Sat, Jun 3, 2017 at 7:35 PM, Colin Ian King <colin.k...@canonical.com> wrote:
> On 03/06/17 16:55, Andy Shevchenko wrote:
>> On Fri, Jun 2, 2017 at 5:58 PM, Colin King <colin.k...@canonical.com> wrote:
>>> The current comparison of entry < 0 will never be tr
if (unlikely((int)entry < 0))
It feels like a hiding some other issue.
--
With Best Regards,
Andy Shevchenko
rn in use if (!ret)
2. Less error prone in case someone decides to expand the code and
missed ! or something else there.
Since both makes an approach less error prone I wouldn't suggest doing
that as I commented in new version.
--
With Best Regards,
Andy Shevchenko
(sdiodev, SDIO_FUNC_2, false, addr,
> pktq);
--
With Best Regards,
Andy Shevchenko
the first 5 will be in.
--
With Best Regards,
Andy Shevchenko
2, when is supposed to be 1, see above.
> +};
> +static const struct stmmac_pci_func_data iot2040_stmmac_func_data[] = {
> + { },
> +};
> + .nfuncs = ARRAY_SIZE(iot2040_stmmac_func_data),
Ditto.
--
With Best Regards,
Andy Shevchenko
};
struct stmmac_pci_dmi_data {
struct stmmac_pci_func_data *func;
size_t nfuncs;
};
(Latter would be better since it allows to use ARRAY_SIZE() and less
error prone for possible asymmetrical amount of values in the former)
?
--
With Best Regards,
Andy Shevchenko
and Galileo Gen2.
So, for patches 1-4,
Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
I'm not convinced that patch 6 is needed, so, my vote is not to include it.
Patch 5 I would like to review later. Main problem to me is {-1, -1}.
It looks non-standard and feels not good. I'll t
_to_cpu(p->des0), le32_to_cpu(p->des1),
>le32_to_cpu(p->des2),
> le32_to_cpu(p->des3));
> p++;
--
With Best Regards,
Andy Shevchenko
ing comes up we would need to extend this and
effectively revert this change.
So, my vote is to leave it as is for now.
--
With Best Regards,
Andy Shevchenko
.driver_data = (void *)galileo_stmmac_dmi_data,
Can't be slightly better
.driver_data = _stmmac_dmi_data,
?
--
With Best Regards,
Andy Shevchenko
*/
if (dmi_...)
return ret;
/*
* Comment goes here, I suppose.
*/
ret = 1;
> + }
--
With Best Regards,
Andy Shevchenko
On Sat, May 27, 2017 at 4:13 PM, Andy Shevchenko
<andy.shevche...@gmail.com> wrote:
> On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka <jan.kis...@siemens.com> wrote:
>> Make stmmac_default_data compatible with stmmac_pci_info.setup and use
>> an info structure for all d
CE(PCI_VENDOR_ID_STMICRO, PCI_DEVICE_ID_STMICRO_MAC,
> + stmmac_pci_info),
> + STMMAC_DEVICE(PCI_VENDOR_ID_INTEL, STMMAC_QUARK_ID, quark_pci_info),
--
With Best Regards,
Andy Shevchenko
On Thu, 2017-05-04 at 12:21 +0300, Andy Shevchenko wrote:
> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16
> bytes. Instead we convert them to use uuid_le type. At the same time
> we
> convert current users.
>
> acpi_str_to_uuid() becomes useless af
Can we modify structures with less intrusion?
I'm pretty sure we can convert (if you wish, however I would leave it
for now, there is no issue with current approach) with as twice less
lines.
--
With Best Regards,
Andy Shevchenko
.setup = quark_default_setup,
}
?
--
With Best Regards,
Andy Shevchenko
New helper is added in order to prevent misconfiguration happened
for one of the platforms when configuration data is expanded.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 52
1 file c
ynopsys.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
The commit abe80fdc6ee6
("net: stmmac: RX queue routing configuration")
missed Intel Quark configuration. Append it here.
Fixes: abe80fdc6ee6 ("net: stmmac: RX queue routing configuration")
Cc: Joao Pinto <joao.pi...@synopsys.com>
Signed-off-by: Andy
1 - 100 of 217 matches
Mail list logo
